javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(e2e): make the wait logic more flexible

Browse Source 
We will now by default wait for something to be hydrated, and then wait for the passed in tag to be visible whether it is hydrated or not.

This allows the tag passed in to be associated with a standard (non-stencil) element.
This commit is contained in:
Ken Sodemann
2018-02-07 11:27:31 -06:00
parent b69bd04bb6
commit 9cc0e5519c
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/core/scripts/e2e/page.js
View File

@ -11,8 +11,9 @@ module.exports = class E2ETestPage {
async navigate(tagName = '') {
this.driver.navigate().to(this.url);
this.driver.manage().timeouts().implicitlyWait(10000);
await this.driver.wait(until.elementLocated(By.css(`${tagName}.hydrated`)));
return await this.driver.wait(until.elementIsVisible(this.driver.findElement(By.css(`${tagName}.hydrated`))));
await this.driver.wait(until.elementLocated(By.css(`.hydrated`)));
const tag = tagName || '.hydrated';
return await this.driver.wait(until.elementIsVisible(this.driver.findElement(By.css(tag))));
}
async present(clickTarget, options) {