From 9bef17d9c82ef52bf5f1f81bd770fea803ff03dc Mon Sep 17 00:00:00 2001 From: Sean Perkins Date: Fri, 30 Jun 2023 16:12:09 -0400 Subject: [PATCH] refactor: IonRouter defaultHref assignment --- packages/react-router/src/ReactRouter/IonRouter.tsx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/react-router/src/ReactRouter/IonRouter.tsx b/packages/react-router/src/ReactRouter/IonRouter.tsx index 0c1beec010..5dc802dcc4 100644 --- a/packages/react-router/src/ReactRouter/IonRouter.tsx +++ b/packages/react-router/src/ReactRouter/IonRouter.tsx @@ -209,7 +209,11 @@ function IonRouterInner(props: PropsWithChildren) { const handleNavigateBack = (defaultHref: string | RouteInfo = '/', routeAnimation?: AnimationBuilder) => { const config = getConfig(); - defaultHref = defaultHref ? defaultHref : config && config.get('backButtonDefaultHref' as any); + if (!defaultHref && config) { + // If the defaultHref wasn't passed in, then we should use the configured defaultHref. + // Developers can set this on their IonicConfig. + defaultHref = config.get('backButtonDefaultHref'); + } const routeInfo = locationHistory.current.current(); if (routeInfo && routeInfo.pushedByRoute) {