javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(platform): enforce direction values (#11823)

Browse Source 
* fix(lint): unused import

* feat(platform): enforce direction value

* style(platform): make sure not to change indentation

* refactor(platform): rename PageDirection to DocumentDirection
This commit is contained in:
Amit Moryossef
2017-06-07 23:24:27 +03:00
committed by Brandy Carney
parent fe751f7ac3
commit 9aedc9dc52
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/platform/platform.ts
View File

@@ -4,6 +4,7 @@ import { getCss, isTextInput } from '../util/dom';
import { QueryParams } from './query-params';
import { removeArrayItem } from '../util/util';
export type DocumentDirection = 'ltr' | 'rtl';
/**
* @name Platform
@@ -34,7 +35,7 @@ export class Platform {
private _win: Window;
private _doc: HTMLDocument;
private _versions: {[name: string]: PlatformVersion} = {};
private _dir: string;
private _dir: DocumentDirection;
private _lang: string;
private _ua: string;
private _qp = new QueryParams();
@@ -313,11 +314,11 @@ export class Platform {
* `<html dir="ltr">` or `<html dir="rtl">`. This method is useful if the
* direction needs to be dynamically changed per user/session.
* [W3C: Structural markup and right-to-left text in HTML](http://www.w3.org/International/questions/qa-html-dir)
* @param {string} dir Examples: `rtl`, `ltr`
* @param {DocumentDirection} dir Examples: `rtl`, `ltr`
* @param {boolean} updateDocument
*/
setDir(dir: string, updateDocument: boolean) {
this._dir = dir = (dir || '').toLowerCase();
setDir(dir: DocumentDirection, updateDocument: boolean) {
this._dir = dir;
this.isRTL = (dir === 'rtl');
if (updateDocument !== false) {
@@ -330,9 +331,9 @@ export class Platform {
* We recommend the app's `index.html` file already has the correct `dir`
* attribute value set, such as `<html dir="ltr">` or `<html dir="rtl">`.
* [W3C: Structural markup and right-to-left text in HTML](http://www.w3.org/International/questions/qa-html-dir)
* @returns {string}
* @returns {DocumentDirection}
*/
dir(): string {
dir(): DocumentDirection {
return this._dir;
}
@@ -1181,7 +1182,7 @@ export function setupPlatform(doc: HTMLDocument, platformConfigs: {[key: string]
const docElement = doc.documentElement;
plt.setDocument(doc);
const dir = docElement.dir;
plt.setDir(dir || 'ltr', !dir);
plt.setDir(dir === 'rtl' ? 'rtl' : 'ltr', !dir);
plt.setLang(docElement.lang, false);
// set css properties