From 99f2532ee174da79e2b6a462cfa124673edc1170 Mon Sep 17 00:00:00 2001
From: Brandy Carney <brandyscarney@users.noreply.github.com>
Date: Mon, 14 Sep 2020 11:44:37 -0400
Subject: [PATCH] fix(input): only focus the first input / textarea when
 clicking on the parent item (#22049)

fixes #22037 resolves #22032
---
 core/src/components.d.ts                      | 14 ++++++-
 core/src/components/item/item.tsx             | 38 ++++++++++++-------
 .../components/item/test/inputs/index.html    | 23 ++++++++++-
 core/src/components/textarea/readme.md        |  4 +-
 core/src/components/textarea/textarea.tsx     | 34 +++++++++++++++--
 5 files changed, 91 insertions(+), 22 deletions(-)

diff --git a/core/src/components.d.ts b/core/src/components.d.ts
index b3878a8093..6c378ebb70 100644
--- a/core/src/components.d.ts
+++ b/core/src/components.d.ts
@@ -2439,6 +2439,10 @@ export namespace Components {
           * A hint to the browser for which enter key to display. Possible values: `"enter"`, `"done"`, `"go"`, `"next"`, `"previous"`, `"search"`, and `"send"`.
          */
         "enterkeyhint"?: 'enter' | 'done' | 'go' | 'next' | 'previous' | 'search' | 'send';
+        /**
+          * This is required for a WebKit bug which requires us to blur and focus an input to properly focus the input in an item with delegatesFocus. It will no longer be needed with iOS 14.
+         */
+        "fireFocusEvents": boolean;
         /**
           * Returns the native `<textarea>` element used under the hood.
          */
@@ -2480,7 +2484,11 @@ export namespace Components {
          */
         "rows"?: number;
         /**
-          * Sets focus on the specified `ion-textarea`. Use this method instead of the global `input.focus()`.
+          * Sets blur on the native `textarea` in `ion-textarea`. Use this method instead of the global `textarea.blur()`.
+         */
+        "setBlur": () => Promise<void>;
+        /**
+          * Sets focus on the native `textarea` in `ion-textarea`. Use this method instead of the global `textarea.focus()`.
          */
         "setFocus": () => Promise<void>;
         /**
@@ -5738,6 +5746,10 @@ declare namespace LocalJSX {
           * A hint to the browser for which enter key to display. Possible values: `"enter"`, `"done"`, `"go"`, `"next"`, `"previous"`, `"search"`, and `"send"`.
          */
         "enterkeyhint"?: 'enter' | 'done' | 'go' | 'next' | 'previous' | 'search' | 'send';
+        /**
+          * This is required for a WebKit bug which requires us to blur and focus an input to properly focus the input in an item with delegatesFocus. It will no longer be needed with iOS 14.
+         */
+        "fireFocusEvents"?: boolean;
         /**
           * A hint to the browser for which keyboard to display. Possible values: `"none"`, `"text"`, `"tel"`, `"url"`, `"email"`, `"numeric"`, `"decimal"`, and `"search"`.
          */
diff --git a/core/src/components/item/item.tsx b/core/src/components/item/item.tsx
index 25d90f9835..124cc8edfc 100644
--- a/core/src/components/item/item.tsx
+++ b/core/src/components/item/item.tsx
@@ -177,9 +177,9 @@ export class Item implements ComponentInterface, AnchorInterface, ButtonInterfac
     return (this.isClickable() || this.hasCover());
   }
 
-  private hasInputs(): boolean {
-    const inputs = this.el.querySelectorAll('ion-input');
-    return inputs.length > 0;
+  private getFirstInput(): HTMLIonInputElement | HTMLIonTextareaElement {
+    const inputs = this.el.querySelectorAll('ion-input, ion-textarea') as NodeListOf<HTMLIonInputElement | HTMLIonTextareaElement>;
+    return inputs[0];
   }
 
   // This is needed for WebKit due to a delegatesFocus bug where
@@ -187,17 +187,27 @@ export class Item implements ComponentInterface, AnchorInterface, ButtonInterfac
   // but is opening the keyboard. It will no longer be needed with
   // iOS 14.
   @Listen('click')
-  delegateFocus() {
-    if (this.hasInputs()) {
-      const input = this.el.querySelector('ion-input');
-      if (input) {
-        input.fireFocusEvents = false;
-        input.setBlur();
-        input.setFocus();
-        raf(() => {
-          input.fireFocusEvents = true;
-        });
-      }
+  delegateFocus(ev: Event) {
+    const clickedItem = (ev.target as HTMLElement).tagName === 'ION-ITEM';
+    const input = this.getFirstInput();
+    let firstActive = false;
+
+    // If the first input is the same as the active element we need
+    // to focus the first input again, but if the active element
+    // is another input inside of the item we shouldn't switch focus
+    if (input && document.activeElement) {
+      firstActive = input.querySelector('input, textarea') === document.activeElement;
+    }
+
+    // Only focus the first input if we clicked on an ion-item
+    // and the first input exists
+    if (clickedItem && input && firstActive) {
+      input.fireFocusEvents = false;
+      input.setBlur();
+      input.setFocus();
+      raf(() => {
+        input.fireFocusEvents = true;
+      });
     }
   }
 
diff --git a/core/src/components/item/test/inputs/index.html b/core/src/components/item/test/inputs/index.html
index a11e1f0461..8503a0531b 100644
--- a/core/src/components/item/test/inputs/index.html
+++ b/core/src/components/item/test/inputs/index.html
@@ -123,6 +123,27 @@
         </ion-label>
       </ion-list-header>
       <ion-list class="multiple">
+        <ion-item>
+          <ion-label>Multiple inputs</ion-label>
+          <ion-input placeholder="Input 1"></ion-input>
+          <ion-input placeholder="Input 2"></ion-input>
+          <ion-input placeholder="Input 3"></ion-input>
+        </ion-item>
+
+        <ion-item>
+          <ion-label>Multiple textareas</ion-label>
+          <ion-textarea placeholder="Textarea 1"></ion-textarea>
+          <ion-textarea placeholder="Textarea 2"></ion-textarea>
+          <ion-textarea placeholder="Textarea 3"></ion-textarea>
+        </ion-item>
+
+        <ion-item>
+          <ion-label>Multiple input/textareas</ion-label>
+          <ion-textarea placeholder="Textarea 1"></ion-textarea>
+          <ion-input placeholder="Input 2"></ion-input>
+          <ion-textarea placeholder="Textarea 3"></ion-textarea>
+        </ion-item>
+
         <ion-item>
           <ion-checkbox slot="start" id="checkbox-start"></ion-checkbox>
           <ion-label>Multiple inputs w/ cover</ion-label>
@@ -179,7 +200,7 @@
       clickableItem.color = color === undefined ? 'primary' : undefined;
     });
 
-    const inputs = document.querySelectorAll('ion-input');
+    const inputs = document.querySelectorAll('ion-input, ion-textarea');
 
     for (var i = 0; i < inputs.length; i++) {
       const input = inputs[i];
diff --git a/core/src/components/textarea/readme.md b/core/src/components/textarea/readme.md
index 0ea3a05551..831bb6d083 100644
--- a/core/src/components/textarea/readme.md
+++ b/core/src/components/textarea/readme.md
@@ -315,8 +315,8 @@ Type: `Promise<HTMLTextAreaElement>`
 
 ### `setFocus() => Promise<void>`
 
-Sets focus on the specified `ion-textarea`. Use this method instead of the global
-`input.focus()`.
+Sets focus on the native `textarea` in `ion-textarea`. Use this method instead of the global
+`textarea.focus()`.
 
 #### Returns
 
diff --git a/core/src/components/textarea/textarea.tsx b/core/src/components/textarea/textarea.tsx
index 95f37bd172..ffdb527aac 100644
--- a/core/src/components/textarea/textarea.tsx
+++ b/core/src/components/textarea/textarea.tsx
@@ -23,6 +23,16 @@ export class Textarea implements ComponentInterface {
   private didBlurAfterEdit = false;
   private textareaWrapper?: HTMLElement;
 
+  /**
+   * This is required for a WebKit bug which requires us to
+   * blur and focus an input to properly focus the input in
+   * an item with delegatesFocus. It will no longer be needed
+   * with iOS 14.
+   *
+   * @internal
+   */
+  @Prop() fireFocusEvents = true;
+
   @Element() el!: HTMLElement;
 
   @State() hasFocus = false;
@@ -220,8 +230,8 @@ export class Textarea implements ComponentInterface {
   }
 
   /**
-   * Sets focus on the specified `ion-textarea`. Use this method instead of the global
-   * `input.focus()`.
+   * Sets focus on the native `textarea` in `ion-textarea`. Use this method instead of the global
+   * `textarea.focus()`.
    */
   @Method()
   async setFocus() {
@@ -230,6 +240,18 @@ export class Textarea implements ComponentInterface {
     }
   }
 
+  /**
+   * Sets blur on the native `textarea` in `ion-textarea`. Use this method instead of the global
+   * `textarea.blur()`.
+   * @internal
+   */
+  @Method()
+  async setBlur() {
+    if (this.nativeInput) {
+      this.nativeInput.blur();
+    }
+  }
+
   /**
    * Returns the native `<textarea>` element used under the hood.
    */
@@ -296,14 +318,18 @@ export class Textarea implements ComponentInterface {
     this.hasFocus = true;
     this.focusChange();
 
-    this.ionFocus.emit(ev);
+    if (this.fireFocusEvents) {
+      this.ionFocus.emit(ev);
+    }
   }
 
   private onBlur = (ev: FocusEvent) => {
     this.hasFocus = false;
     this.focusChange();
 
-    this.ionBlur.emit(ev);
+    if (this.fireFocusEvents) {
+      this.ionBlur.emit(ev);
+    }
   }
 
   private onKeyDown = () => {