From 98403fa883edb8c6b73ca3c30828e8d3b0997eff Mon Sep 17 00:00:00 2001 From: Brandy Carney Date: Tue, 27 Mar 2018 16:47:23 -0400 Subject: [PATCH] docs(components): update menu and breaking changes --- BREAKING.md | 4 ++-- core/src/components/menu-button/menu-button.tsx | 7 +++---- core/src/components/menu-button/readme.md | 6 ++---- 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/BREAKING.md b/BREAKING.md index 9b940bd951..33d122d026 100644 --- a/BREAKING.md +++ b/BREAKING.md @@ -962,8 +962,8 @@ These have been renamed to the following: |--------------|--------------------|----------------------------------------------------------------------------------------------------------| | `start` | `slot="secondary"` | Positions element to the `left` of the content in `ios` mode, and directly to the `right` in `md` mode. | | `end` | `slot="primary"` | Positions element to the `right` of the content in `ios` mode, and to the far `right` in `md` mode. | -| `left` | `slot="start"` | Positions to the `left` of the button in LTR, and to the `right` in RTL. | -| `right` | `slot="end"` | Positions to the `right` of the button in LTR, and to the `left` in RTL. | +| `left` | `slot="start"` | Positions to the `left` of the content in LTR, and to the `right` in RTL. | +| `right` | `slot="end"` | Positions to the `right` of the content in LTR, and to the `left` in RTL. | **Old Usage Example:** diff --git a/core/src/components/menu-button/menu-button.tsx b/core/src/components/menu-button/menu-button.tsx index fb86932c30..85623c38ca 100644 --- a/core/src/components/menu-button/menu-button.tsx +++ b/core/src/components/menu-button/menu-button.tsx @@ -15,19 +15,18 @@ export class MenuButton { private custom = true; + @Prop({ context: 'config' }) config: Config; + /** * Optional property that maps to a Menu's `menuId` prop. Can also be `left` or `right` for the menu side. This is used to find the correct menu to toggle */ @Prop() menu: string; /** - * Automatically hides the content when the corresponding menu is not - * active + * Automatically hides the menu button when the corresponding menu is not active */ @Prop() autoHide = true; - @Prop({ context: 'config' }) config: Config; - @Element() el: HTMLElement; componentWillLoad() { diff --git a/core/src/components/menu-button/readme.md b/core/src/components/menu-button/readme.md index 24b1b3c239..9cd409b6c9 100644 --- a/core/src/components/menu-button/readme.md +++ b/core/src/components/menu-button/readme.md @@ -11,8 +11,7 @@ boolean -Automatically hides the content when the corresponding menu is not -active +Automatically hides the menu button when the corresponding menu is not active #### menu @@ -28,8 +27,7 @@ Optional property that maps to a Menu's `menuId` prop. Can also be `left` or `ri boolean -Automatically hides the content when the corresponding menu is not -active +Automatically hides the menu button when the corresponding menu is not active #### menu