javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-19 19:57:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(datetime): warn when parsing an invalid date value (#25049)

Browse Source
This commit is contained in:
Sean Perkins
2022-04-05 12:12:13 -04:00
committed by GitHub
parent 83186598ed
commit 982dc853be
2 changed files with 24 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
core/src/components/datetime/datetime.tsx
View File

@ -1,5 +1,6 @@
import type { ComponentInterface, EventEmitter } from '@stencil/core';
import { Component, Element, Event, Host, Method, Prop, State, Watch, h, writeTask } from '@stencil/core';
import { printIonWarning } from '@utils/logging';
import { caretDownSharp, caretUpSharp, chevronBack, chevronDown, chevronForward } from 'ionicons/icons';
import { getIonMode } from '../../global/ionic-global';
@ -298,15 +299,20 @@ export class Datetime implements ComponentInterface {
* This allows us to update the current value's date/time display without
* refocusing or shifting the user's display (leaves the user in place).
*/
const { month, day, year, hour, minute } = parseDate(this.value);
this.activePartsClone = {
...this.activeParts,
month,
day,
year,
hour,
minute,
};
const valueDateParts = parseDate(this.value);
if (valueDateParts) {
const { month, day, year, hour, minute } = valueDateParts;
this.activePartsClone = {
...this.activeParts,
month,
day,
year,
hour,
minute,
};
} else {
printIonWarning(`Unable to parse date string: ${this.value}. Please provide a valid ISO 8601 datetime string.`);
}
}
this.emitStyle();