javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-18 11:17:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(segment): don't emit ionChange until didLoad (#19218)

Browse Source 
fixes #19204
This commit is contained in:
Manu MA
2019-08-29 09:30:37 +02:00
committed by GitHub
parent 6eca5b0d7f
commit 9751f145e1
7 changed files with 67 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
core/src/components/segment/segment.tsx
View File

@ -17,6 +17,8 @@ import { createColorClasses } from '../../utils/theme';
})
export class Segment implements ComponentInterface {
private didInit = false;
@Element() el!: HTMLElement;
/**
@ -43,8 +45,10 @@ export class Segment implements ComponentInterface {
@Watch('value')
protected valueChanged(value: string | undefined) {
this.updateButtons();
this.ionChange.emit({ value });
if (this.didInit) {
this.updateButtons();
this.ionChange.emit({ value });
}
}
/**
@ -63,18 +67,19 @@ export class Segment implements ComponentInterface {
this.value = selectedButton.value;
}
componentWillLoad() {
this.emitStyle();
}
componentDidLoad() {
if (this.value == null) {
connectedCallback() {
if (this.value === undefined) {
const checked = this.getButtons().find(b => b.checked);
if (checked) {
this.value = checked.value;
}
}
this.emitStyle();
}
componentDidLoad() {
this.updateButtons();
this.didInit = true;
}
private emitStyle() {