From 62dd16a5ee3d98cc897422bec8069abfcb84316a Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Thu, 12 Nov 2020 09:30:53 -0500 Subject: [PATCH 1/3] fix(build): add missing es5 output --- core/stencil.config.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/core/stencil.config.ts b/core/stencil.config.ts index d9178de17f..26c92213d8 100644 --- a/core/stencil.config.ts +++ b/core/stencil.config.ts @@ -171,6 +171,7 @@ export const config: Config = { ] } ], + buildEs5: 'prod', extras: { cssVarsShim: true, dynamicImportShim: true, From 3a6fcc7d8b6f95105ced0d38a9154d21286e0c6b Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Thu, 12 Nov 2020 09:38:55 -0500 Subject: [PATCH 2/3] 5.4.4 --- CHANGELOG.md | 9 +++++++++ angular/package-lock.json | 6 +++--- angular/package.json | 4 ++-- core/package-lock.json | 4 ++-- core/package.json | 2 +- docs/package.json | 2 +- packages/angular-server/package-lock.json | 6 +++--- packages/angular-server/package.json | 4 ++-- packages/react-router/package.json | 10 +++++----- packages/react/package.json | 4 ++-- packages/vue-router/package-lock.json | 4 ++-- packages/vue-router/package.json | 2 +- packages/vue/package-lock.json | 4 ++-- packages/vue/package.json | 4 ++-- 14 files changed, 37 insertions(+), 28 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 957adaf91e..fceed58a8e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,12 @@ +## [5.4.4](https://github.com/ionic-team/ionic/compare/v5.4.3...v5.4.4) (2020-11-12) + + +### Bug Fixes + +* **build:** add missing es5 output ([228d349](https://github.com/ionic-team/ionic/commit/228d349c6e29b62cbfee5d5502883682cfa5032f)) + + + ## [5.4.3](https://github.com/ionic-team/ionic/compare/v5.4.2...v5.4.3) (2020-11-06) diff --git a/angular/package-lock.json b/angular/package-lock.json index 8cae03d992..927ba01afd 100644 --- a/angular/package-lock.json +++ b/angular/package-lock.json @@ -1,12 +1,12 @@ { "name": "@ionic/angular", - "version": "5.4.3", + "version": "5.4.4", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/angular", - "version": "5.4.3", + "version": "5.4.4", "license": "MIT", "dependencies": { "@ionic/core": "file:../core", @@ -43,7 +43,7 @@ } }, "../core": { - "version": "5.4.2", + "version": "5.4.3", "license": "MIT", "dependencies": { "ionicons": "^5.1.2", diff --git a/angular/package.json b/angular/package.json index 4a510ae121..03e249c811 100644 --- a/angular/package.json +++ b/angular/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/angular", - "version": "5.4.3", + "version": "5.4.4", "description": "Angular specific wrappers for @ionic/core", "keywords": [ "ionic", @@ -42,7 +42,7 @@ "validate": "npm i && npm run lint && npm run test && npm run build" }, "dependencies": { - "@ionic/core": "5.4.3", + "@ionic/core": "5.4.4", "tslib": "^1.9.3" }, "peerDependencies": { diff --git a/core/package-lock.json b/core/package-lock.json index daf6e176ed..6f3d7364b2 100644 --- a/core/package-lock.json +++ b/core/package-lock.json @@ -1,12 +1,12 @@ { "name": "@ionic/core", - "version": "5.4.3", + "version": "5.4.4", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/core", - "version": "5.4.3", + "version": "5.4.4", "license": "MIT", "dependencies": { "ionicons": "^5.1.2", diff --git a/core/package.json b/core/package.json index 350636f285..f4cb18ce1c 100644 --- a/core/package.json +++ b/core/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/core", - "version": "5.4.3", + "version": "5.4.4", "description": "Base components for Ionic", "keywords": [ "ionic", diff --git a/docs/package.json b/docs/package.json index 0ec0a64d0d..81c54f0669 100644 --- a/docs/package.json +++ b/docs/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/docs", - "version": "5.4.3", + "version": "5.4.4", "description": "Pre-packaged API documentation for the Ionic docs.", "main": "core.json", "types": "core.d.ts", diff --git a/packages/angular-server/package-lock.json b/packages/angular-server/package-lock.json index b9bdfde796..aa2a4a6513 100644 --- a/packages/angular-server/package-lock.json +++ b/packages/angular-server/package-lock.json @@ -1,12 +1,12 @@ { "name": "@ionic/angular-server", - "version": "5.4.3", + "version": "5.4.4", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/angular-server", - "version": "5.4.3", + "version": "5.4.4", "license": "MIT", "devDependencies": { "@angular/animations": "8.2.13", @@ -32,7 +32,7 @@ } }, "../../core": { - "version": "5.4.2", + "version": "5.4.3", "dev": true, "license": "MIT", "dependencies": { diff --git a/packages/angular-server/package.json b/packages/angular-server/package.json index e735d731ab..0dd91780e7 100644 --- a/packages/angular-server/package.json +++ b/packages/angular-server/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/angular-server", - "version": "5.4.3", + "version": "5.4.4", "description": "Angular SSR Module for Ionic", "keywords": [ "ionic", @@ -49,7 +49,7 @@ "@angular/core": "8.2.13", "@angular/platform-browser": "8.2.13", "@angular/platform-server": "8.2.13", - "@ionic/core": "5.4.3", + "@ionic/core": "5.4.4", "ng-packagr": "5.7.1", "tslint": "^5.12.1", "tslint-ionic-rules": "0.0.21", diff --git a/packages/react-router/package.json b/packages/react-router/package.json index 0cbe03579d..a5f6862ed1 100644 --- a/packages/react-router/package.json +++ b/packages/react-router/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/react-router", - "version": "5.4.3", + "version": "5.4.4", "description": "React Router wrapper for @ionic/react", "keywords": [ "ionic", @@ -39,16 +39,16 @@ "tslib": "*" }, "peerDependencies": { - "@ionic/core": "5.4.3", - "@ionic/react": "5.4.3", + "@ionic/core": "5.4.4", + "@ionic/react": "5.4.4", "react": "^16.8.6", "react-dom": "^16.8.6", "react-router": "^5.0.1", "react-router-dom": "^5.0.1" }, "devDependencies": { - "@ionic/core": "5.4.3", - "@ionic/react": "5.4.3", + "@ionic/core": "5.4.4", + "@ionic/react": "5.4.4", "@rollup/plugin-node-resolve": "^8.1.0", "@testing-library/jest-dom": "^5.11.0", "@testing-library/react": "^10.4.9", diff --git a/packages/react/package.json b/packages/react/package.json index 5878990c8f..b3ffd16b22 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/react", - "version": "5.4.3", + "version": "5.4.4", "description": "React specific wrapper for @ionic/core", "keywords": [ "ionic", @@ -39,7 +39,7 @@ "css/" ], "dependencies": { - "@ionic/core": "5.4.3", + "@ionic/core": "5.4.4", "ionicons": "^5.1.2", "tslib": "*" }, diff --git a/packages/vue-router/package-lock.json b/packages/vue-router/package-lock.json index c3f0968178..0f5d08024b 100644 --- a/packages/vue-router/package-lock.json +++ b/packages/vue-router/package-lock.json @@ -1,12 +1,12 @@ { "name": "@ionic/vue-router", - "version": "5.4.3", + "version": "5.4.4", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/vue-router", - "version": "5.4.3", + "version": "5.4.4", "license": "MIT", "dependencies": { "@ionic/core": "file:../../core", diff --git a/packages/vue-router/package.json b/packages/vue-router/package.json index 90f5105acc..ee68d3ab13 100644 --- a/packages/vue-router/package.json +++ b/packages/vue-router/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/vue-router", - "version": "5.4.3", + "version": "5.4.4", "description": "Vue Router integration for @ionic/vue", "scripts": { "test.spec": "jest", diff --git a/packages/vue/package-lock.json b/packages/vue/package-lock.json index 42f650ce4c..13791d57d8 100644 --- a/packages/vue/package-lock.json +++ b/packages/vue/package-lock.json @@ -1,12 +1,12 @@ { "name": "@ionic/vue", - "version": "5.4.3", + "version": "5.4.4", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/vue", - "version": "5.4.3", + "version": "5.4.4", "license": "MIT", "dependencies": { "@ionic/core": "5.4.3", diff --git a/packages/vue/package.json b/packages/vue/package.json index b622d09a63..4761bddc8c 100644 --- a/packages/vue/package.json +++ b/packages/vue/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/vue", - "version": "5.4.3", + "version": "5.4.4", "description": "Vue specific wrapper for @ionic/core", "scripts": { "lint": "echo add linter", @@ -57,7 +57,7 @@ "vue-router": "^4.0.0-beta.11" }, "dependencies": { - "@ionic/core": "5.4.3", + "@ionic/core": "5.4.4", "ionicons": "^5.1.2" }, "vetur": { From bf3f3bb3dc27ab6f1424614e69025e4a965e45e1 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Thu, 12 Nov 2020 10:39:10 -0500 Subject: [PATCH 3/3] test(): disable treeshake test --- .circleci/config.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 0b55f707cd..ebbff9bc84 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -442,8 +442,11 @@ workflows: requires: [puppeteer-dependencies, build-core] - test-core-spec: requires: [build-core] - - test-core-treeshake: - requires: [build-core] + # Adam requested we skip this test for now + # since it is failing on ES5 code which + # will be removed in Ionic Framework v6 + #- test-core-treeshake: + # requires: [build-core] - test-core-screenshot: requires: [build-core] filters: