javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(menu): deprecate main html attribute (#19237)

Browse Source
This commit is contained in:
Manu MA
2019-10-02 23:13:27 +02:00
committed by Brandy Carney
parent f4818a1f3a
commit 9688f4d42f
2 changed files with 29 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
core/src/components/menu/menu.tsx
View File

@ -148,6 +148,17 @@ export class Menu implements ComponentInterface, MenuI {
const el = this.el;
const parent = el.parentNode as any;
if (this.contentId === undefined) {
console.warn(`[DEPRECATED][ion-menu] Using the [main] attribute is deprecated, please use the "contentId" property instead:
BEFORE:
<ion-menu>...</ion-menu>
<div main>...</div>
AFTER:
<ion-menu contentId="my-content"></ion-menu>
<div id="my-content">...</div>
`);
}
const content = this.contentId !== undefined
? document.getElementById(this.contentId)
: parent && parent.querySelector && parent.querySelector('[main]');

18
core/src/components/split-pane/split-pane.tsx
View File

@ -69,6 +69,24 @@ export class SplitPane implements ComponentInterface {
}
}
componentWillLoad() {
if (this.contentId === undefined) {
console.warn(`[DEPRECATED][ion-split-pane] Using the [main] attribute is deprecated, please use the "contentId" property instead:
BEFORE:
<ion-split-pane>
...
<div main>...</div>
</ion-split-pane>
AFTER:
<ion-split-pane contentId="main-content">
...
<div id="main-content">...</div>
</ion-split-pane>
`);
}
}
@Watch('disabled')
@Watch('when')
protected updateState() {