diff --git a/.github/COMPONENT-GUIDE.md b/.github/COMPONENT-GUIDE.md index bc76084634..2212d55949 100644 --- a/.github/COMPONENT-GUIDE.md +++ b/.github/COMPONENT-GUIDE.md @@ -141,7 +141,7 @@ Style the `ion-activated` class based on the spec for that element: } ``` -> Order is important! Activated should be before the focused & hover states. +> Order is important! Activated should be after the focused & hover states. #### User Customization @@ -307,7 +307,7 @@ Style the `:hover` based on the spec for that element: } ``` -> Order is important! Hover should be after the activated and focused states. +> Order is important! Hover should be before the activated state. #### User Customization @@ -729,7 +729,7 @@ For example, if you wanted `transform-origin` to be RTL-aware, you would use the @include transform-origin(start, center); ``` -This would output `transform-origin: left center` in LTR mode and `transform-origin: right center` in RTL mode. +This would output `transform-origin: left center` in LTR mode and `transform-origin: right center` in RTL mode. These mixins depend on the `:host-context` pseudo-class when used inside of shadow components, which is not supported in WebKit. As a result, these mixins will not work in Safari for macOS and iOS when applied to shadow components. @@ -753,4 +753,4 @@ class={{ :host(.my-cmp-rtl) { transform-origin: right center; } -``` \ No newline at end of file +``` diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 786f1e721c..e305a482a2 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -1,8 +1,10 @@ name: 🐛 Bug Report description: Create a report to help us improve Ionic Framework title: 'bug: ' + body: - type: checkboxes + id: prerequisites attributes: label: Prerequisites description: Please ensure you have completed all of the following. @@ -13,46 +15,67 @@ body: required: true - label: I have searched for [existing issues](https://github.com/ionic-team/ionic-framework/issues) that already report this problem, without success. required: true - - type: checkboxes + + - type: dropdown + id: affected-versions attributes: label: Ionic Framework Version - description: Please select which versions of Ionic Framework this issue impacts. For Ionic Framework 1.x issues, please use https://github.com/ionic-team/ionic-v1. For Ionic Framework 2.x and 3.x issues, please use https://github.com/ionic-team/ionic-v3. + description: Which version(s) of Ionic Framework does this issue impact? For Ionic Framework 1.x issues, please use https://github.com/ionic-team/ionic-v1. For Ionic Framework 2.x and 3.x issues, please use https://github.com/ionic-team/ionic-v3. options: - - label: v4.x - - label: v5.x - - label: v6.x - - label: v7.x - - label: Nightly + - v4.x + - v5.x + - v6.x + - v7.x + - Nightly + multiple: true + validations: + required: true + - type: textarea + id: current-behavior attributes: label: Current Behavior description: A clear description of what the bug is and how it manifests. validations: required: true + - type: textarea + id: expected-behavior attributes: label: Expected Behavior description: A clear description of what you expected to happen. validations: required: true + - type: textarea + id: steps-to-reproduce attributes: label: Steps to Reproduce description: Please explain the steps required to duplicate this issue. + placeholder: | + 1. + 2. + 3. validations: required: true + - type: input + id: reproduction-url attributes: label: Code Reproduction URL description: Please reproduce this issue in a blank Ionic Framework starter application and provide a link to the repo. Try out our [Getting Started Wizard](https://ionicframework.com/start#basics) to quickly spin up an Ionic Framework starter app. This is the best way to ensure this issue is triaged quickly. Issues without a code reproduction may be closed if the Ionic Team cannot reproduce the issue you are reporting. placeholder: https://github.com/... + - type: textarea + id: ionic-info attributes: label: Ionic Info description: Please run `ionic info` from within your Ionic Framework project directory and paste the output below. validations: required: true + - type: textarea + id: additional-information attributes: label: Additional Information description: List any other information that is relevant to your issue. Stack traces, related issues, suggestions on how to fix, Stack Overflow links, forum links, etc. diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml index d774ff2776..536ce1540c 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -2,7 +2,9 @@ name: 💡 Feature Request description: Suggest an idea for Ionic Framework title: 'feat: ' body: + - type: checkboxes + id: prerequisites attributes: label: Prerequisites description: Please ensure you have completed all of the following. @@ -13,31 +15,43 @@ body: required: true - label: I have searched for [existing issues](https://github.com/ionic-team/ionic-framework/issues) that already include this feature request, without success. required: true + - type: textarea + id: description attributes: label: Describe the Feature Request description: A clear and concise description of what the feature does. validations: required: true + - type: textarea + id: use-case attributes: label: Describe the Use Case description: A clear and concise use case for what problem this feature would solve. validations: required: true + - type: textarea + id: proposed-solution attributes: label: Describe Preferred Solution description: A clear and concise description of what you how you want this feature to be added to Ionic Framework. + - type: textarea + id: alternatives-considered attributes: label: Describe Alternatives description: A clear and concise description of any alternative solutions or features you have considered. + - type: textarea + id: related-code attributes: label: Related Code description: If you are able to illustrate the feature request with an example, please provide a sample Ionic Framework application. Try out our [Getting Started Wizard](https://ionicframework.com/start#basics) to quickly spin up an Ionic Framework starter app. + - type: textarea + id: additional-information attributes: label: Additional Information description: List any other information that is relevant to your issue. Stack traces, related issues, suggestions on how to implement, Stack Overflow links, forum links, etc. diff --git a/.github/dependabot.yml b/.github/dependabot.yml index d38b83986b..44e677b53e 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -6,4 +6,5 @@ updates: interval: "daily" allow: - dependency-name: "@playwright/test" - dependency-name: "@axe-core/playwright" + - dependency-name: "@axe-core/playwright" + - dependency-name: "@stencil/core" diff --git a/CHANGELOG.md b/CHANGELOG.md index 9078e0dd02..f005226cf5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,38 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.6.2](https://github.com/ionic-team/ionic-framework/compare/v6.6.1...v6.6.2) (2023-03-15) + + +### Bug Fixes + +* **accordion:** include margins during expand animation ([#26390](https://github.com/ionic-team/ionic-framework/issues/26390)) ([f809918](https://github.com/ionic-team/ionic-framework/commit/f80991813ae8873d8ef6038b0aeb763d727f402e)), closes [#26381](https://github.com/ionic-team/ionic-framework/issues/26381) +* **IonicSlides:** remove unnecessary autoplay option ([#26935](https://github.com/ionic-team/ionic-framework/issues/26935)) ([b8f8937](https://github.com/ionic-team/ionic-framework/commit/b8f893731471052df198824b7ece47606ffcc500)) +* **radio:** checked state is updated when value changes ([#26936](https://github.com/ionic-team/ionic-framework/issues/26936)) ([27a5356](https://github.com/ionic-team/ionic-framework/commit/27a5356fa2b72073d565e9d6f527107869faa3ee)) +* **react/vue:** properly switch ionicon based on the mode when ios/md is set ([#26924](https://github.com/ionic-team/ionic-framework/issues/26924)) ([1eb9a08](https://github.com/ionic-team/ionic-framework/commit/1eb9a085b2d69dfcfc71ff49b25d33347dd54aae)), closes [#26207](https://github.com/ionic-team/ionic-framework/issues/26207) +* **textarea:** inherit tabindex to inner textarea ([#26945](https://github.com/ionic-team/ionic-framework/issues/26945)) ([2c68d01](https://github.com/ionic-team/ionic-framework/commit/2c68d01b898a2f879445b8b64014189afe1255d7)), closes [#26944](https://github.com/ionic-team/ionic-framework/issues/26944) + + + + + +## [6.6.1](https://github.com/ionic-team/ionic-framework/compare/v6.6.0...v6.6.1) (2023-03-08) + + +### Bug Fixes + +* **angular:** keepContentsMounted modal is sized correctly ([#26917](https://github.com/ionic-team/ionic-framework/issues/26917)) ([8d184c8](https://github.com/ionic-team/ionic-framework/commit/8d184c8c1b91dba9d6d5bbaf1b4a8480b75a3572)), closes [#26916](https://github.com/ionic-team/ionic-framework/issues/26916) +* **button:** show correct activated state for ios ([#26900](https://github.com/ionic-team/ionic-framework/issues/26900)) ([67815cc](https://github.com/ionic-team/ionic-framework/commit/67815ccbf4650ecbbc6c79d5063ab5ba50cb358c)), closes [#22468](https://github.com/ionic-team/ionic-framework/issues/22468) +* **datetime-button:** time-only values are parsed ([#26852](https://github.com/ionic-team/ionic-framework/issues/26852)) ([f54fc18](https://github.com/ionic-team/ionic-framework/commit/f54fc188843af52e723e06402e01ef92717e541f)), closes [#26851](https://github.com/ionic-team/ionic-framework/issues/26851) +* **datetime:** resolve import error in stencil apps ([#26909](https://github.com/ionic-team/ionic-framework/issues/26909)) ([48c45af](https://github.com/ionic-team/ionic-framework/commit/48c45afdb6ca7dad0a1f2a6d3ece6df8ba23eb69)), closes [#26908](https://github.com/ionic-team/ionic-framework/issues/26908) +* **menu, split-pane:** ssr does not fail on null customElements check ([#26854](https://github.com/ionic-team/ionic-framework/issues/26854)) ([451d220](https://github.com/ionic-team/ionic-framework/commit/451d2204e79a4a10c1eb829ab0bd75c137b02475)), closes [#24714](https://github.com/ionic-team/ionic-framework/issues/24714) +* **modal:** avoid chrome memory leak bug ([#26911](https://github.com/ionic-team/ionic-framework/issues/26911)) ([a3f8e28](https://github.com/ionic-team/ionic-framework/commit/a3f8e281721f6ef8c9479f5870198b7a009daabd)) +* **react:** inline overlays dismiss when parent component unmounts ([#26245](https://github.com/ionic-team/ionic-framework/issues/26245)) ([c0e1bf9](https://github.com/ionic-team/ionic-framework/commit/c0e1bf92c4487c2ec8a117957cf84a2ce00f5fd8)), closes [#25775](https://github.com/ionic-team/ionic-framework/issues/25775) [#26185](https://github.com/ionic-team/ionic-framework/issues/26185) + + + + + # [6.6.0](https://github.com/ionic-team/ionic-framework/compare/v6.5.7...v6.6.0) (2023-03-01) diff --git a/angular/CHANGELOG.md b/angular/CHANGELOG.md index 5afa8a5a4b..2ed6ceafa1 100644 --- a/angular/CHANGELOG.md +++ b/angular/CHANGELOG.md @@ -3,6 +3,25 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.6.2](https://github.com/ionic-team/ionic/compare/v6.6.1...v6.6.2) (2023-03-15) + +**Note:** Version bump only for package @ionic/angular + + + + + +## [6.6.1](https://github.com/ionic-team/ionic/compare/v6.6.0...v6.6.1) (2023-03-08) + + +### Bug Fixes + +* **angular:** keepContentsMounted modal is sized correctly ([#26917](https://github.com/ionic-team/ionic/issues/26917)) ([8d184c8](https://github.com/ionic-team/ionic/commit/8d184c8c1b91dba9d6d5bbaf1b4a8480b75a3572)), closes [#26916](https://github.com/ionic-team/ionic/issues/26916) + + + + + # [6.6.0](https://github.com/ionic-team/ionic/compare/v6.5.7...v6.6.0) (2023-03-01) diff --git a/angular/package-lock.json b/angular/package-lock.json index 78dd8f8425..2ab56b8437 100644 --- a/angular/package-lock.json +++ b/angular/package-lock.json @@ -1,15 +1,15 @@ { "name": "@ionic/angular", - "version": "6.6.0", + "version": "6.6.2", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/angular", - "version": "6.6.0", + "version": "6.6.2", "license": "MIT", "dependencies": { - "@ionic/core": "^6.6.0", + "@ionic/core": "^6.6.2", "ionicons": "^6.1.3", "jsonc-parser": "^3.0.0", "tslib": "^2.0.0" @@ -1006,9 +1006,9 @@ "license": "BSD-3-Clause" }, "node_modules/@ionic/core": { - "version": "6.6.0", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.6.0.tgz", - "integrity": "sha512-1X0b2/ziKhCwSO665tSpG32FOuMyjhyGDLFTJUKoDfQB0j/gIBv1d2okUzAk6GKHdnAPUZQHZFhUHcSIclW9cg==", + "version": "6.6.2", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.6.2.tgz", + "integrity": "sha512-C3XblxE4OcGs+QWy2meWqNGB8sDZV8w0nUVwLy3AmWovi0CA0xPs2UthUSicUxpCism33pzQp6DiDVsq+G5VTQ==", "dependencies": { "@stencil/core": "^2.18.0", "ionicons": "^6.1.3", @@ -7335,9 +7335,9 @@ "dev": true }, "@ionic/core": { - "version": "6.6.0", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.6.0.tgz", - "integrity": "sha512-1X0b2/ziKhCwSO665tSpG32FOuMyjhyGDLFTJUKoDfQB0j/gIBv1d2okUzAk6GKHdnAPUZQHZFhUHcSIclW9cg==", + "version": "6.6.2", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.6.2.tgz", + "integrity": "sha512-C3XblxE4OcGs+QWy2meWqNGB8sDZV8w0nUVwLy3AmWovi0CA0xPs2UthUSicUxpCism33pzQp6DiDVsq+G5VTQ==", "requires": { "@stencil/core": "^2.18.0", "ionicons": "^6.1.3", diff --git a/angular/package.json b/angular/package.json index fd8dcc87de..5da92b5342 100644 --- a/angular/package.json +++ b/angular/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/angular", - "version": "6.6.0", + "version": "6.6.2", "description": "Angular specific wrappers for @ionic/core", "keywords": [ "ionic", @@ -42,7 +42,7 @@ "validate": "npm i && npm run lint && npm run test && npm run build" }, "dependencies": { - "@ionic/core": "^6.6.0", + "@ionic/core": "^6.6.2", "ionicons": "^6.1.3", "jsonc-parser": "^3.0.0", "tslib": "^2.0.0" diff --git a/angular/src/directives/overlays/modal.ts b/angular/src/directives/overlays/modal.ts index 8b47d73815..0d73698f8c 100644 --- a/angular/src/directives/overlays/modal.ts +++ b/angular/src/directives/overlays/modal.ts @@ -80,7 +80,7 @@ export declare interface IonModal extends Components.IonModal { @Component({ selector: 'ion-modal', changeDetection: ChangeDetectionStrategy.OnPush, - template: `
+ template: `
`, inputs: [ diff --git a/angular/test/base/e2e/src/keep-contents-mounted.spec.ts b/angular/test/base/e2e/src/keep-contents-mounted.spec.ts index a4bc99167f..44e47f8253 100644 --- a/angular/test/base/e2e/src/keep-contents-mounted.spec.ts +++ b/angular/test/base/e2e/src/keep-contents-mounted.spec.ts @@ -27,6 +27,12 @@ describe('overlays - keepContentsMounted', () => { cy.get('ion-modal ion-content').should('exist'); }); + + it('should has ion-delegate-host on mount', () => { + cy.visit('/keep-contents-mounted'); + + cy.get('ion-modal .ion-delegate-host').should('exist'); + }); }) describe('popover', () => { it('should not mount component if false', () => { diff --git a/core/CHANGELOG.md b/core/CHANGELOG.md index 028f5744fe..c4c9c1e1ec 100644 --- a/core/CHANGELOG.md +++ b/core/CHANGELOG.md @@ -3,6 +3,36 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.6.2](https://github.com/ionic-team/ionic/compare/v6.6.1...v6.6.2) (2023-03-15) + + +### Bug Fixes + +* **accordion:** include margins during expand animation ([#26390](https://github.com/ionic-team/ionic/issues/26390)) ([f809918](https://github.com/ionic-team/ionic/commit/f80991813ae8873d8ef6038b0aeb763d727f402e)), closes [#26381](https://github.com/ionic-team/ionic/issues/26381) +* **IonicSlides:** remove unnecessary autoplay option ([#26935](https://github.com/ionic-team/ionic/issues/26935)) ([b8f8937](https://github.com/ionic-team/ionic/commit/b8f893731471052df198824b7ece47606ffcc500)) +* **radio:** checked state is updated when value changes ([#26936](https://github.com/ionic-team/ionic/issues/26936)) ([27a5356](https://github.com/ionic-team/ionic/commit/27a5356fa2b72073d565e9d6f527107869faa3ee)) +* **react/vue:** properly switch ionicon based on the mode when ios/md is set ([#26924](https://github.com/ionic-team/ionic/issues/26924)) ([1eb9a08](https://github.com/ionic-team/ionic/commit/1eb9a085b2d69dfcfc71ff49b25d33347dd54aae)), closes [#26207](https://github.com/ionic-team/ionic/issues/26207) +* **textarea:** inherit tabindex to inner textarea ([#26945](https://github.com/ionic-team/ionic/issues/26945)) ([2c68d01](https://github.com/ionic-team/ionic/commit/2c68d01b898a2f879445b8b64014189afe1255d7)), closes [#26944](https://github.com/ionic-team/ionic/issues/26944) + + + + + +## [6.6.1](https://github.com/ionic-team/ionic/compare/v6.6.0...v6.6.1) (2023-03-08) + + +### Bug Fixes + +* **button:** show correct activated state for ios ([#26900](https://github.com/ionic-team/ionic/issues/26900)) ([67815cc](https://github.com/ionic-team/ionic/commit/67815ccbf4650ecbbc6c79d5063ab5ba50cb358c)), closes [#22468](https://github.com/ionic-team/ionic/issues/22468) +* **datetime-button:** time-only values are parsed ([#26852](https://github.com/ionic-team/ionic/issues/26852)) ([f54fc18](https://github.com/ionic-team/ionic/commit/f54fc188843af52e723e06402e01ef92717e541f)), closes [#26851](https://github.com/ionic-team/ionic/issues/26851) +* **datetime:** resolve import error in stencil apps ([#26909](https://github.com/ionic-team/ionic/issues/26909)) ([48c45af](https://github.com/ionic-team/ionic/commit/48c45afdb6ca7dad0a1f2a6d3ece6df8ba23eb69)), closes [#26908](https://github.com/ionic-team/ionic/issues/26908) +* **menu, split-pane:** ssr does not fail on null customElements check ([#26854](https://github.com/ionic-team/ionic/issues/26854)) ([451d220](https://github.com/ionic-team/ionic/commit/451d2204e79a4a10c1eb829ab0bd75c137b02475)), closes [#24714](https://github.com/ionic-team/ionic/issues/24714) +* **modal:** avoid chrome memory leak bug ([#26911](https://github.com/ionic-team/ionic/issues/26911)) ([a3f8e28](https://github.com/ionic-team/ionic/commit/a3f8e281721f6ef8c9479f5870198b7a009daabd)) + + + + + # [6.6.0](https://github.com/ionic-team/ionic/compare/v6.5.7...v6.6.0) (2023-03-01) diff --git a/core/package-lock.json b/core/package-lock.json index 3e2dda194a..ecfae2102d 100644 --- a/core/package-lock.json +++ b/core/package-lock.json @@ -1,12 +1,12 @@ { "name": "@ionic/core", - "version": "6.6.0", + "version": "6.6.2", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/core", - "version": "6.6.0", + "version": "6.6.2", "license": "MIT", "dependencies": { "@stencil/core": "^2.18.0", @@ -18,7 +18,7 @@ "@ionic/eslint-config": "^0.3.0", "@ionic/prettier-config": "^2.0.0", "@jest/core": "^27.5.1", - "@playwright/test": "^1.29.0", + "@playwright/test": "^1.31.1", "@rollup/plugin-node-resolve": "^8.4.0", "@rollup/plugin-virtual": "^2.0.3", "@stencil/angular-output-target": "^0.4.0", @@ -50,6 +50,7 @@ } }, "custom-rules": { + "name": "eslint-plugin-custom-rules", "version": "1.0.0", "dev": true }, @@ -963,15 +964,6 @@ "node": ">=8" } }, - "node_modules/@istanbuljs/load-nyc-config/node_modules/resolve-from": { - "version": "5.0.0", - "resolved": "https://registry.npmjs.org/resolve-from/-/resolve-from-5.0.0.tgz", - "integrity": "sha512-qYg9KP24dD5qka9J47d0aVky0N+b4fTU89LN9iDnjB5waksiC49rvMB0PrUJQGoTmH50XPiqOvAjDfaijGxYZw==", - "dev": true, - "engines": { - "node": ">=8" - } - }, "node_modules/@istanbuljs/schema": { "version": "0.1.2", "resolved": "https://registry.npmjs.org/@istanbuljs/schema/-/schema-0.1.2.tgz", @@ -1511,19 +1503,22 @@ } }, "node_modules/@playwright/test": { - "version": "1.29.2", - "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.29.2.tgz", - "integrity": "sha512-+3/GPwOgcoF0xLz/opTnahel1/y42PdcgZ4hs+BZGIUjtmEFSXGg+nFoaH3NSmuc7a6GSFwXDJ5L7VXpqzigNg==", + "version": "1.31.2", + "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.31.2.tgz", + "integrity": "sha512-BYVutxDI4JeZKV1+ups6dt5WiqKhjBtIYowyZIJ3kBDmJgsuPKsqqKNIMFbUePLSCmp2cZu+BDL427RcNKTRYw==", "dev": true, "dependencies": { "@types/node": "*", - "playwright-core": "1.29.2" + "playwright-core": "1.31.2" }, "bin": { "playwright": "cli.js" }, "engines": { "node": ">=14" + }, + "optionalDependencies": { + "fsevents": "2.3.2" } }, "node_modules/@rollup/plugin-node-resolve": { @@ -2583,36 +2578,6 @@ "url": "https://tidelift.com/funding/github/npm/autoprefixer" } }, - "node_modules/autoprefixer/node_modules/postcss": { - "version": "7.0.32", - "resolved": "https://registry.npmjs.org/postcss/-/postcss-7.0.32.tgz", - "integrity": "sha512-03eXong5NLnNCD05xscnGKGDZ98CyzoqPSMjOe6SuoQY7Z2hIj0Ld1g/O/UQRuOle2aRtiIRDg9tDcTGAkLfKw==", - "dev": true, - "dependencies": { - "chalk": "^2.4.2", - "source-map": "^0.6.1", - "supports-color": "^6.1.0" - }, - "engines": { - "node": ">=6.0.0" - }, - "funding": { - "type": "tidelift", - "url": "https://tidelift.com/funding/github/npm/postcss" - } - }, - "node_modules/autoprefixer/node_modules/supports-color": { - "version": "6.1.0", - "resolved": "https://registry.npmjs.org/supports-color/-/supports-color-6.1.0.tgz", - "integrity": "sha512-qe1jfm1Mg7Nq/NSh6XE24gPXROEVsWHxC1LIx//XNlD9iw7YZQGjZNjYN7xGaEG6iKdA8EtNFW6R0gjnVXp+wQ==", - "dev": true, - "dependencies": { - "has-flag": "^3.0.0" - }, - "engines": { - "node": ">=6" - } - }, "node_modules/axe-core": { "version": "4.6.2", "resolved": "https://registry.npmjs.org/axe-core/-/axe-core-4.6.2.tgz", @@ -3665,15 +3630,6 @@ "node": ">=8" } }, - "node_modules/dir-glob/node_modules/path-type": { - "version": "4.0.0", - "resolved": "https://registry.npmjs.org/path-type/-/path-type-4.0.0.tgz", - "integrity": "sha512-gDKb8aZMDeD/tZWs9P6+q0J9Mwkdl6xMV8TjnGP3qJVJ06bdMgkbBlLU8IdfOsIsFz2BW1rNVT3XuNEl8zPAvw==", - "dev": true, - "engines": { - "node": ">=8" - } - }, "node_modules/dom-serializer": { "version": "0.2.2", "resolved": "https://registry.npmjs.org/dom-serializer/-/dom-serializer-0.2.2.tgz", @@ -8199,14 +8155,14 @@ } }, "node_modules/playwright": { - "version": "1.29.2", - "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.29.2.tgz", - "integrity": "sha512-hKBYJUtdmYzcjdhYDkP9WGtORwwZBBKAW8+Lz7sr0ZMxtJr04ASXVzH5eBWtDkdb0c3LLFsehfPBTRfvlfKJOA==", + "version": "1.31.2", + "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.31.2.tgz", + "integrity": "sha512-jpC47n2PKQNtzB7clmBuWh6ftBRS/Bt5EGLigJ9k2QAKcNeYXZkEaDH5gmvb6+AbcE0DO6GnXdbl9ogG6Eh+og==", "dev": true, "hasInstallScript": true, "peer": true, "dependencies": { - "playwright-core": "1.29.2" + "playwright-core": "1.31.2" }, "bin": { "playwright": "cli.js" @@ -8216,9 +8172,9 @@ } }, "node_modules/playwright-core": { - "version": "1.29.2", - "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.29.2.tgz", - "integrity": "sha512-94QXm4PMgFoHAhlCuoWyaBYKb92yOcGVHdQLoxQ7Wjlc7Flg4aC/jbFW7xMR52OfXMVkWicue4WXE7QEegbIRA==", + "version": "1.31.2", + "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.31.2.tgz", + "integrity": "sha512-a1dFgCNQw4vCsG7bnojZjDnPewZcw7tZUNFN0ZkcLYKj+mPmXvg4MpaaKZ5SgqPsOmqIf2YsVRkgqiRDxD+fDQ==", "dev": true, "bin": { "playwright": "cli.js" @@ -8357,77 +8313,6 @@ "integrity": "sha512-97DXOFbQJhk71ne5/Mt6cOu6yxsSfM0QGQyl0L25Gca4yGWEGJaig7l7gbCX623VqTBNGLRLaVUCnNkcedlRSQ==", "dev": true }, - "node_modules/postcss/node_modules/ansi-styles": { - "version": "3.2.1", - "resolved": "https://registry.npmjs.org/ansi-styles/-/ansi-styles-3.2.1.tgz", - "integrity": "sha512-VT0ZI6kZRdTh8YyJw3SMbYm/u+NqfsAxEpWO0Pf9sq8/e94WxxOpPKx9FR1FlyCtOVDNOQ+8ntlqFxiRc+r5qA==", - "dev": true, - "dependencies": { - "color-convert": "^1.9.0" - }, - "engines": { - "node": ">=4" - } - }, - "node_modules/postcss/node_modules/chalk": { - "version": "2.4.2", - "resolved": "https://registry.npmjs.org/chalk/-/chalk-2.4.2.tgz", - "integrity": "sha512-Mti+f9lpJNcwF4tWV8/OrTTtF1gZi+f8FqlyAdouralcFWFQWF2+NgCHShjkCb+IFBLq9buZwE1xckQU4peSuQ==", - "dev": true, - "dependencies": { - "ansi-styles": "^3.2.1", - "escape-string-regexp": "^1.0.5", - "supports-color": "^5.3.0" - }, - "engines": { - "node": ">=4" - } - }, - "node_modules/postcss/node_modules/chalk/node_modules/supports-color": { - "version": "5.5.0", - "resolved": "https://registry.npmjs.org/supports-color/-/supports-color-5.5.0.tgz", - "integrity": "sha512-QjVjwdXIt408MIiAqCX4oUKsgU2EqAGzs2Ppkm4aQYbjm+ZEWEcW4SfFNTr4uMNZma0ey4f5lgLrkB0aX0QMow==", - "dev": true, - "dependencies": { - "has-flag": "^3.0.0" - }, - "engines": { - "node": ">=4" - } - }, - "node_modules/postcss/node_modules/color-convert": { - "version": "1.9.3", - "resolved": "https://registry.npmjs.org/color-convert/-/color-convert-1.9.3.tgz", - "integrity": "sha512-QfAUtd+vFdAtFQcC8CCyYt1fYWxSqAiK2cSD6zDB8N3cpsEBAvRxp9zOGg6G/SHHJYAT88/az/IuDGALsNVbGg==", - "dev": true, - "dependencies": { - "color-name": "1.1.3" - } - }, - "node_modules/postcss/node_modules/color-name": { - "version": "1.1.3", - "resolved": "https://registry.npmjs.org/color-name/-/color-name-1.1.3.tgz", - "integrity": "sha1-p9BVi9icQveV3UIyj3QIMcpTvCU=", - "dev": true - }, - "node_modules/postcss/node_modules/escape-string-regexp": { - "version": "1.0.5", - "resolved": "https://registry.npmjs.org/escape-string-regexp/-/escape-string-regexp-1.0.5.tgz", - "integrity": "sha1-G2HAViGQqN/2rjuyzwIAyhMLhtQ=", - "dev": true, - "engines": { - "node": ">=0.8.0" - } - }, - "node_modules/postcss/node_modules/has-flag": { - "version": "3.0.0", - "resolved": "https://registry.npmjs.org/has-flag/-/has-flag-3.0.0.tgz", - "integrity": "sha1-tdRU3CGZriJWmfNGfloH87lVuv0=", - "dev": true, - "engines": { - "node": ">=4" - } - }, "node_modules/postcss/node_modules/supports-color": { "version": "6.1.0", "resolved": "https://registry.npmjs.org/supports-color/-/supports-color-6.1.0.tgz", @@ -11127,14 +11012,6 @@ "get-package-type": "^0.1.0", "js-yaml": "^3.13.1", "resolve-from": "^5.0.0" - }, - "dependencies": { - "resolve-from": { - "version": "5.0.0", - "resolved": "https://registry.npmjs.org/resolve-from/-/resolve-from-5.0.0.tgz", - "integrity": "sha512-qYg9KP24dD5qka9J47d0aVky0N+b4fTU89LN9iDnjB5waksiC49rvMB0PrUJQGoTmH50XPiqOvAjDfaijGxYZw==", - "dev": true - } } }, "@istanbuljs/schema": { @@ -11550,13 +11427,14 @@ } }, "@playwright/test": { - "version": "1.29.2", - "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.29.2.tgz", - "integrity": "sha512-+3/GPwOgcoF0xLz/opTnahel1/y42PdcgZ4hs+BZGIUjtmEFSXGg+nFoaH3NSmuc7a6GSFwXDJ5L7VXpqzigNg==", + "version": "1.31.2", + "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.31.2.tgz", + "integrity": "sha512-BYVutxDI4JeZKV1+ups6dt5WiqKhjBtIYowyZIJ3kBDmJgsuPKsqqKNIMFbUePLSCmp2cZu+BDL427RcNKTRYw==", "dev": true, "requires": { "@types/node": "*", - "playwright-core": "1.29.2" + "fsevents": "2.3.2", + "playwright-core": "1.31.2" } }, "@rollup/plugin-node-resolve": { @@ -12298,28 +12176,6 @@ "num2fraction": "^1.2.2", "postcss": "^7.0.32", "postcss-value-parser": "^4.1.0" - }, - "dependencies": { - "postcss": { - "version": "7.0.32", - "resolved": "https://registry.npmjs.org/postcss/-/postcss-7.0.32.tgz", - "integrity": "sha512-03eXong5NLnNCD05xscnGKGDZ98CyzoqPSMjOe6SuoQY7Z2hIj0Ld1g/O/UQRuOle2aRtiIRDg9tDcTGAkLfKw==", - "dev": true, - "requires": { - "chalk": "^2.4.2", - "source-map": "^0.6.1", - "supports-color": "^6.1.0" - } - }, - "supports-color": { - "version": "6.1.0", - "resolved": "https://registry.npmjs.org/supports-color/-/supports-color-6.1.0.tgz", - "integrity": "sha512-qe1jfm1Mg7Nq/NSh6XE24gPXROEVsWHxC1LIx//XNlD9iw7YZQGjZNjYN7xGaEG6iKdA8EtNFW6R0gjnVXp+wQ==", - "dev": true, - "requires": { - "has-flag": "^3.0.0" - } - } } }, "axe-core": { @@ -13088,14 +12944,6 @@ "dev": true, "requires": { "path-type": "^4.0.0" - }, - "dependencies": { - "path-type": { - "version": "4.0.0", - "resolved": "https://registry.npmjs.org/path-type/-/path-type-4.0.0.tgz", - "integrity": "sha512-gDKb8aZMDeD/tZWs9P6+q0J9Mwkdl6xMV8TjnGP3qJVJ06bdMgkbBlLU8IdfOsIsFz2BW1rNVT3XuNEl8zPAvw==", - "dev": true - } } }, "dom-serializer": { @@ -16464,19 +16312,19 @@ } }, "playwright": { - "version": "1.29.2", - "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.29.2.tgz", - "integrity": "sha512-hKBYJUtdmYzcjdhYDkP9WGtORwwZBBKAW8+Lz7sr0ZMxtJr04ASXVzH5eBWtDkdb0c3LLFsehfPBTRfvlfKJOA==", + "version": "1.31.2", + "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.31.2.tgz", + "integrity": "sha512-jpC47n2PKQNtzB7clmBuWh6ftBRS/Bt5EGLigJ9k2QAKcNeYXZkEaDH5gmvb6+AbcE0DO6GnXdbl9ogG6Eh+og==", "dev": true, "peer": true, "requires": { - "playwright-core": "1.29.2" + "playwright-core": "1.31.2" } }, "playwright-core": { - "version": "1.29.2", - "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.29.2.tgz", - "integrity": "sha512-94QXm4PMgFoHAhlCuoWyaBYKb92yOcGVHdQLoxQ7Wjlc7Flg4aC/jbFW7xMR52OfXMVkWicue4WXE7QEegbIRA==", + "version": "1.31.2", + "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.31.2.tgz", + "integrity": "sha512-a1dFgCNQw4vCsG7bnojZjDnPewZcw7tZUNFN0ZkcLYKj+mPmXvg4MpaaKZ5SgqPsOmqIf2YsVRkgqiRDxD+fDQ==", "dev": true }, "postcss": { @@ -16490,64 +16338,6 @@ "supports-color": "^6.1.0" }, "dependencies": { - "ansi-styles": { - "version": "3.2.1", - "resolved": "https://registry.npmjs.org/ansi-styles/-/ansi-styles-3.2.1.tgz", - "integrity": "sha512-VT0ZI6kZRdTh8YyJw3SMbYm/u+NqfsAxEpWO0Pf9sq8/e94WxxOpPKx9FR1FlyCtOVDNOQ+8ntlqFxiRc+r5qA==", - "dev": true, - "requires": { - "color-convert": "^1.9.0" - } - }, - "chalk": { - "version": "2.4.2", - "resolved": "https://registry.npmjs.org/chalk/-/chalk-2.4.2.tgz", - "integrity": "sha512-Mti+f9lpJNcwF4tWV8/OrTTtF1gZi+f8FqlyAdouralcFWFQWF2+NgCHShjkCb+IFBLq9buZwE1xckQU4peSuQ==", - "dev": true, - "requires": { - "ansi-styles": "^3.2.1", - "escape-string-regexp": "^1.0.5", - "supports-color": "^5.3.0" - }, - "dependencies": { - "supports-color": { - "version": "5.5.0", - "resolved": "https://registry.npmjs.org/supports-color/-/supports-color-5.5.0.tgz", - "integrity": "sha512-QjVjwdXIt408MIiAqCX4oUKsgU2EqAGzs2Ppkm4aQYbjm+ZEWEcW4SfFNTr4uMNZma0ey4f5lgLrkB0aX0QMow==", - "dev": true, - "requires": { - "has-flag": "^3.0.0" - } - } - } - }, - "color-convert": { - "version": "1.9.3", - "resolved": "https://registry.npmjs.org/color-convert/-/color-convert-1.9.3.tgz", - "integrity": "sha512-QfAUtd+vFdAtFQcC8CCyYt1fYWxSqAiK2cSD6zDB8N3cpsEBAvRxp9zOGg6G/SHHJYAT88/az/IuDGALsNVbGg==", - "dev": true, - "requires": { - "color-name": "1.1.3" - } - }, - "color-name": { - "version": "1.1.3", - "resolved": "https://registry.npmjs.org/color-name/-/color-name-1.1.3.tgz", - "integrity": "sha1-p9BVi9icQveV3UIyj3QIMcpTvCU=", - "dev": true - }, - "escape-string-regexp": { - "version": "1.0.5", - "resolved": "https://registry.npmjs.org/escape-string-regexp/-/escape-string-regexp-1.0.5.tgz", - "integrity": "sha1-G2HAViGQqN/2rjuyzwIAyhMLhtQ=", - "dev": true - }, - "has-flag": { - "version": "3.0.0", - "resolved": "https://registry.npmjs.org/has-flag/-/has-flag-3.0.0.tgz", - "integrity": "sha1-tdRU3CGZriJWmfNGfloH87lVuv0=", - "dev": true - }, "supports-color": { "version": "6.1.0", "resolved": "https://registry.npmjs.org/supports-color/-/supports-color-6.1.0.tgz", diff --git a/core/package.json b/core/package.json index a7122850ba..58558f5e77 100644 --- a/core/package.json +++ b/core/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/core", - "version": "6.6.0", + "version": "6.6.2", "description": "Base components for Ionic", "keywords": [ "ionic", @@ -40,7 +40,7 @@ "@ionic/eslint-config": "^0.3.0", "@ionic/prettier-config": "^2.0.0", "@jest/core": "^27.5.1", - "@playwright/test": "^1.29.0", + "@playwright/test": "^1.31.1", "@rollup/plugin-node-resolve": "^8.4.0", "@rollup/plugin-virtual": "^2.0.3", "@stencil/angular-output-target": "^0.4.0", diff --git a/core/src/components.d.ts b/core/src/components.d.ts index 844887bb26..ee2a8c7bdc 100644 --- a/core/src/components.d.ts +++ b/core/src/components.d.ts @@ -5623,7 +5623,7 @@ declare namespace LocalJSX { */ "onDidDismiss"?: (event: IonModalCustomEvent) => void; /** - * Emitted after the modal has presented. Shorthand for ionModalWillDismiss. + * Emitted after the modal has presented. Shorthand for ionModalDidPresent. */ "onDidPresent"?: (event: IonModalCustomEvent) => void; /** diff --git a/core/src/components/accordion/accordion.scss b/core/src/components/accordion/accordion.scss index 1305913a92..e560c5de33 100644 --- a/core/src/components/accordion/accordion.scss +++ b/core/src/components/accordion/accordion.scss @@ -57,6 +57,14 @@ max-height: 0; } +/** + * Prevent margins of content-wrapper + * from collapsing, breaking the animation. + */ +:host(.accordion-expanding) #content-wrapper { + overflow: auto; +} + :host(.accordion-disabled) #header, :host(.accordion-readonly) #header, :host(.accordion-disabled) #content, diff --git a/core/src/components/accordion/test/nested/accordion.e2e.ts-snapshots/accordion-parent-disabled-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/accordion/test/nested/accordion.e2e.ts-snapshots/accordion-parent-disabled-ios-ltr-Mobile-Firefox-linux.png index e6f8073408..f5dfc06d2f 100644 Binary files a/core/src/components/accordion/test/nested/accordion.e2e.ts-snapshots/accordion-parent-disabled-ios-ltr-Mobile-Firefox-linux.png and b/core/src/components/accordion/test/nested/accordion.e2e.ts-snapshots/accordion-parent-disabled-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/accordion/test/nested/accordion.e2e.ts-snapshots/accordion-parent-disabled-md-ltr-Mobile-Firefox-linux.png b/core/src/components/accordion/test/nested/accordion.e2e.ts-snapshots/accordion-parent-disabled-md-ltr-Mobile-Firefox-linux.png index 42a22edde4..a2709d3d33 100644 Binary files a/core/src/components/accordion/test/nested/accordion.e2e.ts-snapshots/accordion-parent-disabled-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/accordion/test/nested/accordion.e2e.ts-snapshots/accordion-parent-disabled-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/accordion/test/standalone/index.html b/core/src/components/accordion/test/standalone/index.html index d01bed44c0..50cf965424 100644 --- a/core/src/components/accordion/test/standalone/index.html +++ b/core/src/components/accordion/test/standalone/index.html @@ -77,6 +77,26 @@
+ +
+

Margins In Content

+ + + + Accordion + + + Card Title + Card Subtitle + + + + Here's a small text description for the card content. Nothing more, nothing less. + + + + +
diff --git a/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts-snapshots/action-sheet-basic-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts-snapshots/action-sheet-basic-diff-md-ltr-Mobile-Chrome-linux.png index 1becfdf287..2f35a0e5a8 100644 Binary files a/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts-snapshots/action-sheet-basic-diff-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts-snapshots/action-sheet-basic-diff-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts-snapshots/action-sheet-basic-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts-snapshots/action-sheet-basic-diff-md-rtl-Mobile-Chrome-linux.png index 0079f12900..9a3257175f 100644 Binary files a/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts-snapshots/action-sheet-basic-diff-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts-snapshots/action-sheet-basic-diff-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts-snapshots/action-sheet-cancel-only-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts-snapshots/action-sheet-cancel-only-diff-md-ltr-Mobile-Chrome-linux.png index f674afa725..a1bad57eaf 100644 Binary files a/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts-snapshots/action-sheet-cancel-only-diff-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts-snapshots/action-sheet-cancel-only-diff-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts-snapshots/action-sheet-cancel-only-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts-snapshots/action-sheet-cancel-only-diff-md-rtl-Mobile-Chrome-linux.png index 475f6a255b..2c10c59217 100644 Binary files a/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts-snapshots/action-sheet-cancel-only-diff-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts-snapshots/action-sheet-cancel-only-diff-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts-snapshots/action-sheet-custom-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts-snapshots/action-sheet-custom-diff-md-ltr-Mobile-Chrome-linux.png index 28e84a0616..973bb91806 100644 Binary files a/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts-snapshots/action-sheet-custom-diff-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts-snapshots/action-sheet-custom-diff-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts-snapshots/action-sheet-custom-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts-snapshots/action-sheet-custom-diff-md-rtl-Mobile-Chrome-linux.png index 950a79819e..f73ae3b33b 100644 Binary files a/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts-snapshots/action-sheet-custom-diff-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts-snapshots/action-sheet-custom-diff-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/alert/alert-interface.ts b/core/src/components/alert/alert-interface.ts index 25ffd5e391..adc854abad 100644 --- a/core/src/components/alert/alert-interface.ts +++ b/core/src/components/alert/alert-interface.ts @@ -31,6 +31,9 @@ export interface AlertInput { name?: string; placeholder?: string; value?: any; // TODO(FW-2832): type + /** + * The label text to display next to the input, if the input type is `radio` or `checkbox`. + */ label?: string; checked?: boolean; disabled?: boolean; diff --git a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-basic-md-ltr-Mobile-Chrome-linux.png b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-basic-md-ltr-Mobile-Chrome-linux.png index 3423704756..0bdd673e37 100644 Binary files a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-basic-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-basic-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-basic-md-rtl-Mobile-Chrome-linux.png b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-basic-md-rtl-Mobile-Chrome-linux.png index 78f5118947..7a6740c767 100644 Binary files a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-basic-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-basic-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-checkbox-md-ltr-Mobile-Chrome-linux.png b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-checkbox-md-ltr-Mobile-Chrome-linux.png index afb3e956ea..7e8d8aff6d 100644 Binary files a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-checkbox-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-checkbox-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-checkbox-md-rtl-Mobile-Chrome-linux.png b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-checkbox-md-rtl-Mobile-Chrome-linux.png index b7edd8839e..ac81986daf 100644 Binary files a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-checkbox-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-checkbox-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-confirm-md-ltr-Mobile-Chrome-linux.png b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-confirm-md-ltr-Mobile-Chrome-linux.png index d73255faac..e7208c91ce 100644 Binary files a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-confirm-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-confirm-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-confirm-md-rtl-Mobile-Chrome-linux.png b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-confirm-md-rtl-Mobile-Chrome-linux.png index f631309360..acf8c10d1c 100644 Binary files a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-confirm-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-confirm-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-longMessage-md-ltr-Mobile-Chrome-linux.png b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-longMessage-md-ltr-Mobile-Chrome-linux.png index e42721753a..29480750b2 100644 Binary files a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-longMessage-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-longMessage-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-longMessage-md-rtl-Mobile-Chrome-linux.png b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-longMessage-md-rtl-Mobile-Chrome-linux.png index 9deefc183d..a5ba459656 100644 Binary files a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-longMessage-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-longMessage-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-multipleButtons-md-ltr-Mobile-Chrome-linux.png b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-multipleButtons-md-ltr-Mobile-Chrome-linux.png index 40bf8e885c..a5c6aef38b 100644 Binary files a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-multipleButtons-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-multipleButtons-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-multipleButtons-md-rtl-Mobile-Chrome-linux.png b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-multipleButtons-md-rtl-Mobile-Chrome-linux.png index d612e58592..70ad9593ff 100644 Binary files a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-multipleButtons-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-multipleButtons-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-noMessage-md-ltr-Mobile-Chrome-linux.png b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-noMessage-md-ltr-Mobile-Chrome-linux.png index 9dd980f1b7..ab2d0fb3d4 100644 Binary files a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-noMessage-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-noMessage-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-noMessage-md-rtl-Mobile-Chrome-linux.png b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-noMessage-md-rtl-Mobile-Chrome-linux.png index 883e22f7a8..7fcb10fd88 100644 Binary files a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-noMessage-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-noMessage-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-prompt-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-prompt-ios-ltr-Mobile-Firefox-linux.png index dda835796f..4f9d08b42c 100644 Binary files a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-prompt-ios-ltr-Mobile-Firefox-linux.png and b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-prompt-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-prompt-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-prompt-ios-rtl-Mobile-Firefox-linux.png index 9b09ce76e6..f569629cbc 100644 Binary files a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-prompt-ios-rtl-Mobile-Firefox-linux.png and b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-prompt-ios-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-prompt-md-ltr-Mobile-Firefox-linux.png b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-prompt-md-ltr-Mobile-Firefox-linux.png index 6f86e5d2ac..b3624a9dcd 100644 Binary files a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-prompt-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-prompt-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-prompt-md-rtl-Mobile-Firefox-linux.png b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-prompt-md-rtl-Mobile-Firefox-linux.png index 01769a836f..fc29447a41 100644 Binary files a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-prompt-md-rtl-Mobile-Firefox-linux.png and b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-prompt-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-radio-md-ltr-Mobile-Chrome-linux.png b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-radio-md-ltr-Mobile-Chrome-linux.png index 383227b102..7cea977e99 100644 Binary files a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-radio-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-radio-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-radio-md-rtl-Mobile-Chrome-linux.png b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-radio-md-rtl-Mobile-Chrome-linux.png index 9cf97cfeef..e855a8f944 100644 Binary files a/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-radio-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-radio-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-action-sheet-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-action-sheet-diff-ios-ltr-Mobile-Chrome-linux.png index 8fa3a0d6ea..69f07d773f 100644 Binary files a/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-action-sheet-diff-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-action-sheet-diff-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-picker-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-picker-diff-ios-ltr-Mobile-Chrome-linux.png index 22beb3bd38..59026cf3b0 100644 Binary files a/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-picker-diff-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-picker-diff-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-toast-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-toast-diff-ios-ltr-Mobile-Chrome-linux.png index 4f073858fb..b6f4d5403d 100644 Binary files a/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-toast-diff-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/app/test/safe-area/app.e2e.ts-snapshots/app-toast-diff-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/back-button/test/basic/back-button.e2e.ts-snapshots/back-button-basic-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/back-button/test/basic/back-button.e2e.ts-snapshots/back-button-basic-ios-ltr-Mobile-Chrome-linux.png index c97b19e651..55a0538e42 100644 Binary files a/core/src/components/back-button/test/basic/back-button.e2e.ts-snapshots/back-button-basic-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/back-button/test/basic/back-button.e2e.ts-snapshots/back-button-basic-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/back-button/test/basic/back-button.e2e.ts-snapshots/back-button-basic-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/back-button/test/basic/back-button.e2e.ts-snapshots/back-button-basic-ios-rtl-Mobile-Chrome-linux.png index 87bf4c01c8..333e9f54c8 100644 Binary files a/core/src/components/back-button/test/basic/back-button.e2e.ts-snapshots/back-button-basic-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/back-button/test/basic/back-button.e2e.ts-snapshots/back-button-basic-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/back-button/test/basic/back-button.e2e.ts-snapshots/back-button-basic-md-ltr-Mobile-Chrome-linux.png b/core/src/components/back-button/test/basic/back-button.e2e.ts-snapshots/back-button-basic-md-ltr-Mobile-Chrome-linux.png index 6bce36c048..af87a98e9a 100644 Binary files a/core/src/components/back-button/test/basic/back-button.e2e.ts-snapshots/back-button-basic-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/back-button/test/basic/back-button.e2e.ts-snapshots/back-button-basic-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/back-button/test/basic/back-button.e2e.ts-snapshots/back-button-basic-md-rtl-Mobile-Chrome-linux.png b/core/src/components/back-button/test/basic/back-button.e2e.ts-snapshots/back-button-basic-md-rtl-Mobile-Chrome-linux.png index 77503ca54c..39006b7f90 100644 Binary files a/core/src/components/back-button/test/basic/back-button.e2e.ts-snapshots/back-button-basic-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/back-button/test/basic/back-button.e2e.ts-snapshots/back-button-basic-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Chrome-linux.png index 7620b199e2..5335ea0fa9 100644 Binary files a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Chrome-linux.png index d14b748651..42edcb5543 100644 Binary files a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/button/button.ios.scss b/core/src/components/button/button.ios.scss index 68e52e1332..9af8a43a34 100644 --- a/core/src/components/button/button.ios.scss +++ b/core/src/components/button/button.ios.scss @@ -72,6 +72,7 @@ :host(.button-clear) { --background-activated: transparent; + --background-activated-opacity: 0; --background-focused: #{ion-color(primary, base)}; --background-hover: transparent; --background-focused-opacity: .1; @@ -131,25 +132,6 @@ } -// iOS Button Activated -// -------------------------------------------------- - -:host(.button-clear.ion-activated) { - opacity: #{$button-ios-clear-opacity-activated}; -} - -:host(.button-outline.ion-activated.ion-color) .button-native { - color: current-color(contrast); - - &::after { - background: current-color(base); - } -} - -:host(.button-solid.ion-color.ion-activated) .button-native::after { - background: #{current-color(shade)}; -} - // iOS Button Focused // -------------------------------------------------- @@ -166,14 +148,16 @@ background: #{current-color(shade)}; } + // iOS Button Hover // -------------------------------------------------- @media (any-hover: hover) { // Clear and outline buttons use opacity so set - // background to transparent - :host(.button-clear:hover), - :host(.button-outline:hover) { + // background to transparent, but this shouldn't + // apply on top of activated + :host(.button-clear:not(.ion-activated):hover), + :host(.button-outline:not(.ion-activated):hover) { opacity: #{$button-ios-clear-opacity-hover}; } @@ -192,10 +176,31 @@ } // Solid buttons inside of a toolbar should use a tint of the current - // background so use white to tint it - :host(:hover.button-solid.in-toolbar:not(.ion-color):not(.in-toolbar-color)) .button-native::after { + // background so use white to tint it, but this should not apply + // when activated + :host(:hover.button-solid.in-toolbar:not(.ion-color):not(.in-toolbar-color):not(.ion-activated)) .button-native::after { background: #fff; opacity: 0.10; } } + + +// iOS Button Activated +// -------------------------------------------------- + +:host(.button-clear.ion-activated) { + opacity: #{$button-ios-clear-opacity-activated}; +} + +:host(.button-outline.ion-activated.ion-color) .button-native { + color: current-color(contrast); + + &::after { + background: current-color(base); + } +} + +:host(.button-solid.ion-color.ion-activated) .button-native::after { + background: #{current-color(shade)}; +} diff --git a/core/src/components/button/button.scss b/core/src/components/button/button.scss index 00eebd84a8..f75b76a683 100644 --- a/core/src/components/button/button.scss +++ b/core/src/components/button/button.scss @@ -246,17 +246,6 @@ ion-ripple-effect { @include button-state(); } -// Button Activated -:host(.ion-activated) { - color: var(--color-activated); -} - -:host(.ion-activated) .button-native::after { - background: var(--background-activated); - - opacity: var(--background-activated-opacity); -} - // Button Focused :host(.ion-focused) { color: var(--color-focused); @@ -281,6 +270,17 @@ ion-ripple-effect { } } +// Button Activated +:host(.ion-activated) { + color: var(--color-activated); +} + +:host(.ion-activated) .button-native::after { + background: var(--background-activated); + + opacity: var(--background-activated-opacity); +} + // Button Colors // -------------------------------------------------- @@ -305,6 +305,7 @@ ion-ripple-effect { color: current-color(base); } + // Button in Toolbar // -------------------------------------------------- @@ -320,3 +321,11 @@ ion-ripple-effect { background: #{var(--ion-toolbar-color, var(--background))}; color: #{var(--ion-toolbar-background, var(--color))}; } + +// Activated Button in Toolbar +// -------------------------------------------------- + +:host(.button-outline.ion-activated.in-toolbar:not(.ion-color):not(.in-toolbar-color)) .button-native { + background: var(--ion-toolbar-color, var(--color)); + color: #{var(--ion-toolbar-background, var(--background), ion-color(primary, contrast))}; +} diff --git a/core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-ltr-Mobile-Chrome-linux.png index 58fe149c80..d0d171c354 100644 Binary files a/core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-rtl-Mobile-Chrome-linux.png index f9cbbdeb2a..057d7a3f31 100644 Binary files a/core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-md-ltr-Mobile-Chrome-linux.png index a865bdae45..ff220f2154 100644 Binary files a/core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-md-rtl-Mobile-Chrome-linux.png index 50727dec04..605e2f66ba 100644 Binary files a/core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/button/test/basic/button.e2e.ts-snapshots/button-ripple-effect-md-ltr-Mobile-Chrome-linux.png b/core/src/components/button/test/basic/button.e2e.ts-snapshots/button-ripple-effect-md-ltr-Mobile-Chrome-linux.png index 04931cc4f5..b9720d444f 100644 Binary files a/core/src/components/button/test/basic/button.e2e.ts-snapshots/button-ripple-effect-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/button/test/basic/button.e2e.ts-snapshots/button-ripple-effect-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/button/test/basic/button.e2e.ts-snapshots/button-ripple-effect-md-rtl-Mobile-Chrome-linux.png b/core/src/components/button/test/basic/button.e2e.ts-snapshots/button-ripple-effect-md-rtl-Mobile-Chrome-linux.png index e6e8111333..fe9f587247 100644 Binary files a/core/src/components/button/test/basic/button.e2e.ts-snapshots/button-ripple-effect-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/button/test/basic/button.e2e.ts-snapshots/button-ripple-effect-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/button/test/clear/button.e2e.ts-snapshots/button-clear-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/button/test/clear/button.e2e.ts-snapshots/button-clear-ios-ltr-Mobile-Chrome-linux.png index 715717d160..8b478ea016 100644 Binary files a/core/src/components/button/test/clear/button.e2e.ts-snapshots/button-clear-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/button/test/clear/button.e2e.ts-snapshots/button-clear-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/button/test/clear/button.e2e.ts-snapshots/button-clear-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/button/test/clear/button.e2e.ts-snapshots/button-clear-ios-rtl-Mobile-Chrome-linux.png index afaf27be70..7599a47588 100644 Binary files a/core/src/components/button/test/clear/button.e2e.ts-snapshots/button-clear-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/button/test/clear/button.e2e.ts-snapshots/button-clear-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/button/test/clear/button.e2e.ts-snapshots/button-clear-md-ltr-Mobile-Chrome-linux.png b/core/src/components/button/test/clear/button.e2e.ts-snapshots/button-clear-md-ltr-Mobile-Chrome-linux.png index 5171a79cd0..440f2d7e0d 100644 Binary files a/core/src/components/button/test/clear/button.e2e.ts-snapshots/button-clear-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/button/test/clear/button.e2e.ts-snapshots/button-clear-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/button/test/clear/button.e2e.ts-snapshots/button-clear-md-rtl-Mobile-Chrome-linux.png b/core/src/components/button/test/clear/button.e2e.ts-snapshots/button-clear-md-rtl-Mobile-Chrome-linux.png index 3b574d8cc8..cf9749d9c7 100644 Binary files a/core/src/components/button/test/clear/button.e2e.ts-snapshots/button-clear-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/button/test/clear/button.e2e.ts-snapshots/button-clear-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/button/test/expand/button.e2e.ts-snapshots/button-expand-md-ltr-Mobile-Chrome-linux.png b/core/src/components/button/test/expand/button.e2e.ts-snapshots/button-expand-md-ltr-Mobile-Chrome-linux.png index 1a421f03d4..b4b4144db1 100644 Binary files a/core/src/components/button/test/expand/button.e2e.ts-snapshots/button-expand-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/button/test/expand/button.e2e.ts-snapshots/button-expand-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/button/test/icon/button.e2e.ts-snapshots/button-icon-md-ltr-Mobile-Chrome-linux.png b/core/src/components/button/test/icon/button.e2e.ts-snapshots/button-icon-md-ltr-Mobile-Chrome-linux.png index 9e10a1e8f6..37f5e15567 100644 Binary files a/core/src/components/button/test/icon/button.e2e.ts-snapshots/button-icon-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/button/test/icon/button.e2e.ts-snapshots/button-icon-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/button/test/icon/button.e2e.ts-snapshots/button-icon-md-rtl-Mobile-Chrome-linux.png b/core/src/components/button/test/icon/button.e2e.ts-snapshots/button-icon-md-rtl-Mobile-Chrome-linux.png index 326c074980..1a3c2b0306 100644 Binary files a/core/src/components/button/test/icon/button.e2e.ts-snapshots/button-icon-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/button/test/icon/button.e2e.ts-snapshots/button-icon-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-ltr-Mobile-Chrome-linux.png index b168e07583..0268cbd7da 100644 Binary files a/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-ltr-Mobile-Firefox-linux.png index 72ef0a5cbc..340456619f 100644 Binary files a/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-ltr-Mobile-Firefox-linux.png and b/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-ltr-Mobile-Safari-linux.png b/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-ltr-Mobile-Safari-linux.png index af7a35f82b..f504eda8b1 100644 Binary files a/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-rtl-Mobile-Chrome-linux.png index fcbc72e2ff..42d32a1534 100644 Binary files a/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-rtl-Mobile-Firefox-linux.png index 10c6db5d7c..c99bbac820 100644 Binary files a/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-rtl-Mobile-Firefox-linux.png and b/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-rtl-Mobile-Safari-linux.png b/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-rtl-Mobile-Safari-linux.png index 057317cace..d2fb171939 100644 Binary files a/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-md-ltr-Mobile-Chrome-linux.png b/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-md-ltr-Mobile-Chrome-linux.png index a9eb609bbd..ba00db8aaf 100644 Binary files a/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-md-rtl-Mobile-Chrome-linux.png b/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-md-rtl-Mobile-Chrome-linux.png index b24bffdc46..28c97ad2ab 100644 Binary files a/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/button/test/round/button.e2e.ts-snapshots/button-round-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/button/test/round/button.e2e.ts-snapshots/button-round-ios-ltr-Mobile-Chrome-linux.png index 7cac86e22a..50778c16d7 100644 Binary files a/core/src/components/button/test/round/button.e2e.ts-snapshots/button-round-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/button/test/round/button.e2e.ts-snapshots/button-round-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/button/test/round/button.e2e.ts-snapshots/button-round-md-ltr-Mobile-Chrome-linux.png b/core/src/components/button/test/round/button.e2e.ts-snapshots/button-round-md-ltr-Mobile-Chrome-linux.png index 989b5a99ec..47f6f1d9f0 100644 Binary files a/core/src/components/button/test/round/button.e2e.ts-snapshots/button-round-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/button/test/round/button.e2e.ts-snapshots/button-round-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/buttons/buttons.ios.scss b/core/src/components/buttons/buttons.ios.scss index c9868f959e..49126cdadc 100644 --- a/core/src/components/buttons/buttons.ios.scss +++ b/core/src/components/buttons/buttons.ios.scss @@ -48,6 +48,7 @@ :host-context(.ion-color)::slotted(*) .button-outline { --color-activated: #{current-color(base)}; --color-focused: #{current-color(contrast)}; + --background-activated: #{current-color(contrast)}; } diff --git a/core/src/components/chip/test/basic/chip.e2e.ts-snapshots/chip-basic-ios-rtl-Mobile-Safari-linux.png b/core/src/components/chip/test/basic/chip.e2e.ts-snapshots/chip-basic-ios-rtl-Mobile-Safari-linux.png index 1e25d2fd8c..5d5f019c5e 100644 Binary files a/core/src/components/chip/test/basic/chip.e2e.ts-snapshots/chip-basic-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/chip/test/basic/chip.e2e.ts-snapshots/chip-basic-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/chip/test/basic/chip.e2e.ts-snapshots/chip-basic-md-rtl-Mobile-Safari-linux.png b/core/src/components/chip/test/basic/chip.e2e.ts-snapshots/chip-basic-md-rtl-Mobile-Safari-linux.png index de5013e772..663a9e2b89 100644 Binary files a/core/src/components/chip/test/basic/chip.e2e.ts-snapshots/chip-basic-md-rtl-Mobile-Safari-linux.png and b/core/src/components/chip/test/basic/chip.e2e.ts-snapshots/chip-basic-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/content/test/basic/content.e2e.ts-snapshots/content-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/content/test/basic/content.e2e.ts-snapshots/content-diff-md-ltr-Mobile-Chrome-linux.png index 6173d1dd4c..6173a9ad20 100644 Binary files a/core/src/components/content/test/basic/content.e2e.ts-snapshots/content-diff-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/content/test/basic/content.e2e.ts-snapshots/content-diff-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/content/test/standalone/content.e2e.ts-snapshots/content-standalone-md-ltr-Mobile-Safari-linux.png b/core/src/components/content/test/standalone/content.e2e.ts-snapshots/content-standalone-md-ltr-Mobile-Safari-linux.png index db025b8ed5..282c9940a0 100644 Binary files a/core/src/components/content/test/standalone/content.e2e.ts-snapshots/content-standalone-md-ltr-Mobile-Safari-linux.png and b/core/src/components/content/test/standalone/content.e2e.ts-snapshots/content-standalone-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/datetime-button/test/disabled/datetime-button.e2e.ts-snapshots/datetime-button-disabled-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/datetime-button/test/disabled/datetime-button.e2e.ts-snapshots/datetime-button-disabled-ios-ltr-Mobile-Chrome-linux.png index f6d8ce73e9..108ca802fc 100644 Binary files a/core/src/components/datetime-button/test/disabled/datetime-button.e2e.ts-snapshots/datetime-button-disabled-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/datetime-button/test/disabled/datetime-button.e2e.ts-snapshots/datetime-button-disabled-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime-button/test/disabled/datetime-button.e2e.ts-snapshots/datetime-button-disabled-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/datetime-button/test/disabled/datetime-button.e2e.ts-snapshots/datetime-button-disabled-ios-rtl-Mobile-Chrome-linux.png index 87ffd9350f..f899b18b58 100644 Binary files a/core/src/components/datetime-button/test/disabled/datetime-button.e2e.ts-snapshots/datetime-button-disabled-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/datetime-button/test/disabled/datetime-button.e2e.ts-snapshots/datetime-button-disabled-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime-button/test/disabled/datetime-button.e2e.ts-snapshots/datetime-button-disabled-md-ltr-Mobile-Chrome-linux.png b/core/src/components/datetime-button/test/disabled/datetime-button.e2e.ts-snapshots/datetime-button-disabled-md-ltr-Mobile-Chrome-linux.png index 3762deef61..ab4b04ba0a 100644 Binary files a/core/src/components/datetime-button/test/disabled/datetime-button.e2e.ts-snapshots/datetime-button-disabled-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/datetime-button/test/disabled/datetime-button.e2e.ts-snapshots/datetime-button-disabled-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime-button/test/disabled/datetime-button.e2e.ts-snapshots/datetime-button-disabled-md-rtl-Mobile-Chrome-linux.png b/core/src/components/datetime-button/test/disabled/datetime-button.e2e.ts-snapshots/datetime-button-disabled-md-rtl-Mobile-Chrome-linux.png index 824828664d..67c81dd664 100644 Binary files a/core/src/components/datetime-button/test/disabled/datetime-button.e2e.ts-snapshots/datetime-button-disabled-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/datetime-button/test/disabled/datetime-button.e2e.ts-snapshots/datetime-button-disabled-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-modal-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-modal-ios-ltr-Mobile-Chrome-linux.png index 789bbf66fa..9bde1858ae 100644 Binary files a/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-modal-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-modal-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-modal-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-modal-ios-rtl-Mobile-Chrome-linux.png index fb98c6c0c7..aeea23ee11 100644 Binary files a/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-modal-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-modal-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-modal-md-ltr-Mobile-Chrome-linux.png b/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-modal-md-ltr-Mobile-Chrome-linux.png index e48081922f..09f60c1daf 100644 Binary files a/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-modal-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-modal-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-modal-md-rtl-Mobile-Chrome-linux.png b/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-modal-md-rtl-Mobile-Chrome-linux.png index c85f04a795..8872f6d238 100644 Binary files a/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-modal-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-modal-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-popover-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-popover-ios-ltr-Mobile-Chrome-linux.png index 01adecdfa4..2620f38f6f 100644 Binary files a/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-popover-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-popover-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-popover-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-popover-ios-rtl-Mobile-Chrome-linux.png index 0ea751da19..f260c8b0d5 100644 Binary files a/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-popover-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-popover-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-popover-md-ltr-Mobile-Chrome-linux.png b/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-popover-md-ltr-Mobile-Chrome-linux.png index 55c92987cb..5701d7d776 100644 Binary files a/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-popover-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-popover-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-popover-md-rtl-Mobile-Chrome-linux.png b/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-popover-md-rtl-Mobile-Chrome-linux.png index c3757dd72f..c9b06292fc 100644 Binary files a/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-popover-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts-snapshots/datetime-overlay-popover-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-date-time-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-date-time-ios-ltr-Mobile-Chrome-linux.png index e20246ff44..ba9c8d1ab8 100644 Binary files a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-date-time-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-date-time-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-date-time-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-date-time-ios-rtl-Mobile-Chrome-linux.png index 7cfd73da51..d137358de1 100644 Binary files a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-date-time-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-date-time-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-date-time-md-ltr-Mobile-Chrome-linux.png b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-date-time-md-ltr-Mobile-Chrome-linux.png index dd57752b39..84ea59a150 100644 Binary files a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-date-time-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-date-time-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-date-time-md-rtl-Mobile-Chrome-linux.png b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-date-time-md-rtl-Mobile-Chrome-linux.png index d77f1477c3..fd132bd60d 100644 Binary files a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-date-time-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-date-time-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-time-date-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-time-date-ios-ltr-Mobile-Chrome-linux.png index 31016f93ee..c7782f19e7 100644 Binary files a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-time-date-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-time-date-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-time-date-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-time-date-ios-rtl-Mobile-Chrome-linux.png index 0c63cafad6..734e04d489 100644 Binary files a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-time-date-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-time-date-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-time-date-md-ltr-Mobile-Chrome-linux.png b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-time-date-md-ltr-Mobile-Chrome-linux.png index bcd6533422..ba280b2e52 100644 Binary files a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-time-date-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-time-date-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-time-date-md-rtl-Mobile-Chrome-linux.png b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-time-date-md-rtl-Mobile-Chrome-linux.png index 64580604e7..1ef7db9698 100644 Binary files a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-time-date-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-cover-time-date-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-date-time-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-date-time-ios-ltr-Mobile-Chrome-linux.png index abe57b598c..a53c202638 100644 Binary files a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-date-time-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-date-time-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-date-time-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-date-time-ios-rtl-Mobile-Chrome-linux.png index 876b7bd29d..09c2f7be0f 100644 Binary files a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-date-time-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-date-time-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-date-time-md-ltr-Mobile-Chrome-linux.png b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-date-time-md-ltr-Mobile-Chrome-linux.png index d1c2118314..10ba5bfc3d 100644 Binary files a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-date-time-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-date-time-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-date-time-md-rtl-Mobile-Chrome-linux.png b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-date-time-md-rtl-Mobile-Chrome-linux.png index 0ee3cceb35..9aa7fdd5e3 100644 Binary files a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-date-time-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-date-time-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-time-date-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-time-date-ios-ltr-Mobile-Chrome-linux.png index 3224391e35..df92eefea8 100644 Binary files a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-time-date-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-time-date-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-time-date-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-time-date-ios-rtl-Mobile-Chrome-linux.png index 923d74f120..6ac45142a6 100644 Binary files a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-time-date-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-time-date-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-time-date-md-ltr-Mobile-Chrome-linux.png b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-time-date-md-ltr-Mobile-Chrome-linux.png index 6de6350492..f604b02188 100644 Binary files a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-time-date-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-time-date-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-time-date-md-rtl-Mobile-Chrome-linux.png b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-time-date-md-rtl-Mobile-Chrome-linux.png index 01d1f53543..811ccf6982 100644 Binary files a/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-time-date-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/display/datetime.e2e.ts-snapshots/datetime-display-time-date-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/format.spec.ts b/core/src/components/datetime/test/format.spec.ts index 74e81bf890..73ef7245dc 100644 --- a/core/src/components/datetime/test/format.spec.ts +++ b/core/src/components/datetime/test/format.spec.ts @@ -168,4 +168,13 @@ describe('getLocalizedTime', () => { expect(getLocalizedTime('en-GB', datetimeParts, false)).toEqual('12:00 am'); }); + it('should parse time-only values correctly', () => { + const datetimeParts = { + hour: 22, + minute: 40, + }; + + expect(getLocalizedTime('en-US', datetimeParts, false)).toEqual('10:40 PM'); + expect(getLocalizedTime('en-US', datetimeParts, true)).toEqual('22:40'); + }); }); diff --git a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts index 2edebb7cff..081f1b76b6 100644 --- a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts +++ b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts @@ -34,9 +34,7 @@ test.describe('datetime: highlightedDates', () => { }); await page.waitForChanges(); - expect(await datetime.screenshot()).toMatchSnapshot( - `datetime-highlightedDates-array-${page.getSnapshotSettings()}.png` - ); + await expect(datetime).toHaveScreenshot(`datetime-highlightedDates-array-${page.getSnapshotSettings()}.png`); }); test('should render highlights correctly when using a callback', async ({ page }) => { @@ -74,9 +72,7 @@ test.describe('datetime: highlightedDates', () => { }); await page.waitForChanges(); - expect(await datetime.screenshot()).toMatchSnapshot( - `datetime-highlightedDates-callback-${page.getSnapshotSettings()}.png` - ); + await expect(datetime).toHaveScreenshot(`datetime-highlightedDates-callback-${page.getSnapshotSettings()}.png`); }); test('should render highlights correctly when only using one color or the other', async ({ page }) => { @@ -96,8 +92,6 @@ test.describe('datetime: highlightedDates', () => { }); await page.waitForChanges(); - expect(await datetime.screenshot()).toMatchSnapshot( - `datetime-highlightedDates-single-color-${page.getSnapshotSettings()}.png` - ); + await expect(datetime).toHaveScreenshot(`datetime-highlightedDates-single-color-${page.getSnapshotSettings()}.png`); }); }); diff --git a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-array-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-array-ios-ltr-Mobile-Chrome-linux.png index 86a3447122..de635679a1 100644 Binary files a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-array-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-array-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-array-ios-ltr-Mobile-Safari-linux.png b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-array-ios-ltr-Mobile-Safari-linux.png index d58794cf18..cbac770a76 100644 Binary files a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-array-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-array-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-array-md-ltr-Mobile-Chrome-linux.png b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-array-md-ltr-Mobile-Chrome-linux.png index c5084a6230..2283fe0091 100644 Binary files a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-array-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-array-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-array-md-ltr-Mobile-Safari-linux.png b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-array-md-ltr-Mobile-Safari-linux.png index b138075ff5..a0702cf11c 100644 Binary files a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-array-md-ltr-Mobile-Safari-linux.png and b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-array-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-callback-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-callback-ios-ltr-Mobile-Chrome-linux.png index e566c190d9..f61f635650 100644 Binary files a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-callback-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-callback-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-callback-ios-ltr-Mobile-Safari-linux.png b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-callback-ios-ltr-Mobile-Safari-linux.png index 58c1376934..5842d73b55 100644 Binary files a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-callback-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-callback-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-callback-md-ltr-Mobile-Chrome-linux.png b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-callback-md-ltr-Mobile-Chrome-linux.png index 75685f791a..1cbca72579 100644 Binary files a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-callback-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-callback-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-callback-md-ltr-Mobile-Safari-linux.png b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-callback-md-ltr-Mobile-Safari-linux.png index da31daf14a..1dadf93563 100644 Binary files a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-callback-md-ltr-Mobile-Safari-linux.png and b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-callback-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-single-color-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-single-color-ios-ltr-Mobile-Chrome-linux.png index c18944f97d..8dd0e4a386 100644 Binary files a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-single-color-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-single-color-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-single-color-ios-ltr-Mobile-Safari-linux.png b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-single-color-ios-ltr-Mobile-Safari-linux.png index 2e9ff91ece..c723ad5c66 100644 Binary files a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-single-color-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-single-color-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-single-color-md-ltr-Mobile-Chrome-linux.png b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-single-color-md-ltr-Mobile-Chrome-linux.png index d71aad7f7b..e7ff086a13 100644 Binary files a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-single-color-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-single-color-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-single-color-md-ltr-Mobile-Safari-linux.png b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-single-color-md-ltr-Mobile-Safari-linux.png index af652b53a9..72ece2a424 100644 Binary files a/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-single-color-md-ltr-Mobile-Safari-linux.png and b/core/src/components/datetime/test/highlightedDates/datetime.e2e.ts-snapshots/datetime-highlightedDates-single-color-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/datetime/utils/format.ts b/core/src/components/datetime/utils/format.ts index 53901f4a58..b335efb4c8 100644 --- a/core/src/components/datetime/utils/format.ts +++ b/core/src/components/datetime/utils/format.ts @@ -11,7 +11,12 @@ const getFormattedDayPeriod = (dayPeriod?: string) => { }; export const getLocalizedTime = (locale: string, refParts: DatetimeParts, use24Hour: boolean): string => { - if (refParts.hour === undefined || refParts.minute === undefined) { + const timeParts: Pick = { + hour: refParts.hour, + minute: refParts.minute, + }; + + if (timeParts.hour === undefined || timeParts.minute === undefined) { return 'Invalid Time'; } @@ -27,7 +32,21 @@ export const getLocalizedTime = (locale: string, refParts: DatetimeParts, use24H }).format( new Date( convertDataToISO({ - ...refParts, + /** + * JS uses a simplified ISO 8601 format which allows for + * date-only formats and date-time formats, but not + * time-only formats: https://tc39.es/ecma262/#sec-date-time-string-format + * As a result, developers who only pass a time will get + * an "Invalid Date" error. To account for this, we make sure that + * year/day/month values are set when passing to new Date(). + * The Intl.DateTimeFormat call above only uses the hour/minute + * values, so passing these date values should have no impact + * on the time output. + */ + year: 2023, + day: 1, + month: 1, + ...timeParts, // TODO: FW-1831 will remove the need to manually set the tzOffset to undefined tzOffset: undefined, }) diff --git a/core/src/components/datetime/utils/state.ts b/core/src/components/datetime/utils/state.ts index f709d7289a..d2a886537a 100644 --- a/core/src/components/datetime/utils/state.ts +++ b/core/src/components/datetime/utils/state.ts @@ -1,5 +1,4 @@ -import { printIonError } from '@utils/logging'; - +import { printIonError } from '../../../utils/logging'; import type { DatetimeHighlight, DatetimeHighlightCallback, diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-ltr-Mobile-Chrome-linux.png index d6f8bf5673..cb4a8ba74c 100644 Binary files a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-rtl-Mobile-Chrome-linux.png index 6d5e79a449..0815af9ab2 100644 Binary files a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/grid/test/offsets/grid.e2e.ts-snapshots/grid-offsets-md-ltr-Mobile-Chrome-linux.png b/core/src/components/grid/test/offsets/grid.e2e.ts-snapshots/grid-offsets-md-ltr-Mobile-Chrome-linux.png index c3c9e8884d..a997065bc2 100644 Binary files a/core/src/components/grid/test/offsets/grid.e2e.ts-snapshots/grid-offsets-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/grid/test/offsets/grid.e2e.ts-snapshots/grid-offsets-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/grid/test/offsets/grid.e2e.ts-snapshots/grid-offsets-md-rtl-Mobile-Chrome-linux.png b/core/src/components/grid/test/offsets/grid.e2e.ts-snapshots/grid-offsets-md-rtl-Mobile-Chrome-linux.png index 8eb4bba9a2..6196af10e2 100644 Binary files a/core/src/components/grid/test/offsets/grid.e2e.ts-snapshots/grid-offsets-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/grid/test/offsets/grid.e2e.ts-snapshots/grid-offsets-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/icon/test/basic/index.html b/core/src/components/icon/test/basic/index.html index 1295cd4af5..e6ea0961b3 100644 --- a/core/src/components/icon/test/basic/index.html +++ b/core/src/components/icon/test/basic/index.html @@ -87,6 +87,30 @@ + + + +

ios: star outline

+

md: star

+ + + + + +

mode: ios

+

ios: star outline

+

md: star

+ + + + + +

mode: md

+

ios: star outline

+

md: star

+ + + ion-item w/ [detail="true"] attr. text text text text text text diff --git a/core/src/components/img/test/basic/img.e2e.ts b/core/src/components/img/test/basic/img.e2e.ts index 07d8fa4edd..097c4c9812 100644 --- a/core/src/components/img/test/basic/img.e2e.ts +++ b/core/src/components/img/test/basic/img.e2e.ts @@ -8,7 +8,8 @@ test.describe('img: basic', () => { skip.mode('ios'); }); - test.describe('image successfully loads', () => { + // TODO FW-3596 + test.describe.skip('image successfully loads', () => { let ionImgWillLoad: EventSpy; let ionImgDidLoad: EventSpy; diff --git a/core/src/components/input/test/input.spec.ts b/core/src/components/input/test/input.spec.ts new file mode 100644 index 0000000000..f07d46c8f0 --- /dev/null +++ b/core/src/components/input/test/input.spec.ts @@ -0,0 +1,14 @@ +import { newSpecPage } from '@stencil/core/testing'; +import { Input } from '../input'; + +it('should inherit attributes', async () => { + const page = await newSpecPage({ + components: [Input], + html: '', + }); + + const nativeEl = page.body.querySelector('ion-input input'); + expect(nativeEl.getAttribute('title')).toBe('my title'); + expect(nativeEl.getAttribute('tabindex')).toBe('-1'); + expect(nativeEl.getAttribute('data-form-type')).toBe('password'); +}); diff --git a/core/src/components/input/test/spec/input.e2e.ts-snapshots/input-spec-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/input/test/spec/input.e2e.ts-snapshots/input-spec-diff-ios-ltr-Mobile-Chrome-linux.png index 0b8cf13bc8..f67dce551e 100644 Binary files a/core/src/components/input/test/spec/input.e2e.ts-snapshots/input-spec-diff-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/input/test/spec/input.e2e.ts-snapshots/input-spec-diff-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/input/test/spec/input.e2e.ts-snapshots/input-spec-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/input/test/spec/input.e2e.ts-snapshots/input-spec-diff-ios-rtl-Mobile-Chrome-linux.png index d2f790f047..e9a3ff63c0 100644 Binary files a/core/src/components/input/test/spec/input.e2e.ts-snapshots/input-spec-diff-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/input/test/spec/input.e2e.ts-snapshots/input-spec-diff-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item-sliding/test/test.utils.ts b/core/src/components/item-sliding/test/test.utils.ts index 9fa3ee27a0..17fe093d11 100644 --- a/core/src/components/item-sliding/test/test.utils.ts +++ b/core/src/components/item-sliding/test/test.utils.ts @@ -23,9 +23,7 @@ export const testSlidingItem = async ( // opening animation takes longer than waitForChanges accounts for await page.waitForTimeout(500); - expect(await item.screenshot()).toMatchSnapshot( - `item-sliding-${screenshotNameSuffix}-${page.getSnapshotSettings()}.png` - ); + await expect(item).toHaveScreenshot(`item-sliding-${screenshotNameSuffix}-${page.getSnapshotSettings()}.png`); await item.evaluate(async (el: HTMLIonItemSlidingElement) => { await el.close(); diff --git a/core/src/components/item/test/buttons/item.e2e.ts-snapshots/item-buttons-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/item/test/buttons/item.e2e.ts-snapshots/item-buttons-diff-md-ltr-Mobile-Chrome-linux.png index 02146e6402..315eb5768b 100644 Binary files a/core/src/components/item/test/buttons/item.e2e.ts-snapshots/item-buttons-diff-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/item/test/buttons/item.e2e.ts-snapshots/item-buttons-diff-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/buttons/item.e2e.ts-snapshots/item-buttons-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/item/test/buttons/item.e2e.ts-snapshots/item-buttons-diff-md-rtl-Mobile-Chrome-linux.png index 624c3302ec..45b664f346 100644 Binary files a/core/src/components/item/test/buttons/item.e2e.ts-snapshots/item-buttons-diff-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/item/test/buttons/item.e2e.ts-snapshots/item-buttons-diff-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Chrome-linux.png index 35fbea9d7c..865937ef15 100644 Binary files a/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-rtl-Mobile-Chrome-linux.png index dda1a2a2ff..a0ca934747 100644 Binary files a/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Chrome-linux.png index b67449f11e..97c12f372d 100644 Binary files a/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-rtl-Mobile-Chrome-linux.png index f4cfd17ca9..7812f64ee4 100644 Binary files a/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/item/test/disabled/item.e2e.ts-snapshots/item-disabled-diff-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-ios-ltr-Mobile-Chrome-linux.png index d995a15e19..7926c38ca1 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-ios-rtl-Mobile-Chrome-linux.png index 0b36defe2e..52ece4de19 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-md-ltr-Mobile-Chrome-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-md-ltr-Mobile-Chrome-linux.png index 47302f74b5..11aa39a5f6 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-md-rtl-Mobile-Chrome-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-md-rtl-Mobile-Chrome-linux.png index 155ad4eebf..0ac43f57bc 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-disabled-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-ltr-Mobile-Chrome-linux.png index 24beccae1b..51c01d7475 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-rtl-Mobile-Chrome-linux.png index 44e6c1cd34..1b8993e123 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-ltr-Mobile-Chrome-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-ltr-Mobile-Chrome-linux.png index b94098737d..c296011485 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-rtl-Mobile-Chrome-linux.png b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-rtl-Mobile-Chrome-linux.png index b2462f8724..133c18eb4b 100644 Binary files a/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/item/test/inputs/item.e2e.ts-snapshots/item-inputs-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-basic-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-basic-diff-md-ltr-Mobile-Chrome-linux.png index 402b8b7f0d..aa13b5f62f 100644 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-basic-diff-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-basic-diff-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-basic-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-basic-diff-md-rtl-Mobile-Chrome-linux.png index 492f66b0ad..3da39bc3d5 100644 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-basic-diff-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-basic-diff-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-ltr-Mobile-Chrome-linux.png index 9a5b7ce8d4..743fe7d397 100644 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-rtl-Mobile-Chrome-linux.png index 31d27f95f0..ff53f176e3 100644 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-html-content-diff-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-md-ltr-Mobile-Chrome-linux.png index 5b446697aa..92269920fa 100644 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-md-rtl-Mobile-Chrome-linux.png index 5e9655189e..167844fce4 100644 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-long-content-diff-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-md-ltr-Mobile-Chrome-linux.png index 92e0a11691..ffea86b7b6 100644 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-md-rtl-Mobile-Chrome-linux.png index 9090036bdc..a02b4ff04d 100644 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-no-spinner-diff-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-ltr-Mobile-Chrome-linux.png index 1e9a5b4519..05c0824b84 100644 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-rtl-Mobile-Chrome-linux.png index 894f64e940..09e07bfc6f 100644 Binary files a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-translucent-diff-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/menu/menu.tsx b/core/src/components/menu/menu.tsx index 178491bef9..fdae1de8c9 100644 --- a/core/src/components/menu/menu.tsx +++ b/core/src/components/menu/menu.tsx @@ -173,7 +173,7 @@ export class Menu implements ComponentInterface, MenuI { async connectedCallback() { // TODO: connectedCallback is fired in CE build // before WC is defined. This needs to be fixed in Stencil. - if (typeof (customElements as any) !== 'undefined') { + if (typeof (customElements as any) !== 'undefined' && (customElements as any) != null) { await customElements.whenDefined('ion-menu'); } diff --git a/core/src/components/modal/modal.tsx b/core/src/components/modal/modal.tsx index 06bca33b73..6332843018 100644 --- a/core/src/components/modal/modal.tsx +++ b/core/src/components/modal/modal.tsx @@ -306,7 +306,7 @@ export class Modal implements ComponentInterface, OverlayInterface { /** * Emitted after the modal has presented. - * Shorthand for ionModalWillDismiss. + * Shorthand for ionModalDidPresent. */ @Event({ eventName: 'didPresent' }) didPresentShorthand!: EventEmitter; diff --git a/core/src/components/modal/test/basic/modal.e2e.ts b/core/src/components/modal/test/basic/modal.e2e.ts index b1ea9f8803..9d6c1b039a 100644 --- a/core/src/components/modal/test/basic/modal.e2e.ts +++ b/core/src/components/modal/test/basic/modal.e2e.ts @@ -75,6 +75,7 @@ test.describe('modal: rendering', () => { await ionModalDidPresent.next(); const modal = await page.locator('ion-modal'); + await expect(modal).toHaveClass(/show-modal/); await page.setIonViewport(); @@ -87,6 +88,7 @@ test.describe('modal: rendering', () => { await ionModalWillDismiss.next(); await ionModalDidDismiss.next(); + await expect(modal).not.toHaveClass(/show-modal/); await expect(modal).toBeHidden(); }; diff --git a/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-md-ltr-Mobile-Chrome-linux.png b/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-md-ltr-Mobile-Chrome-linux.png index a34144d091..cafd8ae3f2 100644 Binary files a/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-md-rtl-Mobile-Chrome-linux.png b/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-md-rtl-Mobile-Chrome-linux.png index 633346bd77..f0c54a8742 100644 Binary files a/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/modal/test/sheet/modal.e2e.ts-snapshots/modal-sheet-present-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/picker-column-internal/test/basic/picker-column-internal.e2e.ts b/core/src/components/picker-column-internal/test/basic/picker-column-internal.e2e.ts index 455a0a25a9..c42c3c1a89 100644 --- a/core/src/components/picker-column-internal/test/basic/picker-column-internal.e2e.ts +++ b/core/src/components/picker-column-internal/test/basic/picker-column-internal.e2e.ts @@ -32,7 +32,8 @@ test.describe('picker-column-internal', () => { expect(activeColumn).not.toBeNull(); }); - test('scrolling should change the active item', async ({ page, skip }) => { + // TODO FW-3616 + test.skip('scrolling should change the active item', async ({ page, skip }) => { skip.browser('firefox', 'https://bugzilla.mozilla.org/show_bug.cgi?id=1766890'); await page.locator('#default').evaluate((el: HTMLIonPickerColumnInternalElement) => { @@ -57,7 +58,8 @@ test.describe('picker-column-internal', () => { expect(ionChangeSpy).not.toHaveReceivedEvent(); }); - test('should emit ionChange when the picker is scrolled', async ({ page, skip }) => { + // TODO FW-3616 + test.skip('should emit ionChange when the picker is scrolled', async ({ page, skip }) => { skip.browser('firefox', 'https://bugzilla.mozilla.org/show_bug.cgi?id=1766890'); const ionChangeSpy = await page.spyOnEvent('ionChange'); diff --git a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-ios-ltr-Mobile-Chrome-linux.png index f3d11e6c46..e57f707c05 100644 Binary files a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-ios-ltr-Mobile-Safari-linux.png b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-ios-ltr-Mobile-Safari-linux.png index 5e6025e57f..8cef6ba1e6 100644 Binary files a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-ios-rtl-Mobile-Chrome-linux.png index 89d66f9610..bc5bec1ad2 100644 Binary files a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-ios-rtl-Mobile-Safari-linux.png b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-ios-rtl-Mobile-Safari-linux.png index f292bcf67b..20f3bba761 100644 Binary files a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-md-ltr-Mobile-Chrome-linux.png b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-md-ltr-Mobile-Chrome-linux.png index 3c508326f9..4cea252d24 100644 Binary files a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-md-ltr-Mobile-Safari-linux.png b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-md-ltr-Mobile-Safari-linux.png index 8aadfbb770..fcef84c56b 100644 Binary files a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-md-ltr-Mobile-Safari-linux.png and b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-md-rtl-Mobile-Chrome-linux.png b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-md-rtl-Mobile-Chrome-linux.png index 0a596811e4..00440256f8 100644 Binary files a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-md-rtl-Mobile-Safari-linux.png b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-md-rtl-Mobile-Safari-linux.png index a8b4534783..0d1841aaac 100644 Binary files a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-md-rtl-Mobile-Safari-linux.png and b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-multiple-column-initial-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-ios-ltr-Mobile-Chrome-linux.png index 2d4cded343..1edaaf1c1a 100644 Binary files a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-ios-ltr-Mobile-Safari-linux.png b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-ios-ltr-Mobile-Safari-linux.png index 5d081ef305..6d90ea060f 100644 Binary files a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-ios-rtl-Mobile-Chrome-linux.png index d1428d8866..25bc8fd052 100644 Binary files a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-ios-rtl-Mobile-Safari-linux.png b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-ios-rtl-Mobile-Safari-linux.png index 97ccd37d7e..ec8ec22fb1 100644 Binary files a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-md-ltr-Mobile-Chrome-linux.png b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-md-ltr-Mobile-Chrome-linux.png index 9df3ec6691..f63d16b653 100644 Binary files a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-md-ltr-Mobile-Safari-linux.png b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-md-ltr-Mobile-Safari-linux.png index 5bccff17a4..88d75074d5 100644 Binary files a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-md-ltr-Mobile-Safari-linux.png and b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-md-rtl-Mobile-Chrome-linux.png b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-md-rtl-Mobile-Chrome-linux.png index a5a777501b..da13ffb5d8 100644 Binary files a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-md-rtl-Mobile-Safari-linux.png b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-md-rtl-Mobile-Safari-linux.png index bb97505e50..0c0a39befb 100644 Binary files a/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-md-rtl-Mobile-Safari-linux.png and b/core/src/components/picker-column/test/standalone/picker-column.e2e.ts-snapshots/picker-single-column-initial-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/picker-column/test/test.utils.ts b/core/src/components/picker-column/test/test.utils.ts index e2007ed554..867086eeef 100644 --- a/core/src/components/picker-column/test/test.utils.ts +++ b/core/src/components/picker-column/test/test.utils.ts @@ -15,9 +15,7 @@ export async function testPickerColumn(page: E2EPage, buttonSelector: string, de await page.waitForChanges(); - expect(await page.screenshot()).toMatchSnapshot( - `picker-${description}-column-initial-${page.getSnapshotSettings()}.png` - ); + await expect(page).toHaveScreenshot(`picker-${description}-column-initial-${page.getSnapshotSettings()}.png`); // TODO FW-3403 /* diff --git a/core/src/components/popover/test/arrow/popover.e2e.ts-snapshots/popover-arrow-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/popover/test/arrow/popover.e2e.ts-snapshots/popover-arrow-ios-ltr-Mobile-Firefox-linux.png index b71200f4db..34c0357770 100644 Binary files a/core/src/components/popover/test/arrow/popover.e2e.ts-snapshots/popover-arrow-ios-ltr-Mobile-Firefox-linux.png and b/core/src/components/popover/test/arrow/popover.e2e.ts-snapshots/popover-arrow-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/popover/test/arrow/popover.e2e.ts-snapshots/popover-arrow-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/popover/test/arrow/popover.e2e.ts-snapshots/popover-arrow-ios-rtl-Mobile-Firefox-linux.png index a5706b42f4..f64314bd3a 100644 Binary files a/core/src/components/popover/test/arrow/popover.e2e.ts-snapshots/popover-arrow-ios-rtl-Mobile-Firefox-linux.png and b/core/src/components/popover/test/arrow/popover.e2e.ts-snapshots/popover-arrow-ios-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/popover/test/arrow/popover.e2e.ts-snapshots/popover-arrow-md-ltr-Mobile-Firefox-linux.png b/core/src/components/popover/test/arrow/popover.e2e.ts-snapshots/popover-arrow-md-ltr-Mobile-Firefox-linux.png index 1d95d875f8..8285fe7c65 100644 Binary files a/core/src/components/popover/test/arrow/popover.e2e.ts-snapshots/popover-arrow-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/popover/test/arrow/popover.e2e.ts-snapshots/popover-arrow-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/popover/test/arrow/popover.e2e.ts-snapshots/popover-arrow-md-rtl-Mobile-Firefox-linux.png b/core/src/components/popover/test/arrow/popover.e2e.ts-snapshots/popover-arrow-md-rtl-Mobile-Firefox-linux.png index f949a4887e..da0847075e 100644 Binary files a/core/src/components/popover/test/arrow/popover.e2e.ts-snapshots/popover-arrow-md-rtl-Mobile-Firefox-linux.png and b/core/src/components/popover/test/arrow/popover.e2e.ts-snapshots/popover-arrow-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ios-ltr-Mobile-Chrome-linux.png index 596f3d0c89..db66eb16c7 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ios-ltr-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ios-ltr-Mobile-Safari-linux.png index bf70c96b67..05d8ff117b 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ios-rtl-Mobile-Chrome-linux.png index 5e1f36f111..a33261572a 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ios-rtl-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ios-rtl-Mobile-Safari-linux.png index 15e94a3412..90758487ac 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-md-ltr-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-md-ltr-Mobile-Chrome-linux.png index 6614a055bc..3ba917b03d 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-md-ltr-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-md-ltr-Mobile-Safari-linux.png index 34f97482e2..8a0daf8b8d 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-md-ltr-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-md-rtl-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-md-rtl-Mobile-Chrome-linux.png index 13045b1477..c6b2367166 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-md-rtl-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-md-rtl-Mobile-Safari-linux.png index a6a55ccbeb..ed6a25d6dc 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-md-rtl-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-basic-popover-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ios-ltr-Mobile-Chrome-linux.png index 7e1ccfa837..0cb46784a7 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ios-ltr-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ios-ltr-Mobile-Safari-linux.png index f1f0cadb0e..ddf089116b 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ios-rtl-Mobile-Chrome-linux.png index 1942066a75..b6281e7bd7 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ios-rtl-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ios-rtl-Mobile-Safari-linux.png index 1c716cb748..75c356223c 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-md-ltr-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-md-ltr-Mobile-Chrome-linux.png index 863909b94b..fbf3c34099 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-md-ltr-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-md-ltr-Mobile-Safari-linux.png index 897c9f68de..7fe72d81b6 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-md-ltr-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-md-rtl-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-md-rtl-Mobile-Chrome-linux.png index 9952ed3ac2..e39b7f42f8 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-md-rtl-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-md-rtl-Mobile-Safari-linux.png index 0f685af789..eb242265b2 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-md-rtl-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-custom-class-popover-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ios-ltr-Mobile-Chrome-linux.png index 292fb70552..92512cf9a5 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ios-ltr-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ios-ltr-Mobile-Safari-linux.png index 055d816e52..919d1d436a 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ios-rtl-Mobile-Chrome-linux.png index b655bb1028..a31de94e5e 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ios-rtl-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ios-rtl-Mobile-Safari-linux.png index 21803fb3d7..bc23f01c07 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-md-ltr-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-md-ltr-Mobile-Chrome-linux.png index 4026bafc04..993d4792cb 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-md-ltr-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-md-ltr-Mobile-Safari-linux.png index 640c91fefa..9e59e96965 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-md-ltr-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-md-rtl-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-md-rtl-Mobile-Chrome-linux.png index 8db6b8393c..98d8b5e04d 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-md-rtl-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-md-rtl-Mobile-Safari-linux.png index ebc9afbabe..007c394122 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-md-rtl-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-header-popover-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ios-ltr-Mobile-Chrome-linux.png index be515272d0..65a0aa7655 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ios-ltr-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ios-ltr-Mobile-Safari-linux.png index 4a29ee84db..3269ddded5 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ios-rtl-Mobile-Chrome-linux.png index ab0dd79d87..e31ec15e7c 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ios-rtl-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ios-rtl-Mobile-Safari-linux.png index a6fc832231..49c4d62d70 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-md-ltr-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-md-ltr-Mobile-Chrome-linux.png index bde1f618b6..81a66862cc 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-md-ltr-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-md-ltr-Mobile-Safari-linux.png index 18625b88d2..f50660fd81 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-md-ltr-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-md-rtl-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-md-rtl-Mobile-Chrome-linux.png index b26d13b1ff..a787a32a38 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-md-rtl-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-md-rtl-Mobile-Safari-linux.png index d9384bda94..c949e05c64 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-md-rtl-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-long-list-popover-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-ios-ltr-Mobile-Chrome-linux.png index 737de0a093..36800fa78c 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-ios-ltr-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-ios-ltr-Mobile-Safari-linux.png index a36fd32f57..eade46dd7d 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-ios-rtl-Mobile-Chrome-linux.png index 45bd849cef..26379edc48 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-ios-rtl-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-ios-rtl-Mobile-Safari-linux.png index 1b33fc7d81..3f613e00d1 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-md-ltr-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-md-ltr-Mobile-Chrome-linux.png index 0d7b008f74..005b2d998f 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-md-ltr-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-md-ltr-Mobile-Safari-linux.png index ed6d15271c..ad371361bd 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-md-ltr-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-md-rtl-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-md-rtl-Mobile-Chrome-linux.png index 96c75f0abb..845385f885 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-md-rtl-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-md-rtl-Mobile-Safari-linux.png index 9c4160869f..e5c061ce47 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-md-rtl-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-no-event-popover-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-ios-ltr-Mobile-Chrome-linux.png index 6f1e673669..614c41c8cc 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-ios-ltr-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-ios-ltr-Mobile-Safari-linux.png index c8f10610fa..b5f8a8ee96 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-ios-rtl-Mobile-Chrome-linux.png index f3be877960..da8da211f8 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-ios-rtl-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-ios-rtl-Mobile-Safari-linux.png index 248b15d52a..fc4ea5089e 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-md-ltr-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-md-ltr-Mobile-Chrome-linux.png index 4026bafc04..993d4792cb 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-md-ltr-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-md-ltr-Mobile-Safari-linux.png index 640c91fefa..9e59e96965 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-md-ltr-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-md-rtl-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-md-rtl-Mobile-Chrome-linux.png index 8db6b8393c..98d8b5e04d 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-md-rtl-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-md-rtl-Mobile-Safari-linux.png index ebc9afbabe..007c394122 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-md-rtl-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-header-popover-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-ios-ltr-Mobile-Chrome-linux.png index 2361952d0a..558ad477e5 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-ios-ltr-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-ios-ltr-Mobile-Safari-linux.png index 0dbda52d35..6383988562 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-ios-rtl-Mobile-Chrome-linux.png index a220a0a6cf..2f39b18fe3 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-ios-rtl-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-ios-rtl-Mobile-Safari-linux.png index 21ee6c8ff6..c8dd0aa7b9 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-md-ltr-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-md-ltr-Mobile-Chrome-linux.png index d1f1e68098..bf2d9481ac 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-md-ltr-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-md-ltr-Mobile-Safari-linux.png index 8f1570a3b9..3a309a2081 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-md-ltr-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-md-rtl-Mobile-Chrome-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-md-rtl-Mobile-Chrome-linux.png index fa2815aed6..2efccb99a0 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-md-rtl-Mobile-Safari-linux.png b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-md-rtl-Mobile-Safari-linux.png index 81805c6991..12d7649148 100644 Binary files a/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-md-rtl-Mobile-Safari-linux.png and b/core/src/components/popover/test/basic/popover.e2e.ts-snapshots/popover-basic-translucent-popover-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/dismissOnSelect/popover.e2e.ts b/core/src/components/popover/test/dismissOnSelect/popover.e2e.ts index 4824740bff..453f4af765 100644 --- a/core/src/components/popover/test/dismissOnSelect/popover.e2e.ts +++ b/core/src/components/popover/test/dismissOnSelect/popover.e2e.ts @@ -23,13 +23,7 @@ test.describe('popover: dismissOnSelect', async () => { await expect(popover).toBeVisible(); }); - test('should not dismiss a popover when clicking a click trigger', async ({ page, skip }) => { - // TODO FW-1486 - skip.browser( - 'firefox', - 'Parent popover disappears when click trigger is clicked. Cannot replicate locally. Needs further investigation.' - ); - + test('should not dismiss a popover when clicking a click trigger', async ({ page }) => { const ionPopoverDidPresent = await page.spyOnEvent('ionPopoverDidPresent'); await openPopover(page, 'click-trigger'); diff --git a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-ios-ltr-Mobile-Chrome-linux.png index db46811d35..e0a31216ac 100644 Binary files a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-ios-ltr-Mobile-Safari-linux.png b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-ios-ltr-Mobile-Safari-linux.png index 01b61832c6..15cb54937b 100644 Binary files a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-ios-rtl-Mobile-Chrome-linux.png index fb09395bbd..6878b17450 100644 Binary files a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-ios-rtl-Mobile-Safari-linux.png b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-ios-rtl-Mobile-Safari-linux.png index 524e829355..ddaac4e6b3 100644 Binary files a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-md-ltr-Mobile-Chrome-linux.png b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-md-ltr-Mobile-Chrome-linux.png index 5c5cb7edc3..6b44651858 100644 Binary files a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-md-ltr-Mobile-Firefox-linux.png b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-md-ltr-Mobile-Firefox-linux.png index fb5fe23072..5b1569e0a0 100644 Binary files a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-md-ltr-Mobile-Safari-linux.png b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-md-ltr-Mobile-Safari-linux.png index a39703fe0c..8a2403952c 100644 Binary files a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-md-ltr-Mobile-Safari-linux.png and b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-md-rtl-Mobile-Chrome-linux.png b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-md-rtl-Mobile-Chrome-linux.png index 31a8f63e39..e8c1dec38c 100644 Binary files a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-md-rtl-Mobile-Firefox-linux.png b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-md-rtl-Mobile-Firefox-linux.png index e491445162..311bd9f6eb 100644 Binary files a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-md-rtl-Mobile-Firefox-linux.png and b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-md-rtl-Mobile-Safari-linux.png b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-md-rtl-Mobile-Safari-linux.png index 5b60d808e3..80f7e993cb 100644 Binary files a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-md-rtl-Mobile-Safari-linux.png and b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-event-trigger-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-ios-ltr-Mobile-Chrome-linux.png index aa6e616fb3..cd289b05e9 100644 Binary files a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-ios-ltr-Mobile-Safari-linux.png b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-ios-ltr-Mobile-Safari-linux.png index 0d77e60024..c77318e0ce 100644 Binary files a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-ios-rtl-Mobile-Chrome-linux.png index 026ad178ca..7984361758 100644 Binary files a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-ios-rtl-Mobile-Safari-linux.png b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-ios-rtl-Mobile-Safari-linux.png index f5d28f9f38..14be2ce2f7 100644 Binary files a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-md-ltr-Mobile-Chrome-linux.png b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-md-ltr-Mobile-Chrome-linux.png index 332f8d712f..bd3ba35fcb 100644 Binary files a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-md-ltr-Mobile-Firefox-linux.png b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-md-ltr-Mobile-Firefox-linux.png index 0dd6afcc70..fa3dd5383c 100644 Binary files a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-md-ltr-Mobile-Safari-linux.png b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-md-ltr-Mobile-Safari-linux.png index 7b9f23686f..b299e2543d 100644 Binary files a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-md-ltr-Mobile-Safari-linux.png and b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-md-rtl-Mobile-Chrome-linux.png b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-md-rtl-Mobile-Chrome-linux.png index 5642f0897a..8ce6683d6c 100644 Binary files a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-md-rtl-Mobile-Firefox-linux.png b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-md-rtl-Mobile-Firefox-linux.png index 7f5a92565d..910d0bdc33 100644 Binary files a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-md-rtl-Mobile-Firefox-linux.png and b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-md-rtl-Mobile-Safari-linux.png b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-md-rtl-Mobile-Safari-linux.png index 6282b962d9..758df7722b 100644 Binary files a/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-md-rtl-Mobile-Safari-linux.png and b/core/src/components/popover/test/reference/popover.e2e.ts-snapshots/popover-reference-trigger-trigger-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/size/popover.e2e.ts b/core/src/components/popover/test/size/popover.e2e.ts index 15842789a9..6c77927a17 100644 --- a/core/src/components/popover/test/size/popover.e2e.ts +++ b/core/src/components/popover/test/size/popover.e2e.ts @@ -1,7 +1,7 @@ import { expect } from '@playwright/test'; import { test, Viewports } from '@utils/test/playwright'; -import { openPopover, screenshotPopover } from '../test.utils'; +import { openPopover } from '../test.utils'; test.describe('popover: size', async () => { /** @@ -22,6 +22,7 @@ test.describe('popover: size', async () => { await expect(page).toHaveScreenshot(`popover-size-${page.getSnapshotSettings()}.png`); // test this one separately since it would overlap others - await screenshotPopover(page, 'no-event-trigger', 'size'); + // TODO FW-3598 + //await screenshotPopover(page, 'no-event-trigger', 'size'); }); }); diff --git a/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-ios-ltr-Mobile-Chrome-linux.png index 8b23563c71..6cb9cadf55 100644 Binary files a/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-ios-rtl-Mobile-Chrome-linux.png index c3f686b959..956b83642d 100644 Binary files a/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-no-event-trigger-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-no-event-trigger-ios-ltr-Mobile-Chrome-linux.png index 45dd3a0fc4..79795e531d 100644 Binary files a/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-no-event-trigger-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-no-event-trigger-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-no-event-trigger-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-no-event-trigger-ios-rtl-Mobile-Chrome-linux.png index 6be470bf84..0d0007ab49 100644 Binary files a/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-no-event-trigger-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/popover/test/size/popover.e2e.ts-snapshots/popover-size-no-event-trigger-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-ios-ltr-Mobile-Chrome-linux.png index ae3cbcd7e6..e04857621a 100644 Binary files a/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-ios-ltr-Mobile-Safari-linux.png b/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-ios-ltr-Mobile-Safari-linux.png index 19074a36b7..0fd4271fb0 100644 Binary files a/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-ios-rtl-Mobile-Chrome-linux.png index 281942d57d..0b98d9e86a 100644 Binary files a/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-ios-rtl-Mobile-Safari-linux.png b/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-ios-rtl-Mobile-Safari-linux.png index f49220b2e6..c3093cf140 100644 Binary files a/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-md-ltr-Mobile-Chrome-linux.png b/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-md-ltr-Mobile-Chrome-linux.png index 35ddf93a2b..acf396a327 100644 Binary files a/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-md-ltr-Mobile-Safari-linux.png b/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-md-ltr-Mobile-Safari-linux.png index 1d219e835e..cac21633c9 100644 Binary files a/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-md-ltr-Mobile-Safari-linux.png and b/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-md-rtl-Mobile-Chrome-linux.png b/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-md-rtl-Mobile-Chrome-linux.png index 4a44318e40..468ec840e9 100644 Binary files a/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-md-rtl-Mobile-Safari-linux.png b/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-md-rtl-Mobile-Safari-linux.png index 2d949be3fa..fe64b8e3bc 100644 Binary files a/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-md-rtl-Mobile-Safari-linux.png and b/core/src/components/popover/test/standalone/popover.e2e.ts-snapshots/popover-standalone-basic-popover-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/popover/test/test.utils.ts b/core/src/components/popover/test/test.utils.ts index 05f7b11ebb..819260315a 100644 --- a/core/src/components/popover/test/test.utils.ts +++ b/core/src/components/popover/test/test.utils.ts @@ -36,5 +36,5 @@ export const screenshotPopover = async (page: E2EPage, buttonID: string, testNam await page.setIonViewport(); await openPopover(page, buttonID); - expect(await page.screenshot()).toMatchSnapshot(`popover-${testName}-${buttonID}-${page.getSnapshotSettings()}.png`); + await expect(page).toHaveScreenshot(`popover-${testName}-${buttonID}-${page.getSnapshotSettings()}.png`); }; diff --git a/core/src/components/radio/radio.tsx b/core/src/components/radio/radio.tsx index 373c5f03a0..f153b54f0b 100644 --- a/core/src/components/radio/radio.tsx +++ b/core/src/components/radio/radio.tsx @@ -60,6 +60,16 @@ export class Radio implements ComponentInterface { */ @Prop() value?: any | null; + @Watch('value') + valueChanged() { + /** + * The new value of the radio may + * match the radio group's value, + * so we see if it should be checked. + */ + this.updateState(); + } + /** * Emitted when the styles change. * @internal diff --git a/core/src/components/radio/test/radio.spec.ts b/core/src/components/radio/test/radio.spec.ts index 4cd981805b..88b4547109 100644 --- a/core/src/components/radio/test/radio.spec.ts +++ b/core/src/components/radio/test/radio.spec.ts @@ -1,4 +1,6 @@ import { Radio } from '../radio.tsx'; +import { RadioGroup } from '../../radio-group/radio-group.tsx'; +import { newSpecPage } from '@stencil/core/testing'; describe('ion-radio', () => { it('should set a default value', async () => { @@ -8,4 +10,24 @@ describe('ion-radio', () => { expect(radio.value).toEqual('ion-rb-0'); }); + + it('should update the checked state when updating the value', async () => { + const page = await newSpecPage({ + components: [Radio, RadioGroup], + html: ` + + + + `, + }); + + const radio = page.root.querySelector('ion-radio'); + expect(radio.classList.contains('radio-checked')).toBe(false); + + radio.value = 'a'; + + await page.waitForChanges(); + + expect(radio.classList.contains('radio-checked')).toBe(true); + }); }); diff --git a/core/src/components/range/test/basic/range.e2e.ts-snapshots/range-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/range/test/basic/range.e2e.ts-snapshots/range-diff-ios-ltr-Mobile-Chrome-linux.png index aba33bb164..1f8ec1b9ae 100644 Binary files a/core/src/components/range/test/basic/range.e2e.ts-snapshots/range-diff-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/range/test/basic/range.e2e.ts-snapshots/range-diff-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/range/test/basic/range.e2e.ts-snapshots/range-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/range/test/basic/range.e2e.ts-snapshots/range-diff-ios-rtl-Mobile-Chrome-linux.png index 225d5bed6c..00aecce687 100644 Binary files a/core/src/components/range/test/basic/range.e2e.ts-snapshots/range-diff-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/range/test/basic/range.e2e.ts-snapshots/range-diff-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/range/test/basic/range.e2e.ts-snapshots/range-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/range/test/basic/range.e2e.ts-snapshots/range-diff-md-ltr-Mobile-Chrome-linux.png index 3aa726fdfa..f809a47ec7 100644 Binary files a/core/src/components/range/test/basic/range.e2e.ts-snapshots/range-diff-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/range/test/basic/range.e2e.ts-snapshots/range-diff-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/range/test/basic/range.e2e.ts-snapshots/range-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/range/test/basic/range.e2e.ts-snapshots/range-diff-md-rtl-Mobile-Chrome-linux.png index 73cb9f7306..b73b3e4e15 100644 Binary files a/core/src/components/range/test/basic/range.e2e.ts-snapshots/range-diff-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/range/test/basic/range.e2e.ts-snapshots/range-diff-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/ripple-effect/test/basic/ripple-effect.e2e.ts b/core/src/components/ripple-effect/test/basic/ripple-effect.e2e.ts index 8b75688c8c..033bff3ce7 100644 --- a/core/src/components/ripple-effect/test/basic/ripple-effect.e2e.ts +++ b/core/src/components/ripple-effect/test/basic/ripple-effect.e2e.ts @@ -2,8 +2,12 @@ import { expect } from '@playwright/test'; import type { E2EPage } from '@utils/test/playwright'; import { test } from '@utils/test/playwright'; -// TODO FW-3081 -test.describe.skip('ripple-effect: basic', () => { +test.describe('ripple-effect: basic', () => { + test.beforeEach(async ({ skip }) => { + skip.rtl(); + skip.mode('ios'); + }); + test('should add .ion-activated when pressed', async ({ page }) => { await verifyRippleEffect(page, '#small-btn'); await verifyRippleEffect(page, '#large-btn'); @@ -14,7 +18,7 @@ test.describe.skip('ripple-effect: basic', () => { test.describe('ripple effect with nested ion-button', () => { test('should add .ion-activated when the block is pressed', async ({ page }) => { - await page.goto(`/src/components/ripple-effect/test/basic?ionic:_testing=false&ionic:mode=md`); + await page.goto('/src/components/ripple-effect/test/basic?ionic:_testing=false'); const el = page.locator('#ripple-with-button'); @@ -30,9 +34,7 @@ test.describe.skip('ripple-effect: basic', () => { // Waits for the ripple effect to be added await page.waitForSelector('.ion-activated'); - const elHandle = await el.elementHandle(); - const classes = await elHandle?.evaluate((el) => el.classList.value); - expect(classes).toMatch('ion-activated'); + await expect(el).toHaveClass(/ion-activated/); }); test('should add .ion-activated when the button is pressed', async ({ page }) => { @@ -42,7 +44,7 @@ test.describe.skip('ripple-effect: basic', () => { }); const verifyRippleEffect = async (page: E2EPage, selector: string) => { - await page.goto(`/src/components/ripple-effect/test/basic?ionic:_testing=false&ionic:mode=md`); + await page.goto('/src/components/ripple-effect/test/basic?ionic:_testing=false'); const el = page.locator(selector); @@ -55,10 +57,7 @@ const verifyRippleEffect = async (page: E2EPage, selector: string) => { await page.mouse.down(); } - // Waits for the ripple effect to be added - await page.waitForSelector(`${selector}.ion-activated`); + await page.waitForSelector('.ion-activated'); - const elHandle = await el.elementHandle(); - const classes = await elHandle?.evaluate((el) => el.classList.value); - expect(classes).toMatch('ion-activated'); + await expect(el).toHaveClass(/ion-activated/); }; diff --git a/core/src/components/segment/test/a11y/segment.e2e.ts b/core/src/components/segment/test/a11y/segment.e2e.ts index 76bcad3be6..8fe9e20049 100644 --- a/core/src/components/segment/test/a11y/segment.e2e.ts +++ b/core/src/components/segment/test/a11y/segment.e2e.ts @@ -10,7 +10,8 @@ test.describe('segment: a11y', () => { expect(results.violations).toEqual([]); }); - test('segment buttons should be keyboard navigable', async ({ page, browserName, skip }, testInfo) => { + // TODO FW-3710 + test.skip('segment buttons should be keyboard navigable', async ({ page, browserName, skip }, testInfo) => { // TODO (FW-2979) skip.browser('webkit', 'Safari 16 only allows text fields and pop-up menus to be focused.'); const tabKey = browserName === 'webkit' ? 'Alt+Tab' : 'Tab'; diff --git a/core/src/components/segment/test/custom/segment.e2e.ts-snapshots/segment-custom-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/segment/test/custom/segment.e2e.ts-snapshots/segment-custom-ios-ltr-Mobile-Chrome-linux.png index 5e645b606f..6e867e6983 100644 Binary files a/core/src/components/segment/test/custom/segment.e2e.ts-snapshots/segment-custom-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/segment/test/custom/segment.e2e.ts-snapshots/segment-custom-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/segment/test/custom/segment.e2e.ts-snapshots/segment-custom-ios-ltr-Mobile-Safari-linux.png b/core/src/components/segment/test/custom/segment.e2e.ts-snapshots/segment-custom-ios-ltr-Mobile-Safari-linux.png index aa5e259502..bb8d5adf8a 100644 Binary files a/core/src/components/segment/test/custom/segment.e2e.ts-snapshots/segment-custom-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/segment/test/custom/segment.e2e.ts-snapshots/segment-custom-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/segment/test/custom/segment.e2e.ts-snapshots/segment-custom-md-ltr-Mobile-Chrome-linux.png b/core/src/components/segment/test/custom/segment.e2e.ts-snapshots/segment-custom-md-ltr-Mobile-Chrome-linux.png index 26188e39f3..854f22b74e 100644 Binary files a/core/src/components/segment/test/custom/segment.e2e.ts-snapshots/segment-custom-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/segment/test/custom/segment.e2e.ts-snapshots/segment-custom-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/skeleton-text/test/basic/skeleton-text.e2e.ts-snapshots/skeleton-text-basic-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/skeleton-text/test/basic/skeleton-text.e2e.ts-snapshots/skeleton-text-basic-ios-ltr-Mobile-Chrome-linux.png index ce5d309b4a..f6dc7ba43e 100644 Binary files a/core/src/components/skeleton-text/test/basic/skeleton-text.e2e.ts-snapshots/skeleton-text-basic-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/skeleton-text/test/basic/skeleton-text.e2e.ts-snapshots/skeleton-text-basic-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/skeleton-text/test/basic/skeleton-text.e2e.ts-snapshots/skeleton-text-basic-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/skeleton-text/test/basic/skeleton-text.e2e.ts-snapshots/skeleton-text-basic-ios-rtl-Mobile-Chrome-linux.png index faa27ceccd..4dfca52c18 100644 Binary files a/core/src/components/skeleton-text/test/basic/skeleton-text.e2e.ts-snapshots/skeleton-text-basic-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/skeleton-text/test/basic/skeleton-text.e2e.ts-snapshots/skeleton-text-basic-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/slides/IonicSlides.ts b/core/src/components/slides/IonicSlides.ts index 3ca87af42d..c8c7d0c018 100644 --- a/core/src/components/slides/IonicSlides.ts +++ b/core/src/components/slides/IonicSlides.ts @@ -16,7 +16,6 @@ export const IonicSlides = (opts: any) => { slidesOffsetBefore: 0, slidesOffsetAfter: 0, touchEventsTarget: 'container', - autoplay: false, freeMode: false, freeModeMomentum: true, freeModeMomentumRatio: 1, diff --git a/core/src/components/spinner/test/basic/spinner.e2e.ts-snapshots/spinner-basic-diff-ios-rtl-Mobile-Safari-linux.png b/core/src/components/spinner/test/basic/spinner.e2e.ts-snapshots/spinner-basic-diff-ios-rtl-Mobile-Safari-linux.png index 61a1ccdc9a..c66c86be18 100644 Binary files a/core/src/components/spinner/test/basic/spinner.e2e.ts-snapshots/spinner-basic-diff-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/spinner/test/basic/spinner.e2e.ts-snapshots/spinner-basic-diff-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/split-pane/split-pane.tsx b/core/src/components/split-pane/split-pane.tsx index eebcfbfbba..decd5d7a59 100644 --- a/core/src/components/split-pane/split-pane.tsx +++ b/core/src/components/split-pane/split-pane.tsx @@ -65,7 +65,7 @@ export class SplitPane implements ComponentInterface { async connectedCallback() { // TODO: connectedCallback is fired in CE build // before WC is defined. This needs to be fixed in Stencil. - if (typeof (customElements as any) !== 'undefined') { + if (typeof (customElements as any) !== 'undefined' && (customElements as any) != null) { await customElements.whenDefined('ion-split-pane'); } this.styleChildren(); diff --git a/core/src/components/tab-button/test/a11y/tab-button.e2e.ts b/core/src/components/tab-button/test/a11y/tab-button.e2e.ts index f4d83659b4..3b5f4852a3 100644 --- a/core/src/components/tab-button/test/a11y/tab-button.e2e.ts +++ b/core/src/components/tab-button/test/a11y/tab-button.e2e.ts @@ -6,7 +6,8 @@ test.describe('tab-button: a11y', () => { test('should not have any axe violations', async ({ page }) => { await page.goto('/src/components/tab-button/test/a11y'); - const results = await new AxeBuilder({ page }).analyze(); + // TODO FW-3604 + const results = await new AxeBuilder({ page }).disableRules('color-contrast').analyze(); expect(results.violations).toEqual([]); }); }); diff --git a/core/src/components/textarea/test/basic/textarea.e2e.ts-snapshots/textarea-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/textarea/test/basic/textarea.e2e.ts-snapshots/textarea-diff-ios-ltr-Mobile-Chrome-linux.png index 3e96c9d975..64a9f2e984 100644 Binary files a/core/src/components/textarea/test/basic/textarea.e2e.ts-snapshots/textarea-diff-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/textarea/test/basic/textarea.e2e.ts-snapshots/textarea-diff-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/textarea/test/basic/textarea.e2e.ts-snapshots/textarea-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/textarea/test/basic/textarea.e2e.ts-snapshots/textarea-diff-ios-rtl-Mobile-Chrome-linux.png index 732718f679..10f1b676f8 100644 Binary files a/core/src/components/textarea/test/basic/textarea.e2e.ts-snapshots/textarea-diff-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/textarea/test/basic/textarea.e2e.ts-snapshots/textarea-diff-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/textarea/test/basic/textarea.e2e.ts-snapshots/textarea-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/textarea/test/basic/textarea.e2e.ts-snapshots/textarea-diff-md-ltr-Mobile-Chrome-linux.png index 6bd1081645..5d3283487e 100644 Binary files a/core/src/components/textarea/test/basic/textarea.e2e.ts-snapshots/textarea-diff-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/textarea/test/basic/textarea.e2e.ts-snapshots/textarea-diff-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/textarea/test/basic/textarea.e2e.ts-snapshots/textarea-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/textarea/test/basic/textarea.e2e.ts-snapshots/textarea-diff-md-rtl-Mobile-Chrome-linux.png index b99f94ec4c..568b1bb5bd 100644 Binary files a/core/src/components/textarea/test/basic/textarea.e2e.ts-snapshots/textarea-diff-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/textarea/test/basic/textarea.e2e.ts-snapshots/textarea-diff-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/textarea/test/textarea.spec.ts b/core/src/components/textarea/test/textarea.spec.ts new file mode 100644 index 0000000000..a3e8a7ec13 --- /dev/null +++ b/core/src/components/textarea/test/textarea.spec.ts @@ -0,0 +1,14 @@ +import { newSpecPage } from '@stencil/core/testing'; +import { Textarea } from '../textarea'; + +it('should inherit attributes', async () => { + const page = await newSpecPage({ + components: [Textarea], + html: '', + }); + + const nativeEl = page.body.querySelector('ion-textarea textarea'); + expect(nativeEl.getAttribute('title')).toBe('my title'); + expect(nativeEl.getAttribute('tabindex')).toBe('-1'); + expect(nativeEl.getAttribute('data-form-type')).toBe('password'); +}); diff --git a/core/src/components/textarea/textarea.tsx b/core/src/components/textarea/textarea.tsx index 1f4f221141..56b50233bd 100644 --- a/core/src/components/textarea/textarea.tsx +++ b/core/src/components/textarea/textarea.tsx @@ -223,7 +223,7 @@ export class Textarea implements ComponentInterface { componentWillLoad() { this.inheritedAttributes = { ...inheritAriaAttributes(this.el), - ...inheritAttributes(this.el, ['data-form-type', 'title']), + ...inheritAttributes(this.el, ['data-form-type', 'title', 'tabindex']), }; } diff --git a/core/src/components/toast/test/basic/toast.e2e.ts-snapshots/toast-bottom-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/toast/test/basic/toast.e2e.ts-snapshots/toast-bottom-ios-ltr-Mobile-Chrome-linux.png index 6f23ac11a6..614d896096 100644 Binary files a/core/src/components/toast/test/basic/toast.e2e.ts-snapshots/toast-bottom-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/toast/test/basic/toast.e2e.ts-snapshots/toast-bottom-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/toast/test/basic/toast.e2e.ts-snapshots/toast-bottom-md-ltr-Mobile-Chrome-linux.png b/core/src/components/toast/test/basic/toast.e2e.ts-snapshots/toast-bottom-md-ltr-Mobile-Chrome-linux.png index 601dc0831a..e4119e5069 100644 Binary files a/core/src/components/toast/test/basic/toast.e2e.ts-snapshots/toast-bottom-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/toast/test/basic/toast.e2e.ts-snapshots/toast-bottom-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/toast/test/basic/toast.e2e.ts-snapshots/toast-middle-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/toast/test/basic/toast.e2e.ts-snapshots/toast-middle-ios-ltr-Mobile-Chrome-linux.png index bbf16507c7..fb1079e153 100644 Binary files a/core/src/components/toast/test/basic/toast.e2e.ts-snapshots/toast-middle-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/toast/test/basic/toast.e2e.ts-snapshots/toast-middle-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/toast/test/basic/toast.e2e.ts-snapshots/toast-middle-md-ltr-Mobile-Chrome-linux.png b/core/src/components/toast/test/basic/toast.e2e.ts-snapshots/toast-middle-md-ltr-Mobile-Chrome-linux.png index d26e5023bd..ffff2cfdae 100644 Binary files a/core/src/components/toast/test/basic/toast.e2e.ts-snapshots/toast-middle-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/toast/test/basic/toast.e2e.ts-snapshots/toast-middle-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/toast/test/basic/toast.e2e.ts-snapshots/toast-top-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/toast/test/basic/toast.e2e.ts-snapshots/toast-top-ios-ltr-Mobile-Chrome-linux.png index f525b8c0d3..3c306738a6 100644 Binary files a/core/src/components/toast/test/basic/toast.e2e.ts-snapshots/toast-top-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/toast/test/basic/toast.e2e.ts-snapshots/toast-top-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/toast/test/basic/toast.e2e.ts-snapshots/toast-top-md-ltr-Mobile-Chrome-linux.png b/core/src/components/toast/test/basic/toast.e2e.ts-snapshots/toast-top-md-ltr-Mobile-Chrome-linux.png index c27d8bf6cf..e873c0a949 100644 Binary files a/core/src/components/toast/test/basic/toast.e2e.ts-snapshots/toast-top-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/toast/test/basic/toast.e2e.ts-snapshots/toast-top-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/toast/test/layout/toast.e2e.ts b/core/src/components/toast/test/layout/toast.e2e.ts index f5c22cd1b1..dbc31913e7 100644 --- a/core/src/components/toast/test/layout/toast.e2e.ts +++ b/core/src/components/toast/test/layout/toast.e2e.ts @@ -10,6 +10,6 @@ test.describe('toast: stacked layout', () => { await ionToastDidPresent.next(); const toastWrapper = page.locator('ion-toast .toast-wrapper'); - expect(await toastWrapper.screenshot()).toMatchSnapshot(`toast-stacked-${page.getSnapshotSettings()}.png`); + await expect(toastWrapper).toHaveScreenshot(`toast-stacked-${page.getSnapshotSettings()}.png`); }); }); diff --git a/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-ios-ltr-Mobile-Chrome-linux.png index 1a906abf68..62fa2e26e6 100644 Binary files a/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-ios-ltr-Mobile-Safari-linux.png b/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-ios-ltr-Mobile-Safari-linux.png index 1d24d41c61..d6370da89a 100644 Binary files a/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-ios-rtl-Mobile-Chrome-linux.png index 1b0edc0efa..cde485172f 100644 Binary files a/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-ios-rtl-Mobile-Safari-linux.png b/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-ios-rtl-Mobile-Safari-linux.png index fdeff15643..f1d2ba3c61 100644 Binary files a/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-md-ltr-Mobile-Chrome-linux.png b/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-md-ltr-Mobile-Chrome-linux.png index 1ba4b083e3..37877bf235 100644 Binary files a/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-md-ltr-Mobile-Safari-linux.png b/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-md-ltr-Mobile-Safari-linux.png index d5827d5ca9..3c3c9e9778 100644 Binary files a/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-md-ltr-Mobile-Safari-linux.png and b/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-md-rtl-Mobile-Chrome-linux.png b/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-md-rtl-Mobile-Chrome-linux.png index 5a20ad3558..b04beede67 100644 Binary files a/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-md-rtl-Mobile-Safari-linux.png b/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-md-rtl-Mobile-Safari-linux.png index e592c426bd..ba629c93ff 100644 Binary files a/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-md-rtl-Mobile-Safari-linux.png and b/core/src/components/toast/test/layout/toast.e2e.ts-snapshots/toast-stacked-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/toggle/test/sizes/toggle.e2e.ts-snapshots/toggle-sizes-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/toggle/test/sizes/toggle.e2e.ts-snapshots/toggle-sizes-diff-ios-ltr-Mobile-Chrome-linux.png index a8c739d147..0a9a7cc18e 100644 Binary files a/core/src/components/toggle/test/sizes/toggle.e2e.ts-snapshots/toggle-sizes-diff-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/toggle/test/sizes/toggle.e2e.ts-snapshots/toggle-sizes-diff-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/toggle/test/sizes/toggle.e2e.ts-snapshots/toggle-sizes-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/toggle/test/sizes/toggle.e2e.ts-snapshots/toggle-sizes-diff-ios-rtl-Mobile-Chrome-linux.png index af174259a8..f50b89c1d1 100644 Binary files a/core/src/components/toggle/test/sizes/toggle.e2e.ts-snapshots/toggle-sizes-diff-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/toggle/test/sizes/toggle.e2e.ts-snapshots/toggle-sizes-diff-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/toolbar/test/basic/index.html b/core/src/components/toolbar/test/basic/index.html index b49d0155ad..e3a2945610 100644 --- a/core/src/components/toolbar/test/basic/index.html +++ b/core/src/components/toolbar/test/basic/index.html @@ -18,7 +18,11 @@ - Toolbar + Toolbar + + + + This is the title that never ends. It just goes on and on my friend. @@ -35,11 +39,7 @@ - Subheader - - - - This is the title that never ends. It just goes on and on my friend. + Toolbar @@ -56,11 +56,135 @@ - This is a long title with buttons. It just goes on and on my friend. + This is a long title with buttons. It just goes on and on my friend. + + + + + + + + + + + + + + + + + Defaults + + + + + + + + + + + + + + + + + Defaults.activated + + + + + + + + + + Solid + + + Solid + + + Help + + + + + + + + + + + + + Solid + + + Solid Activated + + + Help + + + + + + + + + + + + + Star + + + + + Info + + + + Outline + + + + + + + + + + Star + + + + + Info + + + + Outline.activated + + + + + Go Back + + + Edit + + Text Only - Content + +

Content

+ +

Here's a small text description for the content. Nothing more, nothing less.

+ diff --git a/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-ios-ltr-Mobile-Chrome-linux.png index 9521ae3e88..5a62595b96 100644 Binary files a/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-ios-ltr-Mobile-Firefox-linux.png index 36da0ea986..56c365a2b3 100644 Binary files a/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-ios-ltr-Mobile-Firefox-linux.png and b/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-ios-ltr-Mobile-Safari-linux.png b/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-ios-ltr-Mobile-Safari-linux.png index 7597678dea..7dde2304ac 100644 Binary files a/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-ios-rtl-Mobile-Chrome-linux.png index 82037bfbb0..8ebcdc6920 100644 Binary files a/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-ios-rtl-Mobile-Firefox-linux.png index 44b43f809e..d955bd6162 100644 Binary files a/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-ios-rtl-Mobile-Firefox-linux.png and b/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-ios-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-ios-rtl-Mobile-Safari-linux.png b/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-ios-rtl-Mobile-Safari-linux.png index ad5e4dbb2c..9e3b397624 100644 Binary files a/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-md-ltr-Mobile-Chrome-linux.png b/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-md-ltr-Mobile-Chrome-linux.png index c95b1b59f7..750b67136e 100644 Binary files a/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-md-ltr-Mobile-Firefox-linux.png b/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-md-ltr-Mobile-Firefox-linux.png index f1c222d28f..4c6230d5c0 100644 Binary files a/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-md-ltr-Mobile-Safari-linux.png b/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-md-ltr-Mobile-Safari-linux.png index b51cc638fb..82e653a801 100644 Binary files a/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-md-ltr-Mobile-Safari-linux.png and b/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-md-rtl-Mobile-Chrome-linux.png b/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-md-rtl-Mobile-Chrome-linux.png index b420ecb15d..3fe4318573 100644 Binary files a/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-md-rtl-Mobile-Firefox-linux.png b/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-md-rtl-Mobile-Firefox-linux.png index effbafaa61..5f9430cbe3 100644 Binary files a/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-md-rtl-Mobile-Firefox-linux.png and b/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-md-rtl-Mobile-Safari-linux.png b/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-md-rtl-Mobile-Safari-linux.png index 122eea501d..1dc993388f 100644 Binary files a/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-md-rtl-Mobile-Safari-linux.png and b/core/src/components/toolbar/test/basic/toolbar.e2e.ts-snapshots/toolbar-basic-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/toolbar/test/colors/index.html b/core/src/components/toolbar/test/colors/index.html index e76a66e61a..70a3814e87 100644 --- a/core/src/components/toolbar/test/colors/index.html +++ b/core/src/components/toolbar/test/colors/index.html @@ -23,10 +23,8 @@ - Outline - Clear @@ -36,147 +34,140 @@ - - - - Solid + Clear - Clear - - - + Clear + Clear Secondary - - - - Outline + Solid - Clear - - - + Solid + Solid Tertiary - - - - Solid + Outline - Clear - - - + Outline + Outline Success - - - - Outline + Clear - Clear - - - + Clear + Clear Warning - - - Solid - Clear - - - + Solid + Solid Danger - - - - Solid + Outline - Outline - - - + Outline + Outline Light - - - - Solid + Clear - Clear - - - + Clear + Clear Medium - - - Solid - Clear - - - + Solid + Solid Dark +
+ - Solid - Clear Custom + + + + Clear + + + Clear + Clear + + Custom + + + + + Solid + + + Solid + Solid + + Custom + + + + + Outline + + + Outline + Outline + + Custom + diff --git a/core/src/components/toolbar/test/colors/toolbar.e2e.ts b/core/src/components/toolbar/test/colors/toolbar.e2e.ts index 6ff561c021..1cbb101b09 100644 --- a/core/src/components/toolbar/test/colors/toolbar.e2e.ts +++ b/core/src/components/toolbar/test/colors/toolbar.e2e.ts @@ -5,8 +5,8 @@ test.describe('toolbar: colors', () => { test('should not have visual regressions', async ({ page }) => { await page.goto(`/src/components/toolbar/test/colors`); - // only capture the container to avoid extra white space - const container = page.locator('#toolbars'); - await expect(container).toHaveScreenshot(`toolbar-colors-${page.getSnapshotSettings()}.png`); + await page.setIonViewport(); + + await expect(page).toHaveScreenshot(`toolbar-colors-${page.getSnapshotSettings()}.png`); }); }); diff --git a/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ios-ltr-Mobile-Chrome-linux.png index 802b420c12..025cea5371 100644 Binary files a/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ios-ltr-Mobile-Chrome-linux.png and b/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ios-ltr-Mobile-Firefox-linux.png index df502013af..27853aa195 100644 Binary files a/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ios-ltr-Mobile-Firefox-linux.png and b/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ios-ltr-Mobile-Safari-linux.png b/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ios-ltr-Mobile-Safari-linux.png index 4d31b678ef..87ff35b4ca 100644 Binary files a/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ios-ltr-Mobile-Safari-linux.png and b/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ios-rtl-Mobile-Chrome-linux.png index f840d2cb1f..374e34520a 100644 Binary files a/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ios-rtl-Mobile-Chrome-linux.png and b/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ios-rtl-Mobile-Firefox-linux.png index eea2f9cc96..2e3d341876 100644 Binary files a/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ios-rtl-Mobile-Firefox-linux.png and b/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ios-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ios-rtl-Mobile-Safari-linux.png b/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ios-rtl-Mobile-Safari-linux.png index e63f89ec44..e8de9da580 100644 Binary files a/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ios-rtl-Mobile-Safari-linux.png and b/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-md-ltr-Mobile-Chrome-linux.png b/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-md-ltr-Mobile-Chrome-linux.png index d66aefa038..156b8fdbbd 100644 Binary files a/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-md-ltr-Mobile-Firefox-linux.png b/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-md-ltr-Mobile-Firefox-linux.png index 41f374b18d..74fbfa39bf 100644 Binary files a/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-md-ltr-Mobile-Safari-linux.png b/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-md-ltr-Mobile-Safari-linux.png index fd8e41b105..e0a604035e 100644 Binary files a/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-md-ltr-Mobile-Safari-linux.png and b/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-md-rtl-Mobile-Chrome-linux.png b/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-md-rtl-Mobile-Chrome-linux.png index 22ae3f2ece..a814ff6fce 100644 Binary files a/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-md-rtl-Mobile-Firefox-linux.png b/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-md-rtl-Mobile-Firefox-linux.png index 99aca085f0..8d6a1b6ab6 100644 Binary files a/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-md-rtl-Mobile-Firefox-linux.png and b/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-md-rtl-Mobile-Safari-linux.png b/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-md-rtl-Mobile-Safari-linux.png index 4b5bd0632f..263c274b18 100644 Binary files a/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-md-rtl-Mobile-Safari-linux.png and b/core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/css/core.scss b/core/src/css/core.scss index 6204c5720e..7f47bcfdbe 100644 --- a/core/src/css/core.scss +++ b/core/src/css/core.scss @@ -91,8 +91,12 @@ html.ios ion-modal ion-toolbar { * Note 2: This should only apply to non-card and * non-sheet modals. Card and sheet modals have their * own criteria for displaying backdrops/box shadows. + * + * Do not use :not(.overlay-hidden) in place of + * .show-modal because that triggers a memory + * leak in Blink: https://bugs.chromium.org/p/chromium/issues/detail?id=1418768 */ -ion-modal.modal-default:not(.overlay-hidden) ~ ion-modal.modal-default { +ion-modal.modal-default.show-modal ~ ion-modal.modal-default { --backdrop-opacity: 0; --box-shadow: none; } diff --git a/core/src/themes/test/css-variables/index.html b/core/src/themes/test/css-variables/index.html index a881966b88..efd7c342e5 100644 --- a/core/src/themes/test/css-variables/index.html +++ b/core/src/themes/test/css-variables/index.html @@ -90,7 +90,7 @@ Outline - Lists + Default Buttons @@ -101,6 +101,7 @@ Outline + @@ -111,7 +112,7 @@ Outline - Lists + Focused Buttons @@ -122,6 +123,29 @@ Outline + + + + + + Default + Solid + Clear + Outline + + + Activated Buttons + + + + + Default + Solid + Clear + Outline + + + diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 29070bb77f..181ccdaa4e 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -3,6 +3,22 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.6.2](https://github.com/ionic-team/ionic-docs/compare/v6.6.1...v6.6.2) (2023-03-15) + +**Note:** Version bump only for package @ionic/docs + + + + + +## [6.6.1](https://github.com/ionic-team/ionic-docs/compare/v6.6.0...v6.6.1) (2023-03-08) + +**Note:** Version bump only for package @ionic/docs + + + + + # [6.6.0](https://github.com/ionic-team/ionic-docs/compare/v6.5.7...v6.6.0) (2023-03-01) **Note:** Version bump only for package @ionic/docs diff --git a/docs/package-lock.json b/docs/package-lock.json index 97c741fc91..99faa6581d 100644 --- a/docs/package-lock.json +++ b/docs/package-lock.json @@ -1,12 +1,12 @@ { "name": "@ionic/docs", - "version": "6.6.0", + "version": "6.6.2", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/docs", - "version": "6.6.0", + "version": "6.6.2", "license": "MIT" } } diff --git a/docs/package.json b/docs/package.json index d0f6a5bb63..d627d26ece 100644 --- a/docs/package.json +++ b/docs/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/docs", - "version": "6.6.0", + "version": "6.6.2", "description": "Pre-packaged API documentation for the Ionic docs.", "main": "core.json", "types": "core.d.ts", diff --git a/lerna.json b/lerna.json index f89cd3a028..eeaa3489fd 100644 --- a/lerna.json +++ b/lerna.json @@ -5,5 +5,5 @@ "angular", "packages/*" ], - "version": "6.6.0" + "version": "6.6.2" } diff --git a/packages/angular-server/CHANGELOG.md b/packages/angular-server/CHANGELOG.md index 7bb8aba281..a63e4ec771 100644 --- a/packages/angular-server/CHANGELOG.md +++ b/packages/angular-server/CHANGELOG.md @@ -3,6 +3,22 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.6.2](https://github.com/ionic-team/ionic/compare/v6.6.1...v6.6.2) (2023-03-15) + +**Note:** Version bump only for package @ionic/angular-server + + + + + +## [6.6.1](https://github.com/ionic-team/ionic/compare/v6.6.0...v6.6.1) (2023-03-08) + +**Note:** Version bump only for package @ionic/angular-server + + + + + # [6.6.0](https://github.com/ionic-team/ionic/compare/v6.5.7...v6.6.0) (2023-03-01) **Note:** Version bump only for package @ionic/angular-server diff --git a/packages/angular-server/package-lock.json b/packages/angular-server/package-lock.json index b8b0e1fd95..fd351d4a74 100644 --- a/packages/angular-server/package-lock.json +++ b/packages/angular-server/package-lock.json @@ -1,15 +1,15 @@ { "name": "@ionic/angular-server", - "version": "6.6.0", + "version": "6.6.2", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/angular-server", - "version": "6.6.0", + "version": "6.6.2", "license": "MIT", "dependencies": { - "@ionic/core": "^6.6.0" + "@ionic/core": "^6.6.2" }, "devDependencies": { "@angular-eslint/eslint-plugin": "^12.6.1", @@ -742,9 +742,9 @@ "dev": true }, "node_modules/@ionic/core": { - "version": "6.6.0", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.6.0.tgz", - "integrity": "sha512-1X0b2/ziKhCwSO665tSpG32FOuMyjhyGDLFTJUKoDfQB0j/gIBv1d2okUzAk6GKHdnAPUZQHZFhUHcSIclW9cg==", + "version": "6.6.2", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.6.2.tgz", + "integrity": "sha512-C3XblxE4OcGs+QWy2meWqNGB8sDZV8w0nUVwLy3AmWovi0CA0xPs2UthUSicUxpCism33pzQp6DiDVsq+G5VTQ==", "dependencies": { "@stencil/core": "^2.18.0", "ionicons": "^6.1.3", @@ -7201,9 +7201,9 @@ "dev": true }, "@ionic/core": { - "version": "6.6.0", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.6.0.tgz", - "integrity": "sha512-1X0b2/ziKhCwSO665tSpG32FOuMyjhyGDLFTJUKoDfQB0j/gIBv1d2okUzAk6GKHdnAPUZQHZFhUHcSIclW9cg==", + "version": "6.6.2", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.6.2.tgz", + "integrity": "sha512-C3XblxE4OcGs+QWy2meWqNGB8sDZV8w0nUVwLy3AmWovi0CA0xPs2UthUSicUxpCism33pzQp6DiDVsq+G5VTQ==", "requires": { "@stencil/core": "^2.18.0", "ionicons": "^6.1.3", diff --git a/packages/angular-server/package.json b/packages/angular-server/package.json index 11bbede8fe..a800cfae7a 100644 --- a/packages/angular-server/package.json +++ b/packages/angular-server/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/angular-server", - "version": "6.6.0", + "version": "6.6.2", "description": "Angular SSR Module for Ionic", "keywords": [ "ionic", @@ -69,6 +69,6 @@ }, "prettier": "@ionic/prettier-config", "dependencies": { - "@ionic/core": "^6.6.0" + "@ionic/core": "^6.6.2" } } diff --git a/packages/react-router/CHANGELOG.md b/packages/react-router/CHANGELOG.md index f5e8b528bf..12bd5b7a9c 100644 --- a/packages/react-router/CHANGELOG.md +++ b/packages/react-router/CHANGELOG.md @@ -3,6 +3,25 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.6.2](https://github.com/ionic-team/ionic/compare/v6.6.1...v6.6.2) (2023-03-15) + +**Note:** Version bump only for package @ionic/react-router + + + + + +## [6.6.1](https://github.com/ionic-team/ionic/compare/v6.6.0...v6.6.1) (2023-03-08) + + +### Bug Fixes + +* **react:** inline overlays dismiss when parent component unmounts ([#26245](https://github.com/ionic-team/ionic/issues/26245)) ([c0e1bf9](https://github.com/ionic-team/ionic/commit/c0e1bf92c4487c2ec8a117957cf84a2ce00f5fd8)), closes [#25775](https://github.com/ionic-team/ionic/issues/25775) [#26185](https://github.com/ionic-team/ionic/issues/26185) + + + + + # [6.6.0](https://github.com/ionic-team/ionic/compare/v6.5.7...v6.6.0) (2023-03-01) **Note:** Version bump only for package @ionic/react-router diff --git a/packages/react-router/package-lock.json b/packages/react-router/package-lock.json index 5f76149dfd..99dda5de69 100644 --- a/packages/react-router/package-lock.json +++ b/packages/react-router/package-lock.json @@ -1,15 +1,15 @@ { "name": "@ionic/react-router", - "version": "6.6.0", + "version": "6.6.2", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/react-router", - "version": "6.6.0", + "version": "6.6.2", "license": "MIT", "dependencies": { - "@ionic/react": "^6.6.0", + "@ionic/react": "^6.6.2", "tslib": "*" }, "devDependencies": { @@ -205,9 +205,9 @@ "dev": true }, "node_modules/@ionic/core": { - "version": "6.6.0", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.6.0.tgz", - "integrity": "sha512-1X0b2/ziKhCwSO665tSpG32FOuMyjhyGDLFTJUKoDfQB0j/gIBv1d2okUzAk6GKHdnAPUZQHZFhUHcSIclW9cg==", + "version": "6.6.2", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.6.2.tgz", + "integrity": "sha512-C3XblxE4OcGs+QWy2meWqNGB8sDZV8w0nUVwLy3AmWovi0CA0xPs2UthUSicUxpCism33pzQp6DiDVsq+G5VTQ==", "dependencies": { "@stencil/core": "^2.18.0", "ionicons": "^6.1.3", @@ -381,11 +381,11 @@ } }, "node_modules/@ionic/react": { - "version": "6.6.0", - "resolved": "https://registry.npmjs.org/@ionic/react/-/react-6.6.0.tgz", - "integrity": "sha512-fIJK5fiMNfOyHr9EqsaJ9XPDR7gX1fiPxPIYnWef+87LZfe4Gc7l1fZgMKhuZNpaWA160+WHBhWLRwAeSv76dg==", + "version": "6.6.2", + "resolved": "https://registry.npmjs.org/@ionic/react/-/react-6.6.2.tgz", + "integrity": "sha512-eWGW2evk/pNkstcmhtqvRPU1t3FBssa+ySMNcvFQsD7UDV8Qq3rNRtMH/4dXzVThm1r/BACmkEsl95X0N6FswA==", "dependencies": { - "@ionic/core": "6.6.0", + "@ionic/core": "6.6.2", "ionicons": "^6.1.3", "tslib": "*" }, @@ -466,9 +466,9 @@ } }, "node_modules/@stencil/core": { - "version": "2.22.2", - "resolved": "https://registry.npmjs.org/@stencil/core/-/core-2.22.2.tgz", - "integrity": "sha512-r+vbxsGNcBaV1VDOYW25lv4QfXTlNoIb5GpUX7rZ+cr59yqYCZC5tlV+IzX6YgHKW62ulCc9M3RYtTfHtNbNNw==", + "version": "2.22.3", + "resolved": "https://registry.npmjs.org/@stencil/core/-/core-2.22.3.tgz", + "integrity": "sha512-kmVA0M/HojwsfkeHsifvHVIYe4l5tin7J5+DLgtl8h6WWfiMClND5K3ifCXXI2ETDNKiEk21p6jql3Fx9o2rng==", "bin": { "stencil": "bin/stencil" }, @@ -3630,9 +3630,9 @@ "dev": true }, "@ionic/core": { - "version": "6.6.0", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.6.0.tgz", - "integrity": "sha512-1X0b2/ziKhCwSO665tSpG32FOuMyjhyGDLFTJUKoDfQB0j/gIBv1d2okUzAk6GKHdnAPUZQHZFhUHcSIclW9cg==", + "version": "6.6.2", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.6.2.tgz", + "integrity": "sha512-C3XblxE4OcGs+QWy2meWqNGB8sDZV8w0nUVwLy3AmWovi0CA0xPs2UthUSicUxpCism33pzQp6DiDVsq+G5VTQ==", "requires": { "@stencil/core": "^2.18.0", "ionicons": "^6.1.3", @@ -3736,11 +3736,11 @@ "requires": {} }, "@ionic/react": { - "version": "6.6.0", - "resolved": "https://registry.npmjs.org/@ionic/react/-/react-6.6.0.tgz", - "integrity": "sha512-fIJK5fiMNfOyHr9EqsaJ9XPDR7gX1fiPxPIYnWef+87LZfe4Gc7l1fZgMKhuZNpaWA160+WHBhWLRwAeSv76dg==", + "version": "6.6.2", + "resolved": "https://registry.npmjs.org/@ionic/react/-/react-6.6.2.tgz", + "integrity": "sha512-eWGW2evk/pNkstcmhtqvRPU1t3FBssa+ySMNcvFQsD7UDV8Qq3rNRtMH/4dXzVThm1r/BACmkEsl95X0N6FswA==", "requires": { - "@ionic/core": "6.6.0", + "@ionic/core": "6.6.2", "ionicons": "^6.1.3", "tslib": "*" } @@ -3794,9 +3794,9 @@ } }, "@stencil/core": { - "version": "2.22.2", - "resolved": "https://registry.npmjs.org/@stencil/core/-/core-2.22.2.tgz", - "integrity": "sha512-r+vbxsGNcBaV1VDOYW25lv4QfXTlNoIb5GpUX7rZ+cr59yqYCZC5tlV+IzX6YgHKW62ulCc9M3RYtTfHtNbNNw==" + "version": "2.22.3", + "resolved": "https://registry.npmjs.org/@stencil/core/-/core-2.22.3.tgz", + "integrity": "sha512-kmVA0M/HojwsfkeHsifvHVIYe4l5tin7J5+DLgtl8h6WWfiMClND5K3ifCXXI2ETDNKiEk21p6jql3Fx9o2rng==" }, "@types/estree": { "version": "0.0.39", diff --git a/packages/react-router/package.json b/packages/react-router/package.json index f74906537e..b3bacb2fc1 100644 --- a/packages/react-router/package.json +++ b/packages/react-router/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/react-router", - "version": "6.6.0", + "version": "6.6.2", "description": "React Router wrapper for @ionic/react", "keywords": [ "ionic", @@ -38,7 +38,7 @@ "dist/" ], "dependencies": { - "@ionic/react": "^6.6.0", + "@ionic/react": "^6.6.2", "tslib": "*" }, "peerDependencies": { diff --git a/packages/react-router/test-app/src/App.tsx b/packages/react-router/test-app/src/App.tsx index 3a2314f285..cdfa67d136 100644 --- a/packages/react-router/test-app/src/App.tsx +++ b/packages/react-router/test-app/src/App.tsx @@ -37,6 +37,7 @@ import DynamicIonpageClassnames from './pages/dynamic-ionpage-classnames/Dynamic import Tabs from './pages/tabs/Tabs'; import TabsSecondary from './pages/tabs/TabsSecondary'; import Params from './pages/params/Params'; +import Overlays from './pages/overlays/Overlays'; setupIonicReact(); @@ -60,6 +61,7 @@ const App: React.FC = () => { + diff --git a/packages/react-router/test-app/src/pages/Main.tsx b/packages/react-router/test-app/src/pages/Main.tsx index 83c882d0eb..cd4c5f6980 100644 --- a/packages/react-router/test-app/src/pages/Main.tsx +++ b/packages/react-router/test-app/src/pages/Main.tsx @@ -55,9 +55,12 @@ const Main: React.FC = () => { Dynamic IonPage Classnames - + Refs + + Overlays + Tabs diff --git a/packages/react-router/test-app/src/pages/overlays/Overlays.tsx b/packages/react-router/test-app/src/pages/overlays/Overlays.tsx new file mode 100644 index 0000000000..9343df83b9 --- /dev/null +++ b/packages/react-router/test-app/src/pages/overlays/Overlays.tsx @@ -0,0 +1,41 @@ +import { IonButton, IonContent, IonModal } from '@ionic/react'; +import { useState } from 'react'; +import { useHistory } from 'react-router'; + +const Overlays: React.FC = () => { + const [isOpen, setIsOpen] = useState(false); + + const history = useHistory(); + + const goBack = () => history.goBack(); + const replace = () => history.replace('/'); + const push = () => history.push('/'); + + return ( + <> + setIsOpen(true)}> + Open Modal + + { + setIsOpen(false); + }} + > + + + Go Back + + + Replace + + + Push + + + + + ); +}; + +export default Overlays; diff --git a/packages/react-router/test-app/tests/e2e/specs/overlays.cy.js b/packages/react-router/test-app/tests/e2e/specs/overlays.cy.js new file mode 100644 index 0000000000..2557448b20 --- /dev/null +++ b/packages/react-router/test-app/tests/e2e/specs/overlays.cy.js @@ -0,0 +1,41 @@ +const port = 3000; + +describe('Overlays', () => { + it('should remove the overlay when going back to the previous route', () => { + // Requires navigation history to perform a pop + cy.visit(`http://localhost:${port}`); + cy.visit(`http://localhost:${port}/overlays`); + + cy.get('#openModal').click(); + + cy.get('ion-modal').should('exist'); + + cy.get('#goBack').click(); + + cy.get('ion-modal').should('not.exist'); + }); + + it('should remove the overlay when pushing to a new route', () => { + cy.visit(`http://localhost:${port}/overlays`); + + cy.get('#openModal').click(); + + cy.get('ion-modal').should('exist'); + + cy.get('#push').click(); + + cy.get('ion-modal').should('not.exist'); + }); + + it('should remove the overlay when replacing the route', () => { + cy.visit(`http://localhost:${port}/overlays`); + + cy.get('#openModal').click(); + + cy.get('ion-modal').should('exist'); + + cy.get('#replace').click(); + + cy.get('ion-modal').should('not.exist'); + }); +}); diff --git a/packages/react/CHANGELOG.md b/packages/react/CHANGELOG.md index 1c59c41104..81529cc164 100644 --- a/packages/react/CHANGELOG.md +++ b/packages/react/CHANGELOG.md @@ -3,6 +3,28 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.6.2](https://github.com/ionic-team/ionic/compare/v6.6.1...v6.6.2) (2023-03-15) + + +### Bug Fixes + +* **react/vue:** properly switch ionicon based on the mode when ios/md is set ([#26924](https://github.com/ionic-team/ionic/issues/26924)) ([1eb9a08](https://github.com/ionic-team/ionic/commit/1eb9a085b2d69dfcfc71ff49b25d33347dd54aae)), closes [#26207](https://github.com/ionic-team/ionic/issues/26207) + + + + + +## [6.6.1](https://github.com/ionic-team/ionic/compare/v6.6.0...v6.6.1) (2023-03-08) + + +### Bug Fixes + +* **react:** inline overlays dismiss when parent component unmounts ([#26245](https://github.com/ionic-team/ionic/issues/26245)) ([c0e1bf9](https://github.com/ionic-team/ionic/commit/c0e1bf92c4487c2ec8a117957cf84a2ce00f5fd8)), closes [#25775](https://github.com/ionic-team/ionic/issues/25775) [#26185](https://github.com/ionic-team/ionic/issues/26185) + + + + + # [6.6.0](https://github.com/ionic-team/ionic/compare/v6.5.7...v6.6.0) (2023-03-01) diff --git a/packages/react/package-lock.json b/packages/react/package-lock.json index fe1478ff90..dfb6d53143 100644 --- a/packages/react/package-lock.json +++ b/packages/react/package-lock.json @@ -1,15 +1,15 @@ { "name": "@ionic/react", - "version": "6.6.0", + "version": "6.6.2", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/react", - "version": "6.6.0", + "version": "6.6.2", "license": "MIT", "dependencies": { - "@ionic/core": "^6.6.0", + "@ionic/core": "^6.6.2", "ionicons": "^6.1.3", "tslib": "*" }, @@ -697,9 +697,9 @@ "dev": true }, "node_modules/@ionic/core": { - "version": "6.6.0", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.6.0.tgz", - "integrity": "sha512-1X0b2/ziKhCwSO665tSpG32FOuMyjhyGDLFTJUKoDfQB0j/gIBv1d2okUzAk6GKHdnAPUZQHZFhUHcSIclW9cg==", + "version": "6.6.2", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.6.2.tgz", + "integrity": "sha512-C3XblxE4OcGs+QWy2meWqNGB8sDZV8w0nUVwLy3AmWovi0CA0xPs2UthUSicUxpCism33pzQp6DiDVsq+G5VTQ==", "dependencies": { "@stencil/core": "^2.18.0", "ionicons": "^6.1.3", @@ -11765,9 +11765,9 @@ "dev": true }, "@ionic/core": { - "version": "6.6.0", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.6.0.tgz", - "integrity": "sha512-1X0b2/ziKhCwSO665tSpG32FOuMyjhyGDLFTJUKoDfQB0j/gIBv1d2okUzAk6GKHdnAPUZQHZFhUHcSIclW9cg==", + "version": "6.6.2", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.6.2.tgz", + "integrity": "sha512-C3XblxE4OcGs+QWy2meWqNGB8sDZV8w0nUVwLy3AmWovi0CA0xPs2UthUSicUxpCism33pzQp6DiDVsq+G5VTQ==", "requires": { "@stencil/core": "^2.18.0", "ionicons": "^6.1.3", diff --git a/packages/react/package.json b/packages/react/package.json index 9969237605..389cc7d087 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/react", - "version": "6.6.0", + "version": "6.6.2", "description": "React specific wrapper for @ionic/core", "keywords": [ "ionic", @@ -42,7 +42,7 @@ "css/" ], "dependencies": { - "@ionic/core": "^6.6.0", + "@ionic/core": "^6.6.2", "ionicons": "^6.1.3", "tslib": "*" }, diff --git a/packages/react/src/components/IonIcon.tsx b/packages/react/src/components/IonIcon.tsx index 8d782d5348..a873f3c457 100644 --- a/packages/react/src/components/IonIcon.tsx +++ b/packages/react/src/components/IonIcon.tsx @@ -4,7 +4,7 @@ import { NavContext } from '../contexts/NavContext'; import type { IonicReactProps } from './IonicReactProps'; import { IonIconInner } from './inner-proxies'; -import { createForwardRef, isPlatform } from './utils'; +import { createForwardRef, getConfig } from './utils'; interface IonIconProps { color?: string; @@ -34,12 +34,15 @@ class IonIconContainer extends React.PureComponent { } render() { - const { icon, ios, md, ...rest } = this.props; + const { icon, ios, md, mode, ...rest } = this.props; let iconToUse: typeof icon; + const config = getConfig(); + const iconMode = mode || config?.get('mode'); + if (ios || md) { - if (isPlatform('ios')) { + if (iconMode === 'ios') { iconToUse = ios ?? md ?? icon; } else { iconToUse = md ?? ios ?? icon; diff --git a/packages/react/src/components/createInlineOverlayComponent.tsx b/packages/react/src/components/createInlineOverlayComponent.tsx index 03318e231e..70ea275222 100644 --- a/packages/react/src/components/createInlineOverlayComponent.tsx +++ b/packages/react/src/components/createInlineOverlayComponent.tsx @@ -1,4 +1,4 @@ -import type { OverlayEventDetail } from '@ionic/core/components'; +import type { HTMLIonOverlayElement, OverlayEventDetail } from '@ionic/core/components'; import React, { createElement } from 'react'; import { @@ -9,6 +9,7 @@ import { mergeRefs, } from './react-component-lib/utils'; import { createForwardRef } from './utils'; +import { detachProps } from './utils/detachProps'; // TODO(FW-2959): types @@ -35,7 +36,7 @@ export const createInlineOverlayComponent = ( } const displayName = dashToPascalCase(tagName); const ReactComponent = class extends React.Component, InlineOverlayState> { - ref: React.RefObject; + ref: React.RefObject; wrapperRef: React.RefObject; stableMergedRefs: React.RefCallback; @@ -54,60 +55,9 @@ export const createInlineOverlayComponent = ( componentDidMount() { this.componentDidUpdate(this.props); - /** - * Mount the inner component when the - * overlay is about to open. - * - * For ion-popover, this is when `ionMount` is emitted. - * For other overlays, this is when `willPresent` is emitted. - */ - this.ref.current?.addEventListener('ionMount', () => { - this.setState({ isOpen: true }); - }); - - /** - * Mount the inner component - * when overlay is about to open. - * Also manually call the onWillPresent - * handler if present as setState will - * cause the event handlers to be - * destroyed and re-created. - */ - this.ref.current?.addEventListener('willPresent', (evt: any) => { - this.setState({ isOpen: true }); - - this.props.onWillPresent && this.props.onWillPresent(evt); - }); - - /** - * Unmount the inner component. - * React will call Node.removeChild - * which expects the child to be - * a direct descendent of the parent - * but due to the presence of - * Web Component slots, this is not - * always the case. To work around this - * we move the inner component to the root - * of the Web Component so React can - * cleanup properly. - */ - this.ref.current?.addEventListener('didDismiss', (evt: any) => { - const wrapper = this.wrapperRef.current; - const el = this.ref.current; - - /** - * This component might be unmounted already, if the containing - * element was removed while the popover was still open. (For - * example, if an item contains an inline popover with a button - * that removes the item.) - */ - if (wrapper && el) { - el.append(wrapper); - this.setState({ isOpen: false }); - } - - this.props.onDidDismiss && this.props.onDidDismiss(evt); - }); + this.ref.current?.addEventListener('ionMount', this.handleIonMount); + this.ref.current?.addEventListener('willPresent', this.handleWillPresent); + this.ref.current?.addEventListener('didDismiss', this.handleDidDismiss); } componentDidUpdate(prevProps: IonicReactInternalProps) { @@ -115,6 +65,35 @@ export const createInlineOverlayComponent = ( attachProps(node, this.props, prevProps); } + componentWillUnmount() { + const node = this.ref.current; + /** + * If the overlay is being unmounted, but is still + * open, this means the unmount was triggered outside + * of the overlay being dismissed. + * + * This can happen with: + * - The parent component being unmounted + * - The overlay being conditionally rendered + * - A route change (push/pop/replace) + * + * Unmounting the overlay at this stage should skip + * the dismiss lifecycle, including skipping the transition. + * + */ + if (node && this.state.isOpen) { + /** + * Detach the local event listener that performs the state updates, + * before dismissing the overlay, to prevent the callback handlers + * executing after the component has been unmounted. This is to + * avoid memory leaks. + */ + node.removeEventListener('didDismiss', this.handleDidDismiss); + node.remove(); + detachProps(node, this.props); + } + } + render() { // eslint-disable-next-line @typescript-eslint/no-unused-vars const { children, forwardedRef, style, className, ref, ...cProps } = this.props; @@ -172,6 +151,46 @@ export const createInlineOverlayComponent = ( static get displayName() { return displayName; } + + private handleIonMount = () => { + /** + * Mount the inner component when the + * overlay is about to open. + * + * For ion-popover, this is when `ionMount` is emitted. + * For other overlays, this is when `willPresent` is emitted. + */ + this.setState({ isOpen: true }); + }; + + private handleWillPresent = (evt: any) => { + this.setState({ isOpen: true }); + /** + * Manually call the onWillPresent + * handler if present as setState will + * cause the event handlers to be + * destroyed and re-created. + */ + this.props.onWillPresent && this.props.onWillPresent(evt); + }; + + private handleDidDismiss = (evt: any) => { + const wrapper = this.wrapperRef.current; + const el = this.ref.current; + + /** + * This component might be unmounted already, if the containing + * element was removed while the overlay was still open. (For + * example, if an item contains an inline overlay with a button + * that removes the item.) + */ + if (wrapper && el) { + el.append(wrapper); + this.setState({ isOpen: false }); + } + + this.props.onDidDismiss && this.props.onDidDismiss(evt); + }; }; return createForwardRef(ReactComponent, displayName); }; diff --git a/packages/react/src/components/utils/detachProps.ts b/packages/react/src/components/utils/detachProps.ts new file mode 100644 index 0000000000..fb7f136ecb --- /dev/null +++ b/packages/react/src/components/utils/detachProps.ts @@ -0,0 +1,42 @@ +import { isCoveredByReact } from '../react-component-lib/utils'; + +/** + * The @stencil/react-output-target will bind event listeners for any + * attached props that use the `on` prefix. This function will remove + * those event listeners when the component is unmounted. + * + * This prevents memory leaks and React state updates on unmounted components. + */ +export const detachProps = (node: HTMLElement, props: any) => { + if (node instanceof Element) { + Object.keys(props).forEach((name) => { + if (name.indexOf('on') === 0 && name[2] === name[2].toUpperCase()) { + const eventName = name.substring(2); + const eventNameLc = eventName[0].toLowerCase() + eventName.substring(1); + if (!isCoveredByReact(eventNameLc)) { + /** + * Detach custom event bindings (not built-in React events) + * that were added by the @stencil/react-output-target attachProps function. + */ + detachEvent(node, eventNameLc); + } + } + }); + } +}; + +const detachEvent = ( + node: Element & { __events?: { [key: string]: ((e: Event) => any) | undefined } }, + eventName: string +) => { + const eventStore = node.__events || (node.__events = {}); + /** + * If the event listener was added by attachProps, it will + * be stored in the __events object. + */ + const eventHandler = eventStore[eventName]; + if (eventHandler) { + node.removeEventListener(eventName, eventHandler); + eventStore[eventName] = undefined; + } +}; diff --git a/packages/react/test-app/README.md b/packages/react/test-app/README.md new file mode 100644 index 0000000000..10e49c2b06 --- /dev/null +++ b/packages/react/test-app/README.md @@ -0,0 +1,47 @@ +# React Test App + +## Getting Started + +### Setup + +Make sure you are using the latest versions of node and npm. If you do not have these, [download the installer](https://nodejs.org/) for the LTS version of Node.js. This is the best way to also [install npm](https://blog.npmjs.org/post/85484771375/how-to-install-npm#_=_). + +### Building Dependencies + +Navigate to the `core`, `packages/react` and `packages/react-router` directories and build each of them: + +```bash +npm i +npm run build +``` + +Then, install dependencies from this directory for this test app: + +``` +npm i +``` + +### Syncing Changes + +When making changes to the React package, run the following from this directory to sync the changes: + +```bash +npm run sync +``` + +### Previewing App + +To preview this app locally, run the following from this directory: + +```bash +npm start +``` + +### Running Tests + +To run the e2e tests, run the following from this directory: + +``` +npm run build +npm run e2e +``` diff --git a/packages/react/test-app/public/assets/logo-android.svg b/packages/react/test-app/public/assets/logo-android.svg new file mode 100644 index 0000000000..36d03ecea6 --- /dev/null +++ b/packages/react/test-app/public/assets/logo-android.svg @@ -0,0 +1 @@ +Logo Android diff --git a/packages/react/test-app/public/assets/logo-apple.svg b/packages/react/test-app/public/assets/logo-apple.svg new file mode 100644 index 0000000000..838eb7cca7 --- /dev/null +++ b/packages/react/test-app/public/assets/logo-apple.svg @@ -0,0 +1 @@ +Logo Apple diff --git a/packages/react/test-app/src/App.tsx b/packages/react/test-app/src/App.tsx index c6bf826508..2003e4295b 100644 --- a/packages/react/test-app/src/App.tsx +++ b/packages/react/test-app/src/App.tsx @@ -26,6 +26,7 @@ import OverlayHooks from './pages/overlay-hooks/OverlayHooks'; import OverlayComponents from './pages/overlay-components/OverlayComponents'; import KeepContentsMounted from './pages/overlay-components/KeepContentsMounted'; import Tabs from './pages/Tabs'; +import Icons from './pages/Icons'; import NavComponent from './pages/navigation/NavComponent'; import IonModalConditionalSibling from './pages/overlay-components/IonModalConditionalSibling'; import IonModalConditional from './pages/overlay-components/IonModalConditional'; @@ -54,6 +55,7 @@ const App: React.FC = () => ( + diff --git a/packages/react/test-app/src/pages/Icons.tsx b/packages/react/test-app/src/pages/Icons.tsx new file mode 100644 index 0000000000..caf9f0b4e6 --- /dev/null +++ b/packages/react/test-app/src/pages/Icons.tsx @@ -0,0 +1,95 @@ +import React, { useState } from 'react'; +import { IonBackButton, IonButton, IonButtons, IonContent, IonHeader, IonIcon, IonItem, IonLabel, IonList, IonTitle, IonToolbar } from '@ionic/react'; +import { heart, heartCircleOutline, logoApple, logoTwitter, personCircleOutline, star, starOutline, trash } from 'ionicons/icons'; + +interface IconsProps {} + +const Icons: React.FC = () => { + const [dynamic, setDynamic] = useState(star); + const iosCustomSvg = "../assets/logo-apple.svg"; + const mdCustomSvg = "../assets/logo-android.svg"; + + const toggle = () => { + setDynamic(dynamic => dynamic === star ? starOutline : star); + } + + return ( + <> + + + + + + Icons + + + + + + + Icons + + + + + + + Static Icons + + + + + + Logo Icons + + + + + Dynamic Icon + toggle()}> + Toggle Icon + + + + + +

ios: heart circle

+

md: person circle

+ + + + + +

ios: star outline

+

md: star

+ + + + + +

mode: ios

+

ios: star outline

+

md: star

+ + + + + +

mode: md

+

ios: star outline

+

md: star

+ + + + + +

Custom SVG

+ + + + + + ); +}; + +export default Icons; diff --git a/packages/react/test-app/src/pages/Main.tsx b/packages/react/test-app/src/pages/Main.tsx index c5f097357d..0d95f9d0ef 100644 --- a/packages/react/test-app/src/pages/Main.tsx +++ b/packages/react/test-app/src/pages/Main.tsx @@ -25,26 +25,21 @@ const Main: React.FC = () => { Overlay Hooks - - Overlay Components - - Keep Contents Mounted Overlay Components - - Navigation - - Tabs + + Icons + diff --git a/packages/react/test-app/tests/e2e/specs/icons/icons.cy.ts b/packages/react/test-app/tests/e2e/specs/icons/icons.cy.ts new file mode 100644 index 0000000000..5e6d8f4003 --- /dev/null +++ b/packages/react/test-app/tests/e2e/specs/icons/icons.cy.ts @@ -0,0 +1,22 @@ +describe('Icons', () => { + it('should use ios svg', () => { + cy.visit('/icons?ionic:mode=ios'); + + cy.get('#customSvg').shadow().find('svg').should('have.class', 'ios'); + cy.get('#customSvg').shadow().find('svg').should('have.class', 'apple'); + }); + + it('should use md svg', () => { + cy.visit('/icons?ionic:mode=md'); + + cy.get('#customSvg').shadow().find('svg').should('have.class', 'md'); + cy.get('#customSvg').shadow().find('svg').should('have.class', 'android'); + }); + + it('should use fallback md svg', () => { + cy.visit('/icons'); + + cy.get('#customSvg').shadow().find('svg').should('have.class', 'md'); + cy.get('#customSvg').shadow().find('svg').should('have.class', 'android'); + }); +}) diff --git a/packages/vue-router/CHANGELOG.md b/packages/vue-router/CHANGELOG.md index 098de74c59..2903914712 100644 --- a/packages/vue-router/CHANGELOG.md +++ b/packages/vue-router/CHANGELOG.md @@ -3,6 +3,22 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.6.2](https://github.com/ionic-team/ionic/compare/v6.6.1...v6.6.2) (2023-03-15) + +**Note:** Version bump only for package @ionic/vue-router + + + + + +## [6.6.1](https://github.com/ionic-team/ionic/compare/v6.6.0...v6.6.1) (2023-03-08) + +**Note:** Version bump only for package @ionic/vue-router + + + + + # [6.6.0](https://github.com/ionic-team/ionic/compare/v6.5.7...v6.6.0) (2023-03-01) **Note:** Version bump only for package @ionic/vue-router diff --git a/packages/vue-router/package-lock.json b/packages/vue-router/package-lock.json index 36181d1c78..01857eea15 100644 --- a/packages/vue-router/package-lock.json +++ b/packages/vue-router/package-lock.json @@ -1,15 +1,15 @@ { "name": "@ionic/vue-router", - "version": "6.6.0", + "version": "6.6.2", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/vue-router", - "version": "6.6.0", + "version": "6.6.2", "license": "MIT", "dependencies": { - "@ionic/vue": "^6.6.0" + "@ionic/vue": "^6.6.2" }, "devDependencies": { "@ionic/eslint-config": "^0.3.0", @@ -660,9 +660,9 @@ "dev": true }, "node_modules/@ionic/core": { - "version": "6.6.0", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.6.0.tgz", - "integrity": "sha512-1X0b2/ziKhCwSO665tSpG32FOuMyjhyGDLFTJUKoDfQB0j/gIBv1d2okUzAk6GKHdnAPUZQHZFhUHcSIclW9cg==", + "version": "6.6.2", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.6.2.tgz", + "integrity": "sha512-C3XblxE4OcGs+QWy2meWqNGB8sDZV8w0nUVwLy3AmWovi0CA0xPs2UthUSicUxpCism33pzQp6DiDVsq+G5VTQ==", "dependencies": { "@stencil/core": "^2.18.0", "ionicons": "^6.1.3", @@ -851,11 +851,11 @@ } }, "node_modules/@ionic/vue": { - "version": "6.6.0", - "resolved": "https://registry.npmjs.org/@ionic/vue/-/vue-6.6.0.tgz", - "integrity": "sha512-rn+yW+zpxZox8F7MuoTgOoTq1rn54Cn7PIQJpwlm7FlDa0fYIwE3x3OaaWHxcKfpl5CBaKfNVvGuc3XPNV5Z0Q==", + "version": "6.6.2", + "resolved": "https://registry.npmjs.org/@ionic/vue/-/vue-6.6.2.tgz", + "integrity": "sha512-UB8UF4vrenu/n/2djXgin0Gjmr6dKrgb0EByBpcy0upmoEJ6ycddG47+iCT+BPVSKx/EeFnH+nDRpwo+yRrIZw==", "dependencies": { - "@ionic/core": "6.6.0", + "@ionic/core": "6.6.2", "ionicons": "^6.1.3" } }, @@ -1303,9 +1303,9 @@ } }, "node_modules/@stencil/core": { - "version": "2.22.2", - "resolved": "https://registry.npmjs.org/@stencil/core/-/core-2.22.2.tgz", - "integrity": "sha512-r+vbxsGNcBaV1VDOYW25lv4QfXTlNoIb5GpUX7rZ+cr59yqYCZC5tlV+IzX6YgHKW62ulCc9M3RYtTfHtNbNNw==", + "version": "2.22.3", + "resolved": "https://registry.npmjs.org/@stencil/core/-/core-2.22.3.tgz", + "integrity": "sha512-kmVA0M/HojwsfkeHsifvHVIYe4l5tin7J5+DLgtl8h6WWfiMClND5K3ifCXXI2ETDNKiEk21p6jql3Fx9o2rng==", "bin": { "stencil": "bin/stencil" }, @@ -7665,9 +7665,9 @@ "dev": true }, "@ionic/core": { - "version": "6.6.0", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.6.0.tgz", - "integrity": "sha512-1X0b2/ziKhCwSO665tSpG32FOuMyjhyGDLFTJUKoDfQB0j/gIBv1d2okUzAk6GKHdnAPUZQHZFhUHcSIclW9cg==", + "version": "6.6.2", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.6.2.tgz", + "integrity": "sha512-C3XblxE4OcGs+QWy2meWqNGB8sDZV8w0nUVwLy3AmWovi0CA0xPs2UthUSicUxpCism33pzQp6DiDVsq+G5VTQ==", "requires": { "@stencil/core": "^2.18.0", "ionicons": "^6.1.3", @@ -7780,11 +7780,11 @@ "requires": {} }, "@ionic/vue": { - "version": "6.6.0", - "resolved": "https://registry.npmjs.org/@ionic/vue/-/vue-6.6.0.tgz", - "integrity": "sha512-rn+yW+zpxZox8F7MuoTgOoTq1rn54Cn7PIQJpwlm7FlDa0fYIwE3x3OaaWHxcKfpl5CBaKfNVvGuc3XPNV5Z0Q==", + "version": "6.6.2", + "resolved": "https://registry.npmjs.org/@ionic/vue/-/vue-6.6.2.tgz", + "integrity": "sha512-UB8UF4vrenu/n/2djXgin0Gjmr6dKrgb0EByBpcy0upmoEJ6ycddG47+iCT+BPVSKx/EeFnH+nDRpwo+yRrIZw==", "requires": { - "@ionic/core": "6.6.0", + "@ionic/core": "6.6.2", "ionicons": "^6.1.3" } }, @@ -8143,9 +8143,9 @@ } }, "@stencil/core": { - "version": "2.22.2", - "resolved": "https://registry.npmjs.org/@stencil/core/-/core-2.22.2.tgz", - "integrity": "sha512-r+vbxsGNcBaV1VDOYW25lv4QfXTlNoIb5GpUX7rZ+cr59yqYCZC5tlV+IzX6YgHKW62ulCc9M3RYtTfHtNbNNw==" + "version": "2.22.3", + "resolved": "https://registry.npmjs.org/@stencil/core/-/core-2.22.3.tgz", + "integrity": "sha512-kmVA0M/HojwsfkeHsifvHVIYe4l5tin7J5+DLgtl8h6WWfiMClND5K3ifCXXI2ETDNKiEk21p6jql3Fx9o2rng==" }, "@tootallnate/once": { "version": "2.0.0", diff --git a/packages/vue-router/package.json b/packages/vue-router/package.json index 14574a4aa7..6b0259c487 100644 --- a/packages/vue-router/package.json +++ b/packages/vue-router/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/vue-router", - "version": "6.6.0", + "version": "6.6.2", "description": "Vue Router integration for @ionic/vue", "scripts": { "test.spec": "jest", @@ -46,7 +46,7 @@ }, "homepage": "https://github.com/ionic-team/ionic#readme", "dependencies": { - "@ionic/vue": "^6.6.0" + "@ionic/vue": "^6.6.2" }, "devDependencies": { "@ionic/eslint-config": "^0.3.0", diff --git a/packages/vue/CHANGELOG.md b/packages/vue/CHANGELOG.md index 9863d154b2..c7fa6862be 100644 --- a/packages/vue/CHANGELOG.md +++ b/packages/vue/CHANGELOG.md @@ -3,6 +3,25 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.6.2](https://github.com/ionic-team/ionic/compare/v6.6.1...v6.6.2) (2023-03-15) + + +### Bug Fixes + +* **react/vue:** properly switch ionicon based on the mode when ios/md is set ([#26924](https://github.com/ionic-team/ionic/issues/26924)) ([1eb9a08](https://github.com/ionic-team/ionic/commit/1eb9a085b2d69dfcfc71ff49b25d33347dd54aae)), closes [#26207](https://github.com/ionic-team/ionic/issues/26207) + + + + + +## [6.6.1](https://github.com/ionic-team/ionic/compare/v6.6.0...v6.6.1) (2023-03-08) + +**Note:** Version bump only for package @ionic/vue + + + + + # [6.6.0](https://github.com/ionic-team/ionic/compare/v6.5.7...v6.6.0) (2023-03-01) diff --git a/packages/vue/package-lock.json b/packages/vue/package-lock.json index ed0b17a525..693f897f8d 100644 --- a/packages/vue/package-lock.json +++ b/packages/vue/package-lock.json @@ -1,15 +1,15 @@ { "name": "@ionic/vue", - "version": "6.6.0", + "version": "6.6.2", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/vue", - "version": "6.6.0", + "version": "6.6.2", "license": "MIT", "dependencies": { - "@ionic/core": "^6.6.0", + "@ionic/core": "^6.6.2", "ionicons": "^6.1.3" }, "devDependencies": { @@ -208,9 +208,9 @@ "dev": true }, "node_modules/@ionic/core": { - "version": "6.6.0", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.6.0.tgz", - "integrity": "sha512-1X0b2/ziKhCwSO665tSpG32FOuMyjhyGDLFTJUKoDfQB0j/gIBv1d2okUzAk6GKHdnAPUZQHZFhUHcSIclW9cg==", + "version": "6.6.2", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.6.2.tgz", + "integrity": "sha512-C3XblxE4OcGs+QWy2meWqNGB8sDZV8w0nUVwLy3AmWovi0CA0xPs2UthUSicUxpCism33pzQp6DiDVsq+G5VTQ==", "dependencies": { "@stencil/core": "^2.18.0", "ionicons": "^6.1.3", @@ -3776,9 +3776,9 @@ "dev": true }, "@ionic/core": { - "version": "6.6.0", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.6.0.tgz", - "integrity": "sha512-1X0b2/ziKhCwSO665tSpG32FOuMyjhyGDLFTJUKoDfQB0j/gIBv1d2okUzAk6GKHdnAPUZQHZFhUHcSIclW9cg==", + "version": "6.6.2", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.6.2.tgz", + "integrity": "sha512-C3XblxE4OcGs+QWy2meWqNGB8sDZV8w0nUVwLy3AmWovi0CA0xPs2UthUSicUxpCism33pzQp6DiDVsq+G5VTQ==", "requires": { "@stencil/core": "^2.18.0", "ionicons": "^6.1.3", diff --git a/packages/vue/package.json b/packages/vue/package.json index ca253b47b9..f5871c2e77 100644 --- a/packages/vue/package.json +++ b/packages/vue/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/vue", - "version": "6.6.0", + "version": "6.6.2", "description": "Vue specific wrapper for @ionic/core", "scripts": { "eslint": "eslint src", @@ -68,7 +68,7 @@ "vue-router": "^4.0.16" }, "dependencies": { - "@ionic/core": "^6.6.0", + "@ionic/core": "^6.6.2", "ionicons": "^6.1.3" }, "vetur": { diff --git a/packages/vue/src/components/IonIcon.ts b/packages/vue/src/components/IonIcon.ts index dea7ca86ab..9840652f8d 100644 --- a/packages/vue/src/components/IonIcon.ts +++ b/packages/vue/src/components/IonIcon.ts @@ -1,7 +1,8 @@ -import { isPlatform } from "@ionic/core/components"; import { defineCustomElement } from "ionicons/components/ion-icon.js"; import { h, defineComponent } from "vue"; +import { getConfig } from "../utils"; + export const IonIcon = /*@__PURE__*/ defineComponent({ name: "IonIcon", props: { @@ -19,11 +20,15 @@ export const IonIcon = /*@__PURE__*/ defineComponent({ setup(props, { slots }) { defineCustomElement(); return () => { - const { icon, ios, md } = props; + const { icon, ios, md, mode } = props; let iconToUse: typeof icon; + + const config = getConfig(); + const iconMode = mode || config?.get("mode"); + if (ios || md) { - if (isPlatform("ios")) { + if (iconMode === "ios") { iconToUse = ios ?? md ?? icon; } else { iconToUse = md ?? ios ?? icon; diff --git a/packages/vue/test/base/public/assets/logo-android.svg b/packages/vue/test/base/public/assets/logo-android.svg new file mode 100644 index 0000000000..36d03ecea6 --- /dev/null +++ b/packages/vue/test/base/public/assets/logo-android.svg @@ -0,0 +1 @@ +Logo Android diff --git a/packages/vue/test/base/public/assets/logo-apple.svg b/packages/vue/test/base/public/assets/logo-apple.svg new file mode 100644 index 0000000000..838eb7cca7 --- /dev/null +++ b/packages/vue/test/base/public/assets/logo-apple.svg @@ -0,0 +1 @@ +Logo Apple diff --git a/packages/vue/test/base/src/router/index.ts b/packages/vue/test/base/src/router/index.ts index d67ca47993..51f037d969 100644 --- a/packages/vue/test/base/src/router/index.ts +++ b/packages/vue/test/base/src/router/index.ts @@ -33,6 +33,10 @@ const routes: Array = [ path: '/keep-contents-mounted', component: () => import('@/views/OverlaysKeepContentsMounted.vue') }, + { + path: '/icons', + component: () => import('@/views/Icons.vue') + }, { path: '/inputs', component: () => import('@/views/Inputs.vue') diff --git a/packages/vue/test/base/src/views/Home.vue b/packages/vue/test/base/src/views/Home.vue index 2d0e6a875a..0ce1b7cab0 100644 --- a/packages/vue/test/base/src/views/Home.vue +++ b/packages/vue/test/base/src/views/Home.vue @@ -20,6 +20,9 @@ Overlays + + Icons + Inputs diff --git a/packages/vue/test/base/src/views/Icons.vue b/packages/vue/test/base/src/views/Icons.vue new file mode 100644 index 0000000000..f44e3516b1 --- /dev/null +++ b/packages/vue/test/base/src/views/Icons.vue @@ -0,0 +1,143 @@ + + + diff --git a/packages/vue/test/base/tests/e2e/specs/icons.cy.js b/packages/vue/test/base/tests/e2e/specs/icons.cy.js new file mode 100644 index 0000000000..cdf34a0130 --- /dev/null +++ b/packages/vue/test/base/tests/e2e/specs/icons.cy.js @@ -0,0 +1,22 @@ +describe('Icons', () => { + it('should use ios svg', () => { + cy.visit('http://localhost:8080/icons?ionic:mode=ios'); + + cy.get('#customSvg').shadow().find('svg').should('have.class', 'ios'); + cy.get('#customSvg').shadow().find('svg').should('have.class', 'apple'); + }); + + it('should use md svg', () => { + cy.visit('http://localhost:8080/icons?ionic:mode=md'); + + cy.get('#customSvg').shadow().find('svg').should('have.class', 'md'); + cy.get('#customSvg').shadow().find('svg').should('have.class', 'android'); + }); + + it('should use fallback md svg', () => { + cy.visit('http://localhost:8080/icons'); + + cy.get('#customSvg').shadow().find('svg').should('have.class', 'md'); + cy.get('#customSvg').shadow().find('svg').should('have.class', 'android'); + }); +})