javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-08 23:58:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(datetime): remove safari 14 hack (#29035)

Browse Source 
Issue number: Internal

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

This code was added to account for a Safari 14 issue that would cause
datetime to render incorrectly. The Safari bug was fixed starting in
Safari 15. However, Ionic v7 supported back to Safari 14.

More context is available
[here](https://github.com/ionic-team/ionic-framework/pull/24421#discussion_r796113907)

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Removed the Safari 14 workarounds since Ionic v8 does not support
Safari 14

I tested on iOS 15, 16, and 17 to verify that removing this hack does
not cause any issues. Also verified that removing this hack does
reproduce the issue on iOS 14 (to verify that I am reproducing the
original issue correctly)

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer
for more information.
-->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
This commit is contained in:
Liam DeBeasi
2024-02-13 11:57:47 -05:00
committed by GitHub
parent b37fa5e997
commit 957604c3a0
1 changed files with 0 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
core/src/components/datetime/datetime.tsx
View File

@ -1662,14 +1662,6 @@ export class Datetime implements ComponentInterface {
disabled={disabled}
value={todayString}
onIonChange={(ev: CustomEvent) => {
// TODO(FW-1823) Remove this when iOS 14 support is dropped.
// Due to a Safari 14 issue we need to destroy
// the scroll listener before we update state
// and trigger a re-render.
if (this.destroyCalendarListener) {
this.destroyCalendarListener();
}
const { value } = ev.detail;
const findPart = parts.find(({ month, day, year }) => value === `${year}-${month}-${day}`);
@ -1683,10 +1675,6 @@ export class Datetime implements ComponentInterface {
...findPart,
});
// We can re-attach the scroll listener after
// the working parts have been updated.
this.initializeCalendarListener();
ev.stopPropagation();
}}
>
@ -1793,14 +1781,6 @@ export class Datetime implements ComponentInterface {
disabled={disabled}
value={pickerColumnValue}
onIonChange={(ev: CustomEvent) => {
// TODO(FW-1823) Remove this when iOS 14 support is dropped.
// Due to a Safari 14 issue we need to destroy
// the scroll listener before we update state
// and trigger a re-render.
if (this.destroyCalendarListener) {
this.destroyCalendarListener();
}
this.setWorkingParts({
...workingParts,
day: ev.detail.value,
@ -1811,10 +1791,6 @@ export class Datetime implements ComponentInterface {
day: ev.detail.value,
});
// We can re-attach the scroll listener after
// the working parts have been updated.
this.initializeCalendarListener();
ev.stopPropagation();
}}
>
@ -1848,14 +1824,6 @@ export class Datetime implements ComponentInterface {
disabled={disabled}
value={workingParts.month}
onIonChange={(ev: CustomEvent) => {
// TODO(FW-1823) Remove this when iOS 14 support is dropped.
// Due to a Safari 14 issue we need to destroy
// the scroll listener before we update state
// and trigger a re-render.
if (this.destroyCalendarListener) {
this.destroyCalendarListener();
}
this.setWorkingParts({
...workingParts,
month: ev.detail.value,
@ -1866,10 +1834,6 @@ export class Datetime implements ComponentInterface {
month: ev.detail.value,
});
// We can re-attach the scroll listener after
// the working parts have been updated.
this.initializeCalendarListener();
ev.stopPropagation();
}}
>
@ -1902,14 +1866,6 @@ export class Datetime implements ComponentInterface {
disabled={disabled}
value={workingParts.year}
onIonChange={(ev: CustomEvent) => {
// TODO(FW-1823) Remove this when iOS 14 support is dropped.
// Due to a Safari 14 issue we need to destroy
// the scroll listener before we update state
// and trigger a re-render.
if (this.destroyCalendarListener) {
this.destroyCalendarListener();
}
this.setWorkingParts({
...workingParts,
year: ev.detail.value,
@ -1920,10 +1876,6 @@ export class Datetime implements ComponentInterface {
year: ev.detail.value,
});
// We can re-attach the scroll listener after
// the working parts have been updated.
this.initializeCalendarListener();
ev.stopPropagation();
}}
>