From 949d93e078737ea5b7e4898baf601046d1253382 Mon Sep 17 00:00:00 2001 From: Brandy Carney Date: Tue, 19 Jun 2018 13:04:06 -0400 Subject: [PATCH] fix(icon): target element for style and add to breaking --- angular/BREAKING.md | 5 ++++- core/src/components/icon/test/standalone/index.html | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/angular/BREAKING.md b/angular/BREAKING.md index 0f6d4e32f6..b2697c5e87 100644 --- a/angular/BREAKING.md +++ b/angular/BREAKING.md @@ -463,11 +463,14 @@ If any `CSS` is being overridden for an icon it will need to change to override **New Usage Example:** ```css -.icon { +ion-icon { fill: #000; } ``` +_Note: we are no longer adding the `icon` class to an `ion-icon`, so the element should be targeted instead._ + + ### Property Removed The `isActive` property has been removed. It only worked for `ios` icons previously. If you would like to switch between an outline and solid icon you should set it in the `name`, or `ios`/`md` attribute and then change it when needed. diff --git a/core/src/components/icon/test/standalone/index.html b/core/src/components/icon/test/standalone/index.html index e11c066024..6e46657b74 100644 --- a/core/src/components/icon/test/standalone/index.html +++ b/core/src/components/icon/test/standalone/index.html @@ -55,7 +55,7 @@