From 947780e70a4e1b3d83f9cdef11561fbc71af96d9 Mon Sep 17 00:00:00 2001 From: Adam Bradley Date: Sat, 19 Nov 2016 20:19:13 -0600 Subject: [PATCH] feat(virtual-scroll): apply contain:strict to virtual scroll items --- src/components/virtual-scroll/test/list/app-module.ts | 7 +++---- src/components/virtual-scroll/test/list/main.html | 11 +---------- src/components/virtual-scroll/virtual-scroll.scss | 2 ++ 3 files changed, 6 insertions(+), 14 deletions(-) diff --git a/src/components/virtual-scroll/test/list/app-module.ts b/src/components/virtual-scroll/test/list/app-module.ts index aaa37f89e9..337d195f75 100644 --- a/src/components/virtual-scroll/test/list/app-module.ts +++ b/src/components/virtual-scroll/test/list/app-module.ts @@ -6,7 +6,7 @@ import { IonicApp, IonicModule } from '../../../..'; templateUrl: 'main.html' }) export class E2EPage { - items: Array<{title: string, date: string}>; + items: Array<{title: string}>; constructor() { this.emptyList(); @@ -14,10 +14,9 @@ export class E2EPage { fillList() { this.items = []; - for (let i = 0; i < 59; i++) { + for (let i = 0; i < 500; i++) { this.items.push({ - title: 'Item ' + i, - date: '23:' + (59 - i) + title: 'Item ' + i }); } } diff --git a/src/components/virtual-scroll/test/list/main.html b/src/components/virtual-scroll/test/list/main.html index 8a3c36e5e9..25c7bfaebe 100644 --- a/src/components/virtual-scroll/test/list/main.html +++ b/src/components/virtual-scroll/test/list/main.html @@ -20,16 +20,7 @@ - - - - {{item.title}} - - - {{item.date}} - - - + {{item.title}} diff --git a/src/components/virtual-scroll/virtual-scroll.scss b/src/components/virtual-scroll/virtual-scroll.scss index cb73aeb3f6..5b7810e647 100644 --- a/src/components/virtual-scroll/virtual-scroll.scss +++ b/src/components/virtual-scroll/virtual-scroll.scss @@ -14,6 +14,8 @@ left: 0; transition-duration: 0ms; + + contain: strict; } .virtual-scroll .virtual-hidden {