javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-15 17:42:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(react, vue): tab buttons no longer throw an error if href is undefined (#22998)

Browse Source 
resolves #22997
This commit is contained in:
Liam DeBeasi
2021-03-02 10:05:59 -05:00
committed by GitHub
parent 9282aa6871
commit 943e3f6ae3
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/react-router/src/ReactRouter/IonRouter.tsx
View File

@ -76,7 +76,9 @@ class IonRouterInner extends React.PureComponent<IonRouteProps, IonRouteState> {
}; };
} }
handleChangeTab(tab: string, path: string, routeOptions?: any) { handleChangeTab(tab: string, path?: string, routeOptions?: any) {
if (!path) { return; }
const routeInfo = this.locationHistory.getCurrentRouteInfoForTab(tab); const routeInfo = this.locationHistory.getCurrentRouteInfoForTab(tab);
const [pathname, search] = path.split('?'); const [pathname, search] = path.split('?');
if (routeInfo) { if (routeInfo) {

4
packages/vue-router/src/router.ts
View File

@ -252,7 +252,9 @@ export const createIonRouter = (opts: IonicVueRouterOptions, router: Router) =>
} }
} }
const changeTab = (tab: string, path: string) => { const changeTab = (tab: string, path?: string) => {
if (!path) return;
const routeInfo = locationHistory.getCurrentRouteInfoForTab(tab); const routeInfo = locationHistory.getCurrentRouteInfoForTab(tab);
const [pathname] = path.split('?'); const [pathname] = path.split('?');