From 9318d2418ec144bbce4a3b7ead33cf099d6ec25b Mon Sep 17 00:00:00 2001 From: Brandy Carney Date: Fri, 3 Jan 2020 12:19:17 -0500 Subject: [PATCH] fix(icons): fix the ellipsis fill in ionicons (#20137) - update docs icon usage for Ionicons 5 - update tests to remove mode prefixed icons - update tests to use the correct icons for Ionicons 5 - update to latest ionicons dev which fixes the ellipsis icon fill --- core/package.json | 2 +- .../components/button/test/toolbar/index.html | 10 ++-- core/src/components/buttons/readme.md | 20 +++---- .../components/buttons/test/icon/index.html | 2 +- core/src/components/buttons/usage/angular.md | 4 +- .../components/buttons/usage/javascript.md | 4 +- core/src/components/buttons/usage/react.md | 6 +- core/src/components/buttons/usage/vue.md | 6 +- .../card/test/translucent/index.html | 2 +- core/src/components/fab/readme.md | 18 +++--- core/src/components/fab/usage/angular.md | 6 +- core/src/components/fab/usage/javascript.md | 6 +- core/src/components/fab/usage/react.md | 6 +- core/src/components/fab/usage/vue.md | 6 +- core/src/components/icon/usage/angular.md | 8 +-- core/src/components/icon/usage/javascript.md | 8 +-- core/src/components/icon/usage/react.md | 16 ++---- core/src/components/icon/usage/vue.md | 8 +-- core/src/components/item-sliding/readme.md | 32 +++++------ .../item-sliding/test/basic/index.html | 22 ++++---- .../item-sliding/test/lines/index.html | 2 +- .../components/item-sliding/usage/angular.md | 8 +-- .../item-sliding/usage/javascript.md | 8 +-- .../components/item-sliding/usage/react.md | 8 +-- core/src/components/item-sliding/usage/vue.md | 8 +-- .../src/components/list/test/icons/index.html | 2 +- .../components/range/test/basic/index.html | 8 +-- .../range/test/standalone/index.html | 8 +-- core/src/components/tab-button/readme.md | 8 +-- .../components/tab-button/usage/angular.md | 2 +- .../components/tab-button/usage/javascript.md | 2 +- core/src/components/tab-button/usage/react.md | 2 +- core/src/components/tab-button/usage/vue.md | 2 +- core/src/components/tabs/readme.md | 8 +-- core/src/components/tabs/usage/angular.md | 2 +- core/src/components/tabs/usage/javascript.md | 2 +- core/src/components/tabs/usage/react.md | 2 +- core/src/components/tabs/usage/vue.md | 2 +- core/src/components/toolbar/readme.md | 56 +++++++++---------- .../components/toolbar/test/basic/index.html | 2 +- .../components/toolbar/test/colors/index.html | 22 ++++---- .../toolbar/test/scenarios/index.html | 6 +- .../components/toolbar/test/spec/index.html | 2 +- core/src/components/toolbar/usage/angular.md | 14 ++--- .../components/toolbar/usage/javascript.md | 14 ++--- core/src/components/toolbar/usage/react.md | 14 ++--- core/src/components/toolbar/usage/vue.md | 14 ++--- core/src/themes/test/css-variables/index.html | 30 +++++----- 48 files changed, 217 insertions(+), 233 deletions(-) diff --git a/core/package.json b/core/package.json index 96199bfde1..ca2bdf48df 100644 --- a/core/package.json +++ b/core/package.json @@ -30,7 +30,7 @@ "loader/" ], "dependencies": { - "ionicons": "^5.0.0-13", + "ionicons": "5.0.0-15", "tslib": "^1.10.0" }, "devDependencies": { diff --git a/core/src/components/button/test/toolbar/index.html b/core/src/components/button/test/toolbar/index.html index 8a17767817..de8ecc726f 100644 --- a/core/src/components/button/test/toolbar/index.html +++ b/core/src/components/button/test/toolbar/index.html @@ -40,7 +40,7 @@ - + This is a long title with buttons. It just goes on and on my friend. @@ -57,7 +57,7 @@ - + This is a long title with buttons. It just goes on and on my friend. @@ -74,7 +74,7 @@ - + This is a long title with buttons. It just goes on and on my friend. @@ -91,7 +91,7 @@ - + Defaults @@ -108,7 +108,7 @@ - + Defaults.activated diff --git a/core/src/components/buttons/readme.md b/core/src/components/buttons/readme.md index b654e4879c..30587cf014 100644 --- a/core/src/components/buttons/readme.md +++ b/core/src/components/buttons/readme.md @@ -30,7 +30,7 @@ The `` element can be positioned inside of the toolbar using a name - + @@ -39,7 +39,7 @@ The `` element can be positioned inside of the toolbar using a name Default Buttons - + @@ -80,7 +80,7 @@ The `` element can be positioned inside of the toolbar using a name - + @@ -89,7 +89,7 @@ The `` element can be positioned inside of the toolbar using a name Default Buttons - + @@ -148,7 +148,7 @@ export const ButtonsExample: React.FC = () => ( - + @@ -157,7 +157,7 @@ export const ButtonsExample: React.FC = () => ( Default Buttons - + @@ -173,7 +173,7 @@ export const ButtonsExample: React.FC = () => ( - + @@ -201,7 +201,7 @@ export const ButtonsExample: React.FC = () => ( - + @@ -210,7 +210,7 @@ export const ButtonsExample: React.FC = () => ( Default Buttons - + @@ -226,7 +226,7 @@ export const ButtonsExample: React.FC = () => ( - + diff --git a/core/src/components/buttons/test/icon/index.html b/core/src/components/buttons/test/icon/index.html index e528bf9d24..92b1f88321 100644 --- a/core/src/components/buttons/test/icon/index.html +++ b/core/src/components/buttons/test/icon/index.html @@ -22,7 +22,7 @@ - + diff --git a/core/src/components/buttons/usage/angular.md b/core/src/components/buttons/usage/angular.md index 029528963c..3af3e63a4d 100644 --- a/core/src/components/buttons/usage/angular.md +++ b/core/src/components/buttons/usage/angular.md @@ -9,7 +9,7 @@ - + @@ -18,7 +18,7 @@ Default Buttons - + diff --git a/core/src/components/buttons/usage/javascript.md b/core/src/components/buttons/usage/javascript.md index d7b9fbd5eb..707cfc4e16 100644 --- a/core/src/components/buttons/usage/javascript.md +++ b/core/src/components/buttons/usage/javascript.md @@ -9,7 +9,7 @@ - + @@ -18,7 +18,7 @@ Default Buttons - + diff --git a/core/src/components/buttons/usage/react.md b/core/src/components/buttons/usage/react.md index 89c089cece..dbb51964ce 100644 --- a/core/src/components/buttons/usage/react.md +++ b/core/src/components/buttons/usage/react.md @@ -23,7 +23,7 @@ export const ButtonsExample: React.FC = () => ( - + @@ -32,7 +32,7 @@ export const ButtonsExample: React.FC = () => ( Default Buttons - + @@ -48,7 +48,7 @@ export const ButtonsExample: React.FC = () => ( - + diff --git a/core/src/components/buttons/usage/vue.md b/core/src/components/buttons/usage/vue.md index 887a96c729..114cc2579b 100644 --- a/core/src/components/buttons/usage/vue.md +++ b/core/src/components/buttons/usage/vue.md @@ -10,7 +10,7 @@ - + @@ -19,7 +19,7 @@ Default Buttons - + @@ -35,7 +35,7 @@ - + diff --git a/core/src/components/card/test/translucent/index.html b/core/src/components/card/test/translucent/index.html index a23e7b3cf4..f4d4704c37 100644 --- a/core/src/components/card/test/translucent/index.html +++ b/core/src/components/card/test/translucent/index.html @@ -232,7 +232,7 @@ - + Share diff --git a/core/src/components/fab/readme.md b/core/src/components/fab/readme.md index 256233c000..4762403a98 100644 --- a/core/src/components/fab/readme.md +++ b/core/src/components/fab/readme.md @@ -21,21 +21,21 @@ Fabs are container elements that contain one or more fab buttons. They should be - + - + - + @@ -110,21 +110,21 @@ export const FabExample: React.FC = () => ( {/*-- fab placed to the bottom end --*/} - + {/*-- fab placed to the top start --*/} - + {/*-- fab placed to the bottom start --*/} - + @@ -197,21 +197,21 @@ export const FabExample: React.FC = () => ( - + - + - + diff --git a/core/src/components/fab/usage/angular.md b/core/src/components/fab/usage/angular.md index 8a07afa839..3f13c497c7 100644 --- a/core/src/components/fab/usage/angular.md +++ b/core/src/components/fab/usage/angular.md @@ -10,21 +10,21 @@ - + - + - + diff --git a/core/src/components/fab/usage/javascript.md b/core/src/components/fab/usage/javascript.md index 8a07afa839..3f13c497c7 100644 --- a/core/src/components/fab/usage/javascript.md +++ b/core/src/components/fab/usage/javascript.md @@ -10,21 +10,21 @@ - + - + - + diff --git a/core/src/components/fab/usage/react.md b/core/src/components/fab/usage/react.md index e37f1967bb..392ec6a352 100644 --- a/core/src/components/fab/usage/react.md +++ b/core/src/components/fab/usage/react.md @@ -14,21 +14,21 @@ export const FabExample: React.FC = () => ( {/*-- fab placed to the bottom end --*/} - + {/*-- fab placed to the top start --*/} - + {/*-- fab placed to the bottom start --*/} - + diff --git a/core/src/components/fab/usage/vue.md b/core/src/components/fab/usage/vue.md index 6c96bb671f..c7f57e6d33 100644 --- a/core/src/components/fab/usage/vue.md +++ b/core/src/components/fab/usage/vue.md @@ -11,21 +11,21 @@ - + - + - + diff --git a/core/src/components/icon/usage/angular.md b/core/src/components/icon/usage/angular.md index 97d37c9b7c..7ea7dbe54f 100644 --- a/core/src/components/icon/usage/angular.md +++ b/core/src/components/icon/usage/angular.md @@ -1,13 +1,9 @@ ```html - + - - - - - + diff --git a/core/src/components/icon/usage/javascript.md b/core/src/components/icon/usage/javascript.md index 97d37c9b7c..7ea7dbe54f 100644 --- a/core/src/components/icon/usage/javascript.md +++ b/core/src/components/icon/usage/javascript.md @@ -1,13 +1,9 @@ ```html - + - - - - - + diff --git a/core/src/components/icon/usage/react.md b/core/src/components/icon/usage/react.md index 370a05713f..a1843bfcc0 100644 --- a/core/src/components/icon/usage/react.md +++ b/core/src/components/icon/usage/react.md @@ -5,22 +5,18 @@ import { IonIcon } from '@ionic/react'; const Example: React.FC<{}> = () => ( <> - {/*-- automatically uses the correct "star" icon depending on the mode --*/} - + {/*-- uses "star" icon for both modes --*/} + {/*-- explicitly set the icon for each mode --*/} - - - {/*-- always use the same icon, no matter what the mode is --*/} - - + {/*-- use a custom svg icon --*/} - + {/*-- set the icon size --*/} - - + + ); diff --git a/core/src/components/icon/usage/vue.md b/core/src/components/icon/usage/vue.md index 79a66d8ec6..c009083b38 100644 --- a/core/src/components/icon/usage/vue.md +++ b/core/src/components/icon/usage/vue.md @@ -1,14 +1,10 @@ ```html