diff --git a/BREAKING.md b/BREAKING.md index 33d122d026..013d638eb2 100644 --- a/BREAKING.md +++ b/BREAKING.md @@ -3,6 +3,8 @@ A list of the breaking changes introduced in Ionic Angular v4. +- [Alert](#alert) +- [Action Sheet](#action-sheet) - [Dynamic Mode](#dynamic-mode) - [Button](#button) - [Chip](#chip) @@ -25,9 +27,57 @@ A list of the breaking changes introduced in Ionic Angular v4. - [Select](#select) - [Spinner](#spinner) - [Text / Typography](#text--typography) +- [Tabs](#tabs) - [Theming](#theming) - [Toolbar](#toolbar) +## Alert + +The `title` and `subTitle` properties has been renamed to `header` and `subHeader` respectivelly. + +**Old Usage Example:** + +```js +const alert = await alertCtrl.create({ + title: 'This is the title', + subTitle: 'this is the sub title' +}); +await alert.present(); +``` + +**New Usage Example:** + +```js +const alert = await alertCtrl.create({ + header: 'This is the title', + subHeader: 'this is the sub title' +}); +await alert.present(); +``` + +## Action Sheet + +The `title` and `subTitle` properties has been renamed to `header` and `subHeader` respectivelly. + +**Old Usage Example:** + +```js +const actionSheet = await actionSheetCtrl.create({ + title: 'This is the title', + subTitle: 'this is the sub title' +}); +await actionSheet.present(); +``` + +**New Usage Example:** + +```js +const actionSheet = await actionSheetCtrl.create({ + header: 'This is the title', + subHeader: 'this is the sub title' +}); +await actionSheet.present(); +``` ## Dynamic Mode @@ -873,6 +923,33 @@ Typography should now be written as an `` element. Previously the `ion

``` +## Tab + +Some properties in `ion-tab` changed: + +- [tabTitle] -> [label] +- [tabIcon] -> [icon] +- [tabBadge] -> [badge] +- [tabBadgeStyle] -> [badgeStyle] + +**Old Usage Example:** + +```html + + + + +``` + +**New Usage Example:** + +```html + + + + +``` + ## Theming diff --git a/core/src/components/button/button.tsx b/core/src/components/button/button.tsx index 789a82bcc4..9f7f1c9f7d 100644 --- a/core/src/components/button/button.tsx +++ b/core/src/components/button/button.tsx @@ -149,8 +149,8 @@ export class Button { disabled={this.disabled} onFocus={this.onFocus.bind(this)} onKeyUp={this.onKeyUp.bind(this)} - onClick={(ev) => openURL(this.href, ev, this.goBack)} - onBlur={this.onBlur.bind(this)}> + onBlur={this.onBlur.bind(this)} + onClick={(ev) => openURL(this.href, ev, this.goBack)}>