From 91d041485cb3565fa81fea24c1811e48108f277a Mon Sep 17 00:00:00 2001 From: Hans Krywalsky Date: Mon, 2 Nov 2020 19:14:15 +0100 Subject: [PATCH] fix(refresher): work properly in modal by waiting for content to be ready (#22390) resolves #22256 --- core/src/components/refresher/refresher.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/components/refresher/refresher.tsx b/core/src/components/refresher/refresher.tsx index fd9ebf6e67..175f9be5f5 100644 --- a/core/src/components/refresher/refresher.tsx +++ b/core/src/components/refresher/refresher.tsx @@ -371,8 +371,6 @@ export class Refresher implements ComponentInterface { const pullingSpinner = this.el.querySelector('ion-refresher-content .refresher-pulling ion-spinner') as HTMLIonSpinnerElement; const refreshingSpinner = this.el.querySelector('ion-refresher-content .refresher-refreshing ion-spinner') as HTMLIonSpinnerElement; - await contentEl.componentOnReady(); - if (getIonMode(this) === 'ios') { this.setupiOSNativeRefresher(pullingSpinner, refreshingSpinner); } else { @@ -396,6 +394,8 @@ export class Refresher implements ComponentInterface { return; } + await contentEl.componentOnReady(); + this.scrollEl = await contentEl.getScrollElement(); this.backgroundContentEl = getElementRoot(contentEl).querySelector('#background-content') as HTMLElement;