javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-17 18:54:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(vue): correct route is replaced when using router.replace (#24533)

Browse Source 
resolves #24226
This commit is contained in:
Liam DeBeasi
2022-01-10 11:58:35 -05:00
committed by GitHub
parent f539ff4788
commit 90458da406
2 changed files with 34 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/vue-router/src/router.ts
View File

@ -238,7 +238,19 @@ export const createIonRouter = (opts: IonicVueRouterOptions, router: Router) =>
const lastRoute = locationHistory.getCurrentRouteInfoForTab(routeInfo.tab);
routeInfo.pushedByRoute = lastRoute?.pushedByRoute;
} else if (routeInfo.routerAction === 'replace') {
const currentRouteInfo = locationHistory.last();
/**
* When replacing a route, we want to make sure we select the current route
* that we are on, not the last route in the stack. The last route in the stack
* is not always the current route.
* Example:
* Given the following history: /page1 --> /page2
* Doing router.go(-1) would bring you to /page1.
* If you then did router.replace('/page3'), /page1 should
* be replaced with /page3 even though /page2 is the last
* item in the stack/
*/
const currentRouteInfo = locationHistory.current(initialHistoryPosition, currentHistoryPosition);
/**
* If going from /home to /child, then replacing from