javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(modal, popover): do not dismiss when ionDismiss is emitted from select (#25125)

Browse Source 
resolves #25124
This commit is contained in:
Liam DeBeasi
2022-04-15 19:09:38 +05:45
committed by GitHub
parent 96b2003b2b
commit 90115db985
2 changed files with 0 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
core/src/components/modal/modal.tsx
View File

@ -723,13 +723,6 @@ export class Modal implements ComponentInterface, OverlayInterface {
this.dismiss(undefined, BACKDROP);
};
private onDismiss = (ev: UIEvent) => {
ev.stopPropagation();
ev.preventDefault();
this.dismiss();
};
private onLifecycle = (modalEvent: CustomEvent) => {
const el = this.usersElement;
const name = LIFECYCLE_MAP[modalEvent.type];
@ -770,7 +763,6 @@ export class Modal implements ComponentInterface, OverlayInterface {
}}
id={modalId}
onIonBackdropTap={this.onBackdropTap}
onIonDismiss={this.onDismiss}
onIonModalDidPresent={this.onLifecycle}
onIonModalWillPresent={this.onLifecycle}
onIonModalWillDismiss={this.onLifecycle}