javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-13 21:17:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(checkbox): cleanup

Browse Source
This commit is contained in:
Maria Hutt
2025-11-03 08:57:39 -08:00
parent ec4eb8344e
commit 8e46414bd5
1 changed files with 2 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
core/src/components/checkbox/checkbox.tsx
View File

@@ -1,5 +1,5 @@
import type { ComponentInterface, EventEmitter } from '@stencil/core';
import { Component, Element, Event, Host, Method, Prop, State, h, forceUpdate, Build } from '@stencil/core';
import { Component, Element, Event, Host, Method, Prop, State, h, Build } from '@stencil/core';
import { checkInvalidState } from '@utils/forms';
import type { Attributes } from '@utils/helpers';
import { inheritAriaAttributes, renderHiddenInput } from '@utils/helpers';
@@ -186,7 +186,7 @@ export class Checkbox implements ComponentInterface {
}
// Always set initial state
this.isInvalid = this.checkInvalidState();
this.isInvalid = checkInvalidState(el);
}
componentWillLoad() {
@@ -235,13 +235,6 @@ export class Checkbox implements ComponentInterface {
};
private onBlur = () => {
const newIsInvalid = this.checkInvalidState();
if (this.isInvalid !== newIsInvalid) {
this.isInvalid = newIsInvalid;
// Force a re-render to update aria-describedby immediately.
forceUpdate(this);
}
this.ionBlur.emit();
};
@@ -312,16 +305,6 @@ export class Checkbox implements ComponentInterface {
);
}
/**
* Checks if the input is in an invalid state based on Ionic validation classes
*/
private checkInvalidState(): boolean {
const hasIonTouched = this.el.classList.contains('ion-touched');
const hasIonInvalid = this.el.classList.contains('ion-invalid');
return hasIonTouched && hasIonInvalid;
}
render() {
const {
color,