From 8dc08f9c1fc6a9ecc7e676693d321d5c534f9771 Mon Sep 17 00:00:00 2001 From: Manuel Mtz-Almeida Date: Wed, 28 Jun 2017 17:23:54 +0200 Subject: [PATCH] fix(select): _inputUpdated should not be called manually --- src/components/select/select.ts | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/components/select/select.ts b/src/components/select/select.ts index 6edabee27c..1d495cb3e0 100644 --- a/src/components/select/select.ts +++ b/src/components/select/select.ts @@ -460,7 +460,7 @@ export class Select extends BaseInput implements OnDestroy { // we use writeValue() because we don't want to update ngModel this.writeValue(val.filter(o => o.selected).map(o => o.value)); } else { - this._inputUpdated(); + this._updateText(); } } @@ -479,7 +479,7 @@ export class Select extends BaseInput implements OnDestroy { /** * @hidden */ - _inputUpdated() { + _updateText() { this._texts.length = 0; if (this._options) { @@ -496,6 +496,13 @@ export class Select extends BaseInput implements OnDestroy { } this._text = this._texts.join(', '); + } + + /** + * @hidden + */ + _inputUpdated() { + this._updateText(); super._inputUpdated(); }