javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-22 13:32:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(all): memory leaks

Browse Source 
fixes #10459
fixes #10416
fixes #10286
This commit is contained in:
Manu Mtz.-Almeida
2017-02-23 20:55:30 +01:00
parent be0b6a8872
commit 8d9f374065
13 changed files with 25 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/navigation/nav-controller-base.ts
View File

@ -723,7 +723,7 @@ export class NavControllerBase extends Ion implements NavController {
if (transition.isRoot()) {
// this is the root transition
// it's save to destroy this transition
// it's safe to destroy this transition
this._trnsCtrl.destroy(transition.trnsId);
// it's safe to enable the app again
@ -909,13 +909,10 @@ export class NavControllerBase extends Ion implements NavController {
view._destroy(this._renderer);
}
// purge stack
this._views.length = 0;
// release swipe back gesture and transition
this._sbGesture && this._sbGesture.destroy();
this._sbTrns && this._sbTrns.destroy();
this._sbGesture = this._sbTrns = null;
this._queue = this._views = this._sbGesture = this._sbTrns = null;
// Unregister navcontroller
if (this.parent && this.parent.unregisterChildNav) {

2
src/navigation/view-controller.ts
View File

@ -523,7 +523,7 @@ export class ViewController {
this._cmp.destroy();
}
this._nav = this._cmp = this.instance = this._cntDir = this._cntRef = this._hdrDir = this._ftrDir = this._nb = this._onDidDismiss = this._onWillDismiss = null;
this._nav = this._cmp = this.instance = this._cntDir = this._cntRef = this._leavingOpts = this._hdrDir = this._ftrDir = this._nb = this._onDidDismiss = this._onWillDismiss = null;
}
/**