javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-09 08:09:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(angular): keepContentsMounted modal is sized correctly (#26917)

Browse Source 
resolves #26916
This commit is contained in:
Liam DeBeasi
2023-03-07 09:25:09 -05:00
committed by GitHub
parent 0afc61917c
commit 8d184c8c1b
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
angular/src/directives/overlays/modal.ts
View File

@ -80,7 +80,7 @@ export declare interface IonModal extends Components.IonModal {
@Component({ @Component({
selector: 'ion-modal', selector: 'ion-modal',
changeDetection: ChangeDetectionStrategy.OnPush, changeDetection: ChangeDetectionStrategy.OnPush,
template: `<div class="ion-page" *ngIf="isCmpOpen || keepContentsMounted"> template: `<div class="ion-delegate-host ion-page" *ngIf="isCmpOpen || keepContentsMounted">
<ng-container [ngTemplateOutlet]="template"></ng-container> <ng-container [ngTemplateOutlet]="template"></ng-container>
</div>`, </div>`,
inputs: [ inputs: [

6
angular/test/base/e2e/src/keep-contents-mounted.spec.ts
View File

@ -27,6 +27,12 @@ describe('overlays - keepContentsMounted', () => {
cy.get('ion-modal ion-content').should('exist'); cy.get('ion-modal ion-content').should('exist');
}); });
it('should has ion-delegate-host on mount', () => {
cy.visit('/keep-contents-mounted');
cy.get('ion-modal .ion-delegate-host').should('exist');
});
}) })
describe('popover', () => { describe('popover', () => {
it('should not mount component if false', () => { it('should not mount component if false', () => {