javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(ionSlideBox): use live nodeList to preserve ordering

Browse Source
This commit is contained in:
Andrew
2014-11-05 13:51:56 -07:00
parent debccaeaaa
commit 8b1bef3ea1
13 changed files with 237 additions and 348 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
js/angular/controller/slideController.js vendored
View File

@@ -6,34 +6,22 @@ IonicModule
function(scope, element, $q) {
var self = this;
scope.$on('$destroy', function() {
// Re-attach the element so it can be properly removed
attachSlide();
});
element.on(ionic.CSS.TRANSITIONEND, onTransitionEnd);
self.element = element;
self.onAdded = onAdded;
self.onRemoved = onRemoved;
self.node = element[0];
self.transform = transform;
self.state = '';
self.setState = setState;
self.setState('detached');
// ***
// Public Methods
// ***
function onAdded() {
// Set default state
self.setState('detached');
}
function onRemoved() {
self.setState('detached');
}
var isTransforming;
// percent is negative 0-1 for dragging left
// percent is positive 0-1 for dragging right
@@ -83,20 +71,10 @@ function(scope, element, $q) {
// ***
function attachSlide() {
// if (!self.element[0].parentNode) {
// self.parentElement.append(self.element);
// ionic.Utils.reconnectScope(scope);
// }
ionic.Utils.reconnectScope(scope);
}
function detachSlide() {
// Don't use self.element.remove(), that will destroy the element's data
// var parent = self.element[0].parentNode;
// if (parent) {
// parent.removeChild(self.element[0]);
// ionic.Utils.disconnectScope(scope);
// }
ionic.Utils.disconnectScope(scope);
}