From 89ba55d07b65e07923f4225f038e7e151885ee0b Mon Sep 17 00:00:00 2001 From: "Manu Mtz.-Almeida" Date: Wed, 29 Aug 2018 19:56:37 +0200 Subject: [PATCH] fix(overlay): overlay is not hidden --- core/src/components/datetime/datetime.tsx | 4 +--- core/src/utils/overlays.ts | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/core/src/components/datetime/datetime.tsx b/core/src/components/datetime/datetime.tsx index 7e74d4b113..2132f6eddc 100644 --- a/core/src/components/datetime/datetime.tsx +++ b/core/src/components/datetime/datetime.tsx @@ -232,9 +232,7 @@ export class Datetime { const pickerOptions = this.generatePickerOptions(); this.picker = await this.pickerCtrl.create(pickerOptions); await this.validate(); - if (this.picker) { - await this.picker.present(); - } + await this.picker.present(); } private emitStyle() { diff --git a/core/src/utils/overlays.ts b/core/src/utils/overlays.ts index fe85f93e93..da4bc0de90 100644 --- a/core/src/utils/overlays.ts +++ b/core/src/utils/overlays.ts @@ -9,7 +9,7 @@ export function createOverlay(element: T, opts: // convert the passed in overlay options into props // that get passed down into the new overlay Object.assign(element, opts); - element.classList.add('ion-page-hidden'); + element.classList.add('ion-page-invisible'); const overlayIndex = lastId++; element.overlayIndex = overlayIndex; if (!element.hasAttribute('id')) { @@ -137,7 +137,7 @@ async function overlayAnimation( } // Make overlay visible in case it's hidden - baseEl.classList.remove('ion-page-hidden'); + baseEl.classList.remove('ion-page-invisible'); const aniRoot = baseEl.shadowRoot || overlay.el; const animation = overlay.animation = await overlay.animationCtrl.create(animationBuilder, aniRoot, opts);