From 89861e0e6139de60204addc8b9ec6361859242aa Mon Sep 17 00:00:00 2001 From: Adam Bradley Date: Thu, 11 Feb 2016 22:12:02 -0600 Subject: [PATCH] fix(radio): radio w/ falsy value not checkable Closes #5348 --- ionic/components/radio/radio-group.ts | 2 +- ionic/components/radio/test/basic/index.ts | 7 +++++++ ionic/components/radio/test/basic/main.html | 14 ++++++++++++++ 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/ionic/components/radio/radio-group.ts b/ionic/components/radio/radio-group.ts index 5b570336d2..9965891135 100644 --- a/ionic/components/radio/radio-group.ts +++ b/ionic/components/radio/radio-group.ts @@ -103,7 +103,7 @@ export class RadioGroup { let oldVal = this.value; // set the radiogroup's value - this.value = val || ''; + this.value = isDefined(val) ? val : ''; this.updateValue(); diff --git a/ionic/components/radio/test/basic/index.ts b/ionic/components/radio/test/basic/index.ts index 87116f9695..17887cecd5 100644 --- a/ionic/components/radio/test/basic/index.ts +++ b/ionic/components/radio/test/basic/index.ts @@ -34,6 +34,13 @@ class E2EApp { this.relationship = 'enemies'; + + this.items = [ + { description: 'value undefined', value: undefined }, + { description: 'value false string', value: 'false' }, + { description: 'value false boolean', value: false }, + { description: 'value 0', value: 0 }, + ]; } setApple() { diff --git a/ionic/components/radio/test/basic/main.html b/ionic/components/radio/test/basic/main.html index 5000028ecb..2fbfc97e49 100644 --- a/ionic/components/radio/test/basic/main.html +++ b/ionic/components/radio/test/basic/main.html @@ -99,4 +99,18 @@ pet: {{pet}} + + + + {{ item.description }} + +​ + + + + +
+ someNumber: {{someNumber}} +
+