javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-21 04:53:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(nav): create opts object when undefined/null

Browse Source 
Closes #5737
This commit is contained in:
Adam Bradley
2016-03-06 14:07:26 -06:00
parent 5863e2c74f
commit 897501650a
14 changed files with 84 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ionic/components/segment/segment.ts
View File

@ -1,7 +1,7 @@
import {Directive, Component, ElementRef, Renderer, Optional, EventEmitter, Input, Output, HostListener, ContentChildren, QueryList} from 'angular2/core';
import {NgControl} from 'angular2/common';
import {isDefined} from '../../util/util';
import {isPresent} from '../../util/util';
/**
@ -82,7 +82,7 @@ export class SegmentButton {
* @private
*/
ngOnInit() {
if (!isDefined(this.value)) {
if (!isPresent(this.value)) {
console.warn('<ion-segment-button> requires a "value" attribute');
}
}
@ -174,7 +174,7 @@ export class Segment {
* Write a new value to the element.
*/
writeValue(value) {
this.value = isDefined(value) ? value : '';
this.value = isPresent(value) ? value : '';
if (this._buttons) {
let buttons = this._buttons.toArray();
for (let button of buttons) {
@ -195,7 +195,7 @@ export class Segment {
this.change.emit(selectedButton);
});
if (isDefined(this.value)) {
if (isPresent(this.value)) {
button.isActive = (button.value === this.value);
}
}