+
+
+ Pokémon Yellow
+ Super Metroid
+ Mega Man X
+ The Legend of Zelda
+ Halo
+
+
+
+ `);
- expect(await page.screenshot()).toMatchSnapshot(`list-inset-diff-${page.getSnapshotSettings()}.png`);
+ const listWrapper = page.locator('.wrapper');
+
+ expect(await listWrapper.screenshot()).toMatchSnapshot(`list-inset-diff-${page.getSnapshotSettings()}.png`);
});
});
});
diff --git a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Chrome-linux.png
index aea501b3c2..e96cb4d099 100644
Binary files a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Chrome-linux.png differ
diff --git a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Firefox-linux.png
index 835de87d4c..393901b4a3 100644
Binary files a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Firefox-linux.png differ
diff --git a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Safari-linux.png
index 57f5686cff..c3ebbee25c 100644
Binary files a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Safari-linux.png and b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Safari-linux.png differ
diff --git a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Chrome-linux.png
index e9cf3fda98..a9012713ac 100644
Binary files a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Chrome-linux.png differ
diff --git a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Firefox-linux.png b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Firefox-linux.png
index 80f8645f22..2fc724e293 100644
Binary files a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Firefox-linux.png and b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Firefox-linux.png differ
diff --git a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Safari-linux.png b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Safari-linux.png
index 734b76a6b4..016eb3a1d1 100644
Binary files a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Safari-linux.png and b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Safari-linux.png differ
diff --git a/core/src/components/modal/gestures/utils.ts b/core/src/components/modal/gestures/utils.ts
index 694227d630..54ebcba17a 100644
--- a/core/src/components/modal/gestures/utils.ts
+++ b/core/src/components/modal/gestures/utils.ts
@@ -1,6 +1,5 @@
-import { GESTURE } from '@utils/overlays';
-
import type { Animation } from '../../../interface';
+import { GESTURE } from '../../../utils/overlays';
export const handleCanDismiss = async (el: HTMLIonModalElement, animation: Animation) => {
/**
diff --git a/core/src/components/picker-column-internal/test/disabled/picker-column-internal.e2e.ts b/core/src/components/picker-column-internal/test/disabled/picker-column-internal.e2e.ts
index 879f3ff6e8..3362ac7d22 100644
--- a/core/src/components/picker-column-internal/test/disabled/picker-column-internal.e2e.ts
+++ b/core/src/components/picker-column-internal/test/disabled/picker-column-internal.e2e.ts
@@ -60,7 +60,7 @@ test.describe('picker-column-internal: disabled', () => {
`);
const disabledItem = page.locator('ion-picker-column-internal .picker-item.picker-item-disabled');
- expect(disabledItem).not.toBeEnabled();
+ await expect(disabledItem).not.toBeEnabled();
});
test('disabled picker item should not be considered active', async ({ page }) => {
await page.setContent(`
@@ -79,7 +79,7 @@ test.describe('picker-column-internal: disabled', () => {
`);
const disabledItem = page.locator('ion-picker-column-internal .picker-item[data-value="b"]');
- expect(disabledItem).not.toHaveClass(/picker-item-active/);
+ await expect(disabledItem).not.toHaveClass(/picker-item-active/);
});
test('setting the value to a disabled item should not cause that item to be active', async ({ page }) => {
await page.setContent(`
@@ -103,8 +103,8 @@ test.describe('picker-column-internal: disabled', () => {
await page.waitForChanges();
const disabledItem = page.locator('ion-picker-column-internal .picker-item[data-value="b"]');
- expect(disabledItem).toHaveClass(/picker-item-disabled/);
- expect(disabledItem).not.toHaveClass(/picker-item-active/);
+ await expect(disabledItem).toHaveClass(/picker-item-disabled/);
+ await expect(disabledItem).not.toHaveClass(/picker-item-active/);
});
test('defaulting the value to a disabled item should not cause that item to be active', async ({ page }) => {
await page.setContent(`
@@ -124,7 +124,7 @@ test.describe('picker-column-internal: disabled', () => {
`);
const disabledItem = page.locator('ion-picker-column-internal .picker-item[data-value="b"]');
- expect(disabledItem).toHaveClass(/picker-item-disabled/);
- expect(disabledItem).not.toHaveClass(/picker-item-active/);
+ await expect(disabledItem).toHaveClass(/picker-item-disabled/);
+ await expect(disabledItem).not.toHaveClass(/picker-item-active/);
});
});
diff --git a/core/src/components/picker-internal/test/basic/picker-internal.e2e.ts b/core/src/components/picker-internal/test/basic/picker-internal.e2e.ts
index 1789273377..d103413200 100644
--- a/core/src/components/picker-internal/test/basic/picker-internal.e2e.ts
+++ b/core/src/components/picker-internal/test/basic/picker-internal.e2e.ts
@@ -47,13 +47,13 @@ test.describe('picker-internal', () => {
// Focus first column
await page.keyboard.press('Tab');
- expect(firstColumn).toBeFocused();
+ await expect(firstColumn).toBeFocused();
await page.waitForChanges();
// Focus second column
await page.keyboard.press('Tab');
- expect(secondColumn).toBeFocused();
+ await expect(secondColumn).toBeFocused();
});
test('tabbing should correctly move focus back', async ({ page }) => {
@@ -61,13 +61,13 @@ test.describe('picker-internal', () => {
const secondColumn = page.locator('ion-picker-column-internal#second');
await secondColumn.focus();
- expect(secondColumn).toBeFocused();
+ await expect(secondColumn).toBeFocused();
await page.waitForChanges();
// Focus first column
await page.keyboard.press('Shift+Tab');
- expect(firstColumn).toBeFocused();
+ await expect(firstColumn).toBeFocused();
});
});
diff --git a/core/src/components/radio-group/test/search/radio-group.e2e.ts b/core/src/components/radio-group/test/search/radio-group.e2e.ts
index e5c2be6c9f..62ee657722 100644
--- a/core/src/components/radio-group/test/search/radio-group.e2e.ts
+++ b/core/src/components/radio-group/test/search/radio-group.e2e.ts
@@ -24,7 +24,7 @@ test.describe('radio-group', () => {
expect(radio).toBeHidden();
// ensure radio group has the same value
- expect(radioGroup).toHaveJSProperty('value', 'two');
+ await expect(radioGroup).toHaveJSProperty('value', 'two');
// clear the search so the radio appears
await page.fill('ion-searchbar input', '');
diff --git a/core/src/components/range/test/basic/range.e2e.ts b/core/src/components/range/test/basic/range.e2e.ts
index 3862f2f16f..b69bbda61a 100644
--- a/core/src/components/range/test/basic/range.e2e.ts
+++ b/core/src/components/range/test/basic/range.e2e.ts
@@ -12,6 +12,7 @@ test.describe('range: basic', () => {
/**
* The mouse events are flaky on CI
+ * TODO FW-2873
*/
test.fixme('should emit start/end events', async ({ page }, testInfo) => {
await page.setContent(`