diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 10982df08c..fe8eb929f6 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -13,3 +13,60 @@ # Global owners * @ionic-team/framework + +# Frameworks + +## Angular + +/angular/ @sean-perkins +/packages/angular-server @sean-perkins +/angular/test + +## React + +/packages/react/ @amandaejohnston +/packages/react-router @amandaejohnston +/packages/react/test-app/ +/packages/react-router/test-app/ + +## Vue + +/packages/vue/ @liamdebeasi +/packages/vue-router/ @liamdebeasi +/packages/vue/test/ +/packages/vue-router/__tests__ + +# Components + +/core/src/components/accordion/ @liamdebeasi +/core/src/components/accordion-group/ @liamdebeasi + +/core/src/components/datetime/ @liamdebeasi @amandaejohnston @sean-perkins +/core/src/components/datetime-button/ @liamdebeasi + +/core/src/components/menu/ @amandaejohnston +/core/src/components/menu-toggle/ @amandaejohnston + +/core/src/components/nav/ @sean-perkins +/core/src/components/nav-link/ @sean-perkins + +/core/src/components/picker-internal/ @liamdebeasi +/core/src/components/picker-column-internal/ @liamdebeasi + +/core/src/components/refresher/ @liamdebeasi +/core/src/components/refresher-content/ @liamdebeasi + +# Codeowner should own the source, but everyone should own the tests +/core/src/components/**/test/ @ionic-team/framework + +# Utilities + +/core/src/utils/animation/ @liamdebeasi +/core/src/utils/content/ @sean-perkins +/core/src/utils/gesture/ @liamdebeasi +/core/src/utils/input-shims/ @liamdebeasi +/core/src/utils/keyboard/ @liamdebeasi +/core/src/utils/logging/ @amandaejohnston +/core/src/utils/sanitization/ @liamdebeasi +/core/src/utils/tap-click/ @liamdebeasi +/core/src/utils/transition/ @liamdebeasi diff --git a/.github/workflows/stencil-eval.yml b/.github/workflows/stencil-eval.yml index eda82c31f0..ff9bf587e8 100644 --- a/.github/workflows/stencil-eval.yml +++ b/.github/workflows/stencil-eval.yml @@ -47,13 +47,6 @@ jobs: - uses: actions/checkout@v3 - uses: ./.github/workflows/actions/test-core-spec - test-core-e2e: - needs: [build-core] - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 - - uses: ./.github/workflows/actions/test-core-e2e - test-core-screenshot: strategy: # This ensures that all screenshot shard diff --git a/core/playwright.config.ts b/core/playwright.config.ts index 6336c28a48..91d1885b92 100644 --- a/core/playwright.config.ts +++ b/core/playwright.config.ts @@ -85,7 +85,10 @@ const config: PlaywrightTestConfig = { }, /* Fail the build on CI if you accidentally left test.only in the source code. */ forbidOnly: !!process.env.CI, - retries: process.env.CI ? 2 : 0, + /* Fail fast on CI */ + maxFailures: process.env.CI ? 1 : 0, + /* Flaky test should be either addressed or disabled until we can address them */ + retries: 0, /* Opt out of parallel tests on CI. */ workers: process.env.CI ? 1 : undefined, /* Reporter to use. See https://playwright.dev/docs/test-reporters */ diff --git a/core/src/components/accordion/test/accordion.e2e.ts b/core/src/components/accordion/test/accordion.e2e.ts index ab0a48dc28..92f6017cd6 100644 --- a/core/src/components/accordion/test/accordion.e2e.ts +++ b/core/src/components/accordion/test/accordion.e2e.ts @@ -19,7 +19,7 @@ test.describe('accordion: states', () => { const accordionGroup = page.locator('ion-accordion-group'); const accordion = page.locator('ion-accordion'); - expect(accordion).toHaveJSProperty('readonly', false); + await expect(accordion).toHaveJSProperty('readonly', false); await accordionGroup.evaluate((el: HTMLIonAccordionGroupElement) => { el.readonly = true; @@ -27,7 +27,7 @@ test.describe('accordion: states', () => { await page.waitForChanges(); - expect(accordion).toHaveJSProperty('readonly', true); + await expect(accordion).toHaveJSProperty('readonly', true); }); test('should properly set disabled on child accordions', async ({ page }) => { @@ -43,7 +43,7 @@ test.describe('accordion: states', () => { const accordionGroup = page.locator('ion-accordion-group'); const accordion = page.locator('ion-accordion'); - expect(accordion).toHaveJSProperty('disabled', false); + await expect(accordion).toHaveJSProperty('disabled', false); await accordionGroup.evaluate((el: HTMLIonAccordionGroupElement) => { el.disabled = true; @@ -51,6 +51,6 @@ test.describe('accordion: states', () => { await page.waitForChanges(); - expect(accordion).toHaveJSProperty('disabled', true); + await expect(accordion).toHaveJSProperty('disabled', true); }); }); diff --git a/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts b/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts index 449a64cd8a..4c3f0a2b61 100644 --- a/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts +++ b/core/src/components/action-sheet/test/basic/action-sheet.e2e.ts @@ -41,7 +41,7 @@ test.describe('action sheet: basic', () => { await actionSheetFixture.open('#basic'); const actionSheet = page.locator('ion-action-sheet'); - expect(actionSheet).toHaveAttribute('data-testid', 'basic-action-sheet'); + await expect(actionSheet).toHaveAttribute('data-testid', 'basic-action-sheet'); }); }); test.describe('action sheet: variants', () => { @@ -78,7 +78,7 @@ test.describe('action sheet: basic', () => { await actionSheetFixture.open('#customBackdrop'); const backdrop = page.locator('ion-action-sheet ion-backdrop'); - expect(backdrop).toHaveCSS('opacity', '1'); + await expect(backdrop).toHaveCSS('opacity', '1'); }); test('should open alert from action sheet', async ({ page, skip }) => { skip.rtl(); @@ -96,7 +96,7 @@ test.describe('action sheet: basic', () => { const actionSheet = page.locator('ion-action-sheet'); await actionSheet.locator('ion-backdrop').click(); - expect(actionSheet).toBeVisible(); + await expect(actionSheet).toBeVisible(); }); }); test.describe('action sheet: focus trap', () => { @@ -133,14 +133,14 @@ class ActionSheetFixture { await this.page.locator(selector).click(); await ionActionSheetDidPresent.next(); this.actionSheet = this.page.locator('ion-action-sheet'); - expect(this.actionSheet).toBeVisible(); + await expect(this.actionSheet).toBeVisible(); } async dismiss() { const ionActionSheetDidDismiss = await this.page.spyOnEvent('ionActionSheetDidDismiss'); await this.actionSheet.evaluate((el: HTMLIonActionSheetElement) => el.dismiss()); await ionActionSheetDidDismiss.next(); - expect(this.actionSheet).not.toBeVisible(); + await expect(this.actionSheet).not.toBeVisible(); } async screenshot(modifier: string) { diff --git a/core/src/components/alert/test/basic/alert.e2e.ts b/core/src/components/alert/test/basic/alert.e2e.ts index 9c3e641e67..c62e9c2e7c 100644 --- a/core/src/components/alert/test/basic/alert.e2e.ts +++ b/core/src/components/alert/test/basic/alert.e2e.ts @@ -51,7 +51,7 @@ test.describe('alert: basic', () => { await page.goto(`/src/components/alert/test/basic`); const alert = await openAlert(page, 'basic'); - expect(alert).toHaveAttribute('data-testid', 'basic-alert'); + await expect(alert).toHaveAttribute('data-testid', 'basic-alert'); }); test('should dismiss when async handler resolves', async ({ page, skip }) => { diff --git a/core/src/components/datetime-button/test/basic/datetime-button.e2e.ts b/core/src/components/datetime-button/test/basic/datetime-button.e2e.ts index cca426a6fa..08cf95542d 100644 --- a/core/src/components/datetime-button/test/basic/datetime-button.e2e.ts +++ b/core/src/components/datetime-button/test/basic/datetime-button.e2e.ts @@ -14,21 +14,21 @@ test.describe('datetime-button: switching to correct view', () => { }); test('should switch to a date-only view when the date button is clicked', async ({ page }) => { const datetime = page.locator('ion-datetime'); - expect(datetime).toHaveJSProperty('presentation', 'date-time'); + await expect(datetime).toHaveJSProperty('presentation', 'date-time'); await page.locator('#date-button').click(); await page.waitForChanges(); - expect(datetime).toHaveJSProperty('presentation', 'date'); + await expect(datetime).toHaveJSProperty('presentation', 'date'); }); test('should switch to a time-only view when the time button is clicked', async ({ page }) => { const datetime = page.locator('ion-datetime'); - expect(datetime).toHaveJSProperty('presentation', 'date-time'); + await expect(datetime).toHaveJSProperty('presentation', 'date-time'); await page.locator('#time-button').click(); await page.waitForChanges(); - expect(datetime).toHaveJSProperty('presentation', 'time'); + await expect(datetime).toHaveJSProperty('presentation', 'time'); }); }); diff --git a/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts b/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts index e52acb142a..6adef5bcfb 100644 --- a/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts +++ b/core/src/components/datetime-button/test/overlays/datetime-button.e2e.ts @@ -68,38 +68,38 @@ test.describe('datetime-button: popover', () => { await ionPopoverDidPresent.next(); - expect(datetime).toBeVisible(); + await expect(datetime).toBeVisible(); }); test('should open the time popover', async ({ page }) => { await page.locator('#time-button').click(); await ionPopoverDidPresent.next(); - expect(datetime).toBeVisible(); + await expect(datetime).toBeVisible(); }); test('should open the date popover then the time popover', async ({ page }) => { await page.locator('#date-button').click(); await ionPopoverDidPresent.next(); - expect(datetime).toBeVisible(); + await expect(datetime).toBeVisible(); await popover.evaluate((el: HTMLIonPopoverElement) => el.dismiss()); await ionPopoverDidDismiss.next(); await page.locator('#time-button').click(); await ionPopoverDidPresent.next(); - expect(datetime).toBeVisible(); + await expect(datetime).toBeVisible(); }); test('should open the time popover then the date popover', async ({ page }) => { await page.locator('#time-button').click(); await ionPopoverDidPresent.next(); - expect(datetime).toBeVisible(); + await expect(datetime).toBeVisible(); await popover.evaluate((el: HTMLIonPopoverElement) => el.dismiss()); await ionPopoverDidDismiss.next(); await page.locator('#date-button').click(); await ionPopoverDidPresent.next(); - expect(datetime).toBeVisible(); + await expect(datetime).toBeVisible(); }); }); @@ -130,37 +130,37 @@ test.describe('datetime-button: modal', () => { await ionModalDidPresent.next(); - expect(datetime).toBeVisible(); + await expect(datetime).toBeVisible(); }); test('should open the time modal', async ({ page }) => { await page.locator('#time-button').click(); await ionModalDidPresent.next(); - expect(datetime).toBeVisible(); + await expect(datetime).toBeVisible(); }); test('should open the date modal then the time modal', async ({ page }) => { await page.locator('#date-button').click(); await ionModalDidPresent.next(); - expect(datetime).toBeVisible(); + await expect(datetime).toBeVisible(); await modal.evaluate((el: HTMLIonModalElement) => el.dismiss()); await ionModalDidDismiss.next(); await page.locator('#time-button').click(); await ionModalDidPresent.next(); - expect(datetime).toBeVisible(); + await expect(datetime).toBeVisible(); }); test('should open the time modal then the date modal', async ({ page }) => { await page.locator('#time-button').click(); await ionModalDidPresent.next(); - expect(datetime).toBeVisible(); + await expect(datetime).toBeVisible(); await modal.evaluate((el: HTMLIonModalElement) => el.dismiss()); await ionModalDidDismiss.next(); await page.locator('#date-button').click(); await ionModalDidPresent.next(); - expect(datetime).toBeVisible(); + await expect(datetime).toBeVisible(); }); }); diff --git a/core/src/components/datetime/test/basic/datetime.e2e.ts b/core/src/components/datetime/test/basic/datetime.e2e.ts index 4860082063..73aaeb0314 100644 --- a/core/src/components/datetime/test/basic/datetime.e2e.ts +++ b/core/src/components/datetime/test/basic/datetime.e2e.ts @@ -300,10 +300,13 @@ test.describe('datetime: visibility', () => { await datetime.evaluate((el: HTMLIonDatetimeElement) => el.style.setProperty('display', 'none')); await expect(datetime).toBeHidden(); + await expect(datetime).not.toHaveClass(/datetime-ready/); await datetime.evaluate((el: HTMLIonDatetimeElement) => el.style.removeProperty('display')); await expect(datetime).toBeVisible(); + await page.waitForSelector('.datetime-ready'); + // month/year interface should be reset await expect(monthYearInterface).toBeHidden(); }); diff --git a/core/src/components/datetime/test/prefer-wheel/datetime.e2e.ts b/core/src/components/datetime/test/prefer-wheel/datetime.e2e.ts index 09e97a369b..e6ca56c6c8 100644 --- a/core/src/components/datetime/test/prefer-wheel/datetime.e2e.ts +++ b/core/src/components/datetime/test/prefer-wheel/datetime.e2e.ts @@ -214,8 +214,8 @@ test.describe('datetime: prefer wheel', () => { const monthValues = page.locator('.month-column .picker-item:not(.picker-item-empty)'); const dayValues = page.locator('.day-column .picker-item:not(.picker-item-empty)'); - expect(monthValues).toHaveText(['1月', '2月', '3月']); - expect(dayValues).toHaveText(['1日', '2日', '3日']); + await expect(monthValues).toHaveText(['1月', '2月', '3月']); + await expect(dayValues).toHaveText(['1日', '2日', '3日']); }); test('should render the columns according to locale - en-US', async ({ page }) => { await page.setContent(` @@ -334,7 +334,7 @@ test.describe('datetime: prefer wheel', () => { const dateValues = page.locator('.date-column .picker-item:not(.picker-item-empty)'); - expect(dateValues).toHaveText(['2月1日(火)', '2月2日(水)', '2月3日(木)']); + await expect(dateValues).toHaveText(['2月1日(火)', '2月2日(水)', '2月3日(木)']); }); test('should respect min and max bounds even across years', async ({ page }) => { await page.setContent(` @@ -495,7 +495,7 @@ test.describe('datetime: prefer wheel', () => { const dateValues = page.locator('.date-column .picker-item:not(.picker-item-empty)'); - expect(dateValues).toHaveText(['2月1日(火)', '2月2日(水)', '2月3日(木)']); + await expect(dateValues).toHaveText(['2月1日(火)', '2月2日(水)', '2月3日(木)']); }); test('should respect min and max bounds even across years', async ({ page }) => { await page.setContent(` diff --git a/core/src/components/datetime/test/presentation/datetime.e2e.ts b/core/src/components/datetime/test/presentation/datetime.e2e.ts index e23acbf25f..5fcbeacef8 100644 --- a/core/src/components/datetime/test/presentation/datetime.e2e.ts +++ b/core/src/components/datetime/test/presentation/datetime.e2e.ts @@ -159,9 +159,10 @@ class TimePickerFixture { } async goto() { - await this.page.goto(`/src/components/datetime/test/presentation`); - await this.page.locator('select').selectOption('time'); - await this.page.waitForSelector('.datetime-presentation-time'); + await this.page.setContent(` + + `); + await this.page.waitForSelector('.datetime-ready'); this.timePicker = this.page.locator('ion-datetime'); } diff --git a/core/src/components/fab/test/basic/fab.e2e.ts b/core/src/components/fab/test/basic/fab.e2e.ts index eebd562efe..bc66101676 100644 --- a/core/src/components/fab/test/basic/fab.e2e.ts +++ b/core/src/components/fab/test/basic/fab.e2e.ts @@ -47,28 +47,28 @@ test.describe('fab: basic (functionality checks)', () => { const fab = page.locator('#fab1'); const fabList = fab.locator('ion-fab-list'); - expect(fabList).not.toHaveClass(/fab-list-active/); + await expect(fabList).not.toHaveClass(/fab-list-active/); // open fab await fab.click(); await page.waitForChanges(); - expect(fabList).toHaveClass(/fab-list-active/); + await expect(fabList).toHaveClass(/fab-list-active/); // close fab await fab.click(); await page.waitForChanges(); - expect(fabList).not.toHaveClass(/fab-list-active/); + await expect(fabList).not.toHaveClass(/fab-list-active/); }); test('should not open when disabled', async ({ page }) => { const fab = page.locator('#fab2'); const fabList = fab.locator('ion-fab-list'); - expect(fabList).not.toHaveClass(/fab-list-active/); + await expect(fabList).not.toHaveClass(/fab-list-active/); // attempt to open fab await fab.click(); await page.waitForChanges(); - expect(fabList).not.toHaveClass(/fab-list-active/); + await expect(fabList).not.toHaveClass(/fab-list-active/); }); }); diff --git a/core/src/components/item-sliding/test/basic/item-sliding.e2e.ts b/core/src/components/item-sliding/test/basic/item-sliding.e2e.ts index b6e124c04d..a93f199b52 100644 --- a/core/src/components/item-sliding/test/basic/item-sliding.e2e.ts +++ b/core/src/components/item-sliding/test/basic/item-sliding.e2e.ts @@ -40,7 +40,8 @@ test.describe('item-sliding: basic', () => { expect(await item.screenshot()).toMatchSnapshot(`item-sliding-gesture-${page.getSnapshotSettings()}.png`); }); - test('should not scroll when the item-sliding is swiped', async ({ page, skip }) => { + // TODO FW-3006 + test.skip('should not scroll when the item-sliding is swiped', async ({ page, skip }) => { skip.browser('webkit', 'mouse.wheel is not available in WebKit'); skip.rtl(); diff --git a/core/src/components/item-sliding/test/scroll-target/item-sliding.e2e.ts b/core/src/components/item-sliding/test/scroll-target/item-sliding.e2e.ts index 9f8f1d7803..e8e0a20d7d 100644 --- a/core/src/components/item-sliding/test/scroll-target/item-sliding.e2e.ts +++ b/core/src/components/item-sliding/test/scroll-target/item-sliding.e2e.ts @@ -2,7 +2,8 @@ import { expect } from '@playwright/test'; import { test } from '@utils/test/playwright'; test.describe('item-sliding: scroll-target', () => { - test('should not scroll when the item-sliding is swiped in custom scroll target', async ({ page, skip }) => { + // TODO FW-3006 + test.skip('should not scroll when the item-sliding is swiped in custom scroll target', async ({ page, skip }) => { skip.browser('webkit', 'mouse.wheel is not available in WebKit'); skip.rtl(); diff --git a/core/src/components/list/test/inset/list.e2e.ts b/core/src/components/list/test/inset/list.e2e.ts index c85f80d5f6..69ec0d9e91 100644 --- a/core/src/components/list/test/inset/list.e2e.ts +++ b/core/src/components/list/test/inset/list.e2e.ts @@ -2,14 +2,25 @@ import { expect } from '@playwright/test'; import { test } from '@utils/test/playwright'; test.describe('list: inset', () => { - test.beforeEach(async ({ page }) => { - await page.goto('/src/components/list/test/inset'); - }); - test.describe('list: visual regression tests', () => { + test.describe('list: rendering', () => { test('should not have visual regressions', async ({ page }) => { - await page.setIonViewport(); + await page.setContent(` + +
+ + Pokémon Yellow + Super Metroid + Mega Man X + The Legend of Zelda + Halo + +
+
+ `); - expect(await page.screenshot()).toMatchSnapshot(`list-inset-diff-${page.getSnapshotSettings()}.png`); + const listWrapper = page.locator('.wrapper'); + + expect(await listWrapper.screenshot()).toMatchSnapshot(`list-inset-diff-${page.getSnapshotSettings()}.png`); }); }); }); diff --git a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Chrome-linux.png index aea501b3c2..e96cb4d099 100644 Binary files a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Firefox-linux.png index 835de87d4c..393901b4a3 100644 Binary files a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Safari-linux.png index 57f5686cff..c3ebbee25c 100644 Binary files a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Safari-linux.png and b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Chrome-linux.png index e9cf3fda98..a9012713ac 100644 Binary files a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Firefox-linux.png b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Firefox-linux.png index 80f8645f22..2fc724e293 100644 Binary files a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Firefox-linux.png and b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Safari-linux.png b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Safari-linux.png index 734b76a6b4..016eb3a1d1 100644 Binary files a/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Safari-linux.png and b/core/src/components/list/test/inset/list.e2e.ts-snapshots/list-inset-diff-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/modal/gestures/utils.ts b/core/src/components/modal/gestures/utils.ts index 694227d630..54ebcba17a 100644 --- a/core/src/components/modal/gestures/utils.ts +++ b/core/src/components/modal/gestures/utils.ts @@ -1,6 +1,5 @@ -import { GESTURE } from '@utils/overlays'; - import type { Animation } from '../../../interface'; +import { GESTURE } from '../../../utils/overlays'; export const handleCanDismiss = async (el: HTMLIonModalElement, animation: Animation) => { /** diff --git a/core/src/components/picker-column-internal/test/disabled/picker-column-internal.e2e.ts b/core/src/components/picker-column-internal/test/disabled/picker-column-internal.e2e.ts index 879f3ff6e8..3362ac7d22 100644 --- a/core/src/components/picker-column-internal/test/disabled/picker-column-internal.e2e.ts +++ b/core/src/components/picker-column-internal/test/disabled/picker-column-internal.e2e.ts @@ -60,7 +60,7 @@ test.describe('picker-column-internal: disabled', () => { `); const disabledItem = page.locator('ion-picker-column-internal .picker-item.picker-item-disabled'); - expect(disabledItem).not.toBeEnabled(); + await expect(disabledItem).not.toBeEnabled(); }); test('disabled picker item should not be considered active', async ({ page }) => { await page.setContent(` @@ -79,7 +79,7 @@ test.describe('picker-column-internal: disabled', () => { `); const disabledItem = page.locator('ion-picker-column-internal .picker-item[data-value="b"]'); - expect(disabledItem).not.toHaveClass(/picker-item-active/); + await expect(disabledItem).not.toHaveClass(/picker-item-active/); }); test('setting the value to a disabled item should not cause that item to be active', async ({ page }) => { await page.setContent(` @@ -103,8 +103,8 @@ test.describe('picker-column-internal: disabled', () => { await page.waitForChanges(); const disabledItem = page.locator('ion-picker-column-internal .picker-item[data-value="b"]'); - expect(disabledItem).toHaveClass(/picker-item-disabled/); - expect(disabledItem).not.toHaveClass(/picker-item-active/); + await expect(disabledItem).toHaveClass(/picker-item-disabled/); + await expect(disabledItem).not.toHaveClass(/picker-item-active/); }); test('defaulting the value to a disabled item should not cause that item to be active', async ({ page }) => { await page.setContent(` @@ -124,7 +124,7 @@ test.describe('picker-column-internal: disabled', () => { `); const disabledItem = page.locator('ion-picker-column-internal .picker-item[data-value="b"]'); - expect(disabledItem).toHaveClass(/picker-item-disabled/); - expect(disabledItem).not.toHaveClass(/picker-item-active/); + await expect(disabledItem).toHaveClass(/picker-item-disabled/); + await expect(disabledItem).not.toHaveClass(/picker-item-active/); }); }); diff --git a/core/src/components/picker-internal/test/basic/picker-internal.e2e.ts b/core/src/components/picker-internal/test/basic/picker-internal.e2e.ts index 1789273377..d103413200 100644 --- a/core/src/components/picker-internal/test/basic/picker-internal.e2e.ts +++ b/core/src/components/picker-internal/test/basic/picker-internal.e2e.ts @@ -47,13 +47,13 @@ test.describe('picker-internal', () => { // Focus first column await page.keyboard.press('Tab'); - expect(firstColumn).toBeFocused(); + await expect(firstColumn).toBeFocused(); await page.waitForChanges(); // Focus second column await page.keyboard.press('Tab'); - expect(secondColumn).toBeFocused(); + await expect(secondColumn).toBeFocused(); }); test('tabbing should correctly move focus back', async ({ page }) => { @@ -61,13 +61,13 @@ test.describe('picker-internal', () => { const secondColumn = page.locator('ion-picker-column-internal#second'); await secondColumn.focus(); - expect(secondColumn).toBeFocused(); + await expect(secondColumn).toBeFocused(); await page.waitForChanges(); // Focus first column await page.keyboard.press('Shift+Tab'); - expect(firstColumn).toBeFocused(); + await expect(firstColumn).toBeFocused(); }); }); diff --git a/core/src/components/radio-group/test/search/radio-group.e2e.ts b/core/src/components/radio-group/test/search/radio-group.e2e.ts index e5c2be6c9f..62ee657722 100644 --- a/core/src/components/radio-group/test/search/radio-group.e2e.ts +++ b/core/src/components/radio-group/test/search/radio-group.e2e.ts @@ -24,7 +24,7 @@ test.describe('radio-group', () => { expect(radio).toBeHidden(); // ensure radio group has the same value - expect(radioGroup).toHaveJSProperty('value', 'two'); + await expect(radioGroup).toHaveJSProperty('value', 'two'); // clear the search so the radio appears await page.fill('ion-searchbar input', ''); diff --git a/core/src/components/range/test/basic/range.e2e.ts b/core/src/components/range/test/basic/range.e2e.ts index 3862f2f16f..b69bbda61a 100644 --- a/core/src/components/range/test/basic/range.e2e.ts +++ b/core/src/components/range/test/basic/range.e2e.ts @@ -12,6 +12,7 @@ test.describe('range: basic', () => { /** * The mouse events are flaky on CI + * TODO FW-2873 */ test.fixme('should emit start/end events', async ({ page }, testInfo) => { await page.setContent(``); @@ -57,7 +58,8 @@ test.describe('range: basic', () => { expect(rangeEnd).toHaveReceivedEventDetail({ value: 21 }); }); - test('should not scroll when the knob is swiped', async ({ page, skip }) => { + // TODO FW-2873 + test.skip('should not scroll when the knob is swiped', async ({ page, skip }) => { skip.browser('webkit', 'mouse.wheel is not available in WebKit'); skip.rtl(); diff --git a/core/src/components/range/test/scroll-target/range.e2e.ts b/core/src/components/range/test/scroll-target/range.e2e.ts index ff7723f1db..7050a7b770 100644 --- a/core/src/components/range/test/scroll-target/range.e2e.ts +++ b/core/src/components/range/test/scroll-target/range.e2e.ts @@ -1,7 +1,8 @@ import { expect } from '@playwright/test'; import { test } from '@utils/test/playwright'; -test.describe('range: scroll-target', () => { +// TODO FW-2873 +test.describe.skip('range: scroll-target', () => { test('should not scroll when the knob is swiped in custom scroll target', async ({ page, skip }) => { skip.browser('webkit', 'mouse.wheel is not available in WebKit'); skip.rtl(); diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts b/core/src/components/searchbar/test/basic/searchbar.e2e.ts index 0d8ec153d0..1a5025665e 100644 --- a/core/src/components/searchbar/test/basic/searchbar.e2e.ts +++ b/core/src/components/searchbar/test/basic/searchbar.e2e.ts @@ -1,28 +1,11 @@ import { expect } from '@playwright/test'; import { test } from '@utils/test/playwright'; -test.describe('searchbar: basic', () => { +test.describe('searchbar: cancel button', () => { test.beforeEach(async ({ page }) => { await page.goto(`/src/components/searchbar/test/basic`); }); - test('should not have visual regressions', async ({ page }) => { - await page.setIonViewport(); - /** - * The searchbar test template is rendering an ion-searchbar - * that is animated. This requires the searchbar to render, - * before the cancel button can be positioned correctly. - * - * We wait for changes to ensure the searchbar has rendered - * correctly before capturing the screenshot. - */ - await page.waitForChanges(); - - expect(await page.screenshot({ animations: 'disabled' })).toMatchSnapshot( - `searchbar-diff-${page.getSnapshotSettings()}.png` - ); - }); - test('should show cancel button on focus if show-cancel-button=focus', async ({ page }) => { const searchbar = page.locator('#basic'); const cancelButton = searchbar.locator('.searchbar-cancel-button'); @@ -89,3 +72,76 @@ test.describe('searchbar: clear button', () => { await expect(nativeInput).toBeFocused(); }); }); + +test.describe('searchbar: rendering', () => { + test('should render searchbar', async ({ page }) => { + await page.setContent(` + + `); + + const searchbar = page.locator('ion-searchbar'); + + expect(await searchbar.screenshot()).toMatchSnapshot(`searchbar-${page.getSnapshotSettings()}.png`); + }); + + test('should render cancel and clear buttons', async ({ page }) => { + await page.setContent(` + + `); + + const searchbar = page.locator('ion-searchbar'); + + expect(await searchbar.screenshot()).toMatchSnapshot(`searchbar-buttons-${page.getSnapshotSettings()}.png`); + }); + + test('should render searchbar with color', async ({ page, skip }) => { + skip.rtl(); + + await page.setContent(` + + `); + + const searchbar = page.locator('ion-searchbar'); + + expect(await searchbar.screenshot()).toMatchSnapshot(`searchbar-color-${page.getSnapshotSettings()}.png`); + }); + + test('should render disabled searchbar', async ({ page, skip }) => { + skip.rtl(); + + await page.setContent(` + + `); + + const searchbar = page.locator('ion-searchbar'); + + expect(await searchbar.screenshot()).toMatchSnapshot(`searchbar-disabled-${page.getSnapshotSettings()}.png`); + }); + + test('should render custom search icon', async ({ page, skip }) => { + skip.rtl(); + + await page.setContent(` + + `); + + const icon = page.locator('ion-searchbar ion-icon.searchbar-search-icon'); + + expect(await icon.screenshot()).toMatchSnapshot(`searchbar-search-icon-${page.getSnapshotSettings()}.png`); + }); +}); + +test.describe('searchbar: placeholder', () => { + test.beforeEach(({ skip }) => { + skip.rtl(); + skip.mode('ios'); + }); + test('should set placeholder', async ({ page }) => { + await page.setContent(` + + `); + + const nativeInput = page.locator('ion-searchbar input'); + await expect(nativeInput).toHaveAttribute('placeholder', 'My Placeholder'); + }); +}); diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-ios-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..bfd9193947 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-ios-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..b5b6dd8161 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-ios-ltr-Mobile-Safari-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-ios-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..a5da3fb0f6 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-ios-rtl-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..7861fe3c58 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-ios-rtl-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..4b3a37c5cf Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-ios-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-ios-rtl-Mobile-Safari-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-ios-rtl-Mobile-Safari-linux.png new file mode 100644 index 0000000000..fd249ee2aa Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-md-ltr-Mobile-Chrome-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-md-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..f3aec3d2df Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-md-ltr-Mobile-Firefox-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-md-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..01e29c0963 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-md-ltr-Mobile-Safari-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-md-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..1b479cb871 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-md-rtl-Mobile-Chrome-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-md-rtl-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..43a21f8d58 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-md-rtl-Mobile-Firefox-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-md-rtl-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..262da58c0c Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-md-rtl-Mobile-Safari-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-md-rtl-Mobile-Safari-linux.png new file mode 100644 index 0000000000..afb09e5591 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-buttons-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-color-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-color-ios-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..0c48f35bba Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-color-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-color-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-color-ios-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..bdea31313b Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-color-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-color-ios-ltr-Mobile-Safari-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-color-ios-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..9ace3fd550 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-color-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-color-md-ltr-Mobile-Chrome-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-color-md-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..3c75275a4a Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-color-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-color-md-ltr-Mobile-Firefox-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-color-md-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..a901e3dd54 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-color-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-color-md-ltr-Mobile-Safari-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-color-md-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..05aba9ad80 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-color-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-ios-ltr-Mobile-Chrome-linux.png deleted file mode 100644 index c9d2598154..0000000000 Binary files a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-ios-ltr-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-ios-ltr-Mobile-Firefox-linux.png deleted file mode 100644 index 6163ad95d5..0000000000 Binary files a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-ios-ltr-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-ios-ltr-Mobile-Safari-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-ios-ltr-Mobile-Safari-linux.png deleted file mode 100644 index d070e8b192..0000000000 Binary files a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-ios-ltr-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-ios-rtl-Mobile-Chrome-linux.png deleted file mode 100644 index a39b625077..0000000000 Binary files a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-ios-rtl-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-ios-rtl-Mobile-Firefox-linux.png deleted file mode 100644 index f94dca8997..0000000000 Binary files a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-ios-rtl-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-ios-rtl-Mobile-Safari-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-ios-rtl-Mobile-Safari-linux.png deleted file mode 100644 index 42f344570c..0000000000 Binary files a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-ios-rtl-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-md-ltr-Mobile-Chrome-linux.png deleted file mode 100644 index 1e7cae886b..0000000000 Binary files a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-md-ltr-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-md-ltr-Mobile-Firefox-linux.png deleted file mode 100644 index 08a8f6ef72..0000000000 Binary files a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-md-ltr-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-md-ltr-Mobile-Safari-linux.png deleted file mode 100644 index 593b3adeef..0000000000 Binary files a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-md-ltr-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-md-rtl-Mobile-Chrome-linux.png deleted file mode 100644 index df989fa665..0000000000 Binary files a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-md-rtl-Mobile-Chrome-linux.png and /dev/null differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-md-rtl-Mobile-Firefox-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-md-rtl-Mobile-Firefox-linux.png deleted file mode 100644 index db2f8fb992..0000000000 Binary files a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-md-rtl-Mobile-Firefox-linux.png and /dev/null differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-md-rtl-Mobile-Safari-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-md-rtl-Mobile-Safari-linux.png deleted file mode 100644 index 72ee1e8aed..0000000000 Binary files a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-diff-md-rtl-Mobile-Safari-linux.png and /dev/null differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-disabled-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-disabled-ios-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..9ca3fccf06 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-disabled-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-disabled-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-disabled-ios-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..5140cfcc34 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-disabled-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-disabled-ios-ltr-Mobile-Safari-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-disabled-ios-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..8d969b8011 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-disabled-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-disabled-md-ltr-Mobile-Chrome-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-disabled-md-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..7760b4c2d8 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-disabled-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-disabled-md-ltr-Mobile-Firefox-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-disabled-md-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..bbaaafe2cd Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-disabled-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-disabled-md-ltr-Mobile-Safari-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-disabled-md-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..e9634c57e9 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-disabled-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-ios-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..bc5672cbca Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-ios-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..e0cdaefed7 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-ios-ltr-Mobile-Safari-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-ios-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..9fca197eea Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-ios-rtl-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..0a294812e2 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-ios-rtl-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..b459b226ea Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-ios-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-ios-rtl-Mobile-Safari-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-ios-rtl-Mobile-Safari-linux.png new file mode 100644 index 0000000000..cdbce9fbdc Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-md-ltr-Mobile-Chrome-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-md-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..1f93dc3ca4 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-md-ltr-Mobile-Firefox-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-md-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..1a0398744f Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-md-ltr-Mobile-Safari-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-md-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..9b4a5b1285 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-md-rtl-Mobile-Chrome-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-md-rtl-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..37bdbdfef4 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-md-rtl-Mobile-Firefox-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-md-rtl-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..500f4b6360 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-md-rtl-Mobile-Safari-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-md-rtl-Mobile-Safari-linux.png new file mode 100644 index 0000000000..139d994aed Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-search-icon-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-search-icon-ios-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..ee48fb40b9 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-search-icon-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-search-icon-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-search-icon-ios-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..d143a5ba53 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-search-icon-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-search-icon-ios-ltr-Mobile-Safari-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-search-icon-ios-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..4b8ef46703 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-search-icon-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-search-icon-md-ltr-Mobile-Chrome-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-search-icon-md-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..8be3252a65 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-search-icon-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-search-icon-md-ltr-Mobile-Firefox-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-search-icon-md-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..4e2dd694f3 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-search-icon-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-search-icon-md-ltr-Mobile-Safari-linux.png b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-search-icon-md-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..860e409275 Binary files /dev/null and b/core/src/components/searchbar/test/basic/searchbar.e2e.ts-snapshots/searchbar-search-icon-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/textarea/test/autogrow/textarea.e2e.ts b/core/src/components/textarea/test/autogrow/textarea.e2e.ts index 1cf59bba5c..e4837a0c73 100644 --- a/core/src/components/textarea/test/autogrow/textarea.e2e.ts +++ b/core/src/components/textarea/test/autogrow/textarea.e2e.ts @@ -11,30 +11,20 @@ test.describe('textarea: autogrow', () => { }); test('should grow when typing', async ({ page }) => { - await page.setContent( - ` - - - - - - - - - ` + await page.setContent(` + + `); + + const ionTextarea = page.locator('ion-textarea'); + const nativeTextarea = ionTextarea.locator('textarea'); + + await nativeTextarea.type('Now, this is a story all about how'); + + expect(await ionTextarea.screenshot({})).toMatchSnapshot( + `textarea-autogrow-initial-${page.getSnapshotSettings()}.png` ); - const textarea = await page.waitForSelector('ion-textarea'); - - await textarea.click(); - - await textarea.type('Now, this is a story all about how'); - - await page.setIonViewport(); - - expect(await textarea.screenshot()).toMatchSnapshot(`textarea-autogrow-initial-${page.getSnapshotSettings()}.png`); - - await textarea.type( + await nativeTextarea.type( [ `\nMy life got flipped-turned upside down`, `And I'd like to take a minute`, @@ -43,7 +33,7 @@ test.describe('textarea: autogrow', () => { ].join('\n') ); - expect(await textarea.screenshot()).toMatchSnapshot(`textarea-autogrow-after-${page.getSnapshotSettings()}.png`); + expect(await ionTextarea.screenshot()).toMatchSnapshot(`textarea-autogrow-after-${page.getSnapshotSettings()}.png`); }); test('should break long lines without white space', async ({ page }) => { @@ -53,17 +43,13 @@ test.describe('textarea: autogrow', () => { }); await page.setContent( - ` - - - - - ` + ` + ` ); - const textarea = await page.locator('ion-textarea'); + const textarea = page.locator('ion-textarea'); expect(await textarea.screenshot()).toMatchSnapshot( `textarea-autogrow-word-break-${page.getSnapshotSettings()}.png` diff --git a/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-after-md-ltr-Mobile-Chrome-linux.png b/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-after-md-ltr-Mobile-Chrome-linux.png index 63640ab228..6ee632885b 100644 Binary files a/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-after-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-after-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-after-md-ltr-Mobile-Firefox-linux.png b/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-after-md-ltr-Mobile-Firefox-linux.png index b750e70e7a..fa46118d4b 100644 Binary files a/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-after-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-after-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-after-md-ltr-Mobile-Safari-linux.png b/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-after-md-ltr-Mobile-Safari-linux.png index 3f29ca5c72..32faf49fcd 100644 Binary files a/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-after-md-ltr-Mobile-Safari-linux.png and b/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-after-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-after-md-rtl-Mobile-Chrome-linux.png b/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-after-md-rtl-Mobile-Chrome-linux.png index 1d3a6e7251..8f1750138d 100644 Binary files a/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-after-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-after-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-after-md-rtl-Mobile-Firefox-linux.png b/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-after-md-rtl-Mobile-Firefox-linux.png index c982adf9fc..f7c26adb9b 100644 Binary files a/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-after-md-rtl-Mobile-Firefox-linux.png and b/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-after-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-after-md-rtl-Mobile-Safari-linux.png b/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-after-md-rtl-Mobile-Safari-linux.png index b8c07ca29b..dbeb9be6f9 100644 Binary files a/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-after-md-rtl-Mobile-Safari-linux.png and b/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-after-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-md-ltr-Mobile-Chrome-linux.png b/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-md-ltr-Mobile-Chrome-linux.png index d897ef88dd..a5b4ffbd15 100644 Binary files a/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-md-ltr-Mobile-Chrome-linux.png and b/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-md-ltr-Mobile-Firefox-linux.png b/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-md-ltr-Mobile-Firefox-linux.png index 26a3105499..65ed56ed0a 100644 Binary files a/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-md-ltr-Mobile-Firefox-linux.png and b/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-md-ltr-Mobile-Safari-linux.png b/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-md-ltr-Mobile-Safari-linux.png index ffc0d250d1..b64b582432 100644 Binary files a/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-md-ltr-Mobile-Safari-linux.png and b/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-md-rtl-Mobile-Chrome-linux.png b/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-md-rtl-Mobile-Chrome-linux.png index 39d32695f7..371d2e2382 100644 Binary files a/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-md-rtl-Mobile-Chrome-linux.png and b/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-md-rtl-Mobile-Firefox-linux.png b/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-md-rtl-Mobile-Firefox-linux.png index bb3a353a19..1e5408ea84 100644 Binary files a/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-md-rtl-Mobile-Firefox-linux.png and b/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-md-rtl-Mobile-Safari-linux.png b/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-md-rtl-Mobile-Safari-linux.png index 04ade3e70c..14c38fb30a 100644 Binary files a/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-md-rtl-Mobile-Safari-linux.png and b/core/src/components/textarea/test/autogrow/textarea.e2e.ts-snapshots/textarea-autogrow-initial-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/utils/tap-click/test/tap-click.e2e.ts b/core/src/utils/tap-click/test/tap-click.e2e.ts index 29512706c9..4a8eb46b5b 100644 --- a/core/src/utils/tap-click/test/tap-click.e2e.ts +++ b/core/src/utils/tap-click/test/tap-click.e2e.ts @@ -1,6 +1,12 @@ +import { expect } from '@playwright/test'; import { test } from '@utils/test/playwright'; -test.describe('tap click utility', () => { +// TODO FW-3010 +test.describe.skip('tap click utility', () => { + test.beforeEach(({ skip }) => { + skip.rtl(); + skip.mode('ios'); + }); test('it should apply activated class when clicking element', async ({ page }) => { await page.setContent(` @@ -14,8 +20,9 @@ test.describe('tap click utility', () => { if (box) { await page.mouse.move(box.x + box.width / 2, box.y + box.height / 2); await page.mouse.down(); + await page.waitForChanges(); } - await page.waitForSelector('button.ion-activated'); + await expect(button).toHaveClass(/ion-activated/); }); }); diff --git a/core/src/utils/test/overlays/overlays.e2e.ts b/core/src/utils/test/overlays/overlays.e2e.ts index 5c18b933ba..d663c58648 100644 --- a/core/src/utils/test/overlays/overlays.e2e.ts +++ b/core/src/utils/test/overlays/overlays.e2e.ts @@ -108,29 +108,6 @@ test.describe('overlays: focus', () => { test.beforeEach(({ skip }) => { skip.rtl(); }); - test('should not focus the overlay container if element inside of overlay is focused', async ({ page }) => { - await page.setContent(` - Show Modal - - - - - - `); - - const ionModalDidPresent = await page.spyOnEvent('ionModalDidPresent'); - const button = page.locator('ion-button'); - const input = page.locator('ion-input'); - - await button.click(); - await input.evaluate((el: HTMLIonInputElement) => el.setFocus()); - - await ionModalDidPresent.next(); - await page.waitForChanges(); - - await expect(page.locator('ion-input input')).toBeFocused(); - }); - test('should not select a hidden focusable element', async ({ page, browserName }) => { await page.setContent(`