javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-23 22:17:40 +08:00
Code Issues Packages Projects Releases Wiki Activity

perf(virtual-list): relaxed restrictions for fast path

Browse Source
This commit is contained in:
Manuel Mtz-Almeida
2017-04-20 19:31:04 +02:00
parent 325cc5eea7
commit 88e5642f60
3 changed files with 65 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
src/components/virtual-scroll/virtual-scroll.ts
View File

@ -379,7 +379,6 @@ export class VirtualScroll implements DoCheck, AfterContentInit, OnDestroy {
return this._virtualTrackBy;
}
constructor(
private _iterableDiffers: IterableDiffers,
private _elementRef: ElementRef,
@ -412,6 +411,28 @@ export class VirtualScroll implements DoCheck, AfterContentInit, OnDestroy {
});
}
/**
* @hidden
*/
firstRecord(): number {
const cells = this._cells;
if (cells.length > 0) {
return cells[0].record;
}
return 0;
}
/**
* @hidden
*/
lastRecord(): number {
const cells = this._cells;
if (cells.length > 0) {
return cells[cells.length - 1].record;
}
return 0;
}
/**
* @hidden
*/
@ -429,8 +450,9 @@ export class VirtualScroll implements DoCheck, AfterContentInit, OnDestroy {
let needClean = false;
if (changes) {
var lastRecord = this.lastRecord() + 1;
changes.forEachOperation((item, _, cindex) => {
if (item.previousIndex != null || (cindex < this._recordSize)) {
if (item.previousIndex != null || (cindex < lastRecord)) {
needClean = true;
}
});
@ -443,10 +465,13 @@ export class VirtualScroll implements DoCheck, AfterContentInit, OnDestroy {
this.writeUpdate(needClean);
}
/**
* @hidden
*/
readUpdate(needClean: boolean) {
if (needClean) {
// reset everything
console.debug(`virtual-scroll, readUpdate: slow path`);
console.debug('virtual-scroll, readUpdate: slow path');
this._cells.length = 0;
this._nodes.length = 0;
this._itmTmp.viewContainer.clear();
@ -458,8 +483,11 @@ export class VirtualScroll implements DoCheck, AfterContentInit, OnDestroy {
}
}
/**
* @hidden
*/
writeUpdate(needClean: boolean) {
console.debug(`virtual-scroll, writeUpdate`);
console.debug('virtual-scroll, writeUpdate need clean:', needClean);
const data = this._data;
const stopAtHeight = (data.scrollTop + data.renderHeight);
data.scrollDiff = SCROLL_DIFFERENCE_MINIMUM + 1;
@ -475,6 +503,9 @@ export class VirtualScroll implements DoCheck, AfterContentInit, OnDestroy {
this.renderVirtual(needClean);
}
/**
* @hidden
*/
private calcDimensions() {
calcDimensions(this._data, this._elementRef.nativeElement,
this.approxItemWidth, this.approxItemHeight,
@ -571,7 +602,7 @@ export class VirtualScroll implements DoCheck, AfterContentInit, OnDestroy {
}
/**
* @private
* @hidden
*/
resize() {
// only continue if we've already initialized
@ -605,7 +636,7 @@ export class VirtualScroll implements DoCheck, AfterContentInit, OnDestroy {
}
/**
* @private
* @hidden
*/
private _stepChangeDetection() {
// we need to do some change detection in this frame
@ -624,7 +655,7 @@ export class VirtualScroll implements DoCheck, AfterContentInit, OnDestroy {
}
/**
* @private
* @hidden
*/
private _stepNoChanges() {
const data = this._data;
@ -675,7 +706,7 @@ export class VirtualScroll implements DoCheck, AfterContentInit, OnDestroy {
}
/**
* @private
* @hidden
*/
scrollUpdate(ev: ScrollEvent) {
// set the scroll top from the scroll event
@ -718,6 +749,7 @@ export class VirtualScroll implements DoCheck, AfterContentInit, OnDestroy {
}
/**
* @hidden
* NO DOM
*/
private _listeners() {
@ -738,6 +770,7 @@ export class VirtualScroll implements DoCheck, AfterContentInit, OnDestroy {
}
/**
* @hidden
* DOM WRITE
*/
private _setHeight(newVirtualHeight: number) {
@ -762,6 +795,9 @@ export class VirtualScroll implements DoCheck, AfterContentInit, OnDestroy {
}
}
/**
* @hidden
*/
setElementClass(className: string, add: boolean) {
this._renderer.setElementClass(this._elementRef.nativeElement, className, add);
}