From 87bc207dad59f57931aef770642aae8dadfd2882 Mon Sep 17 00:00:00 2001 From: Sean Perkins Date: Thu, 10 Aug 2023 10:33:57 -0500 Subject: [PATCH] chore(input): remove generated documentation for size attribute (#27951) Issue number: Resolves #27945 --------- ## What is the current behavior? The `ion-input` accepts a `size` attribute that implies that it will effect the size of the input under certain rules. This is not the case. The `size` attribute has no effect on the size of the `input` element since Ionic sets the input width to 100%. ## What is the new behavior? - Removes the documentation around the `size` attribute so that it will be removed from the Ionic Docs - Adds a task link to remove the `size` attribute in an upcoming major release ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information --- core/src/components.d.ts | 6 ------ core/src/components/input/input.tsx | 4 +--- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/core/src/components.d.ts b/core/src/components.d.ts index 7a0c2638ba..1cd7c27747 100644 --- a/core/src/components.d.ts +++ b/core/src/components.d.ts @@ -1277,9 +1277,6 @@ export namespace Components { * The shape of the input. If "round" it will have an increased border radius. */ "shape"?: 'round'; - /** - * The initial size of the control. This value is in pixels unless the value of the type attribute is `"text"` or `"password"`, in which case it is an integer number of characters. This attribute applies only when the `type` attribute is set to `"text"`, `"search"`, `"tel"`, `"url"`, `"email"`, or `"password"`, otherwise it is ignored. - */ "size"?: number; /** * If `true`, the element will have its spelling and grammar checked. @@ -5339,9 +5336,6 @@ declare namespace LocalJSX { * The shape of the input. If "round" it will have an increased border radius. */ "shape"?: 'round'; - /** - * The initial size of the control. This value is in pixels unless the value of the type attribute is `"text"` or `"password"`, in which case it is an integer number of characters. This attribute applies only when the `type` attribute is set to `"text"`, `"search"`, `"tel"`, `"url"`, `"email"`, or `"password"`, otherwise it is ignored. - */ "size"?: number; /** * If `true`, the element will have its spelling and grammar checked. diff --git a/core/src/components/input/input.tsx b/core/src/components/input/input.tsx index edbc963c37..44dec367e4 100644 --- a/core/src/components/input/input.tsx +++ b/core/src/components/input/input.tsx @@ -268,9 +268,7 @@ export class Input implements ComponentInterface { */ @Prop() step?: string; - /** - * The initial size of the control. This value is in pixels unless the value of the type attribute is `"text"` or `"password"`, in which case it is an integer number of characters. This attribute applies only when the `type` attribute is set to `"text"`, `"search"`, `"tel"`, `"url"`, `"email"`, or `"password"`, otherwise it is ignored. - */ + // FW-4914 Remove this property in Ionic 8 @Prop() size?: number; /**