javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat(menu): add console error for incorrect usage of contentId (#23871)

Browse Source 
resolves #23810
This commit is contained in:
William Martin
2021-09-08 08:54:01 -04:00
committed by GitHub
parent 5fd80fd438
commit 879ab8ebda
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
core/src/components/menu/menu.tsx
View File

@ -179,6 +179,11 @@ AFTER:
console.error('Menu: must have a "content" element to listen for drag events on.'); console.error('Menu: must have a "content" element to listen for drag events on.');
return; return;
} }
if (this.el.contains(content)) {
console.error(`Menu: "contentId" should refer to the main view's ion-content, not the ion-content inside of the ion-menu.`);
}
this.contentEl = content as HTMLElement; this.contentEl = content as HTMLElement;
// add menu's content classes // add menu's content classes