javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(): remove deprecated controllers (#20165)

Browse Source 
* remove action-sheet-controller and alert-controller

* rmeove loading controller

* remove popover controller

* remove toast controller

* remove picker-controller

* remove modal controller

* remove menu controller

* update menu ctrl in tests

* run linter

* remove window refs

* Update core/src/components/loading/test/standalone/index.html

Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>

* remove window from modal tests

* test

* testing timeout

* change timeout

Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
This commit is contained in:
Liam DeBeasi
2020-01-14 12:09:35 -05:00
committed by GitHub
parent 5b0400d5af
commit 8732a10757
45 changed files with 227 additions and 1701 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
core/src/components/menu/test/standalone/index.html
View File

@ -9,7 +9,12 @@
<link href="../../../../../scripts/testing/styles.css" rel="stylesheet">
<script src="../../../../../scripts/testing/scripts.js"></script>
<script nomodule src="../../../../../dist/ionic/ionic.js"></script>
<script type="module" src="../../../../../dist/ionic/ionic.esm.js"></script> <style>
<script type="module" src="../../../../../dist/ionic/ionic.esm.js"></script>
<script type="module">
import { menuController } from '../../../../dist/ionic/index.esm.js';
window.menuController = menuController;
</script>
<style>
.ion-page ion-content {
--padding-top: 16px;
--padding-end: 16px;
@ -65,18 +70,13 @@
<ion-button expand="block" onclick="openEnd()">Open End Menu</ion-button>
</ion-content>
</div>
<ion-menu-controller></ion-menu-controller>
<script>
function openStart() {
document.querySelector('ion-menu-controller')
.open('start');
menuController.open('start');
}
function openEnd() {
document.querySelector('ion-menu-controller')
.open('end');
menuController.open('end');
}
</script>
</body>

2
core/src/components/menu/test/test.utils.ts
View File

@ -25,7 +25,7 @@ export const testMenu = async (
const menu = await page.find(selector);
await menu.callMethod('open');
await page.waitFor(250);
await page.waitFor(1000);
screenshotCompares.push(await page.compareScreenshot());