diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md
index 38e85dc9a4..6672ac0cd8 100644
--- a/.github/CONTRIBUTING.md
+++ b/.github/CONTRIBUTING.md
@@ -140,12 +140,13 @@ Before creating a pull request, please read our requirements that explains the m
#### Modifying Documentation
-1. Locate the `readme.md` file in the component's directory.
-2. Modify the documentation **above** the line that says `` in this file.
-3. To update any of the auto generated documentation below that line, make the relevant changes in the following places:
- - `Usage`: update the component's usage examples in the component's `usage/` directory
- - `Properties`, `Events`, or `Methods`: update the component's TypeScript file (`*.tsx`)
- - `CSS Custom Properties`: update the component's main Sass file (`*.scss`)
+- Changes to manually written documentation should be made in the `ionic-docs` repo: https://github.com/ionic-team/ionic-docs/tree/main/docs
+ - In your `ionic-docs` PR, please add a link back to the related `ionic-framework` PR.
+- Changes to auto generated documentation should be made in the `ionic-framework` repo. These can be done in the same PR as your fix or feature.
+ - Run `npm run build` and commit all updates to ensure your changes make it into the generated documentation.
+ - `Usage`: update the component's usage examples in the component's `usage/` directory.
+ - `Properties`, `Events`, or `Methods`: update the component's TypeScript file (`*.tsx`).
+ - `CSS Custom Properties`: update the component's main Sass file (`*.scss`).
#### Modifying Tests
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index c02a4ffacf..de483aceb0 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -5,6 +5,7 @@
Please check if your PR fulfills the following requirements:
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
+ - Some docs updates need to be made in the `ionic-docs` repo, in a separate PR. See the [contributing guide](https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation) for details.
- [ ] Build (`npm run build`) was run locally and any changes were pushed
- [ ] Lint (`npm run lint`) has passed locally and any fixes were made for failures
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 99362719b5..c599bde1f8 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,6 +3,19 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+## [6.1.6](https://github.com/ionic-team/ionic-framework/compare/v6.1.5...v6.1.6) (2022-05-18)
+
+
+### Bug Fixes
+
+* **loading:** spinner now respects —spinner-color ([#25261](https://github.com/ionic-team/ionic-framework/issues/25261)) ([65f4c74](https://github.com/ionic-team/ionic-framework/commit/65f4c742e7a5e5756f6f72dd853e38e885f90385)), closes [#25180](https://github.com/ionic-team/ionic-framework/issues/25180)
+* **modal:** reset breakpoint to initial breakpoint on present ([#25246](https://github.com/ionic-team/ionic-framework/issues/25246)) ([2557bf3](https://github.com/ionic-team/ionic-framework/commit/2557bf3c3eed9e33e89e07a8d73489da8d81bee3)), closes [#25245](https://github.com/ionic-team/ionic-framework/issues/25245)
+* **scroll-assist:** touch end events continue to bubble on inputs ([#25282](https://github.com/ionic-team/ionic-framework/issues/25282)) ([780f16d](https://github.com/ionic-team/ionic-framework/commit/780f16d9e04ee5aaaf91bb7c6ef15c72cc8aeb45)), closes [#25229](https://github.com/ionic-team/ionic-framework/issues/25229)
+
+
+
+
+
## [6.1.5](https://github.com/ionic-team/ionic-framework/compare/v6.1.4...v6.1.5) (2022-05-11)
diff --git a/angular/CHANGELOG.md b/angular/CHANGELOG.md
index c410a58eb5..cd3f38f619 100644
--- a/angular/CHANGELOG.md
+++ b/angular/CHANGELOG.md
@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+## [6.1.6](https://github.com/ionic-team/ionic/compare/v6.1.5...v6.1.6) (2022-05-18)
+
+**Note:** Version bump only for package @ionic/angular
+
+
+
+
+
## [6.1.5](https://github.com/ionic-team/ionic/compare/v6.1.4...v6.1.5) (2022-05-11)
diff --git a/angular/package-lock.json b/angular/package-lock.json
index 9b8af18f4d..4157deb853 100644
--- a/angular/package-lock.json
+++ b/angular/package-lock.json
@@ -1,15 +1,15 @@
{
"name": "@ionic/angular",
- "version": "6.1.5",
+ "version": "6.1.6",
"lockfileVersion": 2,
"requires": true,
"packages": {
"": {
"name": "@ionic/angular",
- "version": "6.1.5",
+ "version": "6.1.6",
"license": "MIT",
"dependencies": {
- "@ionic/core": "^6.1.5",
+ "@ionic/core": "^6.1.6",
"jsonc-parser": "^3.0.0",
"tslib": "^2.0.0"
},
@@ -1023,9 +1023,9 @@
"dev": true
},
"node_modules/@ionic/core": {
- "version": "6.1.5",
- "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.1.5.tgz",
- "integrity": "sha512-YEpFheFDGV7lifbYNqctcPXRPqEOKiDy5KgSPriFzrrPUbwrv/tnXHZq7hFVPCMUYFBS9QJts4r5FOYTqAfvtw==",
+ "version": "6.1.6",
+ "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.1.6.tgz",
+ "integrity": "sha512-AsYGEHKVHy082RST3RBrIiOZX6VXNy6qYSYtf6TwOwmF/YV+/ASaB1TqVO/jP658ML106nNcjUM0fTkbm9UXRA==",
"dependencies": {
"@stencil/core": "^2.14.2",
"ionicons": "^6.0.0",
@@ -7951,9 +7951,9 @@
"dev": true
},
"@ionic/core": {
- "version": "6.1.5",
- "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.1.5.tgz",
- "integrity": "sha512-YEpFheFDGV7lifbYNqctcPXRPqEOKiDy5KgSPriFzrrPUbwrv/tnXHZq7hFVPCMUYFBS9QJts4r5FOYTqAfvtw==",
+ "version": "6.1.6",
+ "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.1.6.tgz",
+ "integrity": "sha512-AsYGEHKVHy082RST3RBrIiOZX6VXNy6qYSYtf6TwOwmF/YV+/ASaB1TqVO/jP658ML106nNcjUM0fTkbm9UXRA==",
"requires": {
"@stencil/core": "^2.14.2",
"ionicons": "^6.0.0",
diff --git a/angular/package.json b/angular/package.json
index ce780cc02c..c479c802e6 100644
--- a/angular/package.json
+++ b/angular/package.json
@@ -1,6 +1,6 @@
{
"name": "@ionic/angular",
- "version": "6.1.5",
+ "version": "6.1.6",
"description": "Angular specific wrappers for @ionic/core",
"keywords": [
"ionic",
@@ -44,7 +44,7 @@
"validate": "npm i && npm run lint && npm run test && npm run build"
},
"dependencies": {
- "@ionic/core": "^6.1.5",
+ "@ionic/core": "^6.1.6",
"jsonc-parser": "^3.0.0",
"tslib": "^2.0.0"
},
diff --git a/core/CHANGELOG.md b/core/CHANGELOG.md
index de0854b101..444a2f87e3 100644
--- a/core/CHANGELOG.md
+++ b/core/CHANGELOG.md
@@ -3,6 +3,19 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+## [6.1.6](https://github.com/ionic-team/ionic/compare/v6.1.5...v6.1.6) (2022-05-18)
+
+
+### Bug Fixes
+
+* **loading:** spinner now respects —spinner-color ([#25261](https://github.com/ionic-team/ionic/issues/25261)) ([65f4c74](https://github.com/ionic-team/ionic/commit/65f4c742e7a5e5756f6f72dd853e38e885f90385)), closes [#25180](https://github.com/ionic-team/ionic/issues/25180)
+* **modal:** reset breakpoint to initial breakpoint on present ([#25246](https://github.com/ionic-team/ionic/issues/25246)) ([2557bf3](https://github.com/ionic-team/ionic/commit/2557bf3c3eed9e33e89e07a8d73489da8d81bee3)), closes [#25245](https://github.com/ionic-team/ionic/issues/25245)
+* **scroll-assist:** touch end events continue to bubble on inputs ([#25282](https://github.com/ionic-team/ionic/issues/25282)) ([780f16d](https://github.com/ionic-team/ionic/commit/780f16d9e04ee5aaaf91bb7c6ef15c72cc8aeb45)), closes [#25229](https://github.com/ionic-team/ionic/issues/25229)
+
+
+
+
+
## [6.1.5](https://github.com/ionic-team/ionic/compare/v6.1.4...v6.1.5) (2022-05-11)
diff --git a/core/package-lock.json b/core/package-lock.json
index 08e6d49bb2..b3e7ee5cd7 100644
--- a/core/package-lock.json
+++ b/core/package-lock.json
@@ -1,12 +1,12 @@
{
"name": "@ionic/core",
- "version": "6.1.5",
+ "version": "6.1.6",
"lockfileVersion": 2,
"requires": true,
"packages": {
"": {
"name": "@ionic/core",
- "version": "6.1.5",
+ "version": "6.1.6",
"license": "MIT",
"dependencies": {
"@stencil/core": "^2.14.2",
diff --git a/core/package.json b/core/package.json
index 4c6c22971f..9c0016b481 100644
--- a/core/package.json
+++ b/core/package.json
@@ -1,6 +1,6 @@
{
"name": "@ionic/core",
- "version": "6.1.5",
+ "version": "6.1.6",
"description": "Base components for Ionic",
"keywords": [
"ionic",
diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts
new file mode 100644
index 0000000000..961c6c8191
--- /dev/null
+++ b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts
@@ -0,0 +1,12 @@
+import { expect } from '@playwright/test';
+import { test } from '@utils/test/playwright';
+
+test.describe('breadcrumbs: basic', () => {
+ test('should not have visual regressions', async ({ page }) => {
+ await page.goto(`/src/components/breadcrumbs/test/basic`);
+
+ await page.setIonViewport();
+
+ expect(await page.screenshot()).toMatchSnapshot(`breadcrumb-diff-${page.getSnapshotSettings()}.png`);
+ });
+});
diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-ltr-Mobile-Chrome-linux.png
new file mode 100644
index 0000000000..c855d61700
Binary files /dev/null and b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-ltr-Mobile-Chrome-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-ltr-Mobile-Firefox-linux.png
new file mode 100644
index 0000000000..0f19f9edd4
Binary files /dev/null and b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-ltr-Mobile-Firefox-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-ltr-Mobile-Safari-linux.png b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-ltr-Mobile-Safari-linux.png
new file mode 100644
index 0000000000..e56126419e
Binary files /dev/null and b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-ltr-Mobile-Safari-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-rtl-Mobile-Chrome-linux.png
new file mode 100644
index 0000000000..18022b3baf
Binary files /dev/null and b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-rtl-Mobile-Chrome-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-rtl-Mobile-Firefox-linux.png
new file mode 100644
index 0000000000..b371aa94f0
Binary files /dev/null and b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-rtl-Mobile-Firefox-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-rtl-Mobile-Safari-linux.png b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-rtl-Mobile-Safari-linux.png
new file mode 100644
index 0000000000..8f1973ba43
Binary files /dev/null and b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-ios-rtl-Mobile-Safari-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-ltr-Mobile-Chrome-linux.png
new file mode 100644
index 0000000000..e08dff40ee
Binary files /dev/null and b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-ltr-Mobile-Chrome-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-ltr-Mobile-Firefox-linux.png
new file mode 100644
index 0000000000..4bd8cc098b
Binary files /dev/null and b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-ltr-Mobile-Firefox-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-ltr-Mobile-Safari-linux.png
new file mode 100644
index 0000000000..a762d9135a
Binary files /dev/null and b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-ltr-Mobile-Safari-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-rtl-Mobile-Chrome-linux.png
new file mode 100644
index 0000000000..03d28a6524
Binary files /dev/null and b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-rtl-Mobile-Chrome-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-rtl-Mobile-Firefox-linux.png b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-rtl-Mobile-Firefox-linux.png
new file mode 100644
index 0000000000..80fd7ad7a4
Binary files /dev/null and b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-rtl-Mobile-Firefox-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-rtl-Mobile-Safari-linux.png b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-rtl-Mobile-Safari-linux.png
new file mode 100644
index 0000000000..d3719d7a00
Binary files /dev/null and b/core/src/components/breadcrumbs/test/basic/breadcrumbs.e2e.ts-snapshots/breadcrumb-diff-md-rtl-Mobile-Safari-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/basic/e2e.ts b/core/src/components/breadcrumbs/test/basic/e2e.ts
deleted file mode 100644
index 91275fde08..0000000000
--- a/core/src/components/breadcrumbs/test/basic/e2e.ts
+++ /dev/null
@@ -1,19 +0,0 @@
-import { newE2EPage } from '@stencil/core/testing';
-
-test('breadcrumbs: basic', async () => {
- const page = await newE2EPage({
- url: '/src/components/breadcrumbs/test/basic?ionic:_testing=true',
- });
-
- const compare = await page.compareScreenshot();
- expect(compare).toMatchScreenshot();
-});
-
-test('breadcrumbs: basic-rtl', async () => {
- const page = await newE2EPage({
- url: '/src/components/breadcrumbs/test/basic?ionic:_testing=true&rtl=true',
- });
-
- const compare = await page.compareScreenshot();
- expect(compare).toMatchScreenshot();
-});
diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts
new file mode 100644
index 0000000000..76f7a7c913
--- /dev/null
+++ b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts
@@ -0,0 +1,12 @@
+import { expect } from '@playwright/test';
+import { test } from '@utils/test/playwright';
+
+test.describe('breadcrumbs: collapsed', () => {
+ test('should not have visual regressions', async ({ page }) => {
+ await page.goto(`/src/components/breadcrumbs/test/collapsed`);
+
+ await page.setIonViewport();
+
+ expect(await page.screenshot()).toMatchSnapshot(`breadcrumb-collapsed-diff-${page.getSnapshotSettings()}.png`);
+ });
+});
diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-ltr-Mobile-Chrome-linux.png
new file mode 100644
index 0000000000..fef2cc9a35
Binary files /dev/null and b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-ltr-Mobile-Chrome-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-ltr-Mobile-Firefox-linux.png
new file mode 100644
index 0000000000..c21aca1574
Binary files /dev/null and b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-ltr-Mobile-Firefox-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-ltr-Mobile-Safari-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-ltr-Mobile-Safari-linux.png
new file mode 100644
index 0000000000..856b0093a1
Binary files /dev/null and b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-ltr-Mobile-Safari-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-rtl-Mobile-Chrome-linux.png
new file mode 100644
index 0000000000..162ffc763f
Binary files /dev/null and b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-rtl-Mobile-Chrome-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-rtl-Mobile-Firefox-linux.png
new file mode 100644
index 0000000000..f4438cb3e7
Binary files /dev/null and b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-rtl-Mobile-Firefox-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-rtl-Mobile-Safari-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-rtl-Mobile-Safari-linux.png
new file mode 100644
index 0000000000..bfced02d10
Binary files /dev/null and b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-ios-rtl-Mobile-Safari-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Chrome-linux.png
new file mode 100644
index 0000000000..85b279a0d1
Binary files /dev/null and b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Chrome-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Firefox-linux.png
new file mode 100644
index 0000000000..7fcc459eb5
Binary files /dev/null and b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Firefox-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Safari-linux.png
new file mode 100644
index 0000000000..423790c52a
Binary files /dev/null and b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-ltr-Mobile-Safari-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Chrome-linux.png
new file mode 100644
index 0000000000..17af895e31
Binary files /dev/null and b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Chrome-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Firefox-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Firefox-linux.png
new file mode 100644
index 0000000000..290ab5ac1e
Binary files /dev/null and b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Firefox-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Safari-linux.png b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Safari-linux.png
new file mode 100644
index 0000000000..909a163389
Binary files /dev/null and b/core/src/components/breadcrumbs/test/collapsed/breadcrumbs.e2e.ts-snapshots/breadcrumb-collapsed-diff-md-rtl-Mobile-Safari-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/collapsed/e2e.ts b/core/src/components/breadcrumbs/test/collapsed/e2e.ts
deleted file mode 100644
index 3fe6ddb24e..0000000000
--- a/core/src/components/breadcrumbs/test/collapsed/e2e.ts
+++ /dev/null
@@ -1,10 +0,0 @@
-import { newE2EPage } from '@stencil/core/testing';
-
-test('breadcrumbs: collapsed', async () => {
- const page = await newE2EPage({
- url: '/src/components/breadcrumbs/test/collapsed?ionic:_testing=true',
- });
-
- const compare = await page.compareScreenshot();
- expect(compare).toMatchScreenshot();
-});
diff --git a/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts
new file mode 100644
index 0000000000..d4d0a6f61e
--- /dev/null
+++ b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts
@@ -0,0 +1,12 @@
+import { expect } from '@playwright/test';
+import { test } from '@utils/test/playwright';
+
+test.describe('breadcrumbs: standalone', () => {
+ test('should not have visual regressions', async ({ page }) => {
+ await page.goto(`/src/components/breadcrumbs/test/standalone`);
+
+ expect(await page.screenshot({ fullPage: true })).toMatchSnapshot(
+ `breadcrumb-standalone-diff-${page.getSnapshotSettings()}.png`
+ );
+ });
+});
diff --git a/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-ios-ltr-Mobile-Chrome-linux.png
new file mode 100644
index 0000000000..2d3aa1a8c9
Binary files /dev/null and b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-ios-ltr-Mobile-Chrome-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-ios-ltr-Mobile-Firefox-linux.png
new file mode 100644
index 0000000000..d3e3e19904
Binary files /dev/null and b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-ios-ltr-Mobile-Firefox-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-ios-ltr-Mobile-Safari-linux.png b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-ios-ltr-Mobile-Safari-linux.png
new file mode 100644
index 0000000000..2a4fcc1fcd
Binary files /dev/null and b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-ios-ltr-Mobile-Safari-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-ios-rtl-Mobile-Chrome-linux.png
new file mode 100644
index 0000000000..a5cd606eda
Binary files /dev/null and b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-ios-rtl-Mobile-Chrome-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-ios-rtl-Mobile-Firefox-linux.png
new file mode 100644
index 0000000000..d609b0e312
Binary files /dev/null and b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-ios-rtl-Mobile-Firefox-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-ios-rtl-Mobile-Safari-linux.png b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-ios-rtl-Mobile-Safari-linux.png
new file mode 100644
index 0000000000..8468cac598
Binary files /dev/null and b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-ios-rtl-Mobile-Safari-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-md-ltr-Mobile-Chrome-linux.png
new file mode 100644
index 0000000000..3047485c13
Binary files /dev/null and b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-md-ltr-Mobile-Chrome-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-md-ltr-Mobile-Firefox-linux.png
new file mode 100644
index 0000000000..cd00ea3e6f
Binary files /dev/null and b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-md-ltr-Mobile-Firefox-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-md-ltr-Mobile-Safari-linux.png
new file mode 100644
index 0000000000..c20ed35366
Binary files /dev/null and b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-md-ltr-Mobile-Safari-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-md-rtl-Mobile-Chrome-linux.png
new file mode 100644
index 0000000000..cdb2c94428
Binary files /dev/null and b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-md-rtl-Mobile-Chrome-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-md-rtl-Mobile-Firefox-linux.png b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-md-rtl-Mobile-Firefox-linux.png
new file mode 100644
index 0000000000..42a25abd11
Binary files /dev/null and b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-md-rtl-Mobile-Firefox-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-md-rtl-Mobile-Safari-linux.png b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-md-rtl-Mobile-Safari-linux.png
new file mode 100644
index 0000000000..4642ac5f37
Binary files /dev/null and b/core/src/components/breadcrumbs/test/standalone/breadcrumbs.e2e.ts-snapshots/breadcrumb-standalone-diff-md-rtl-Mobile-Safari-linux.png differ
diff --git a/core/src/components/breadcrumbs/test/standalone/e2e.ts b/core/src/components/breadcrumbs/test/standalone/e2e.ts
deleted file mode 100644
index 199e817242..0000000000
--- a/core/src/components/breadcrumbs/test/standalone/e2e.ts
+++ /dev/null
@@ -1,10 +0,0 @@
-import { newE2EPage } from '@stencil/core/testing';
-
-test('breadcrumbs: standalone', async () => {
- const page = await newE2EPage({
- url: '/src/components/breadcrumbs/test/standalone?ionic:_testing=true',
- });
-
- const compare = await page.compareScreenshot();
- expect(compare).toMatchScreenshot();
-});
diff --git a/core/src/components/loading/loading.scss b/core/src/components/loading/loading.scss
index bb5d42de5b..619e9f50b5 100644
--- a/core/src/components/loading/loading.scss
+++ b/core/src/components/loading/loading.scss
@@ -67,11 +67,6 @@
z-index: $z-index-overlay-wrapper;
}
-.spinner-lines,
-.spinner-lines-small,
-.spinner-bubbles,
-.spinner-circles,
-.spinner-crescent,
-.spinner-dots {
+ion-spinner {
color: var(--spinner-color);
}
diff --git a/core/src/components/loading/test/basic/index.html b/core/src/components/loading/test/basic/index.html
index 54623383f7..40ffdefe41 100644
--- a/core/src/components/loading/test/basic/index.html
+++ b/core/src/components/loading/test/basic/index.html
@@ -56,7 +56,7 @@
Show Loading with cssClass
{
await runVisualTest(page, '#translucent-loading', 'translucent');
});
test('should open a loader with a custom class', async ({ page }) => {
- await runVisualTest(page, '#no-spinner-loading', 'no-spinner');
+ await runVisualTest(page, '#custom-class-loading', 'custom-class');
});
test('should open a loader with html content', async ({ page }) => {
await runVisualTest(page, '#html-content-loading', 'html-content');
diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-ltr-Mobile-Chrome-linux.png
new file mode 100644
index 0000000000..d0cdc38469
Binary files /dev/null and b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-ltr-Mobile-Chrome-linux.png differ
diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-ltr-Mobile-Firefox-linux.png
new file mode 100644
index 0000000000..5c9620dec9
Binary files /dev/null and b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-ltr-Mobile-Firefox-linux.png differ
diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-ltr-Mobile-Safari-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-ltr-Mobile-Safari-linux.png
new file mode 100644
index 0000000000..4c563a3cf4
Binary files /dev/null and b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-ltr-Mobile-Safari-linux.png differ
diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-rtl-Mobile-Chrome-linux.png
new file mode 100644
index 0000000000..5db2b66fb9
Binary files /dev/null and b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-rtl-Mobile-Chrome-linux.png differ
diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-rtl-Mobile-Firefox-linux.png
new file mode 100644
index 0000000000..09c3b8cf3e
Binary files /dev/null and b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-rtl-Mobile-Firefox-linux.png differ
diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-rtl-Mobile-Safari-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-rtl-Mobile-Safari-linux.png
new file mode 100644
index 0000000000..bcc1559c59
Binary files /dev/null and b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-ios-rtl-Mobile-Safari-linux.png differ
diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-ltr-Mobile-Chrome-linux.png
new file mode 100644
index 0000000000..6af72178c2
Binary files /dev/null and b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-ltr-Mobile-Chrome-linux.png differ
diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-ltr-Mobile-Firefox-linux.png
new file mode 100644
index 0000000000..923f281ade
Binary files /dev/null and b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-ltr-Mobile-Firefox-linux.png differ
diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-ltr-Mobile-Safari-linux.png
new file mode 100644
index 0000000000..d3595b015a
Binary files /dev/null and b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-ltr-Mobile-Safari-linux.png differ
diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-rtl-Mobile-Chrome-linux.png
new file mode 100644
index 0000000000..d3f714deb7
Binary files /dev/null and b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-rtl-Mobile-Chrome-linux.png differ
diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-rtl-Mobile-Firefox-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-rtl-Mobile-Firefox-linux.png
new file mode 100644
index 0000000000..13af4188f5
Binary files /dev/null and b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-rtl-Mobile-Firefox-linux.png differ
diff --git a/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-rtl-Mobile-Safari-linux.png b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-rtl-Mobile-Safari-linux.png
new file mode 100644
index 0000000000..4f8dcbb2a0
Binary files /dev/null and b/core/src/components/loading/test/basic/loading.e2e.ts-snapshots/loading-custom-class-diff-md-rtl-Mobile-Safari-linux.png differ
diff --git a/core/src/components/modal/modal.tsx b/core/src/components/modal/modal.tsx
index 1c66ac9713..655006931f 100644
--- a/core/src/components/modal/modal.tsx
+++ b/core/src/components/modal/modal.tsx
@@ -442,6 +442,12 @@ export class Modal implements ComponentInterface, OverlayInterface {
await this.currentTransition;
}
+ /**
+ * If the modal is presented multiple times (inline modals), we
+ * need to reset the current breakpoint to the initial breakpoint.
+ */
+ this.currentBreakpoint = this.initialBreakpoint;
+
const data = {
...this.componentProps,
modal: this.el,
@@ -668,7 +674,7 @@ export class Modal implements ComponentInterface, OverlayInterface {
enteringAnimation.forEach((ani) => ani.destroy());
}
-
+ this.currentBreakpoint = undefined;
this.currentTransition = undefined;
this.animation = undefined;
return dismissed;
diff --git a/core/src/components/modal/test/basic/modal.e2e.ts b/core/src/components/modal/test/basic/modal.e2e.ts
index b3954018b0..0d1114ab84 100644
--- a/core/src/components/modal/test/basic/modal.e2e.ts
+++ b/core/src/components/modal/test/basic/modal.e2e.ts
@@ -43,8 +43,6 @@ test.describe('modal: focus trapping', () => {
page,
browserName,
}) => {
- // TODO FW-1436
- test.skip(browserName === 'firefox', 'Focus is flaky on Firefox');
await page.goto('/src/components/modal/test/basic');
const ionModalDidPresent = await page.spyOnEvent('ionModalDidPresent');
const ionModalDidDismiss = await page.spyOnEvent('ionModalDidDismiss');
diff --git a/core/src/components/modal/test/sheet/modal.e2e.ts b/core/src/components/modal/test/sheet/modal.e2e.ts
index 498eb4a639..b1bbb24a66 100644
--- a/core/src/components/modal/test/sheet/modal.e2e.ts
+++ b/core/src/components/modal/test/sheet/modal.e2e.ts
@@ -133,4 +133,65 @@ test.describe('sheet modal: setting the breakpoint', () => {
expect(ionBreakpointDidChange.events.length).toBe(1);
});
});
+
+ test('it should reset the breakpoint value on dismiss', async ({ page }) => {
+ test.info().annotations.push({
+ type: 'issue',
+ description: 'https://github.com/ionic-team/ionic-framework/issues/25245',
+ });
+
+ await page.setContent(`
+
+ Open
+
+
+ Dismiss
+ Set breakpoint
+
+
+
+
+ `);
+
+ const modal = page.locator('ion-modal');
+ const dismissButton = page.locator('#dismiss');
+ const openButton = page.locator('#open-modal');
+ const setBreakpointButton = page.locator('#set-breakpoint');
+
+ const ionModalDidPresent = await page.spyOnEvent('ionModalDidPresent');
+ const ionModalDidDismiss = await page.spyOnEvent('ionModalDidDismiss');
+ const ionBreakpointDidChange = await page.spyOnEvent('ionBreakpointDidChange');
+
+ await openButton.click();
+ await ionModalDidPresent.next();
+
+ await setBreakpointButton.click();
+ await ionBreakpointDidChange.next();
+
+ await dismissButton.click();
+ await ionModalDidDismiss.next();
+
+ await openButton.click();
+ await ionModalDidPresent.next();
+
+ const breakpoint = await modal.evaluate((el: HTMLIonModalElement) => el.getCurrentBreakpoint());
+
+ expect(breakpoint).toBe(0.25);
+
+ await setBreakpointButton.click();
+ await ionBreakpointDidChange.next();
+
+ const updatedBreakpoint = await modal.evaluate((el: HTMLIonModalElement) => el.getCurrentBreakpoint());
+
+ expect(updatedBreakpoint).toBe(0.5);
+ });
});
diff --git a/core/src/components/picker-internal/test/basic/picker-internal.e2e.ts b/core/src/components/picker-internal/test/basic/picker-internal.e2e.ts
index e14fc96dc1..cce0ec95d9 100644
--- a/core/src/components/picker-internal/test/basic/picker-internal.e2e.ts
+++ b/core/src/components/picker-internal/test/basic/picker-internal.e2e.ts
@@ -14,7 +14,7 @@ test.describe('picker-internal', () => {
test.describe('within overlay:', () => {
// TODO (FW-1397): Remove this test.skip when the issue is fixed.
- test.skip('Flaky test', 'Mobile Safari and Chrome on Linux renders the selected option incorrectly');
+ test.skip(true, 'Mobile Safari and Chrome on Linux renders the selected option incorrectly');
test('popover: should not have visual regression', async ({ page }) => {
await page.goto(`/src/components/picker-internal/test/basic`);
diff --git a/core/src/components/popover/test/arrow/e2e.ts b/core/src/components/popover/test/arrow/e2e.ts
deleted file mode 100644
index 6962564627..0000000000
--- a/core/src/components/popover/test/arrow/e2e.ts
+++ /dev/null
@@ -1,61 +0,0 @@
-import { newE2EPage } from '@stencil/core/testing';
-
-test('popover - arrow side: top', async () => {
- await testPopover('top', false);
-});
-
-test('popover - arrow side: right', async () => {
- await testPopover('right', false);
-});
-
-test('popover - arrow side: bottom', async () => {
- await testPopover('bottom', false);
-});
-
-test('popover - arrow side: left', async () => {
- await testPopover('left', false);
-});
-
-test('popover - arrow side: start', async () => {
- await testPopover('start', false);
-});
-
-test('popover - arrow side: end', async () => {
- await testPopover('end', false);
-});
-
-test('popover - arrow side: start, rtl', async () => {
- await testPopover('start', true);
-});
-
-test('popover - arrow side: end, rtl', async () => {
- await testPopover('end', true);
-});
-
-const testPopover = async (side: string, isRTL = false) => {
- const rtl = isRTL ? '&rtl=true' : '';
- const page = await newE2EPage({ url: `/src/components/popover/test/arrow?ionic:_testing=true${rtl}` });
-
- const POPOVER_CLASS = `${side}-popover`;
- const TRIGGER_ID = `${side}-trigger`;
- const screenshotCompares = [];
-
- const trigger = await page.find(`#${TRIGGER_ID}`);
-
- await page.evaluate((POPOVER_TRIGGER_ID) => {
- const popoverTrigger = document.querySelector(`#${POPOVER_TRIGGER_ID}`);
- popoverTrigger?.scrollIntoView({ block: 'center' });
- }, TRIGGER_ID);
-
- trigger.click();
-
- await page.waitForSelector(`.${POPOVER_CLASS}`);
- const popover = await page.find(`.${POPOVER_CLASS}`);
- await popover.waitForVisible();
-
- screenshotCompares.push(await page.compareScreenshot());
-
- for (const screenshotCompare of screenshotCompares) {
- expect(screenshotCompare).toMatchScreenshot();
- }
-};
diff --git a/core/src/components/popover/test/arrow/index.html b/core/src/components/popover/test/arrow/index.html
index d5db907e12..3586c78659 100644
--- a/core/src/components/popover/test/arrow/index.html
+++ b/core/src/components/popover/test/arrow/index.html
@@ -13,10 +13,13 @@