diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 7e9e602c77..10982df08c 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -12,4 +12,4 @@ # This should make it easy to add new rules without breaking existing ones. # Global owners -* @ionic-team/framework-core +* @ionic-team/framework diff --git a/CHANGELOG.md b/CHANGELOG.md index 3c2dd682be..20a4680454 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,25 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.2.8](https://github.com/ionic-team/ionic-framework/compare/v6.2.7...v6.2.8) (2022-09-21) + + +### Bug Fixes + +* **datetime:** account for 12AM with min times and 12 hour format ([#25952](https://github.com/ionic-team/ionic-framework/issues/25952)) ([55ebd6c](https://github.com/ionic-team/ionic-framework/commit/55ebd6cdf39c01b401e876b76e755bfa04db8f65)), closes [#25183](https://github.com/ionic-team/ionic-framework/issues/25183) +* **item:** show the highlight on iOS when --highlight-height is set ([#25905](https://github.com/ionic-team/ionic-framework/issues/25905)) ([d7db133](https://github.com/ionic-team/ionic-framework/commit/d7db1333f13834ecb447b4b1da62cfffed9fb333)) +* **overlays:** focus trapping no longer includes disabled elements ([#25949](https://github.com/ionic-team/ionic-framework/issues/25949)) ([6cb5827](https://github.com/ionic-team/ionic-framework/commit/6cb5827d069c255ab0a9a8c319aba9994a4c5196)) +* **overlays:** focus trapping no longer includes hidden elements ([#25948](https://github.com/ionic-team/ionic-framework/issues/25948)) ([5c10f98](https://github.com/ionic-team/ionic-framework/commit/5c10f98ceb3ae42d3363b38ba786b9122676a59c)) + + +### Performance Improvements + +* **card:** avoid force compositing on ios ([#25942](https://github.com/ionic-team/ionic-framework/issues/25942)) ([174c3b3](https://github.com/ionic-team/ionic-framework/commit/174c3b30a0bce7e7ab13e5605348ec107af69dd6)) + + + + + ## [6.2.7](https://github.com/ionic-team/ionic-framework/compare/v6.2.6...v6.2.7) (2022-09-14) diff --git a/angular/CHANGELOG.md b/angular/CHANGELOG.md index d0969035c3..05d62b85c6 100644 --- a/angular/CHANGELOG.md +++ b/angular/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.2.8](https://github.com/ionic-team/ionic/compare/v6.2.7...v6.2.8) (2022-09-21) + +**Note:** Version bump only for package @ionic/angular + + + + + ## [6.2.7](https://github.com/ionic-team/ionic/compare/v6.2.6...v6.2.7) (2022-09-14) diff --git a/angular/package-lock.json b/angular/package-lock.json index 4f04602415..2e9b578e75 100644 --- a/angular/package-lock.json +++ b/angular/package-lock.json @@ -1,15 +1,15 @@ { "name": "@ionic/angular", - "version": "6.2.7", + "version": "6.2.8", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/angular", - "version": "6.2.7", + "version": "6.2.8", "license": "MIT", "dependencies": { - "@ionic/core": "^6.2.7", + "@ionic/core": "^6.2.8", "jsonc-parser": "^3.0.0", "tslib": "^2.0.0" }, @@ -1023,9 +1023,9 @@ "dev": true }, "node_modules/@ionic/core": { - "version": "6.2.7", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.2.7.tgz", - "integrity": "sha512-pQWcIqr5zfCX5De/MQ9kFs+nhaPCr8HIh5QjmydxvmlLv6WU4vlny/Mg0y1+JwLE0qxPD0T9sMykawWH9e3y5Q==", + "version": "6.2.8", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.2.8.tgz", + "integrity": "sha512-tUUdvCPo9Z4RQXjvxNXBXQsVTFDAH2ju/HAhzZiAvdfwpHfpA39DWkXwAQeoV9gfFFblaOmCmeSq/8JP/FRn4A==", "dependencies": { "@stencil/core": "^2.17.4", "ionicons": "^6.0.3", @@ -7951,9 +7951,9 @@ "dev": true }, "@ionic/core": { - "version": "6.2.7", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.2.7.tgz", - "integrity": "sha512-pQWcIqr5zfCX5De/MQ9kFs+nhaPCr8HIh5QjmydxvmlLv6WU4vlny/Mg0y1+JwLE0qxPD0T9sMykawWH9e3y5Q==", + "version": "6.2.8", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.2.8.tgz", + "integrity": "sha512-tUUdvCPo9Z4RQXjvxNXBXQsVTFDAH2ju/HAhzZiAvdfwpHfpA39DWkXwAQeoV9gfFFblaOmCmeSq/8JP/FRn4A==", "requires": { "@stencil/core": "^2.17.4", "ionicons": "^6.0.3", diff --git a/angular/package.json b/angular/package.json index 84e0d220b8..5988dad017 100644 --- a/angular/package.json +++ b/angular/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/angular", - "version": "6.2.7", + "version": "6.2.8", "description": "Angular specific wrappers for @ionic/core", "keywords": [ "ionic", @@ -44,7 +44,7 @@ "validate": "npm i && npm run lint && npm run test && npm run build" }, "dependencies": { - "@ionic/core": "^6.2.7", + "@ionic/core": "^6.2.8", "jsonc-parser": "^3.0.0", "tslib": "^2.0.0" }, diff --git a/core/CHANGELOG.md b/core/CHANGELOG.md index 50e255da2a..28ac1530ff 100644 --- a/core/CHANGELOG.md +++ b/core/CHANGELOG.md @@ -3,6 +3,25 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.2.8](https://github.com/ionic-team/ionic/compare/v6.2.7...v6.2.8) (2022-09-21) + + +### Bug Fixes + +* **datetime:** account for 12AM with min times and 12 hour format ([#25952](https://github.com/ionic-team/ionic/issues/25952)) ([55ebd6c](https://github.com/ionic-team/ionic/commit/55ebd6cdf39c01b401e876b76e755bfa04db8f65)), closes [#25183](https://github.com/ionic-team/ionic/issues/25183) +* **item:** show the highlight on iOS when --highlight-height is set ([#25905](https://github.com/ionic-team/ionic/issues/25905)) ([d7db133](https://github.com/ionic-team/ionic/commit/d7db1333f13834ecb447b4b1da62cfffed9fb333)) +* **overlays:** focus trapping no longer includes disabled elements ([#25949](https://github.com/ionic-team/ionic/issues/25949)) ([6cb5827](https://github.com/ionic-team/ionic/commit/6cb5827d069c255ab0a9a8c319aba9994a4c5196)) +* **overlays:** focus trapping no longer includes hidden elements ([#25948](https://github.com/ionic-team/ionic/issues/25948)) ([5c10f98](https://github.com/ionic-team/ionic/commit/5c10f98ceb3ae42d3363b38ba786b9122676a59c)) + + +### Performance Improvements + +* **card:** avoid force compositing on ios ([#25942](https://github.com/ionic-team/ionic/issues/25942)) ([174c3b3](https://github.com/ionic-team/ionic/commit/174c3b30a0bce7e7ab13e5605348ec107af69dd6)) + + + + + ## [6.2.7](https://github.com/ionic-team/ionic/compare/v6.2.6...v6.2.7) (2022-09-14) diff --git a/core/package-lock.json b/core/package-lock.json index 40dc48fec6..e49ebffd95 100644 --- a/core/package-lock.json +++ b/core/package-lock.json @@ -1,12 +1,12 @@ { "name": "@ionic/core", - "version": "6.2.7", + "version": "6.2.8", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/core", - "version": "6.2.7", + "version": "6.2.8", "license": "MIT", "dependencies": { "@stencil/core": "^2.17.4", diff --git a/core/package.json b/core/package.json index 2cdba75f71..06916fd7e0 100644 --- a/core/package.json +++ b/core/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/core", - "version": "6.2.7", + "version": "6.2.8", "description": "Base components for Ionic", "keywords": [ "ionic", diff --git a/core/src/components/card-header/test/basic/card-header.e2e.ts b/core/src/components/card-header/test/basic/card-header.e2e.ts new file mode 100644 index 0000000000..d6fc201cc4 --- /dev/null +++ b/core/src/components/card-header/test/basic/card-header.e2e.ts @@ -0,0 +1,12 @@ +import { expect } from '@playwright/test'; +import { test } from '@utils/test/playwright'; + +test.describe('card-header: basic', () => { + test('should not have visual regressions', async ({ page }) => { + await page.goto(`/src/components/card-header/test/basic`); + + await page.setIonViewport(); + + expect(await page.screenshot()).toMatchSnapshot(`card-header-diff-${page.getSnapshotSettings()}.png`); + }); +}); diff --git a/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-ios-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..74e875880d Binary files /dev/null and b/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-ios-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..8331647057 Binary files /dev/null and b/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-ios-ltr-Mobile-Safari-linux.png b/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-ios-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..cb149d3dd0 Binary files /dev/null and b/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-ios-rtl-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..d5328957f4 Binary files /dev/null and b/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-ios-rtl-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..c229d3a2b2 Binary files /dev/null and b/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-ios-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-ios-rtl-Mobile-Safari-linux.png b/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-ios-rtl-Mobile-Safari-linux.png new file mode 100644 index 0000000000..4eb414cc60 Binary files /dev/null and b/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-md-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..593c6ad5db Binary files /dev/null and b/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-md-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..1722e4754e Binary files /dev/null and b/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-md-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..0697f260b4 Binary files /dev/null and b/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-md-rtl-Mobile-Chrome-linux.png b/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-md-rtl-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..198b57a5e5 Binary files /dev/null and b/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-md-rtl-Mobile-Firefox-linux.png b/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-md-rtl-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..ec907f2db3 Binary files /dev/null and b/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-md-rtl-Mobile-Safari-linux.png b/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-md-rtl-Mobile-Safari-linux.png new file mode 100644 index 0000000000..85e7198271 Binary files /dev/null and b/core/src/components/card-header/test/basic/card-header.e2e.ts-snapshots/card-header-diff-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/card-header/test/basic/e2e.ts b/core/src/components/card-header/test/basic/e2e.ts deleted file mode 100644 index fd30428b4e..0000000000 --- a/core/src/components/card-header/test/basic/e2e.ts +++ /dev/null @@ -1,10 +0,0 @@ -import { newE2EPage } from '@stencil/core/testing'; - -test('card-header: basic', async () => { - const page = await newE2EPage({ - url: '/src/components/card-header/test/basic?ionic:_testing=true', - }); - - const compare = await page.compareScreenshot(); - expect(compare).toMatchScreenshot(); -}); diff --git a/core/src/components/card-header/test/basic/index.html b/core/src/components/card-header/test/basic/index.html index 787bc186ec..9002435635 100644 --- a/core/src/components/card-header/test/basic/index.html +++ b/core/src/components/card-header/test/basic/index.html @@ -47,14 +47,6 @@ Custom background, color=secondary on ion-card-header - - - - Card Subtitle - Card Title - - color=danger on ion-card-header - - - diff --git a/core/src/components/fab/test/basic/e2e.ts b/core/src/components/fab/test/basic/e2e.ts deleted file mode 100644 index 520cf1fc4c..0000000000 --- a/core/src/components/fab/test/basic/e2e.ts +++ /dev/null @@ -1,17 +0,0 @@ -import { testDisabledFab, testFab } from '../test.utils'; - -test('fab: basic', async () => { - await testFab('basic', '#fab1'); -}); - -test('fab:rtl: basic', async () => { - await testFab('basic', '#fab1', true); -}); - -test('fab: disabled', async () => { - await testDisabledFab('basic', '#fab2'); -}); - -test('fab:rtl: disabled', async () => { - await testDisabledFab('basic', '#fab2', true); -}); diff --git a/core/src/components/fab/test/basic/fab.e2e.ts b/core/src/components/fab/test/basic/fab.e2e.ts new file mode 100644 index 0000000000..2fe3836dbb --- /dev/null +++ b/core/src/components/fab/test/basic/fab.e2e.ts @@ -0,0 +1,72 @@ +import { expect } from '@playwright/test'; +import { test } from '@utils/test/playwright'; + +test.describe('fab: basic (visual checks)', () => { + test.beforeEach(async ({ page }) => { + await page.goto(`/src/components/fab/test/basic`); + }); + + test('should not have visual regressions', async ({ page }) => { + await page.setIonViewport(); + + expect(await page.screenshot()).toMatchSnapshot(`fab-basic-${page.getSnapshotSettings()}.png`); + }); + + test('should not have visual regressions when open', async ({ page }) => { + // this fab has multiple buttons on each side, so it covers all the bases + const fab = page.locator('#fab5'); + + await fab.click(); + await page.waitForChanges(); + + /** + * fab.screenshot doesn't work since ion-fab's bounding box only covers the + * central button. This viewport size crops extra white space while also + * containing all the buttons in the open fab. + */ + await page.setViewportSize({ + width: 320, + height: 415, + }); + + expect(await page.screenshot()).toMatchSnapshot(`fab-open-${page.getSnapshotSettings()}.png`); + }); +}); + +test.describe('fab: basic (functionality checks)', () => { + test.beforeEach(async ({ page, skip }) => { + skip.rtl(); + skip.mode('ios'); + + await page.goto(`/src/components/fab/test/basic`); + }); + + test('should toggle active state when clicked', async ({ page }) => { + const fab = page.locator('#fab1'); + const fabList = fab.locator('ion-fab-list'); + + expect(fabList).not.toHaveClass(/fab-list-active/); + + // open fab + await fab.click(); + await page.waitForChanges(); + expect(fabList).toHaveClass(/fab-list-active/); + + // close fab + await fab.click(); + await page.waitForChanges(); + expect(fabList).not.toHaveClass(/fab-list-active/); + }); + + test('should not open when disabled', async ({ page }) => { + const fab = page.locator('#fab2'); + const fabList = fab.locator('ion-fab-list'); + + expect(fabList).not.toHaveClass(/fab-list-active/); + + // attempt to open fab + await fab.click(); + await page.waitForChanges(); + expect(fabList).not.toHaveClass(/fab-list-active/); + }); +}); diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..a17c5f719c Binary files /dev/null and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..2eaa929c40 Binary files /dev/null and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-ltr-Mobile-Safari-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..6765a30791 Binary files /dev/null and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-rtl-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..605357fdcb Binary files /dev/null and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-rtl-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..a7ec1b6393 Binary files /dev/null and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-rtl-Mobile-Safari-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-rtl-Mobile-Safari-linux.png new file mode 100644 index 0000000000..156cc0aec8 Binary files /dev/null and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-md-ltr-Mobile-Chrome-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-md-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..1cb0d16630 Binary files /dev/null and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-md-ltr-Mobile-Firefox-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-md-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..32f03edcdc Binary files /dev/null and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-md-ltr-Mobile-Safari-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-md-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..cf149b71cf Binary files /dev/null and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-md-rtl-Mobile-Chrome-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-md-rtl-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..a4b2dc12d1 Binary files /dev/null and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-md-rtl-Mobile-Firefox-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-md-rtl-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..1971d4f22c Binary files /dev/null and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-md-rtl-Mobile-Safari-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-md-rtl-Mobile-Safari-linux.png new file mode 100644 index 0000000000..1adf87b85d Binary files /dev/null and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-basic-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-ios-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..956bb4077b Binary files /dev/null and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-ios-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..8d4024a653 Binary files /dev/null and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-ios-ltr-Mobile-Safari-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-ios-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..a87d140a85 Binary files /dev/null and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-ios-rtl-Mobile-Chrome-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-ios-rtl-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..f700c9027b Binary files /dev/null and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-ios-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-ios-rtl-Mobile-Firefox-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-ios-rtl-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..f5f39513f3 Binary files /dev/null and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-ios-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-ios-rtl-Mobile-Safari-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-ios-rtl-Mobile-Safari-linux.png new file mode 100644 index 0000000000..bb948a8734 Binary files /dev/null and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-ios-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-md-ltr-Mobile-Chrome-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-md-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..d67f22f8f3 Binary files /dev/null and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-md-ltr-Mobile-Firefox-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-md-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..5d91e45899 Binary files /dev/null and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-md-ltr-Mobile-Safari-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-md-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..76f96dac2a Binary files /dev/null and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-md-rtl-Mobile-Chrome-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-md-rtl-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..c4abb5511b Binary files /dev/null and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-md-rtl-Mobile-Chrome-linux.png differ diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-md-rtl-Mobile-Firefox-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-md-rtl-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..ff8f9822ac Binary files /dev/null and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-md-rtl-Mobile-Firefox-linux.png differ diff --git a/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-md-rtl-Mobile-Safari-linux.png b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-md-rtl-Mobile-Safari-linux.png new file mode 100644 index 0000000000..bd09b95ed6 Binary files /dev/null and b/core/src/components/fab/test/basic/fab.e2e.ts-snapshots/fab-open-md-rtl-Mobile-Safari-linux.png differ diff --git a/core/src/components/fab/test/basic/index.html b/core/src/components/fab/test/basic/index.html index 1d7baa61c3..731164625c 100644 --- a/core/src/components/fab/test/basic/index.html +++ b/core/src/components/fab/test/basic/index.html @@ -26,117 +26,108 @@ - 
log
Test FAB - + - + - + - + - + - - - + + + - + - + - + - + - + - + - + - + - - - - - - - - - - - - - - - - - - - - - + - + - + - - - - - - - - + - - + + + + + + + + + + + + + + + + + + + + + - + @@ -157,28 +148,10 @@ referenceNode.parentNode.insertBefore(el, referenceNode.nextSibling); } - function insertLog(message) { - console.log(message); - var el = document.querySelector('#log'); - const oldHTML = el.innerHTML; - el.innerHTML = oldHTML + '\n' + message; - } - function add() { var newEle = document.createElement('f'); var ref = document.querySelector('f'); insertAfter(newEle, ref); - insertLog('add'); - } - - function clickMainFAB(container) { - let message = 'Clicked open social menu'; - insertLog(message); - } - - function openSocial(network, container) { - let message = 'Share in ' + network; - insertLog(message); } function closeLists() { diff --git a/core/src/components/fab/test/standalone/e2e.ts b/core/src/components/fab/test/standalone/e2e.ts deleted file mode 100644 index 72229cd2bd..0000000000 --- a/core/src/components/fab/test/standalone/e2e.ts +++ /dev/null @@ -1,10 +0,0 @@ -import { newE2EPage } from '@stencil/core/testing'; - -test('fab: standalone', async () => { - const page = await newE2EPage({ - url: '/src/components/fab/test/standalone?ionic:_testing=true', - }); - - const compare = await page.compareScreenshot(); - expect(compare).toMatchScreenshot(); -}); diff --git a/core/src/components/fab/test/standalone/index.html b/core/src/components/fab/test/standalone/index.html deleted file mode 100644 index 0d7e778c6a..0000000000 --- a/core/src/components/fab/test/standalone/index.html +++ /dev/null @@ -1,78 +0,0 @@ - - - - - Floating Action Button - Standalone - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/core/src/components/fab/test/states/e2e.ts b/core/src/components/fab/test/states/e2e.ts deleted file mode 100644 index f824ad315d..0000000000 --- a/core/src/components/fab/test/states/e2e.ts +++ /dev/null @@ -1,10 +0,0 @@ -import { newE2EPage } from '@stencil/core/testing'; - -test('fab: states', async () => { - const page = await newE2EPage({ - url: '/src/components/fab/test/states?ionic:_testing=true', - }); - - const compare = await page.compareScreenshot(); - expect(compare).toMatchScreenshot(); -}); diff --git a/core/src/components/fab/test/states/fab.e2e.ts b/core/src/components/fab/test/states/fab.e2e.ts new file mode 100644 index 0000000000..20d07067b6 --- /dev/null +++ b/core/src/components/fab/test/states/fab.e2e.ts @@ -0,0 +1,11 @@ +import { expect } from '@playwright/test'; +import { test } from '@utils/test/playwright'; + +test('should not have visual regressions', async ({ page, skip }) => { + skip.rtl(); + await page.goto(`/src/components/fab/test/states`); + + await page.setIonViewport(); + + expect(await page.screenshot()).toMatchSnapshot(`fab-states-${page.getSnapshotSettings()}.png`); +}); diff --git a/core/src/components/fab/test/states/fab.e2e.ts-snapshots/fab-states-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/fab/test/states/fab.e2e.ts-snapshots/fab-states-ios-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..81b8580667 Binary files /dev/null and b/core/src/components/fab/test/states/fab.e2e.ts-snapshots/fab-states-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/fab/test/states/fab.e2e.ts-snapshots/fab-states-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/fab/test/states/fab.e2e.ts-snapshots/fab-states-ios-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..f08a04f46a Binary files /dev/null and b/core/src/components/fab/test/states/fab.e2e.ts-snapshots/fab-states-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/fab/test/states/fab.e2e.ts-snapshots/fab-states-ios-ltr-Mobile-Safari-linux.png b/core/src/components/fab/test/states/fab.e2e.ts-snapshots/fab-states-ios-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..86bdac5140 Binary files /dev/null and b/core/src/components/fab/test/states/fab.e2e.ts-snapshots/fab-states-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/fab/test/states/fab.e2e.ts-snapshots/fab-states-md-ltr-Mobile-Chrome-linux.png b/core/src/components/fab/test/states/fab.e2e.ts-snapshots/fab-states-md-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..b1e91e102d Binary files /dev/null and b/core/src/components/fab/test/states/fab.e2e.ts-snapshots/fab-states-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/fab/test/states/fab.e2e.ts-snapshots/fab-states-md-ltr-Mobile-Firefox-linux.png b/core/src/components/fab/test/states/fab.e2e.ts-snapshots/fab-states-md-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..f8e9cffbf2 Binary files /dev/null and b/core/src/components/fab/test/states/fab.e2e.ts-snapshots/fab-states-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/fab/test/states/fab.e2e.ts-snapshots/fab-states-md-ltr-Mobile-Safari-linux.png b/core/src/components/fab/test/states/fab.e2e.ts-snapshots/fab-states-md-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..602c825495 Binary files /dev/null and b/core/src/components/fab/test/states/fab.e2e.ts-snapshots/fab-states-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/fab/test/states/index.html b/core/src/components/fab/test/states/index.html index 9724f5efc0..9ba0a63690 100644 --- a/core/src/components/fab/test/states/index.html +++ b/core/src/components/fab/test/states/index.html @@ -17,26 +17,6 @@ - - - - - - - - - - - - - - - - - - - -

Default

@@ -169,18 +149,6 @@ - - - - diff --git a/core/src/components/picker-internal/picker-internal.tsx b/core/src/components/picker-internal/picker-internal.tsx index 4cde38426a..ae91d97845 100644 --- a/core/src/components/picker-internal/picker-internal.tsx +++ b/core/src/components/picker-internal/picker-internal.tsx @@ -1,5 +1,5 @@ import type { ComponentInterface, EventEmitter } from '@stencil/core'; -import { Component, Element, Event, Host, h } from '@stencil/core'; +import { Component, Element, Event, Listen, Host, h } from '@stencil/core'; import { getElementRoot } from '../../utils/helpers'; @@ -30,6 +30,19 @@ export class PickerInternal implements ComponentInterface { @Event() ionInputModeChange!: EventEmitter; + /** + * When the picker is interacted with + * we need to prevent touchstart so other + * gestures do not fire. For example, + * scrolling on the wheel picker + * in ion-datetime should not cause + * a card modal to swipe to close. + */ + @Listen('touchstart') + preventTouchStartPropagation(ev: TouchEvent) { + ev.stopPropagation(); + } + componentWillLoad() { getElementRoot(this.el).addEventListener('focusin', this.onFocusIn); getElementRoot(this.el).addEventListener('focusout', this.onFocusOut); diff --git a/core/src/utils/animation/animation-utils.ts b/core/src/utils/animation/animation-utils.ts index 2779426bcb..a51ff277a5 100644 --- a/core/src/utils/animation/animation-utils.ts +++ b/core/src/utils/animation/animation-utils.ts @@ -114,7 +114,8 @@ export const generateKeyframeName = (keyframeRules: string) => { }; export const getStyleContainer = (element: HTMLElement) => { - const rootNode = element.getRootNode() as any; + // getRootNode is not always available in SSR environments. + const rootNode = element.getRootNode !== undefined ? (element.getRootNode() as any) : element; return rootNode.head || rootNode; }; diff --git a/core/src/utils/animation/animation.ts b/core/src/utils/animation/animation.ts index a426952730..25a866a5de 100644 --- a/core/src/utils/animation/animation.ts +++ b/core/src/utils/animation/animation.ts @@ -1,4 +1,5 @@ import { raf } from '../helpers'; +import { win } from '../window'; import type { Animation, @@ -83,7 +84,8 @@ export const createAnimation = (animationId?: string): Animation => { const _afterAddWriteFunctions: any[] = []; const webAnimations: any[] = []; const supportsAnimationEffect = - typeof (AnimationEffect as any) === 'function' || typeof (window as any).AnimationEffect === 'function'; + typeof (AnimationEffect as any) === 'function' || + (win !== undefined && typeof (win as any).AnimationEffect === 'function'); const supportsWebAnimations = typeof (Element as any) === 'function' && typeof (Element as any).prototype!.animate === 'function' && diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 2da4924ba3..92f6a60277 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.2.8](https://github.com/ionic-team/ionic-docs/compare/v6.2.7...v6.2.8) (2022-09-21) + +**Note:** Version bump only for package @ionic/docs + + + + + ## [6.2.7](https://github.com/ionic-team/ionic-docs/compare/v6.2.6...v6.2.7) (2022-09-14) **Note:** Version bump only for package @ionic/docs diff --git a/docs/package-lock.json b/docs/package-lock.json index 16ac4ec9f1..a22e6cb68a 100644 --- a/docs/package-lock.json +++ b/docs/package-lock.json @@ -1,12 +1,12 @@ { "name": "@ionic/docs", - "version": "6.2.7", + "version": "6.2.8", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/docs", - "version": "6.2.7", + "version": "6.2.8", "license": "MIT" } } diff --git a/docs/package.json b/docs/package.json index c51982c7de..1c0fc4abf9 100644 --- a/docs/package.json +++ b/docs/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/docs", - "version": "6.2.7", + "version": "6.2.8", "description": "Pre-packaged API documentation for the Ionic docs.", "main": "core.json", "types": "core.d.ts", diff --git a/lerna.json b/lerna.json index 5145c686e1..502f83637f 100644 --- a/lerna.json +++ b/lerna.json @@ -5,5 +5,5 @@ "angular", "packages/*" ], - "version": "6.2.7" + "version": "6.2.8" } diff --git a/packages/angular-server/CHANGELOG.md b/packages/angular-server/CHANGELOG.md index 2353a524e1..40d26665d0 100644 --- a/packages/angular-server/CHANGELOG.md +++ b/packages/angular-server/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.2.8](https://github.com/ionic-team/ionic/compare/v6.2.7...v6.2.8) (2022-09-21) + +**Note:** Version bump only for package @ionic/angular-server + + + + + ## [6.2.7](https://github.com/ionic-team/ionic/compare/v6.2.6...v6.2.7) (2022-09-14) **Note:** Version bump only for package @ionic/angular-server diff --git a/packages/angular-server/package-lock.json b/packages/angular-server/package-lock.json index 2527b8aab8..6be1b22945 100644 --- a/packages/angular-server/package-lock.json +++ b/packages/angular-server/package-lock.json @@ -1,12 +1,12 @@ { "name": "@ionic/angular-server", - "version": "6.2.7", + "version": "6.2.8", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/angular-server", - "version": "6.2.7", + "version": "6.2.8", "license": "MIT", "devDependencies": { "@angular-eslint/eslint-plugin": "^12.6.1", @@ -18,7 +18,7 @@ "@angular/platform-browser": "^12.0.0", "@angular/platform-browser-dynamic": "^12.2.10", "@angular/platform-server": "^12.0.0", - "@ionic/core": "^6.2.7", + "@ionic/core": "^6.2.8", "@ionic/eslint-config": "^0.3.0", "@ionic/prettier-config": "^2.0.0", "@typescript-eslint/eslint-plugin": "^5.2.0", @@ -786,9 +786,9 @@ "license": "BSD-3-Clause" }, "node_modules/@ionic/core": { - "version": "6.2.7", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.2.7.tgz", - "integrity": "sha512-pQWcIqr5zfCX5De/MQ9kFs+nhaPCr8HIh5QjmydxvmlLv6WU4vlny/Mg0y1+JwLE0qxPD0T9sMykawWH9e3y5Q==", + "version": "6.2.8", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.2.8.tgz", + "integrity": "sha512-tUUdvCPo9Z4RQXjvxNXBXQsVTFDAH2ju/HAhzZiAvdfwpHfpA39DWkXwAQeoV9gfFFblaOmCmeSq/8JP/FRn4A==", "dev": true, "dependencies": { "@stencil/core": "^2.17.4", @@ -7116,9 +7116,9 @@ "dev": true }, "@ionic/core": { - "version": "6.2.7", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.2.7.tgz", - "integrity": "sha512-pQWcIqr5zfCX5De/MQ9kFs+nhaPCr8HIh5QjmydxvmlLv6WU4vlny/Mg0y1+JwLE0qxPD0T9sMykawWH9e3y5Q==", + "version": "6.2.8", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.2.8.tgz", + "integrity": "sha512-tUUdvCPo9Z4RQXjvxNXBXQsVTFDAH2ju/HAhzZiAvdfwpHfpA39DWkXwAQeoV9gfFFblaOmCmeSq/8JP/FRn4A==", "dev": true, "requires": { "@stencil/core": "^2.17.4", diff --git a/packages/angular-server/package.json b/packages/angular-server/package.json index 72e9920a27..6aafc41ce9 100644 --- a/packages/angular-server/package.json +++ b/packages/angular-server/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/angular-server", - "version": "6.2.7", + "version": "6.2.8", "description": "Angular SSR Module for Ionic", "keywords": [ "ionic", @@ -56,7 +56,7 @@ "@angular/platform-browser": "^12.0.0", "@angular/platform-browser-dynamic": "^12.2.10", "@angular/platform-server": "^12.0.0", - "@ionic/core": "^6.2.7", + "@ionic/core": "^6.2.8", "@ionic/eslint-config": "^0.3.0", "@ionic/prettier-config": "^2.0.0", "@typescript-eslint/eslint-plugin": "^5.2.0", diff --git a/packages/react-router/CHANGELOG.md b/packages/react-router/CHANGELOG.md index dec8261a5f..987ca1ce9d 100644 --- a/packages/react-router/CHANGELOG.md +++ b/packages/react-router/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.2.8](https://github.com/ionic-team/ionic/compare/v6.2.7...v6.2.8) (2022-09-21) + +**Note:** Version bump only for package @ionic/react-router + + + + + ## [6.2.7](https://github.com/ionic-team/ionic/compare/v6.2.6...v6.2.7) (2022-09-14) **Note:** Version bump only for package @ionic/react-router diff --git a/packages/react-router/package-lock.json b/packages/react-router/package-lock.json index 2a264ea039..7f3dea62f6 100644 --- a/packages/react-router/package-lock.json +++ b/packages/react-router/package-lock.json @@ -1,15 +1,15 @@ { "name": "@ionic/react-router", - "version": "6.2.7", + "version": "6.2.8", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/react-router", - "version": "6.2.7", + "version": "6.2.8", "license": "MIT", "dependencies": { - "@ionic/react": "^6.2.7", + "@ionic/react": "^6.2.8", "tslib": "*" }, "devDependencies": { @@ -147,9 +147,9 @@ } }, "node_modules/@ionic/core": { - "version": "6.2.7", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.2.7.tgz", - "integrity": "sha512-pQWcIqr5zfCX5De/MQ9kFs+nhaPCr8HIh5QjmydxvmlLv6WU4vlny/Mg0y1+JwLE0qxPD0T9sMykawWH9e3y5Q==", + "version": "6.2.8", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.2.8.tgz", + "integrity": "sha512-tUUdvCPo9Z4RQXjvxNXBXQsVTFDAH2ju/HAhzZiAvdfwpHfpA39DWkXwAQeoV9gfFFblaOmCmeSq/8JP/FRn4A==", "dependencies": { "@stencil/core": "^2.17.4", "ionicons": "^6.0.3", @@ -157,11 +157,11 @@ } }, "node_modules/@ionic/react": { - "version": "6.2.7", - "resolved": "https://registry.npmjs.org/@ionic/react/-/react-6.2.7.tgz", - "integrity": "sha512-tw0yG2zcYqmCqlRvEMx0iipuvSrkEysdyv8K6pyy455uAfRUfY/fQ/wD/HBIvJD8bIDVjynUql7tA1IY6ZGA2g==", + "version": "6.2.8", + "resolved": "https://registry.npmjs.org/@ionic/react/-/react-6.2.8.tgz", + "integrity": "sha512-pW2ZQx4/PYIpLObPywqQrrYoiGXdVANnJcauY3RLi4xvY7yWxUCLOuQEV5oXG0g8QRNTQuXWo/JiC3f0aNHupg==", "dependencies": { - "@ionic/core": "^6.2.7", + "@ionic/core": "^6.2.8", "ionicons": "^6.0.2", "tslib": "*" }, @@ -1157,9 +1157,9 @@ } }, "@ionic/core": { - "version": "6.2.7", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.2.7.tgz", - "integrity": "sha512-pQWcIqr5zfCX5De/MQ9kFs+nhaPCr8HIh5QjmydxvmlLv6WU4vlny/Mg0y1+JwLE0qxPD0T9sMykawWH9e3y5Q==", + "version": "6.2.8", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.2.8.tgz", + "integrity": "sha512-tUUdvCPo9Z4RQXjvxNXBXQsVTFDAH2ju/HAhzZiAvdfwpHfpA39DWkXwAQeoV9gfFFblaOmCmeSq/8JP/FRn4A==", "requires": { "@stencil/core": "^2.17.4", "ionicons": "^6.0.3", @@ -1167,11 +1167,11 @@ } }, "@ionic/react": { - "version": "6.2.7", - "resolved": "https://registry.npmjs.org/@ionic/react/-/react-6.2.7.tgz", - "integrity": "sha512-tw0yG2zcYqmCqlRvEMx0iipuvSrkEysdyv8K6pyy455uAfRUfY/fQ/wD/HBIvJD8bIDVjynUql7tA1IY6ZGA2g==", + "version": "6.2.8", + "resolved": "https://registry.npmjs.org/@ionic/react/-/react-6.2.8.tgz", + "integrity": "sha512-pW2ZQx4/PYIpLObPywqQrrYoiGXdVANnJcauY3RLi4xvY7yWxUCLOuQEV5oXG0g8QRNTQuXWo/JiC3f0aNHupg==", "requires": { - "@ionic/core": "^6.2.7", + "@ionic/core": "^6.2.8", "ionicons": "^6.0.2", "tslib": "*" } diff --git a/packages/react-router/package.json b/packages/react-router/package.json index e2077f7132..64a92236ee 100644 --- a/packages/react-router/package.json +++ b/packages/react-router/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/react-router", - "version": "6.2.7", + "version": "6.2.8", "description": "React Router wrapper for @ionic/react", "keywords": [ "ionic", @@ -37,7 +37,7 @@ "dist/" ], "dependencies": { - "@ionic/react": "^6.2.7", + "@ionic/react": "^6.2.8", "tslib": "*" }, "peerDependencies": { diff --git a/packages/react/CHANGELOG.md b/packages/react/CHANGELOG.md index 395715ef55..25ca0c905b 100644 --- a/packages/react/CHANGELOG.md +++ b/packages/react/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.2.8](https://github.com/ionic-team/ionic/compare/v6.2.7...v6.2.8) (2022-09-21) + +**Note:** Version bump only for package @ionic/react + + + + + ## [6.2.7](https://github.com/ionic-team/ionic/compare/v6.2.6...v6.2.7) (2022-09-14) diff --git a/packages/react/package-lock.json b/packages/react/package-lock.json index a9c8b9d414..96edb9193e 100644 --- a/packages/react/package-lock.json +++ b/packages/react/package-lock.json @@ -1,15 +1,15 @@ { "name": "@ionic/react", - "version": "6.2.7", + "version": "6.2.8", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/react", - "version": "6.2.7", + "version": "6.2.8", "license": "MIT", "dependencies": { - "@ionic/core": "^6.2.7", + "@ionic/core": "^6.2.8", "ionicons": "^6.0.2", "tslib": "*" }, @@ -607,9 +607,9 @@ } }, "node_modules/@ionic/core": { - "version": "6.2.7", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.2.7.tgz", - "integrity": "sha512-pQWcIqr5zfCX5De/MQ9kFs+nhaPCr8HIh5QjmydxvmlLv6WU4vlny/Mg0y1+JwLE0qxPD0T9sMykawWH9e3y5Q==", + "version": "6.2.8", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.2.8.tgz", + "integrity": "sha512-tUUdvCPo9Z4RQXjvxNXBXQsVTFDAH2ju/HAhzZiAvdfwpHfpA39DWkXwAQeoV9gfFFblaOmCmeSq/8JP/FRn4A==", "dependencies": { "@stencil/core": "^2.17.4", "ionicons": "^6.0.3", @@ -9534,9 +9534,9 @@ } }, "@ionic/core": { - "version": "6.2.7", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.2.7.tgz", - "integrity": "sha512-pQWcIqr5zfCX5De/MQ9kFs+nhaPCr8HIh5QjmydxvmlLv6WU4vlny/Mg0y1+JwLE0qxPD0T9sMykawWH9e3y5Q==", + "version": "6.2.8", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.2.8.tgz", + "integrity": "sha512-tUUdvCPo9Z4RQXjvxNXBXQsVTFDAH2ju/HAhzZiAvdfwpHfpA39DWkXwAQeoV9gfFFblaOmCmeSq/8JP/FRn4A==", "requires": { "@stencil/core": "^2.17.4", "ionicons": "^6.0.3", diff --git a/packages/react/package.json b/packages/react/package.json index 4b72810b0e..7324159fa5 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/react", - "version": "6.2.7", + "version": "6.2.8", "description": "React specific wrapper for @ionic/core", "keywords": [ "ionic", @@ -41,7 +41,7 @@ "css/" ], "dependencies": { - "@ionic/core": "^6.2.7", + "@ionic/core": "^6.2.8", "ionicons": "^6.0.2", "tslib": "*" }, diff --git a/packages/react/src/components/IonAlert.tsx b/packages/react/src/components/IonAlert.tsx index f7b5acd30c..4f9ada9995 100644 --- a/packages/react/src/components/IonAlert.tsx +++ b/packages/react/src/components/IonAlert.tsx @@ -1,10 +1,10 @@ import { AlertOptions, alertController } from '@ionic/core/components'; -import { IonAlert as IonAlertCmp } from '@ionic/core/components/ion-alert.js'; +import { defineCustomElement } from '@ionic/core/components/ion-alert.js'; import { createControllerComponent } from './createControllerComponent'; export const IonAlert = /*@__PURE__*/ createControllerComponent( 'ion-alert', alertController, - IonAlertCmp + defineCustomElement ); diff --git a/packages/react/src/components/IonLoading.tsx b/packages/react/src/components/IonLoading.tsx index 0d4ab8150a..11528b7346 100644 --- a/packages/react/src/components/IonLoading.tsx +++ b/packages/react/src/components/IonLoading.tsx @@ -1,9 +1,9 @@ import { LoadingOptions, loadingController } from '@ionic/core/components'; -import { IonLoading as IonLoadingCmp } from '@ionic/core/components/ion-loading.js'; +import { defineCustomElement } from '@ionic/core/components/ion-loading.js'; import { createControllerComponent } from './createControllerComponent'; export const IonLoading = /*@__PURE__*/ createControllerComponent< LoadingOptions, HTMLIonLoadingElement ->('ion-loading', loadingController, IonLoadingCmp); +>('ion-loading', loadingController, defineCustomElement); diff --git a/packages/react/src/components/IonPicker.tsx b/packages/react/src/components/IonPicker.tsx index d2ee074ba0..ce575bfe9f 100644 --- a/packages/react/src/components/IonPicker.tsx +++ b/packages/react/src/components/IonPicker.tsx @@ -1,9 +1,9 @@ import { PickerOptions, pickerController } from '@ionic/core/components'; -import { IonPicker as IonPickerCmp } from '@ionic/core/components/ion-picker.js'; +import { defineCustomElement } from '@ionic/core/components/ion-picker.js'; import { createControllerComponent } from './createControllerComponent'; export const IonPicker = /*@__PURE__*/ createControllerComponent< PickerOptions, HTMLIonPickerElement ->('ion-picker', pickerController, IonPickerCmp); +>('ion-picker', pickerController, defineCustomElement); diff --git a/packages/react/src/components/IonToast.tsx b/packages/react/src/components/IonToast.tsx index 0c5fbf2b00..7c5f96eb84 100644 --- a/packages/react/src/components/IonToast.tsx +++ b/packages/react/src/components/IonToast.tsx @@ -3,7 +3,7 @@ import { ToastOptions as ToastOptionsCore, toastController as toastControllerCore, } from '@ionic/core/components'; -import { IonToast as IonToastCmp } from '@ionic/core/components/ion-toast.js'; +import { defineCustomElement } from '@ionic/core/components/ion-toast.js'; import { createControllerComponent } from './createControllerComponent'; @@ -30,5 +30,5 @@ const toastController = { export const IonToast = /*@__PURE__*/ createControllerComponent( 'ion-toast', toastController, - IonToastCmp + defineCustomElement ); diff --git a/packages/react/src/components/createControllerComponent.tsx b/packages/react/src/components/createControllerComponent.tsx index 4f3dc6d82c..11f6bb8068 100644 --- a/packages/react/src/components/createControllerComponent.tsx +++ b/packages/react/src/components/createControllerComponent.tsx @@ -4,7 +4,6 @@ import React from 'react'; import { attachProps, dashToPascalCase, - defineCustomElement, setRef, } from './react-component-lib/utils'; @@ -27,9 +26,11 @@ export const createControllerComponent = < >( tagName: string, controller: { create: (options: OptionsType) => Promise }, - customElement?: any + defineCustomElement?: () => void ) => { - defineCustomElement(tagName, customElement); + if (defineCustomElement) { + defineCustomElement(); + } const displayName = dashToPascalCase(tagName); const didDismissEventName = `on${displayName}DidDismiss`; diff --git a/packages/vue-router/CHANGELOG.md b/packages/vue-router/CHANGELOG.md index c84b19e95c..388d51b954 100644 --- a/packages/vue-router/CHANGELOG.md +++ b/packages/vue-router/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.2.8](https://github.com/ionic-team/ionic/compare/v6.2.7...v6.2.8) (2022-09-21) + +**Note:** Version bump only for package @ionic/vue-router + + + + + ## [6.2.7](https://github.com/ionic-team/ionic/compare/v6.2.6...v6.2.7) (2022-09-14) **Note:** Version bump only for package @ionic/vue-router diff --git a/packages/vue-router/package-lock.json b/packages/vue-router/package-lock.json index 4f9d8bf240..0612286a8e 100644 --- a/packages/vue-router/package-lock.json +++ b/packages/vue-router/package-lock.json @@ -1,15 +1,15 @@ { "name": "@ionic/vue-router", - "version": "6.2.7", + "version": "6.2.8", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/vue-router", - "version": "6.2.7", + "version": "6.2.8", "license": "MIT", "dependencies": { - "@ionic/vue": "^6.2.7" + "@ionic/vue": "^6.2.8" }, "devDependencies": { "@types/jest": "^28.1.1", @@ -578,9 +578,9 @@ "dev": true }, "node_modules/@ionic/core": { - "version": "6.2.7", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.2.7.tgz", - "integrity": "sha512-pQWcIqr5zfCX5De/MQ9kFs+nhaPCr8HIh5QjmydxvmlLv6WU4vlny/Mg0y1+JwLE0qxPD0T9sMykawWH9e3y5Q==", + "version": "6.2.8", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.2.8.tgz", + "integrity": "sha512-tUUdvCPo9Z4RQXjvxNXBXQsVTFDAH2ju/HAhzZiAvdfwpHfpA39DWkXwAQeoV9gfFFblaOmCmeSq/8JP/FRn4A==", "dependencies": { "@stencil/core": "^2.17.4", "ionicons": "^6.0.3", @@ -588,11 +588,11 @@ } }, "node_modules/@ionic/vue": { - "version": "6.2.7", - "resolved": "https://registry.npmjs.org/@ionic/vue/-/vue-6.2.7.tgz", - "integrity": "sha512-gyAV8gG5F/7/2cMASLd/MGw1ijhCq+bTMIzvTejEp8QKr5khS0DLioWAA13WGC7M2k+S4NrRUiz8lWxibGcjSw==", + "version": "6.2.8", + "resolved": "https://registry.npmjs.org/@ionic/vue/-/vue-6.2.8.tgz", + "integrity": "sha512-Ey+uA01nVmfWeTIJA38BMcKPRFBOn3iV17fzvpEnI9z7HdvGjtDmOdeK2N9ubXpWvlOMAGFfTN6lkAH3hvKvCA==", "dependencies": { - "@ionic/core": "^6.2.7", + "@ionic/core": "^6.2.8", "ionicons": "^6.0.2" } }, @@ -5233,9 +5233,9 @@ "dev": true }, "@ionic/core": { - "version": "6.2.7", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.2.7.tgz", - "integrity": "sha512-pQWcIqr5zfCX5De/MQ9kFs+nhaPCr8HIh5QjmydxvmlLv6WU4vlny/Mg0y1+JwLE0qxPD0T9sMykawWH9e3y5Q==", + "version": "6.2.8", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.2.8.tgz", + "integrity": "sha512-tUUdvCPo9Z4RQXjvxNXBXQsVTFDAH2ju/HAhzZiAvdfwpHfpA39DWkXwAQeoV9gfFFblaOmCmeSq/8JP/FRn4A==", "requires": { "@stencil/core": "^2.17.4", "ionicons": "^6.0.3", @@ -5243,11 +5243,11 @@ } }, "@ionic/vue": { - "version": "6.2.7", - "resolved": "https://registry.npmjs.org/@ionic/vue/-/vue-6.2.7.tgz", - "integrity": "sha512-gyAV8gG5F/7/2cMASLd/MGw1ijhCq+bTMIzvTejEp8QKr5khS0DLioWAA13WGC7M2k+S4NrRUiz8lWxibGcjSw==", + "version": "6.2.8", + "resolved": "https://registry.npmjs.org/@ionic/vue/-/vue-6.2.8.tgz", + "integrity": "sha512-Ey+uA01nVmfWeTIJA38BMcKPRFBOn3iV17fzvpEnI9z7HdvGjtDmOdeK2N9ubXpWvlOMAGFfTN6lkAH3hvKvCA==", "requires": { - "@ionic/core": "^6.2.7", + "@ionic/core": "^6.2.8", "ionicons": "^6.0.2" } }, diff --git a/packages/vue-router/package.json b/packages/vue-router/package.json index 33b21c18f9..616b27b2fa 100644 --- a/packages/vue-router/package.json +++ b/packages/vue-router/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/vue-router", - "version": "6.2.7", + "version": "6.2.8", "description": "Vue Router integration for @ionic/vue", "scripts": { "prepublishOnly": "npm run build", @@ -44,7 +44,7 @@ }, "homepage": "https://github.com/ionic-team/ionic#readme", "dependencies": { - "@ionic/vue": "^6.2.7" + "@ionic/vue": "^6.2.8" }, "devDependencies": { "@types/jest": "^28.1.1", diff --git a/packages/vue/CHANGELOG.md b/packages/vue/CHANGELOG.md index 1e71ea5d3f..2de7783f85 100644 --- a/packages/vue/CHANGELOG.md +++ b/packages/vue/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [6.2.8](https://github.com/ionic-team/ionic/compare/v6.2.7...v6.2.8) (2022-09-21) + +**Note:** Version bump only for package @ionic/vue + + + + + ## [6.2.7](https://github.com/ionic-team/ionic/compare/v6.2.6...v6.2.7) (2022-09-14) **Note:** Version bump only for package @ionic/vue diff --git a/packages/vue/package-lock.json b/packages/vue/package-lock.json index f18ccf37cc..9bf1b1f81a 100644 --- a/packages/vue/package-lock.json +++ b/packages/vue/package-lock.json @@ -1,15 +1,15 @@ { "name": "@ionic/vue", - "version": "6.2.7", + "version": "6.2.8", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@ionic/vue", - "version": "6.2.7", + "version": "6.2.8", "license": "MIT", "dependencies": { - "@ionic/core": "^6.2.7", + "@ionic/core": "^6.2.8", "ionicons": "^6.0.2" }, "devDependencies": { @@ -59,9 +59,9 @@ } }, "node_modules/@ionic/core": { - "version": "6.2.7", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.2.7.tgz", - "integrity": "sha512-pQWcIqr5zfCX5De/MQ9kFs+nhaPCr8HIh5QjmydxvmlLv6WU4vlny/Mg0y1+JwLE0qxPD0T9sMykawWH9e3y5Q==", + "version": "6.2.8", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.2.8.tgz", + "integrity": "sha512-tUUdvCPo9Z4RQXjvxNXBXQsVTFDAH2ju/HAhzZiAvdfwpHfpA39DWkXwAQeoV9gfFFblaOmCmeSq/8JP/FRn4A==", "dependencies": { "@stencil/core": "^2.17.4", "ionicons": "^6.0.3", @@ -768,9 +768,9 @@ } }, "@ionic/core": { - "version": "6.2.7", - "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.2.7.tgz", - "integrity": "sha512-pQWcIqr5zfCX5De/MQ9kFs+nhaPCr8HIh5QjmydxvmlLv6WU4vlny/Mg0y1+JwLE0qxPD0T9sMykawWH9e3y5Q==", + "version": "6.2.8", + "resolved": "https://registry.npmjs.org/@ionic/core/-/core-6.2.8.tgz", + "integrity": "sha512-tUUdvCPo9Z4RQXjvxNXBXQsVTFDAH2ju/HAhzZiAvdfwpHfpA39DWkXwAQeoV9gfFFblaOmCmeSq/8JP/FRn4A==", "requires": { "@stencil/core": "^2.17.4", "ionicons": "^6.0.3", diff --git a/packages/vue/package.json b/packages/vue/package.json index 0260d9a0ca..ff159aacda 100644 --- a/packages/vue/package.json +++ b/packages/vue/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/vue", - "version": "6.2.7", + "version": "6.2.8", "description": "Vue specific wrapper for @ionic/core", "scripts": { "prepublishOnly": "npm run build", @@ -61,7 +61,7 @@ "vue-router": "^4.0.16" }, "dependencies": { - "@ionic/core": "^6.2.7", + "@ionic/core": "^6.2.8", "ionicons": "^6.0.2" }, "vetur": {