From 834e2bb17383b526f0b3e95f82baf4eedf507963 Mon Sep 17 00:00:00 2001 From: Andrew Date: Fri, 15 Aug 2014 13:11:44 -0600 Subject: [PATCH] amend($ionicConfigProvider): fix typo, add unit tests --- js/angular/service/ionicConfig.js | 6 ++--- test/unit/angular/service/ionicConfig.unit.js | 22 +++++++++++++++++++ 2 files changed, 25 insertions(+), 3 deletions(-) create mode 100644 test/unit/angular/service/ionicConfig.unit.js diff --git a/js/angular/service/ionicConfig.js b/js/angular/service/ionicConfig.js index 6421d76727..d2cbde8728 100644 --- a/js/angular/service/ionicConfig.js +++ b/js/angular/service/ionicConfig.js @@ -25,7 +25,7 @@ IonicModule /** * @ngdoc method * @name $ionicConfigProvider#prefetchTemplates - * @description Set whether Ionic should prefetch all templateUrls defined in + * @description Set whether Ionic should prefetch all templateUrls defined in * $stateProvider.state. Default true. If set to false, the user will have to wait * for a template to be fetched the first time he/she is going to a a new page. * @param shouldPrefetch Whether Ionic should prefetch templateUrls defined in @@ -34,9 +34,9 @@ IonicModule */ this.prefetchTemplates = function(newValue) { if (arguments.length) { - config.prefetchTemlates = newValue; + config.prefetchTemplates = newValue; } - return config.prefetchTemlates; + return config.prefetchTemplates; }; // private: Service definition for internal Ionic use diff --git a/test/unit/angular/service/ionicConfig.unit.js b/test/unit/angular/service/ionicConfig.unit.js new file mode 100644 index 0000000000..f6fefbaff4 --- /dev/null +++ b/test/unit/angular/service/ionicConfig.unit.js @@ -0,0 +1,22 @@ +describe('$ionicConfigProvider', function() { + + it('should give default true', function() { + module('ionic', function($ionicConfigProvider) { + expect($ionicConfigProvider.prefetchTemplates()).toBe(true); + }); + inject(function($ionicConfig) { + expect($ionicConfig.prefetchTemplates).toBe(true); + }); + }); + + it('should allow setting', function() { + module('ionic', function($ionicConfigProvider) { + $ionicConfigProvider.prefetchTemplates(false); + expect($ionicConfigProvider.prefetchTemplates()).toBe(false); + }); + inject(function($ionicConfig) { + expect($ionicConfig.prefetchTemplates).toBe(false); + }); + }); + +});