From 82bda3e20d16ec6f6bdb6d4f41b55d6eb5154ed1 Mon Sep 17 00:00:00 2001 From: Brandy Carney Date: Mon, 15 Jul 2024 18:09:24 -0400 Subject: [PATCH] say no to memory leaks man cook kiss --- core/src/components/segment-view/segment-view.tsx | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/core/src/components/segment-view/segment-view.tsx b/core/src/components/segment-view/segment-view.tsx index d3bcd2e382..322efbc894 100644 --- a/core/src/components/segment-view/segment-view.tsx +++ b/core/src/components/segment-view/segment-view.tsx @@ -1,6 +1,6 @@ import type { ComponentInterface } from '@stencil/core'; import { Component, Element, Host, Listen, h } from '@stencil/core'; -import { addEventListener } from '@utils/helpers'; +import { addEventListener, removeEventListener } from '@utils/helpers'; @Component({ tag: 'ion-segment-view', @@ -35,6 +35,14 @@ export class SegmentView implements ComponentInterface { } } + disconnectedCallback() { + const segmentEl = this.segmentEl; + if (segmentEl) { + removeEventListener(segmentEl, 'ionChange', this.updateSection); + this.segmentEl = null; + } + } + private updateSection = () => { const { segmentEl } = this;