javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2026-03-13 10:22:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(ionHeaderBar): have no side effects with content in other views

Browse Source 
Closes #1095
This commit is contained in:
Andy Joslin
2014-04-29 09:17:10 -06:00
parent b87bcb30c3
commit 7fd31b6aed
4 changed files with 17 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
js/angular/directive/headerFooterBar.js vendored
View File

@@ -88,7 +88,7 @@ function tapScrollToTopDirective() {
current.tagName.match(/input|textarea|select/i) ||
current.isContentEditable) {
return;
}
}
current = current.parentNode;
}
var touch = e.gesture && e.gesture.touches[0] || e.detail.touches[0];
@@ -121,26 +121,26 @@ function headerFooterBarDirective(isHeader) {
});
var el = $element[0];
//just incase header is on rootscope
var parentScope = $scope.$parent || $scope;
if (isHeader) {
$scope.$watch(function() { return el.className; }, function(value) {
var isSubheader = value.indexOf('bar-subheader') !== -1;
parentScope.$hasHeader = !isSubheader;
parentScope.$hasSubheader = isSubheader;
$scope.$hasHeader = !isSubheader;
$scope.$hasSubheader = isSubheader;
});
$scope.$on('$destroy', function() {
parentScope.$hasHeader = parentScope.$hasSubheader = null;
delete $scope.$hasHeader;
delete $scope.$hasSubheader;
});
} else {
$scope.$watch(function() { return el.className; }, function(value) {
var isSubfooter = value.indexOf('bar-subfooter') !== -1;
parentScope.$hasFooter = !isSubfooter;
parentScope.$hasSubfooter = isSubfooter;
$scope.$hasFooter = !isSubfooter;
$scope.$hasSubfooter = isSubfooter;
});
$scope.$on('$destroy', function() {
parentScope.$hasFooter = parentScope.$hasSubfooter = null;
delete $scope.$hasFooter;
delete $scope.$hasSubfooter;
});
$scope.$watch('$hasTabs', function(val) {
$element.toggleClass('has-tabs', !!val);

3
js/angular/directive/tabs.js vendored
View File

@@ -75,7 +75,8 @@ IonicModule
$scope.$hasTabsTop = isTabsTop && !isHidden;
});
$scope.$on('$destroy', function() {
$scope.$hasTabs = $scope.$hasTabsTop = null;
delete $scope.$hasTabs;
delete $scope.$hasTabsTop;
});
}
}