javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-19 03:32:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

test(radio): skip Safari on legacy tab key tests (#28387)

Browse Source 
Issue number: internal

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

Legacy radio has tests that use `Tab` key presses. These tend to flake
at unknown moments and were skipped until a fix can be implemented.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

Unable to replicate the flakiness locally or on GitHub. However, it only
fails on Safari so the tests were re-enabled except for Safari.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

This only happens on legacy. The legacy form controls will also be
removed in the future. Due to this, these tests will be removed anyways
at that time.
This commit is contained in:
Maria Hutt
2023-10-23 10:36:34 -07:00
committed by GitHub
parent 2b015b2214
commit 7ecd41f385
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
core/src/components/radio/test/legacy/a11y/radio.e2e.ts
View File

@ -6,10 +6,11 @@ import { configs, test } from '@utils/test/playwright';
*/ */
configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => { configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => {
test.describe(title('radio: a11y'), () => { test.describe(title('radio: a11y'), () => {
// TODO(FW-5218) test.beforeEach(async ({ page, skip }) => {
test.fixme('tabbing should switch between radio groups', async ({ page, pageUtils }) => { skip.browser('webkit', 'Tabbing is flaky in Safari');
await page.goto(`/src/components/radio/test/legacy/a11y`, config); await page.goto(`/src/components/radio/test/legacy/a11y`, config);
});
test('tabbing should switch between radio groups', async ({ page, pageUtils }) => {
const firstGroupRadios = page.locator('#first-group ion-radio'); const firstGroupRadios = page.locator('#first-group ion-radio');
const secondGroupRadios = page.locator('#second-group ion-radio'); const secondGroupRadios = page.locator('#second-group ion-radio');
@ -22,10 +23,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
await pageUtils.pressKeys('shift+Tab'); await pageUtils.pressKeys('shift+Tab');
await expect(firstGroupRadios.nth(0)).toBeFocused(); await expect(firstGroupRadios.nth(0)).toBeFocused();
}); });
// TODO(FW-5218) test('using arrow keys should move between enabled radios within group', async ({ page, pageUtils }) => {
test.fixme('using arrow keys should move between enabled radios within group', async ({ page, pageUtils }) => {
await page.goto(`/src/components/radio/test/legacy/a11y`, config);
const firstGroupRadios = page.locator('#first-group ion-radio'); const firstGroupRadios = page.locator('#first-group ion-radio');
await pageUtils.pressKeys('Tab'); await pageUtils.pressKeys('Tab');