mirror of
https://github.com/ionic-team/ionic-framework.git
synced 2025-11-15 05:59:05 +08:00
fix(labels): prevent clicking a label from triggering onClick twice on several components (#30384)
Issue number: resolves #30165 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Currently, several components will trigger their `onClick` twice if you click on their labels. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> After this fix, the affected components will only trigger `onClick` once per click of their labels or click directly on the element. ## Does this introduce a breaking change? - [ ] Yes - [X] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> The affected components are: - Checkbox - Select - Textarea - Toggle - Input I also tested radio and range but could not reproduce the issue for them. Note that two of the components, checkbox and toggle, had to have special implementations for both their test and fix because of how the host component acts as the component for accessibility purposes. Current dev build: `8.5.7-dev.11746044124.147aab6c` --------- Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com> Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
This commit is contained in:
@@ -911,6 +911,18 @@ export class Select implements ComponentInterface {
|
||||
return this.label !== undefined || this.labelSlot !== null;
|
||||
}
|
||||
|
||||
/**
|
||||
* Stops propagation when the label is clicked,
|
||||
* otherwise, two clicks will be triggered.
|
||||
*/
|
||||
private onLabelClick = (ev: MouseEvent) => {
|
||||
// Only stop propagation if the click was directly on the label
|
||||
// and not on the input or other child elements
|
||||
if (ev.target === ev.currentTarget) {
|
||||
ev.stopPropagation();
|
||||
}
|
||||
};
|
||||
|
||||
/**
|
||||
* Renders the border container
|
||||
* when fill="outline".
|
||||
@@ -1173,7 +1185,7 @@ export class Select implements ComponentInterface {
|
||||
[`select-label-placement-${labelPlacement}`]: true,
|
||||
})}
|
||||
>
|
||||
<label class="select-wrapper" id="select-label">
|
||||
<label class="select-wrapper" id="select-label" onClick={this.onLabelClick}>
|
||||
{this.renderLabelContainer()}
|
||||
<div class="select-wrapper-inner">
|
||||
<slot name="start"></slot>
|
||||
|
||||
Reference in New Issue
Block a user