From 7bd2ebe02708ad72f56d4be1409cad395f0c803b Mon Sep 17 00:00:00 2001 From: Brandy Carney Date: Thu, 29 Oct 2015 13:02:03 -0400 Subject: [PATCH] fix(popup): fixed subtitle passing between popups MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit this._defaults was getting all of opts properties added to it every time a popup was opened, switched it so this_defaults wouldn’t be modified and opts would get its properties. Closes #342 --- ionic/components/popup/popup.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/ionic/components/popup/popup.ts b/ionic/components/popup/popup.ts index 1c9e8f2482..79ebb47119 100644 --- a/ionic/components/popup/popup.ts +++ b/ionic/components/popup/popup.ts @@ -82,7 +82,7 @@ export class Popup { opts.promiseResolve = resolve; opts.promiseReject = reject; - return this.ctrl.open(OVERLAY_TYPE, PopupCmp, util.extend(this._defaults, opts)); + return this.ctrl.open(OVERLAY_TYPE, PopupCmp, util.extend(opts, this._defaults)); }); } @@ -129,7 +129,6 @@ export class Popup { button ] }, opts); - return this.open(opts); } @@ -245,7 +244,6 @@ export class Popup { cancelButton, okButton ] }, opts); - return this.open(opts); }