javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-09 08:09:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(all): consistent gesture events

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2018-08-26 01:26:36 +02:00
parent c1c51025f3
commit 7917ba96ef
7 changed files with 50 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
core/src/components/nav/nav.tsx
View File

@ -116,10 +116,10 @@ export class Nav implements NavOutlet {
gestureName: 'goback-swipe',
gesturePriority: 30,
threshold: 10,
canStart: this.canSwipeBack.bind(this),
onStart: this.swipeBackStart.bind(this),
onMove: this.swipeBackProgress.bind(this),
onEnd: this.swipeBackEnd.bind(this),
canStart: this.canStart.bind(this),
onStart: this.onStart.bind(this),
onMove: this.onMove.bind(this),
onEnd: this.onEnd.bind(this),
});
this.swipeGestureChanged();
}
@ -888,7 +888,13 @@ export class Nav implements NavOutlet {
}
}
private swipeBackStart() {
private canStart(): boolean {
return !!this.swipeGesture &&
!this.isTransitioning &&
this.canGoBack();
}
private onStart() {
if (this.isTransitioning || this.transInstr.length > 0) {
return;
}
@ -909,7 +915,7 @@ export class Nav implements NavOutlet {
);
}
private swipeBackProgress(detail: GestureDetail) {
private onMove(detail: GestureDetail) {
if (this.sbTrns) {
// continue to disable the app while actively dragging
this.isTransitioning = true;
@ -922,7 +928,7 @@ export class Nav implements NavOutlet {
}
}
private swipeBackEnd(detail: GestureDetail) {
private onEnd(detail: GestureDetail) {
if (this.sbTrns) {
// the swipe back gesture has ended
const delta = detail.deltaX;
@ -945,10 +951,6 @@ export class Nav implements NavOutlet {
}
}
private canSwipeBack(): boolean {
return !!this.swipeGesture && !this.isTransitioning && this.canGoBack();
}
render() {
return [
this.mode === 'ios' && <div class="nav-decor" />,