javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(prerender): local references to window/document

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2018-04-19 13:26:49 +02:00
parent 86a6cde4a1
commit 78bd146ad2
42 changed files with 174 additions and 139 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
core/src/components/tabs/tabs.tsx
View File

@ -20,6 +20,7 @@ export class Tabs implements NavOutlet {
@State() selectedTab: HTMLIonTabElement | undefined;
@Prop({ context: 'config' }) config: Config;
@Prop({ context: 'document' }) doc: Document;
/**
* The color to use from your Sass `$colors` map.
@ -63,7 +64,7 @@ export class Tabs implements NavOutlet {
@Prop() scrollable = false;
@Prop({mutable: true}) useRouter: boolean;
@Prop({ mutable: true }) useRouter: boolean;
/**
* Emitted when the tab changes.
@ -74,7 +75,7 @@ export class Tabs implements NavOutlet {
componentWillLoad() {
if (!this.useRouter) {
this.useRouter = !!document.querySelector('ion-router') && !this.el.closest('[no-router]');
this.useRouter = !!this.doc.querySelector('ion-router') && !this.el.closest('[no-router]');
}
this.loadConfig('tabsPlacement', 'bottom');
@ -96,7 +97,7 @@ export class Tabs implements NavOutlet {
protected tabChange(ev: CustomEvent<HTMLIonTabElement>) {
const selectedTab = ev.detail;
if (this.useRouter && selectedTab.href != null) {
const router = document.querySelector('ion-router');
const router = this.doc.querySelector('ion-router');
if (router) {
router.push(selectedTab.href);
}
@ -256,7 +257,7 @@ export class Tabs implements NavOutlet {
private notifyRouter() {
if (this.useRouter) {
const router = document.querySelector('ion-router');
const router = this.doc.querySelector('ion-router');
if (router) {
return router.navChanged(RouterDirection.Forward);
}