From 7871b56eccfe63326b6dd4b56ade3b3afd444fce Mon Sep 17 00:00:00 2001
From: Maria Hutt <thetaPC@users.noreply.github.com>
Date: Tue, 5 Dec 2023 10:43:12 -0800
Subject: [PATCH] fix(angular): add missing menu controller methods (#28618)

Issue number: resolves #20053

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

There are a few methods that that are missing for the menu in the
Angular packages. This leads to users to not being able to use methods
like `isAnimating()`.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- The missing methods have been added by implementing `MenuControllerI`.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

Dev build: 7.5.8-dev.11701461830.1be851fd
---
 .../common/src/providers/menu-controller.ts   | 32 +++++++++++++++++--
 1 file changed, 30 insertions(+), 2 deletions(-)

diff --git a/packages/angular/common/src/providers/menu-controller.ts b/packages/angular/common/src/providers/menu-controller.ts
index 0a197b1f5b..2ceb7cba05 100644
--- a/packages/angular/common/src/providers/menu-controller.ts
+++ b/packages/angular/common/src/providers/menu-controller.ts
@@ -1,6 +1,6 @@
-import type { MenuControllerI } from '@ionic/core/components';
+import type { MenuControllerI, AnimationBuilder, MenuI, Animation } from '@ionic/core/components';
 
-export class MenuController {
+export class MenuController implements MenuControllerI {
   constructor(private menuController: MenuControllerI) {}
 
   /**
@@ -98,4 +98,32 @@ export class MenuController {
   getMenus(): Promise<HTMLIonMenuElement[]> {
     return this.menuController.getMenus();
   }
+
+  registerAnimation(name: string, animation: AnimationBuilder): void {
+    return this.menuController.registerAnimation(name, animation);
+  }
+
+  isAnimating(): Promise<boolean> {
+    return this.menuController.isAnimating();
+  }
+
+  _getOpenSync(): HTMLIonMenuElement | undefined {
+    return this.menuController._getOpenSync();
+  }
+
+  _createAnimation(type: string, menuCmp: MenuI): Promise<Animation> {
+    return this.menuController._createAnimation(type, menuCmp);
+  }
+
+  _register(menu: MenuI): void {
+    return this.menuController._register(menu);
+  }
+
+  _unregister(menu: MenuI): void {
+    return this.menuController._unregister(menu);
+  }
+
+  _setOpen(menu: MenuI, shouldOpen: boolean, animated: boolean): Promise<boolean> {
+    return this.menuController._setOpen(menu, shouldOpen, animated);
+  }
 }