javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-09 16:16:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(many): add aria-hidden to decorative icons (#26922)

Browse Source
This commit is contained in:
Liam DeBeasi
2023-03-07 11:57:18 -05:00
committed by GitHub
parent 78f5d960cf
commit 78303dccaa
12 changed files with 143 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
angular/package-lock.json generated
View File

@ -10,7 +10,7 @@
"license": "MIT", "license": "MIT",
"dependencies": { "dependencies": {
"@ionic/core": "^7.0.0-rc.0", "@ionic/core": "^7.0.0-rc.0",
"ionicons": "^6.1.3", "ionicons": "^7.0.0",
"jsonc-parser": "^3.0.0", "jsonc-parser": "^3.0.0",
"tslib": "^2.3.0" "tslib": "^2.3.0"
}, },
@ -1248,6 +1248,26 @@
"npm": ">=6.0.0" "npm": ">=6.0.0"
} }
}, },
"node_modules/@ionic/core/node_modules/ionicons": {
"version": "6.1.3",
"resolved": "https://registry.npmjs.org/ionicons/-/ionicons-6.1.3.tgz",
"integrity": "sha512-ptzz38dd/Yq+PgjhXegh7yhb/SLIk1bvL9vQDtLv1aoSc7alO6mX2DIMgcKYzt9vrNWkRu1f9Jr78zIFFyOXqw==",
"dependencies": {
"@stencil/core": "^2.18.0"
}
},
"node_modules/@ionic/core/node_modules/ionicons/node_modules/@stencil/core": {
"version": "2.22.2",
"resolved": "https://registry.npmjs.org/@stencil/core/-/core-2.22.2.tgz",
"integrity": "sha512-r+vbxsGNcBaV1VDOYW25lv4QfXTlNoIb5GpUX7rZ+cr59yqYCZC5tlV+IzX6YgHKW62ulCc9M3RYtTfHtNbNNw==",
"bin": {
"stencil": "bin/stencil"
},
"engines": {
"node": ">=12.10.0",
"npm": ">=6.0.0"
}
},
"node_modules/@ionic/eslint-config": { "node_modules/@ionic/eslint-config": {
"version": "0.3.0", "version": "0.3.0",
"dev": true, "dev": true,
@ -4506,9 +4526,9 @@
} }
}, },
"node_modules/ionicons": { "node_modules/ionicons": {
"version": "6.1.3", "version": "7.0.0",
"resolved": "https://registry.npmjs.org/ionicons/-/ionicons-6.1.3.tgz", "resolved": "https://registry.npmjs.org/ionicons/-/ionicons-7.0.0.tgz",
"integrity": "sha512-ptzz38dd/Yq+PgjhXegh7yhb/SLIk1bvL9vQDtLv1aoSc7alO6mX2DIMgcKYzt9vrNWkRu1f9Jr78zIFFyOXqw==", "integrity": "sha512-5G9gBxaUfJm0aAr/Kg5Eb/d7d+pMC65yiHjlkGATLrHSZgAzlc9l6ho0dCSdfq3wGef2QiZeNsvyChPVggfXwQ==",
"dependencies": { "dependencies": {
"@stencil/core": "^2.18.0" "@stencil/core": "^2.18.0"
} }
@ -8117,6 +8137,21 @@
"version": "3.1.0", "version": "3.1.0",
"resolved": "https://registry.npmjs.org/@stencil/core/-/core-3.1.0.tgz", "resolved": "https://registry.npmjs.org/@stencil/core/-/core-3.1.0.tgz",
"integrity": "sha512-Zfe+evaw9m2L/HkTO97Hu8go2ThXrObyWkVqa7V3HjTnq+8TUd/nwld9PC0bOItC/eyMRXsWHdEDCpJAZ1tEVQ==" "integrity": "sha512-Zfe+evaw9m2L/HkTO97Hu8go2ThXrObyWkVqa7V3HjTnq+8TUd/nwld9PC0bOItC/eyMRXsWHdEDCpJAZ1tEVQ=="
},
"ionicons": {
"version": "6.1.3",
"resolved": "https://registry.npmjs.org/ionicons/-/ionicons-6.1.3.tgz",
"integrity": "sha512-ptzz38dd/Yq+PgjhXegh7yhb/SLIk1bvL9vQDtLv1aoSc7alO6mX2DIMgcKYzt9vrNWkRu1f9Jr78zIFFyOXqw==",
"requires": {
"@stencil/core": "^2.18.0"
},
"dependencies": {
"@stencil/core": {
"version": "2.22.2",
"resolved": "https://registry.npmjs.org/@stencil/core/-/core-2.22.2.tgz",
"integrity": "sha512-r+vbxsGNcBaV1VDOYW25lv4QfXTlNoIb5GpUX7rZ+cr59yqYCZC5tlV+IzX6YgHKW62ulCc9M3RYtTfHtNbNNw=="
}
}
} }
} }
}, },
@ -10153,9 +10188,9 @@
} }
}, },
"ionicons": { "ionicons": {
"version": "6.1.3", "version": "7.0.0",
"resolved": "https://registry.npmjs.org/ionicons/-/ionicons-6.1.3.tgz", "resolved": "https://registry.npmjs.org/ionicons/-/ionicons-7.0.0.tgz",
"integrity": "sha512-ptzz38dd/Yq+PgjhXegh7yhb/SLIk1bvL9vQDtLv1aoSc7alO6mX2DIMgcKYzt9vrNWkRu1f9Jr78zIFFyOXqw==", "integrity": "sha512-5G9gBxaUfJm0aAr/Kg5Eb/d7d+pMC65yiHjlkGATLrHSZgAzlc9l6ho0dCSdfq3wGef2QiZeNsvyChPVggfXwQ==",
"requires": { "requires": {
"@stencil/core": "^2.18.0" "@stencil/core": "^2.18.0"
} }

2
angular/package.json
View File

@ -48,7 +48,7 @@
}, },
"dependencies": { "dependencies": {
"@ionic/core": "^7.0.0-rc.0", "@ionic/core": "^7.0.0-rc.0",
"ionicons": "^6.1.3", "ionicons": "^7.0.0",
"jsonc-parser": "^3.0.0", "jsonc-parser": "^3.0.0",
"tslib": "^2.3.0" "tslib": "^2.3.0"
}, },

14
core/package-lock.json generated
View File

@ -10,7 +10,7 @@
"license": "MIT", "license": "MIT",
"dependencies": { "dependencies": {
"@stencil/core": "^3.1.0", "@stencil/core": "^3.1.0",
"ionicons": "^6.1.1", "ionicons": "^7.0.0",
"tslib": "^2.1.0" "tslib": "^2.1.0"
}, },
"devDependencies": { "devDependencies": {
@ -5254,9 +5254,9 @@
} }
}, },
"node_modules/ionicons": { "node_modules/ionicons": {
"version": "6.1.3", "version": "7.0.0",
"resolved": "https://registry.npmjs.org/ionicons/-/ionicons-6.1.3.tgz", "resolved": "https://registry.npmjs.org/ionicons/-/ionicons-7.0.0.tgz",
"integrity": "sha512-ptzz38dd/Yq+PgjhXegh7yhb/SLIk1bvL9vQDtLv1aoSc7alO6mX2DIMgcKYzt9vrNWkRu1f9Jr78zIFFyOXqw==", "integrity": "sha512-5G9gBxaUfJm0aAr/Kg5Eb/d7d+pMC65yiHjlkGATLrHSZgAzlc9l6ho0dCSdfq3wGef2QiZeNsvyChPVggfXwQ==",
"dependencies": { "dependencies": {
"@stencil/core": "^2.18.0" "@stencil/core": "^2.18.0"
} }
@ -14152,9 +14152,9 @@
} }
}, },
"ionicons": { "ionicons": {
"version": "6.1.3", "version": "7.0.0",
"resolved": "https://registry.npmjs.org/ionicons/-/ionicons-6.1.3.tgz", "resolved": "https://registry.npmjs.org/ionicons/-/ionicons-7.0.0.tgz",
"integrity": "sha512-ptzz38dd/Yq+PgjhXegh7yhb/SLIk1bvL9vQDtLv1aoSc7alO6mX2DIMgcKYzt9vrNWkRu1f9Jr78zIFFyOXqw==", "integrity": "sha512-5G9gBxaUfJm0aAr/Kg5Eb/d7d+pMC65yiHjlkGATLrHSZgAzlc9l6ho0dCSdfq3wGef2QiZeNsvyChPVggfXwQ==",
"requires": { "requires": {
"@stencil/core": "^2.18.0" "@stencil/core": "^2.18.0"
}, },

2
core/package.json
View File

@ -32,7 +32,7 @@
], ],
"dependencies": { "dependencies": {
"@stencil/core": "^3.1.0", "@stencil/core": "^3.1.0",
"ionicons": "^6.1.1", "ionicons": "^7.0.0",
"tslib": "^2.1.0" "tslib": "^2.1.0"
}, },
"devDependencies": { "devDependencies": {

4
core/src/components/range/test/a11y/index.html
View File

@ -20,8 +20,8 @@
<ion-range aria-label="my aria label"></ion-range><br /> <ion-range aria-label="my aria label"></ion-range><br />
<ion-range> <ion-range>
<span slot="label">temperature</span> <span slot="label">temperature</span>
<ion-icon name="snow" slot="start"></ion-icon> <ion-icon name="snow" slot="start" aria-hidden="true"></ion-icon>
<ion-icon name="flame" slot="end"></ion-icon> </ion-range <ion-icon name="flame" slot="end" aria-hidden="true"></ion-icon> </ion-range
><br /> ><br />
</main> </main>
</body> </body>

4
core/src/components/refresher-content/refresher-content.tsx
View File

@ -82,7 +82,7 @@ export class RefresherContent implements ComponentInterface {
<ion-spinner name={this.pullingIcon as SpinnerTypes} paused></ion-spinner> <ion-spinner name={this.pullingIcon as SpinnerTypes} paused></ion-spinner>
{mode === 'md' && this.pullingIcon === 'circular' && ( {mode === 'md' && this.pullingIcon === 'circular' && (
<div class="arrow-container"> <div class="arrow-container">
<ion-icon icon={caretBackSharp}></ion-icon> <ion-icon icon={caretBackSharp} aria-hidden="true"></ion-icon>
</div> </div>
)} )}
</div> </div>
@ -90,7 +90,7 @@ export class RefresherContent implements ComponentInterface {
)} )}
{this.pullingIcon && !hasSpinner && ( {this.pullingIcon && !hasSpinner && (
<div class="refresher-pulling-icon"> <div class="refresher-pulling-icon">
<ion-icon icon={this.pullingIcon} lazy={false}></ion-icon> <ion-icon icon={this.pullingIcon} lazy={false} aria-hidden="true"></ion-icon>
</div> </div>
)} )}
{this.pullingText !== undefined && ( {this.pullingText !== undefined && (

2
core/src/components/reorder/reorder.tsx
View File

@ -37,7 +37,7 @@ export class Reorder implements ComponentInterface {
return ( return (
<Host class={mode}> <Host class={mode}>
<slot> <slot>
<ion-icon icon={reorderIcon} lazy={false} class="reorder-icon" part="icon" /> <ion-icon icon={reorderIcon} lazy={false} class="reorder-icon" part="icon" aria-hidden="true" />
</slot> </slot>
</Host> </Host>
); );

1
core/src/components/toast/toast.tsx
View File

@ -382,6 +382,7 @@ export class Toast implements ComponentInterface, OverlayInterface {
<div class="toast-button-inner"> <div class="toast-button-inner">
{b.icon && ( {b.icon && (
<ion-icon <ion-icon
aria-hidden="true"
icon={b.icon} icon={b.icon}
slot={b.text === undefined ? 'icon-only' : undefined} slot={b.text === undefined ? 'icon-only' : undefined}
class="toast-button-icon" class="toast-button-icon"

49
packages/react/package-lock.json generated
View File

@ -10,7 +10,7 @@
"license": "MIT", "license": "MIT",
"dependencies": { "dependencies": {
"@ionic/core": "^7.0.0-rc.0", "@ionic/core": "^7.0.0-rc.0",
"ionicons": "^6.1.3", "ionicons": "^7.0.0",
"tslib": "*" "tslib": "*"
}, },
"devDependencies": { "devDependencies": {
@ -718,6 +718,26 @@
"npm": ">=6.0.0" "npm": ">=6.0.0"
} }
}, },
"node_modules/@ionic/core/node_modules/ionicons": {
"version": "6.1.3",
"resolved": "https://registry.npmjs.org/ionicons/-/ionicons-6.1.3.tgz",
"integrity": "sha512-ptzz38dd/Yq+PgjhXegh7yhb/SLIk1bvL9vQDtLv1aoSc7alO6mX2DIMgcKYzt9vrNWkRu1f9Jr78zIFFyOXqw==",
"dependencies": {
"@stencil/core": "^2.18.0"
}
},
"node_modules/@ionic/core/node_modules/ionicons/node_modules/@stencil/core": {
"version": "2.22.2",
"resolved": "https://registry.npmjs.org/@stencil/core/-/core-2.22.2.tgz",
"integrity": "sha512-r+vbxsGNcBaV1VDOYW25lv4QfXTlNoIb5GpUX7rZ+cr59yqYCZC5tlV+IzX6YgHKW62ulCc9M3RYtTfHtNbNNw==",
"bin": {
"stencil": "bin/stencil"
},
"engines": {
"node": ">=12.10.0",
"npm": ">=6.0.0"
}
},
"node_modules/@ionic/eslint-config": { "node_modules/@ionic/eslint-config": {
"version": "0.3.0", "version": "0.3.0",
"resolved": "https://registry.npmjs.org/@ionic/eslint-config/-/eslint-config-0.3.0.tgz", "resolved": "https://registry.npmjs.org/@ionic/eslint-config/-/eslint-config-0.3.0.tgz",
@ -5670,9 +5690,9 @@
} }
}, },
"node_modules/ionicons": { "node_modules/ionicons": {
"version": "6.1.3", "version": "7.0.0",
"resolved": "https://registry.npmjs.org/ionicons/-/ionicons-6.1.3.tgz", "resolved": "https://registry.npmjs.org/ionicons/-/ionicons-7.0.0.tgz",
"integrity": "sha512-ptzz38dd/Yq+PgjhXegh7yhb/SLIk1bvL9vQDtLv1aoSc7alO6mX2DIMgcKYzt9vrNWkRu1f9Jr78zIFFyOXqw==", "integrity": "sha512-5G9gBxaUfJm0aAr/Kg5Eb/d7d+pMC65yiHjlkGATLrHSZgAzlc9l6ho0dCSdfq3wGef2QiZeNsvyChPVggfXwQ==",
"dependencies": { "dependencies": {
"@stencil/core": "^2.18.0" "@stencil/core": "^2.18.0"
} }
@ -11790,6 +11810,21 @@
"version": "3.1.0", "version": "3.1.0",
"resolved": "https://registry.npmjs.org/@stencil/core/-/core-3.1.0.tgz", "resolved": "https://registry.npmjs.org/@stencil/core/-/core-3.1.0.tgz",
"integrity": "sha512-Zfe+evaw9m2L/HkTO97Hu8go2ThXrObyWkVqa7V3HjTnq+8TUd/nwld9PC0bOItC/eyMRXsWHdEDCpJAZ1tEVQ==" "integrity": "sha512-Zfe+evaw9m2L/HkTO97Hu8go2ThXrObyWkVqa7V3HjTnq+8TUd/nwld9PC0bOItC/eyMRXsWHdEDCpJAZ1tEVQ=="
},
"ionicons": {
"version": "6.1.3",
"resolved": "https://registry.npmjs.org/ionicons/-/ionicons-6.1.3.tgz",
"integrity": "sha512-ptzz38dd/Yq+PgjhXegh7yhb/SLIk1bvL9vQDtLv1aoSc7alO6mX2DIMgcKYzt9vrNWkRu1f9Jr78zIFFyOXqw==",
"requires": {
"@stencil/core": "^2.18.0"
},
"dependencies": {
"@stencil/core": {
"version": "2.22.2",
"resolved": "https://registry.npmjs.org/@stencil/core/-/core-2.22.2.tgz",
"integrity": "sha512-r+vbxsGNcBaV1VDOYW25lv4QfXTlNoIb5GpUX7rZ+cr59yqYCZC5tlV+IzX6YgHKW62ulCc9M3RYtTfHtNbNNw=="
}
}
} }
} }
}, },
@ -15147,9 +15182,9 @@
} }
}, },
"ionicons": { "ionicons": {
"version": "6.1.3", "version": "7.0.0",
"resolved": "https://registry.npmjs.org/ionicons/-/ionicons-6.1.3.tgz", "resolved": "https://registry.npmjs.org/ionicons/-/ionicons-7.0.0.tgz",
"integrity": "sha512-ptzz38dd/Yq+PgjhXegh7yhb/SLIk1bvL9vQDtLv1aoSc7alO6mX2DIMgcKYzt9vrNWkRu1f9Jr78zIFFyOXqw==", "integrity": "sha512-5G9gBxaUfJm0aAr/Kg5Eb/d7d+pMC65yiHjlkGATLrHSZgAzlc9l6ho0dCSdfq3wGef2QiZeNsvyChPVggfXwQ==",
"requires": { "requires": {
"@stencil/core": "^2.18.0" "@stencil/core": "^2.18.0"
} }

2
packages/react/package.json
View File

@ -42,7 +42,7 @@
], ],
"dependencies": { "dependencies": {
"@ionic/core": "^7.0.0-rc.0", "@ionic/core": "^7.0.0-rc.0",
"ionicons": "^6.1.3", "ionicons": "^7.0.0",
"tslib": "*" "tslib": "*"
}, },
"peerDependencies": { "peerDependencies": {

49
packages/vue/package-lock.json generated
View File

@ -10,7 +10,7 @@
"license": "MIT", "license": "MIT",
"dependencies": { "dependencies": {
"@ionic/core": "^7.0.0-rc.0", "@ionic/core": "^7.0.0-rc.0",
"ionicons": "^6.1.3" "ionicons": "^7.0.0"
}, },
"devDependencies": { "devDependencies": {
"@babel/types": "^7.18.4", "@babel/types": "^7.18.4",
@ -229,6 +229,26 @@
"npm": ">=6.0.0" "npm": ">=6.0.0"
} }
}, },
"node_modules/@ionic/core/node_modules/ionicons": {
"version": "6.1.3",
"resolved": "https://registry.npmjs.org/ionicons/-/ionicons-6.1.3.tgz",
"integrity": "sha512-ptzz38dd/Yq+PgjhXegh7yhb/SLIk1bvL9vQDtLv1aoSc7alO6mX2DIMgcKYzt9vrNWkRu1f9Jr78zIFFyOXqw==",
"dependencies": {
"@stencil/core": "^2.18.0"
}
},
"node_modules/@ionic/core/node_modules/ionicons/node_modules/@stencil/core": {
"version": "2.22.2",
"resolved": "https://registry.npmjs.org/@stencil/core/-/core-2.22.2.tgz",
"integrity": "sha512-r+vbxsGNcBaV1VDOYW25lv4QfXTlNoIb5GpUX7rZ+cr59yqYCZC5tlV+IzX6YgHKW62ulCc9M3RYtTfHtNbNNw==",
"bin": {
"stencil": "bin/stencil"
},
"engines": {
"node": ">=12.10.0",
"npm": ">=6.0.0"
}
},
"node_modules/@ionic/core/node_modules/tslib": { "node_modules/@ionic/core/node_modules/tslib": {
"version": "2.2.0", "version": "2.2.0",
"resolved": "https://registry.npmjs.org/tslib/-/tslib-2.2.0.tgz", "resolved": "https://registry.npmjs.org/tslib/-/tslib-2.2.0.tgz",
@ -2249,9 +2269,9 @@
} }
}, },
"node_modules/ionicons": { "node_modules/ionicons": {
"version": "6.1.3", "version": "7.0.0",
"resolved": "https://registry.npmjs.org/ionicons/-/ionicons-6.1.3.tgz", "resolved": "https://registry.npmjs.org/ionicons/-/ionicons-7.0.0.tgz",
"integrity": "sha512-ptzz38dd/Yq+PgjhXegh7yhb/SLIk1bvL9vQDtLv1aoSc7alO6mX2DIMgcKYzt9vrNWkRu1f9Jr78zIFFyOXqw==", "integrity": "sha512-5G9gBxaUfJm0aAr/Kg5Eb/d7d+pMC65yiHjlkGATLrHSZgAzlc9l6ho0dCSdfq3wGef2QiZeNsvyChPVggfXwQ==",
"dependencies": { "dependencies": {
"@stencil/core": "^2.18.0" "@stencil/core": "^2.18.0"
} }
@ -3790,6 +3810,21 @@
"resolved": "https://registry.npmjs.org/@stencil/core/-/core-3.1.0.tgz", "resolved": "https://registry.npmjs.org/@stencil/core/-/core-3.1.0.tgz",
"integrity": "sha512-Zfe+evaw9m2L/HkTO97Hu8go2ThXrObyWkVqa7V3HjTnq+8TUd/nwld9PC0bOItC/eyMRXsWHdEDCpJAZ1tEVQ==" "integrity": "sha512-Zfe+evaw9m2L/HkTO97Hu8go2ThXrObyWkVqa7V3HjTnq+8TUd/nwld9PC0bOItC/eyMRXsWHdEDCpJAZ1tEVQ=="
}, },
"ionicons": {
"version": "6.1.3",
"resolved": "https://registry.npmjs.org/ionicons/-/ionicons-6.1.3.tgz",
"integrity": "sha512-ptzz38dd/Yq+PgjhXegh7yhb/SLIk1bvL9vQDtLv1aoSc7alO6mX2DIMgcKYzt9vrNWkRu1f9Jr78zIFFyOXqw==",
"requires": {
"@stencil/core": "^2.18.0"
},
"dependencies": {
"@stencil/core": {
"version": "2.22.2",
"resolved": "https://registry.npmjs.org/@stencil/core/-/core-2.22.2.tgz",
"integrity": "sha512-r+vbxsGNcBaV1VDOYW25lv4QfXTlNoIb5GpUX7rZ+cr59yqYCZC5tlV+IzX6YgHKW62ulCc9M3RYtTfHtNbNNw=="
}
}
},
"tslib": { "tslib": {
"version": "2.2.0", "version": "2.2.0",
"resolved": "https://registry.npmjs.org/tslib/-/tslib-2.2.0.tgz", "resolved": "https://registry.npmjs.org/tslib/-/tslib-2.2.0.tgz",
@ -5268,9 +5303,9 @@
} }
}, },
"ionicons": { "ionicons": {
"version": "6.1.3", "version": "7.0.0",
"resolved": "https://registry.npmjs.org/ionicons/-/ionicons-6.1.3.tgz", "resolved": "https://registry.npmjs.org/ionicons/-/ionicons-7.0.0.tgz",
"integrity": "sha512-ptzz38dd/Yq+PgjhXegh7yhb/SLIk1bvL9vQDtLv1aoSc7alO6mX2DIMgcKYzt9vrNWkRu1f9Jr78zIFFyOXqw==", "integrity": "sha512-5G9gBxaUfJm0aAr/Kg5Eb/d7d+pMC65yiHjlkGATLrHSZgAzlc9l6ho0dCSdfq3wGef2QiZeNsvyChPVggfXwQ==",
"requires": { "requires": {
"@stencil/core": "^2.18.0" "@stencil/core": "^2.18.0"
}, },

2
packages/vue/package.json
View File

@ -68,7 +68,7 @@
}, },
"dependencies": { "dependencies": {
"@ionic/core": "^7.0.0-rc.0", "@ionic/core": "^7.0.0-rc.0",
"ionicons": "^6.1.3" "ionicons": "^7.0.0"
}, },
"vetur": { "vetur": {
"tags": "dist/vetur/tags.json", "tags": "dist/vetur/tags.json",