javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore(): sync with main

Browse Source
This commit is contained in:
Liam DeBeasi
2023-03-08 09:35:37 -05:00
parent c791a78aa2 e846e0d0af
commit 77b9e11c2b
45 changed files with 497 additions and 368 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/src/components/modal/modal.tsx
View File

@ -294,7 +294,7 @@ export class Modal implements ComponentInterface, OverlayInterface {
/**
* Emitted after the modal has presented.
* Shorthand for ionModalWillDismiss.
* Shorthand for ionModalDidPresent.
*/
@Event({ eventName: 'didPresent' }) didPresentShorthand!: EventEmitter<void>;

2
core/src/components/modal/test/basic/modal.e2e.ts
View File

@ -75,6 +75,7 @@ test.describe('modal: rendering', () => {
await ionModalDidPresent.next();
const modal = await page.locator('ion-modal');
await expect(modal).toHaveClass(/show-modal/);
await page.setIonViewport();
@ -87,6 +88,7 @@ test.describe('modal: rendering', () => {
await ionModalWillDismiss.next();
await ionModalDidDismiss.next();
await expect(modal).not.toHaveClass(/show-modal/);
await expect(modal).toBeHidden();
};