fix(item): counter has appropriate contrast (#25266)

resolves #25262
This commit is contained in:
Liam DeBeasi
2022-05-10 11:30:45 -04:00
committed by GitHub
parent 64f18fbd2d
commit 750be33772
16 changed files with 15 additions and 12 deletions

View File

@ -476,7 +476,5 @@
// --------------------------------------------------
.item-counter {
color: #{$item-md-input-counter-color};
letter-spacing: #{$item-md-input-counter-letter-spacing};
}

View File

@ -539,9 +539,11 @@ ion-ripple-effect {
.item-counter {
@include margin-horizontal(auto, null);
padding-inline-start: 16px;
color: #{$background-color-step-550};
white-space: nowrap;
padding-inline-start: 16px;
}
// Item: Reduced Motion

View File

@ -2,15 +2,6 @@ import type { E2EPage } from '@stencil/core/testing';
import { newE2EPage } from '@stencil/core/testing';
describe('item: counter', () => {
it('should match existing visual screenshots', async () => {
const page = await newE2EPage({
url: '/src/components/item/test/counter?ionic:_testing=true',
});
const compare = await page.compareScreenshot();
expect(compare).toMatchScreenshot();
});
describe('custom formatter', () => {
let page: E2EPage;

View File

@ -0,0 +1,12 @@
import { expect } from '@playwright/test';
import { test } from '@utils/test/playwright';
test.describe('item: counter', () => {
test('should not have visual regressions', async ({ page }) => {
await page.goto(`/src/components/item/test/counter`);
await page.setIonViewport();
expect(await page.screenshot()).toMatchSnapshot(`item-counter-diff-${page.getSnapshotSettings()}.png`);
});
});

Binary file not shown.

After

Width:  |  Height:  |  Size: 53 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 21 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 46 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 52 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 21 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 46 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 50 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 19 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 43 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 50 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 19 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 43 KiB