javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-20 12:29:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(angular): nav controller can pop views after leaving tabs outlet (#25690)

Browse Source 
Resolves #18593
This commit is contained in:
Sean Perkins
2022-09-08 12:52:17 -04:00
committed by GitHub
parent 2969169f50
commit 725b13fa60
11 changed files with 159 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
angular/src/directives/navigation/ion-router-outlet.ts
View File

@ -308,8 +308,19 @@ export class IonRouterOutlet implements OnDestroy, OnInit {
}
this.activatedView = enteringView;
/**
* The top outlet is set prior to the entering view's transition completing,
* so that when we have nested outlets (e.g. ion-tabs inside an ion-router-outlet),
* the tabs outlet will be assigned as the top outlet when a view inside tabs is
* activated.
*
* In this scenario, activeWith is called for both the tabs and the root router outlet.
* To avoid a race condition, we assign the top outlet synchronously.
*/
this.navCtrl.setTopOutlet(this);
this.stackCtrl.setActive(enteringView).then((data) => {
this.navCtrl.setTopOutlet(this);
this.activateEvents.emit(cmpRef.instance);
this.stackEvents.emit(data);
});