From 71137a2ffa055e529e16018c25bf9cf85b322a37 Mon Sep 17 00:00:00 2001 From: Manu MA Date: Mon, 22 Jul 2019 18:54:50 +0200 Subject: [PATCH] fix(tap-click): ensure ripple is removed (#18854) fixes #18836 --- core/src/utils/tap-click.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/core/src/utils/tap-click.ts b/core/src/utils/tap-click.ts index 593a2ad321..fd4e27105b 100644 --- a/core/src/utils/tap-click.ts +++ b/core/src/utils/tap-click.ts @@ -109,14 +109,20 @@ export const startTapClick = (config: Config) => { const rippleEffect = useRippleEffect && getRippleEffect(el); if (rippleEffect && rippleEffect.addRipple) { + removeRipple(); activeRipple = rippleEffect.addRipple(x, y); } }; - const removeActivated = (smooth: boolean) => { + const removeRipple = () => { if (activeRipple !== undefined) { activeRipple.then(remove => remove()); + activeRipple = undefined; } + }; + + const removeActivated = (smooth: boolean) => { + removeRipple(); const active = activatableEle; if (!active) { return;