javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-22 13:32:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor: improve tree shaking abilities

Browse Source 
Internal refactor completed in order to improve tree shaking and dead
code removal. The public API, with an exception to ion-slides, has
stayed the same. However, internally many changes were required so
bundlers could better exclude modules which should not be bundled.
Ultimately most changes resorted to removing references to `window` or
`document`, or a module that referenced one of those.

BREAKING CHANGES

ion-slides was refactored to remove the external dependencies, and
rewritten in TypeScript/ES6 modules to again improve tree shaking
abilities.
This commit is contained in:
Adam Bradley
2017-01-09 09:51:39 -06:00
parent 13cf6a6cb7
commit 7000b1b173
191 changed files with 9401 additions and 13664 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/components/show-hide-when/show-hide-when.ts
View File

@ -10,9 +10,7 @@ export class DisplayWhen {
isMatch: boolean = false;
conditions: string[];
constructor(conditions: string, public platform: Platform, public zone: NgZone) {
this.platform = platform;
constructor(conditions: string, public _plt: Platform, public zone: NgZone) {
if (!conditions) return;
this.conditions = conditions.replace(/\s/g, '').split(',');
@ -20,7 +18,7 @@ export class DisplayWhen {
// check if its one of the matching platforms first
// a platform does not change during the life of an app
for (let i = 0; i < this.conditions.length; i++) {
if (this.conditions[i] && platform.is(this.conditions[i])) {
if (this.conditions[i] && _plt.is(this.conditions[i])) {
this.isMatch = true;
return;
}
@ -28,7 +26,7 @@ export class DisplayWhen {
if (this.orientation()) {
// add window resize listener
platform.onResize(() => {
_plt.onResize(() => {
zone.run(() => {
this.orientation();
});
@ -42,12 +40,12 @@ export class DisplayWhen {
for (let i = 0; i < this.conditions.length; i++) {
if (this.conditions[i] === 'portrait') {
this.isMatch = this.platform.isPortrait();
this.isMatch = this._plt.isPortrait();
return true;
}
if (this.conditions[i] === 'landscape') {
this.isMatch = this.platform.isLandscape();
this.isMatch = this._plt.isLandscape();
return true;
}
}
@ -106,10 +104,10 @@ export class ShowWhen extends DisplayWhen {
constructor(
@Attribute('showWhen') showWhen: string,
platform: Platform,
plt: Platform,
zone: NgZone
) {
super(showWhen, platform, zone);
super(showWhen, plt, zone);
}
}
@ -165,10 +163,10 @@ export class HideWhen extends DisplayWhen {
constructor(
@Attribute('hideWhen') hideWhen: string,
platform: Platform,
plt: Platform,
zone: NgZone
) {
super(hideWhen, platform, zone);
super(hideWhen, plt, zone);
}
}