From 6f2cbe6e59eacb3b57ab24248ef88e9567f1396b Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Wed, 20 Jan 2021 14:02:56 -0500 Subject: [PATCH] breaking(config): remove experimentalTransitionShadow config option (#22797) --- BREAKING.md | 14 ++++++++++++++ core/src/components/content/content.tsx | 3 +-- core/src/utils/config.ts | 5 ----- 3 files changed, 15 insertions(+), 7 deletions(-) diff --git a/BREAKING.md b/BREAKING.md index 73168856da..5c1aa54e6f 100644 --- a/BREAKING.md +++ b/BREAKING.md @@ -4,11 +4,25 @@ This is a comprehensive list of the breaking changes introduced in the major ver ## Versions +- [Version 6.x](#version-6x) - [Version 5.x](#version-5x) - [Version 4.x](#version-4x) - [Legacy](#legacy) +## Version 6.x + +- [Config](#config) + * [Transition Shadow](#transition-shadow) + + +### Config + +#### Transition Shadow + +The `experimentalTransitionShadow` config option has been removed. The transition shadow is now enabled when running in `ios` mode. + + ## Version 5.x - [CSS](#css) diff --git a/core/src/components/content/content.tsx b/core/src/components/content/content.tsx index 5f417daaf8..97c5afb080 100644 --- a/core/src/components/content/content.tsx +++ b/core/src/components/content/content.tsx @@ -1,6 +1,5 @@ import { Component, ComponentInterface, Element, Event, EventEmitter, Host, Listen, Method, Prop, forceUpdate, h, readTask } from '@stencil/core'; -import { config } from '../../global/config'; import { getIonMode } from '../../global/ionic-global'; import { Color, ScrollBaseDetail, ScrollDetail } from '../../interface'; import { isPlatform } from '../../utils/platform'; @@ -307,7 +306,7 @@ export class Content implements ComponentInterface { const { scrollX, scrollY } = this; const mode = getIonMode(this); const forceOverscroll = this.shouldForceOverscroll(); - const transitionShadow = (mode === 'ios' && config.getBoolean('experimentalTransitionShadow', true)); + const transitionShadow = mode === 'ios'; this.resize(); diff --git a/core/src/utils/config.ts b/core/src/utils/config.ts index bd2a78e5eb..4bb2f8f334 100644 --- a/core/src/utils/config.ts +++ b/core/src/utils/config.ts @@ -170,11 +170,6 @@ export interface IonicConfig { */ pickerLeave?: AnimationBuilder; - /** - * EXPERIMENTAL: Adds a page shadow to transitioning pages on iOS. Disabled by default. - */ - experimentalTransitionShadow?: boolean; - /** * If `true`, Ionic will enable a basic DOM sanitizer on component properties that accept custom HTML. */